Re: [Qemu-block] [Qemu-devel] [PATCH 4/5] pci: Add INTERFACE_LEGACY_PCI_DEVICE to legacy PCI devices

On Mon, Aug 28, 2017 at 06:58:37PM -0400, John Snow wrote: > > > On 08/25/2017 03:39 PM, Eduardo Habkost wrote: > > CCing maintainers of affected devices (sorry for not CCing you > > before). > > > > On Wed, Aug 23, 2017 at 07:14:44PM -0300, Eduardo Habkost wrote: > >> Add

Re: [Qemu-block] [Qemu-devel] Persistent bitmaps for non-qcow2 formats

On 08/25/2017 09:44 AM, Max Reitz wrote: > On 2017-08-25 02:55, John Snow wrote: >> Sorry in advance for :words: ... >> >> On 08/23/2017 02:04 PM, Vladimir Sementsov-Ogievskiy wrote: >>> 23.08.2017 11:59, Vladimir Sementsov-Ogievskiy wrote: 22.08.2017 22:07, John Snow wrote: [snip]

Re: [Qemu-block] [Qemu-devel] [PATCH 7/9] AHCI: Rework IRQ constants

On 08/25/2017 10:00 AM, Philippe Mathieu-Daudé wrote: > Hi John, > > On 08/08/2017 03:33 PM, John Snow wrote: >> Create a new enum so that we can name the IRQ bits, which will make >> debugging >> them a little nicer if we can print them out. Not handled in this >> patch, but >> this will make

Re: [Qemu-block] [Qemu-devel] [PATCH 5/9] IDE: replace DEBUG_AIO with trace events

On 08/25/2017 09:46 AM, Philippe Mathieu-Daudé wrote: > Hi John, > > On 08/08/2017 03:33 PM, John Snow wrote: >> Signed-off-by: John Snow >> --- >> hw/ide/atapi.c| 5 + >> hw/ide/core.c | 17 ++--- >> hw/ide/trace-events | 3

Re: [Qemu-block] [Qemu-devel] [PATCH 9/9] AHCI: remove DPRINTF macro

On 08/25/2017 09:48 AM, Philippe Mathieu-Daudé wrote: > On 08/08/2017 03:33 PM, John Snow wrote: >> Signed-off-by: John Snow > > Reviewed-by: Philippe Mathieu-Daudé > :) I'll wait on V2 to hear back. Thank you for your feedback so far.

Re: [Qemu-block] [Qemu-devel] [PATCH 6/9] AHCI: Replace DPRINTF with trace-events

On 08/25/2017 09:17 AM, Philippe Mathieu-Daudé wrote: > Hi John, > > On 08/08/2017 03:33 PM, John Snow wrote: >> There are a few hangers-on that will be dealt with individually >> in forthcoming patches. >> >> Signed-off-by: John Snow >> --- >> hw/ide/ahci.c | 157 >>

Re: [Qemu-block] [Qemu-devel] [PATCH 4/9] ATAPI: Replace DEBUG_IDE_ATAPI with tracing events

On 08/08/2017 04:59 PM, Eric Blake wrote: > On 08/08/2017 01:33 PM, John Snow wrote: >> Goodbye, printfs. >> Hello, fancy printfs. >> >> Signed-off-by: John Snow >> --- >> hw/ide/atapi.c| 64 >> +-- >>

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.11] hw/ide/microdrive: Mark the dscm1xxxx device with user_creatable = false

On 08/23/2017 11:03 PM, Thomas Huth wrote: > QEMU currently aborts with an assertion message when the user is trying > to remove a dscm1 again: > > $ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic > QEMU 2.9.93 monitor - type 'help' for more information > (qemu)

Re: [Qemu-block] [Qemu-devel] [PATCH 4/5] pci: Add INTERFACE_LEGACY_PCI_DEVICE to legacy PCI devices

On 08/25/2017 03:39 PM, Eduardo Habkost wrote: > CCing maintainers of affected devices (sorry for not CCing you > before). > > On Wed, Aug 23, 2017 at 07:14:44PM -0300, Eduardo Habkost wrote: >> Add INTERFACE_LEGACY_PCI_DEVICE to all direct subtypes of >> TYPE_PCI_DEVICE, except: >> >> 1) The

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.11] ide: ahci: unparent children buses before freeing their memory

On 08/28/2017 12:34 PM, Igor Mammedov wrote: > Fixes read after freeing error reported > https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04243.html > Message-Id: <59a56959-ca12-ea75-33fa-ff07eba1b...@redhat.com> > > ich9-ahci device creates ide buses and attaches them as QOM

Re: [Qemu-block] [Qemu-devel] reduce write bandwidth of qcow2 driver while allocating new cluster

On 08/28/2017 01:56 AM, Liu Qing wrote: > Dear list, > Recently I used fio to test qcow2 driver in the guest os, and found out > that when a new cluster is allocated the 4K IO will occupy 64K(default cluster > size) bandwith. > From the code qcow2 driver will fill the unused part of new

Re: [Qemu-block] [Qemu-devel] Persistent bitmaps for non-qcow2 formats

On 08/27/2017 10:57 PM, Fam Zheng wrote: > On Fri, 08/25 15:44, Max Reitz wrote: >> Well, OK. The main argument against supporting anything but qcow2 is >> "if you want features, use qcow2; and we are working on making qcow2 as >> fast as possible." I think that's a very good argument still.

Re: [Qemu-block] [PATCH for-2.11] ide: ahci: unparent children buses before freeing their memory

On Mon, Aug 28, 2017 at 06:34:45PM +0200, Igor Mammedov wrote: > Fixes read after freeing error reported > https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04243.html > Message-Id: <59a56959-ca12-ea75-33fa-ff07eba1b...@redhat.com> > > ich9-ahci device creates ide buses and attaches

Re: [Qemu-block] [PATCH for-2.11] ide: ahci: unparent children buses before freeing their memory

On 28.08.2017 18:34, Igor Mammedov wrote: > Fixes read after freeing error reported > https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04243.html > Message-Id: <59a56959-ca12-ea75-33fa-ff07eba1b...@redhat.com> > > ich9-ahci device creates ide buses and attaches them as QOM children >

[Qemu-block] ALPSS: reminder and submission deadline

Just one more month to go until the Alpine Linux Persistence and Storage Summit (ALPSS) will be held from September 27-29 at the Lizumerhuette in Austria! If you want to submit a 30-minute talk please do so until Sep 1st, as we plan to finalize our schedule. BOFs and team meetings will be

Re: [Qemu-block] [PATCH for-2.11] ide: ahci: unparent children buses before freeing their memory

On 08/28/2017 01:34 PM, Igor Mammedov wrote: Fixes read after freeing error reported https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04243.html Message-Id: <59a56959-ca12-ea75-33fa-ff07eba1b...@redhat.com> ich9-ahci device creates ide buses and attaches them as QOM children at

[Qemu-block] [PATCH for-2.11] ide: ahci: unparent children buses before freeing their memory

Fixes read after freeing error reported https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04243.html Message-Id: <59a56959-ca12-ea75-33fa-ff07eba1b...@redhat.com> ich9-ahci device creates ide buses and attaches them as QOM children at realize time, however it forgets to properly clean

Re: [Qemu-block] [Qemu-devel] reduce write bandwidth of qcow2 driver while allocating new cluster

[adding qemu-block] On 08/28/2017 12:56 AM, Liu Qing wrote: > Dear list, > Recently I used fio to test qcow2 driver in the guest os, and found out > that when a new cluster is allocated the 4K IO will occupy 64K(default cluster > size) bandwith. > From the code qcow2 driver will fill the

Re: [Qemu-block] [PATCH] qemu-iotests: Extend non-shared storage migration test (194)

On Mon, Aug 28, 2017 at 09:51:43AM -0500, Eric Blake wrote: > On 08/28/2017 06:29 AM, Kashyap Chamarthy wrote: > > This is the follow-up patch that was discussed[*] as part of feedback to > > qemu-iotest 194. > > > > Changes in this patch: > > > > - Supply 'job-id' parameter to `drive-mirror`

Re: [Qemu-block] [PATCH] qemu-iotests: Extend non-shared storage migration test (194)

On 08/28/2017 06:29 AM, Kashyap Chamarthy wrote: > This is the follow-up patch that was discussed[*] as part of feedback to > qemu-iotest 194. > > Changes in this patch: > > - Supply 'job-id' parameter to `drive-mirror` invocation. > > - Issue `block-job-cancel` command on the source QEMU

Re: [Qemu-block] [PATCH v3 5/7] block/throttle-groups.c: remove throttle-groups list

On Fri 25 Aug 2017 03:23:30 PM CEST, Manos Pitsidianakis wrote: > @@ -1957,12 +1957,18 @@ void blk_io_limits_enable(BlockBackend *blk, const > char *group, Error **errp) > BlockDriverState *bs = blk_bs(blk), *throttle_node; > QDict *options = qdict_new(); > Error *local_err =

Re: [Qemu-block] [PATCH v3 4/7] block: remove legacy I/O throttling

On Fri 25 Aug 2017 03:23:29 PM CEST, Manos Pitsidianakis wrote: > This commit removes all I/O throttling from block/block-backend.c. In > order to support the existing interface, it is changed to use the > block/throttle.c filter driver. > > The throttle filter node that is created by the legacy

Re: [Qemu-block] [PATCH v3 3/7] block: require job-id when device is a node name

On Fri 25 Aug 2017 03:23:28 PM CEST, Manos Pitsidianakis wrote: > With implicit filter nodes on the top of the graph it is not possible > to generate job-ids with the name of the device in block_job_create() > anymore, since the job's bs will not be a child_root. Reviewed-by: Alberto Garcia

Re: [Qemu-block] [PATCH v3 1/7] block: skip implicit nodes in snapshots, blockjobs

On Fri 25 Aug 2017 03:23:26 PM CEST, Manos Pitsidianakis wrote: > +static inline BlockDriverState *child_bs(BlockDriverState *bs) > +{ > +BlockDriverState *backing = backing_bs(bs); > +BlockDriverState *file = file_bs(bs); > +assert(!(file && backing)); > +return backing ?: file;

[Qemu-block] [PATCH] qemu-iotests: Extend non-shared storage migration test (194)

This is the follow-up patch that was discussed[*] as part of feedback to qemu-iotest 194. Changes in this patch: - Supply 'job-id' parameter to `drive-mirror` invocation. - Issue `block-job-cancel` command on the source QEMU to gracefully complete the mirroring operation. - Stop the

Re: [Qemu-block] [PATCH v9 4/6] block: convert ThrottleGroup to object with QOM

On Fri 25 Aug 2017 03:20:26 PM CEST, Manos Pitsidianakis wrote: > ThrottleGroup is converted to an object. This will allow the future > throttle block filter drive easy creation and configuration of throttle > groups in QMP and cli. Reviewed-by: Alberto Garcia Berto

Re: [Qemu-block] [Qemu-devel] [PATCH 4/5] pci: Add INTERFACE_LEGACY_PCI_DEVICE to legacy PCI devices

On Fri 25 Aug 2017 09:39:22 PM CEST, Eduardo Habkost wrote: > CCing maintainers of affected devices (sorry for not CCing you > before). >> diff --git a/hw/ipack/tpci200.c b/hw/ipack/tpci200.c >> index 4dfa6b3..e380378 100644 >> --- a/hw/ipack/tpci200.c >> +++ b/hw/ipack/tpci200.c >> @@ -646,6