Re: [Qemu-block] [Qemu-devel] [PATCH v4 02/23] block: Add flag to avoid wasted work in bdrv_is_allocated()

2017-09-28 Thread Eric Blake
On 09/26/2017 01:31 PM, John Snow wrote: > > > On 09/13/2017 12:03 PM, Eric Blake wrote: >> Not all callers care about which BDS owns the mapping for a given >> range of the file. In particular, bdrv_is_allocated() cares more >> about finding the largest run of allocated data from the guest >>

Re: [Qemu-block] [Xen-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices

2017-09-28 Thread Eduardo Habkost
On Thu, Sep 28, 2017 at 02:33:57AM -0600, Jan Beulich wrote: > >>> On 27.09.17 at 21:56, wrote: > > --- a/hw/xen/xen_pt.c > > +++ b/hw/xen/xen_pt.c > > @@ -964,6 +964,10 @@ static const TypeInfo xen_pci_passthrough_info = { > > .instance_size =

[Qemu-block] [PATCH] iotests: test clearing unknown autoclear_features by qcow2

2017-09-28 Thread Vladimir Sementsov-Ogievskiy
Test clearing unknown autoclear_features by qcow2 on incoming migration. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Here is a test, related to this problem, which fails with SIGABRT on master and is successful on 2.9 I've tried to fix it by some interchanges in

Re: [Qemu-block] [Xen-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices

2017-09-28 Thread Jan Beulich
>>> On 27.09.17 at 21:56, wrote: > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -964,6 +964,10 @@ static const TypeInfo xen_pci_passthrough_info = { > .instance_size = sizeof(XenPCIPassthroughState), > .instance_finalize = xen_pci_passthrough_finalize, >

[Qemu-block] [PATCH] block/mirror: check backing in bdrv_mirror_top_refresh_filename

2017-09-28 Thread Vladimir Sementsov-Ogievskiy
Backing may be zero after failed bdrv_attach_child in bdrv_set_backing_hd, which leads to SIGSEGV. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all. We have faced into this SIGSEGV because of image locking: trying to call qemu-img commit on locked image leads to

Re: [Qemu-block] [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-28 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 28.09.2017 um 01:05 hat Jan Dakinevich geschrieben: > > > OK but if it's useful as an hmp command, why not as a qmp command? > > > > The command is designed for debugging and produces quite sightly output. For > > respective qmp command most of `info

Re: [Qemu-block] [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-28 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Thu, Sep 28, 2017 at 02:05:37AM +0300, Jan Dakinevich wrote: > > > OK but if it's useful as an hmp command, why not as a qmp command? > > > > > > > The command is designed for debugging and produces quite sightly output. For > > respective

Re: [Qemu-block] [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-28 Thread Daniel P. Berrange
On Thu, Sep 28, 2017 at 02:05:37AM +0300, Jan Dakinevich wrote: > > OK but if it's useful as an hmp command, why not as a qmp command? > > > > The command is designed for debugging and produces quite sightly output. For > respective qmp command most of `info virtio' output would excessive and >

Re: [Qemu-block] [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-28 Thread Cornelia Huck
On Thu, 28 Sep 2017 12:02:35 +0200 Kevin Wolf wrote: > Am 28.09.2017 um 01:05 hat Jan Dakinevich geschrieben: > > > OK but if it's useful as an hmp command, why not as a qmp command? > > > > The command is designed for debugging and produces quite sightly output. For > >

Re: [Qemu-block] [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-28 Thread Kevin Wolf
Am 28.09.2017 um 01:05 hat Jan Dakinevich geschrieben: > > OK but if it's useful as an hmp command, why not as a qmp command? > > The command is designed for debugging and produces quite sightly output. For > respective qmp command most of `info virtio' output would excessive and > unneccesary.

Re: [Qemu-block] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices

2017-09-28 Thread Marcel Apfelbaum
On 27/09/2017 22:56, Eduardo Habkost wrote: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to all direct subtypes of TYPE_PCI_DEVICE, except: 1) The ones that already have INTERFACE_PCIE_DEVICE set: * base-xhci * e1000e * nvme * pvscsi * vfio-pci * virtio-pci * vmxnet3 2) base-pci-bridge Not all PCI

Re: [Qemu-block] [PATCH v2 3/5] pci: Add INTERFACE_PCIE_DEVICE to all PCIe devices

2017-09-28 Thread Marcel Apfelbaum
On 27/09/2017 22:56, Eduardo Habkost wrote: Change all devices that set is_express=1 to implement INTERFACE_PCIE_DEVICE. Cc: Keith Busch Cc: Kevin Wolf Cc: Max Reitz Cc: Dmitry Fleytman Cc: Jason Wang

[Qemu-block] [PATCH v3 0/2] Truncate the tail of the image file in qcow2 shrinking

2017-09-28 Thread Pavel Butsykin
Now after shrinking the qcow2 image, at the end of the image file, there might be a tail that probably will never be used. Although it will not bring any tangible benefit, we can cut the tail if it is. Yes, it will not free up disk space, but if the blocks were be allocated sequentially and the

[Qemu-block] [PATCH v3 2/2] qcow2: truncate the tail of the image file after shrinking the image

2017-09-28 Thread Pavel Butsykin
Now after shrinking the image, at the end of the image file, there might be a tail that probably will never be used. So we can find the last used cluster and cut the tail. Signed-off-by: Pavel Butsykin Reviewed-by: John Snow --- block/qcow2-refcount.c

[Qemu-block] [PATCH v3 1/2] qcow2: fix return error code in qcow2_truncate()

2017-09-28 Thread Pavel Butsykin
Signed-off-by: Pavel Butsykin Reviewed-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Max Reitz --- block/qcow2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c

Re: [Qemu-block] [PATCH v2 2/2] qcow2: truncate the tail of the image file after shrinking the image

2017-09-28 Thread Pavel Butsykin
On 27.09.2017 19:36, Max Reitz wrote: On 2017-09-27 18:27, Pavel Butsykin wrote: On 27.09.2017 19:00, Max Reitz wrote: On 2017-09-22 11:39, Pavel Butsykin wrote: Now after shrinking the image, at the end of the image file, there might be a tail that probably will never be used. So we can find

Re: [Qemu-block] [PATCH 2/5] iotests: Set up Python logging

2017-09-28 Thread Lukáš Doktor
Dne 27.9.2017 v 15:03 Eduardo Habkost napsal(a): > Set up Python logging module instead of relying on > QEMUMachine._debug to enable debugging messages. > > Cc: Kevin Wolf > Cc: Max Reitz > Cc: qemu-block@nongnu.org > Signed-off-by: Eduardo Habkost

Re: [Qemu-block] [PATCH v4 0/6] Misc improvements to crypto block driver

2017-09-28 Thread Daniel P. Berrange
On Wed, Sep 27, 2017 at 11:06:24PM +0200, Max Reitz wrote: > On 2017-09-27 14:53, Daniel P. Berrange wrote: > > This is a followup to > > > > v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg00781.html > > v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06464.html > >