On Monday, 18 December 2017 22:31:40 CET Richard W.M. Jones wrote:
> On Mon, Dec 18, 2017 at 01:43:39PM -0500, John Snow wrote:
> > Hi, friendly ping:
> >
> > It's been over a month with no replies, so it's safe to say this has
> > gotten lost in the 2.11 release shuffle.
> >
> > Recommend you re
On Mon, Dec 18, 2017 at 01:43:39PM -0500, John Snow wrote:
> Hi, friendly ping:
>
> It's been over a month with no replies, so it's safe to say this has
> gotten lost in the 2.11 release shuffle.
>
> Recommend you re-send it for the 2.12 window.
Actually there is an interop problem with the ssh
No functional changes, just whitespace manipulation.
Signed-off-by: Jeff Cody
Reviewed-by: Eric Blake
Reviewed-by: Darren Kenny
Signed-off-by: Jeff Cody
---
block/sheepdog.c | 164 +++
1 file changed, 82 insertions(+), 82 deletions(-)
diff
From: John Snow
If users set an unreasonably low speed (like one byte per second), the
calculated delay may exceed many hours. While we like to punish users
for asking for stupid things, we do also like to allow users to correct
their wicked ways.
When a user provides a new speed, kick the job t
Signed-off-by: Jeff Cody
Reviewed-by: Richard W.M. Jones
Signed-off-by: Jeff Cody
---
block/curl.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/block/curl.c b/block/curl.c
index 00a9879..35cf417 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -857,6 +857,9 @@ out_noclean:
qemu
From: Vladimir Sementsov-Ogievskiy
We can use copy_bitmap instead of sync_bitmap. copy_bitmap is
initialized from sync_bitmap and it is more informative: we will not try
to process data, that is already in progress (by write notifier).
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: St
From: Vladimir Sementsov-Ogievskiy
Set fake progress for non-dirty clusters in copy_bitmap initialization,
to. It simplifies code and allows further refactoring.
This patch changes user's view of backup progress, but formally it
doesn't changed: progress hops are just moved to the beginning.
Ac
From: Vladimir Sementsov-Ogievskiy
We should not copy non-dirty clusters in write notifiers. So,
initialize copy_bitmap from sync_bitmap.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Reviewed-by: Jeff Cody
Reviewed-by: Stefan Hajnoczi
Message-id: 20171012135313.227864-4
If curl_global_init() fails, per the documentation no other curl
functions may be called, so make sure to check the return value.
Also, some minor changes to the initialization latch variable 'inited':
- Make it static in the file, for clarity
- Change the name for clarity
- Make it a bool
Signe
'tag' is already checked in the lines immediately preceding this check,
and set to non-NULL if NULL. No need to check again, it hasn't changed.
Signed-off-by: Jeff Cody
Reviewed-by: Eric Blake
Reviewed-by: Darren Kenny
Signed-off-by: Jeff Cody
---
block/sheepdog.c | 2 +-
1 file changed, 1 i
From: Vladimir Sementsov-Ogievskiy
Use HBitmap copy_bitmap instead of done_bitmap. This is needed to
improve incremental backup in following patches and to unify backup
loop for full/incremental modes in future patches.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Jeff Cody
Reviewe
The following changes since commit 411ad78115ebeb3411cf4b7622784b93dfabe259:
Merge remote-tracking branch
'remotes/stefanberger/tags/pull-tpm-2017-12-15-1' into staging (2017-12-17
15:27:41 +)
are available in the git repository at:
git://github.com/codyprime/qemu-kvm-jtc.git tags/bloc
From: Vladimir Sementsov-Ogievskiy
The function searches for next zero bit.
Also add interface for BdrvDirtyBitmap and unit test.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20171012135313.227864-2-vsement...@virtuozzo.com
Signed-off-by: Jeff Cody
---
block
On Tue, Nov 07, 2017 at 05:27:17PM -0500, Jeff Cody wrote:
> Changes from v2 -> v3:
>
> Patch 1: Return -EIO for ssh_state_init() (Thanks Eric)
> Patch 4: fixed missed line (Thanks Eric)
> Patch 7: fixed opaque pointer assignment (Thanks Eric)
>
> git-backport-diff -r master.. -u 81fb084
>
> 001
On Wed, Nov 15, 2017 at 05:26:48PM +0100, Pino Toscano wrote:
> Rewrite the implementation of the ssh block driver to use libssh instead
> of libssh2. The libssh library has various advantages over libssh2:
> - easier API for authentication (for example for using ssh-agent)
> - easier API for know
Hi, friendly ping:
It's been over a month with no replies, so it's safe to say this has
gotten lost in the 2.11 release shuffle.
Recommend you re-send it for the 2.12 window.
Thanks,
John
On 11/15/2017 11:26 AM, Pino Toscano wrote:
> Rewrite the implementation of the ssh block driver to use lib
Commit 0f5314a (v1.0) added section "Device URL Syntax" to
qemu-options.hx. It's enclosed in STEXI..ETEXI, thus affects only
qemu-options.texi, not --help. It appears as a subsection under
section "Invocation". Similarly, qemu.1 has it as a subsection under
"OPTIONS".
Commit f9dadc9 (v1.1.0) dr
Cc: Ronnie Sahlberg
Cc: Kevin Wolf
Cc: Max Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
Reviewed-by: Ronnie Sahlberg
---
qemu-options.hx | 6 ++
1 file changed, 6 insertions(+)
diff --git a/qemu-options.hx b/qemu-options.hx
index 3d05bc
-iscsi ended up under the "Device URL Syntax" heading by a sequence of
errors, as explained in the previous commit. Move it under the "Block
device options" heading. Nothing left under "Device URL Syntax";
drop the heading.
Cc: Ronnie Sahlberg
Cc: Kevin Wolf
Cc: Max Reitz
Cc: qemu-block@nongn
It's been marked as deprecated since QEMU v2.10.0, and so far nobody
complained that we should keep it, so let's remove this legacy option
now to simplify the code quite a bit.
Signed-off-by: Thomas Huth
---
qemu-doc.texi | 8 --
qemu-options.hx | 19 ++---
vl.c| 86 ++
It's not working anymore since QEMU v1.3.0 - time to remove it now.
Signed-off-by: Thomas Huth
---
blockdev.c| 11 ---
qemu-doc.texi | 6 --
2 files changed, 17 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 56a6b24..c21ba27 100644
--- a/blockdev.c
+++ b/blockdev.c
@@
Looks like we forgot to announce the deprecation of these options in
the corresponding chapter of the qemu-doc text, so let's do that now.
Signed-off-by: Thomas Huth
---
qemu-doc.texi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/qemu-doc.texi b/qemu-doc.texi
index af495ad
Remove the deprecated "-drive boot" and "-hdachs" options and properly
mark some other deprecated options in the deprecation chapter.
Thomas Huth (3):
block: Remove the obsolete -drive boot=on|off parameter
block: Remove the deprecated -hdachs option
block: Mention -drive cyls/heads/secs/tra
> C code can reuse existing header files for struct definitions instead
> of doing oid, pnm, psn = struct.unpack(">x2s5sxLxxx", data).
On the other hand, C code risks having the same bug in tests and
device models, and also endianness is less apparent in C. Overall
I'd say it's a wash---if I wer
Inactivate all if started in paused mode to make it possible to modify
drives through nbd before start (a kind of external reatore).
Invalidation should be done in qmp cont command.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Hi all!
We need the following option: start vm in stopped mode (
On 18/12/2017 17:12, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
v2: use g_strdup_printf(), use 'pci_dev' variable.
hw/pci-host/piix.c | 45 -
1 file changed, 20 insertions(+), 25 deletions(-)
diff --git a/hw/pci-host/p
On 12/18/2017 05:21 PM, Yoni Bettan wrote:
according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement
INTERFACE_PCIE_DEVICE so we don't need is_express field anymore.
Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1)
or
devices that implements only INTERFACE_CO
according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement
INTERFACE_PCIE_DEVICE so we don't need is_express field anymore.
Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1)
or
devices that implements only INTERFACE_CONVENTIONAL_PCI_DEVICE (is_express == 0)
where n
All PCI devices are now QOM'ified.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marcel Apfelbaum
---
v2: added Marcel's R-b
include/hw/pci/pci.h | 1 -
hw/pci/pci.c | 14 --
2 files changed, 15 deletions(-)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
in
Hi,
In this series we QOM'ify the last few PCI devices still using
PCIDeviceClass->init() by converting this init() to realize(),
Then we finally remove the then PCIDeviceClass->init() method for good.
Regards,
Phil.
v2: addressed review feedbacks from Marcel Apfelbaum
Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
---
v2: use g_strdup_printf(), use 'pci_dev' variable.
hw/pci-host/piix.c | 45 -
1 file changed, 20 insertions(+), 25 deletions(-)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index a684a7cca9..bb6560f815
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/nvme.c | 32 +---
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 441e21ed1f..9c5f898da0 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -920,9 +920,9 @@ st
[...]
>>> -static int host_pci_config_read(int pos, int len, uint32_t *val)
>>> +static void host_pci_config_read(int pos, int len, uint32_t *val,
>>> Error **errp)
>>> {
>>> char path[PATH_MAX];
>>> int config_fd;
>>> @@ -812,19 +812,19 @@ static int host_pci_config_read(int pos, i
Hi Marcel,
On 12/18/2017 04:05 AM, Marcel Apfelbaum wrote:
> Hi Philippe,
>
> Thanks for the patch.
>
> On 17/12/2017 22:49, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> hw/pci-host/piix.c | 31 +++
>> 1 file changed, 15 inserti
Pin-based interrupt of NVMe controller did not work properly
because using an obsolated function pci_irq_pulse().
To fix this, change to use pci_irq_assert() / pci_irq_deassert()
instead of pci_irq_pulse().
Signed-off-by: Hikaru Nishida
---
hw/block/nvme.c | 39 ++
On Wed, Dec 13, 2017 at 07:59:53PM -0500, John Snow wrote:
> Signed-off-by: John Snow
> ---
> block/backup.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
On Wed, Dec 13, 2017 at 07:59:52PM -0500, John Snow wrote:
> Signed-off-by: John Snow
> ---
> block/stream.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
On Wed, Dec 13, 2017 at 07:59:51PM -0500, John Snow wrote:
> Depending on the value of `speed` and how fast our backends are,
> delay_ns might be 0 very, very often. This creates some warning
> messages that spook users, but it's also pretty inefficient.
>
> Use block_job_throttle instead to yield
On Wed, Dec 13, 2017 at 07:59:49PM -0500, John Snow wrote:
> +/**
> + * block_job_throttle:
> + * @job: The job that calls the function.
> + *
> + * Yield if it has been SLICE_TIME nanoseconds since the last yield.
> + * Otherwise, check if we need to pause (and update the yield counter).
> + */
>
On Wed, Dec 13, 2017 at 07:59:48PM -0500, John Snow wrote:
> They're all the same. If it actually becomes important to configure it,
> it can become a job or driver property.
>
> Signed-off-by: John Snow
> ---
> block/backup.c | 1 -
> block/commit.c | 2 --
> block/m
On Thu, Dec 14, 2017 at 10:55:22AM -0500, John Snow wrote:
>
>
> On 12/14/2017 03:38 AM, Paolo Bonzini wrote:
> > On 14/12/2017 01:59, John Snow wrote:
> >> qemu_coroutine_yield();
> >> +job->last_yield_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
> >
> > This is not the time the job ha
On Thu, Dec 14, 2017 at 03:35:07PM +, Nir Soffer wrote:
> On Thu, Dec 14, 2017 at 11:39 AM Stefan Hajnoczi
> wrote:
>
> > On Wed, Dec 13, 2017 at 06:35:51PM -0300, Philippe Mathieu-Daudé wrote:
> > > Hi,
> > >
> > > With this series we can now write tests using Python rather than C.
> > > For
On Tue, Dec 12, 2017 at 07:36:49AM +0200, Yoni Bettan wrote:
> * according to Eduardo Habkost's commit
> fd3b02c8896d597dd8b9e053dec579cf0386aee1
>
> * since all PCIEs now implement INTERFACE_PCIE_DEVICE we
> don't need this field anymore
>
> * Devices
On Fri, Dec 15, 2017 at 04:59:13PM -0800, Deepa Srinivasan wrote:
> Starting qemu with the following arguments causes qemu to segfault:
> ... -device lsi,id=lsi0 -drive file=iscsi:<...>,format=raw,if=none,node-name=
> iscsi1 -device scsi-block,bus=lsi0.0,id=<...>,drive=iscsi1
>
> This patch fixes
On Tue, Dec 12, 2017 at 07:36:49AM +0200, Yoni Bettan wrote:
> * according to Eduardo Habkost's commit
> fd3b02c8896d597dd8b9e053dec579cf0386aee1
>
> * since all PCIEs now implement INTERFACE_PCIE_DEVICE we
> don't need this field anymore
>
> * Devices
On 16/12/2017 01:59, Deepa Srinivasan wrote:
> Starting qemu with the following arguments causes qemu to segfault:
> ... -device lsi,id=lsi0 -drive file=iscsi:<...>,format=raw,if=none,node-name=
> iscsi1 -device scsi-block,bus=lsi0.0,id=<...>,drive=iscsi1
>
> This patch fixes blk_aio_ioctl() so it
On 18/12/2017 11:16, Daniel P. Berrange wrote:
> These patches were previously posted as part of a larger series:
>
> https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02064.html
>
> These patches port the NBD server to use QIONetListener, which allows for
> easy setup of multiple listen
From: Klim Kireev
To implement xml format, some defines and structures
from parallels.c are required.
Signed-off-by: Klim Kireev
Reviewed-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
---
block/parallels.h | 83 +++
Parallels Desktop and Parallels Cloud Server uses images glued with the
bundle description in XML format. This series contains very basic
description of this XML files and makes preparations for actual
implementation to be followed.
Signed-off-by: Edgar Kaziakhmedov
Signed-off-by: Klim Kireev
Si
From: Edgar Kaziakhmedov
Since parallels format supports backing files, refine
readv/writev (allocate_clusters) to redirect read/write requests
to a backing file (if cluster is not available in the current bs).
Signed-off-by: Edgar Kaziakhmedov
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signe
From: Klim Kireev
This patch adds main information about Parallels Disk
format, which consists of DiskDescriptor.xml and other files.
Signed-off-by: Edgar Kaziakhmedov
Signed-off-by: Klim Kireev
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
--
From: Klim Kireev
This dependency is required for adequate Parallels images support.
Typically the disk consists of several images which are glued by
XML disk descriptor. Also XML hides inside several important parameters
which are not available in the image header.
The patch also adds clause to
From: Klim Kireev
Signed-off-by: Klim Kireev
Reviewed-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
---
block/parallels.h | 2 ++
block/parallels.c | 5 +++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/block/parallels.h b/block/paralle
Instead of creating a QIOChannelSocket directly for the NBD
server socket, use a QIONetListener. This provides the ability
to listen on multiple sockets at the same time, so enables
full support for IPv4/IPv6 dual stack.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrange
---
blockdev-nbd
Instead of creating a QIOChannelSocket directly for the NBD
server socket, use a QIONetListener. This provides the ability
to listen on multiple sockets at the same time, so enables
full support for IPv4/IPv6 dual stack. This also means we can
honour multiple FDs received during socket activation.
These patches were previously posted as part of a larger series:
https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02064.html
These patches port the NBD server to use QIONetListener, which allows for
easy setup of multiple listening sockets. This enables full support for
IPv4/IPv6 dual s
Max Reitz writes:
[...]
> == Image creation ==
>
> Image creation and op blockers:
> At least for the time being, we probably just want file-posix to open
> the new file with O_CREAT | O_RDWR, then claim the appropriate op
> blockers (WRITE and RESIZE) and then invoke ftruncate().
> Alter
57 matches
Mail list logo
