Re: [Qemu-block] [PATCH 9/9] iotests: new test 206 for NBD BLOCK_STATUS

On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/206 | 34 ++ tests/qemu-iotests/206.out | 2 ++ tests/qemu-iotests/group | 1 + 3 files changed,

Re: [Qemu-block] [Qemu-devel] [PATCH 5/6] ahci-test: fix opts leak of skip tests

On 02/15/2018 04:25 PM, Marc-André Lureau wrote: > Fixes the following ASAN report: > > Direct leak of 128 byte(s) in 8 object(s) allocated from: > #0 0x7fefce311850 in malloc (/lib64/libasan.so.4+0xde850) > #1 0x7fefcdd5ef0c in g_malloc ../glib/gmem.c:94 > #2 0x559b976faff0 in

Re: [Qemu-block] [PATCH 8/9] iotests: add file_path helper

On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Simple way to have auto generated filenames with auto clenup. Like s/clenup/cleanup/ FilePath but without using 'with' statement and without additional indentation of the whole test. Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-block] [PATCH 7/9] iotests.py: tiny refactor: move system imports up

On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) What breaks if they aren't moved? But stylistically, this looks

Re: [Qemu-block] [PATCH 6/9] nbd: BLOCK_STATUS for standard get_block_status function: client part

On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal realization: only one extent in server answer is supported. Flag NBD_CMD_FLAG_REQ_ONE is used to force this behavior. Tests 140, 147 and 205 are fixed due to now server failed on searching export in context of

Re: [Qemu-block] Block Migration and CPU throttling

* Peter Lieven (p...@kamp.de) wrote: > > > Am 07.02.2018 um 19:29 schrieb Dr. David Alan Gilbert : > > > > * Peter Lieven (p...@kamp.de) wrote: > >> Am 12.12.2017 um 18:05 schrieb Dr. David Alan Gilbert: > >>> * Peter Lieven (p...@kamp.de) wrote: > Am 21.09.2017 um

Re: [Qemu-block] [PATCH 5/9] nbd/client: fix error messages in nbd_handle_reply_err

On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: 1. NBD_REP_ERR_INVALID is not only about length, so, make message more general 2. hex format is not very good: it's hard to read something like "option a (set meta context)", so switch to dec. It would be okay as option 0xa;

Re: [Qemu-block] [PATCH 4/9] block/nbd-client: save first fatal error in nbd_iter_error

On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: It is ok, that fatal error hides previous not fatal, but hiding first fatal error is a bad feature. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.c | 4 +++- 1 file changed, 3

Re: [Qemu-block] [PATCH 3/9] nbd: BLOCK_STATUS for standard get_block_status function: server part

On 02/16/2018 08:43 AM, Vladimir Sementsov-Ogievskiy wrote: 16.02.2018 16:21, Eric Blake wrote: On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal realization: only one extent in server answer is supported. Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-block] [PATCH v10 00/12] Dirty bitmaps postcopy migration

07.02.2018 18:58, Vladimir Sementsov-Ogievskiy wrote: Hi all! There is a new version of dirty bitmap postcopy migration series. Now it is based on Max's block tree: https://github.com/XanClic/qemu/commits/block, where it needs only one patch: "block: maintain persistent disabled bitmaps", but

Re: [Qemu-block] [PATCH 3/9] nbd: BLOCK_STATUS for standard get_block_status function: server part

16.02.2018 16:21, Eric Blake wrote: On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal realization: only one extent in server answer is supported. Signed-off-by: Vladimir Sementsov-Ogievskiy --- continuing where I left off, +++ b/nbd/common.c @@

Re: [Qemu-block] [PATCH 3/9] nbd: BLOCK_STATUS for standard get_block_status function: server part

On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal realization: only one extent in server answer is supported. Signed-off-by: Vladimir Sementsov-Ogievskiy --- continuing where I left off, +++ b/nbd/common.c @@ -75,6 +75,10 @@ const char

Re: [Qemu-block] [PATCH] block: implement the bdrv_reopen_prepare helper for LUKS driver

Ping, can this be queued in the block tree, since it appears the no-op impl is ok ? On Thu, Jan 18, 2018 at 10:31:43AM +, Daniel P. Berrange wrote: > If the bdrv_reopen_prepare helper isn't provided, the qemu-img commit > command fails to re-open the base layer after committing changes into >

Re: [Qemu-block] [PATCH] nbd: Honor server's advertised minimum block size

15.02.2018 06:29, Eric Blake wrote: Commit 79ba8c98 (v2.7) changed the setting of request_alignment to occur only during bdrv_refresh_limits(), rather than at at bdrv_open() time; but at the time, NBD was unaffected, because it still used sector-based callbacks, so the block layer defaulted NBD

Re: [Qemu-block] [PATCH 3/9] nbd: BLOCK_STATUS for standard get_block_status function: server part

On 02/16/2018 05:09 AM, Vladimir Sementsov-Ogievskiy wrote: 16.02.2018 02:02, Eric Blake wrote: On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal realization: only one extent in server answer is supported. Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-block] [PATCH v2 7/8] file-posix: account discard operations

On Mon 12 Feb 2018 05:19:57 PM CET, Anton Nefedov wrote: >>> @@ -158,6 +158,11 @@ typedef struct BDRVRawState { >>> bool page_cache_inconsistent:1; >>> bool has_fallocate; >>> bool needs_alignment; >>> +struct { >>> +int64_t discard_nb_ok; >>> +int64_t

Re: [Qemu-block] [PATCH 3/9] nbd: BLOCK_STATUS for standard get_block_status function: server part

16.02.2018 02:02, Eric Blake wrote: On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal realization: only one extent in server answer is supported. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   include/block/nbd.h |  33 ++   nbd/common.c   

Re: [Qemu-block] [PATCH v2] block: unify blocksize types

On Fri 09 Feb 2018 10:53:12 AM CET, Piotr Sarna wrote: > BlockSizes structure used in block size probing has uint32_t types > for logical and physical sizes. These fields are wrongfully assigned > to uint16_t in BlockConf, which results, among other errors, > in assigning 0 instead of 65536 (which