On 07/13/2018 03:41 PM, Max Reitz wrote:
> The test directory should be filtered before the image format, otherwise
> the test will fail if the image format is part of the test directory,
> like so:
>
> [...]
> -can't open: Could not open 'TEST_DIR/t.IMGFMT': Is a directory
> +can't open: Could
The test directory should be filtered before the image format, otherwise
the test will fail if the image format is part of the test directory,
like so:
[...]
-can't open: Could not open 'TEST_DIR/t.IMGFMT': Is a directory
+can't open: Could not open '/tmp/test-IMGFMT/t.IMGFMT': Is a directory
[...
On 07/13/2018 03:15 PM, Max Reitz wrote:
> 223 tests persistent dirty bitmaps which are not supported in
> compat=0.10, so that option is unsupported for this test.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/223 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/qe
223 tests persistent dirty bitmaps which are not supported in
compat=0.10, so that option is unsupported for this test.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/223 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/223 b/tests/qemu-iotests/223
index b63b7a4f9e..8b18
On 07/13/2018 03:10 AM, Kevin Wolf wrote:
> The test case uses block devices with driver=file, which causes the test
> to fail after commit 230ff73904 added a deprecation warning for this.
> Fix the test case to use driver=host_device and update the reference
> output accordingly.
>
> Signed-of
This test doesn't actually care about the format anyway, it just
supports "all formats" as a convenience. LUKS however does not use a
simple image filename which confuses this iotest.
We can simply skip the test for formats that use IMGOPTSSYNTAX for
their filenames without missing much coverage.
On 07/13/2018 03:09 AM, Kevin Wolf wrote:
> Am 13.07.2018 um 00:12 hat John Snow geschrieben:
>> This test doesn't actually care about the format anyway, it just
>> supports "all formats" as a convenience. LUKS however does not use a
>> simple image filename which confuses this iotest.
>>
>> We
Our bad. Change-Id tag snuck into those from gerrit
(https://review.gerrithub.io/c/davidsaOpenu/qemu/+/415434).
Took a note to replace this line with "[PATCH v2]" but, I guess, it makes
sense
if additional comments will follow, right?
Thanks for taking a look.
On 12 July 2018 at 14:47, Kevin Wol
On Fri, Jul 13, 2018 at 08:40:19AM +0200, Paolo Bonzini wrote:
> On 12/07/2018 18:30, Stefan Hajnoczi wrote:
> > On Wed, Jul 11, 2018 at 03:33:21PM +0200, Cornelia Huck wrote:
> >> The other qemu-nbds (the inet and the unix socket ones from the first
> >> run, the second inet one from the second ru
On Wed, Jul 04, 2018 at 03:54:10PM +0100, Stefan Hajnoczi wrote:
> Throttle groups consist of members sharing one throttling state
> (including bps/iops limits). Round-robin scheduling is used to ensure
> fairness. If a group member already has a timer pending then other
> groups members do not s
On Thu, 12 Jul 2018 17:47:00 +0200
Thomas Huth wrote:
> On 12.07.2018 08:32, Markus Armbruster wrote:
> > Daniel P. Berrangé writes:
> [...]
> >> For libvirt, I think whenever something is proposed for deprecation
> >> we could just CC libvir-list, or ask one of the libvirt people to
> >> conf
Past the end of the source backing file, we memset() buf_old to zero, so
it is clearly easy to use blk_pwrite_zeroes() instead of blk_pwrite()
then.
Signed-off-by: Max Reitz
---
qemu-img.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
ind
This patch adds a test for rebasing an image that currently does not
have a backing file.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/024 | 70 ++
tests/qemu-iotests/024.out | 37
2 files changed, 107 insertions(+)
diff --git a/te
Currently, you cannot add a backing file to an image when it currently
has none. It is really simple to allow this, though (effectively by
setting old_backing_size to 0), so this patch does just that.
Signed-off-by: Max Reitz
---
qemu-img.c | 61 ++---
This series allows using qemu-img rebase on images that do not have a
backing file. Right now, this fails with the rather cryptic error
message:
$ qemu-img rebase -b base.qcow2 foo.qcow2
qemu-img: Could not open old backing file '': The 'file' block driver requires
a file name
Yeah, well, OK.
On Thu, 12 Jul 2018 18:16:05 -0400
John Snow wrote:
> Hi, on Fedora 28 x64 host, as of 68f1b569 I'm seeing:
>
> `./check -v -qcow`
> - occasional stall on 052
> - stalls on 216
>
> `./check -v -qed`
> - stalls on 200
>
> `./check -v -luks`
> - failures on 226.
>
>
> 0
Ping – any thoughts on the design, Kevin?
(Continuing to see how much of a mess our backing filename handling is
(half of the time, bs->backing_file is seen as a value in the image
header (so relative paths are interpreted relatively to the overlay),
half of the time it is seen as a cache of bs->
Am 13.07.2018 um 09:15 hat Peter Lieven geschrieben:
> the min_sparse convert parameter can overflow (e.g. -S 1024G)
> in the conversion from int64_t to int resulting in a negative
> min_sparse parameter. Avoid this by limiting the valid parameters
> to sane values. In fact anything exceeding the c
Am 12.07.2018 um 21:51 hat Stefan Weil geschrieben:
> Signed-off-by: Stefan Weil
Thanks, applied to the block branch.
Kevin
Am 12.07.2018 um 21:08 hat Peter Lieven geschrieben:
> the min_sparse convert parameter can overflow (e.g. -S 1024G)
> in the conversion from int64_t to int resulting in a negative
> min_sparse parameter. Avoid this by limiting the valid parameters
> to sane values. In fact anything exceeding the c
the min_sparse convert parameter can overflow (e.g. -S 1024G)
in the conversion from int64_t to int resulting in a negative
min_sparse parameter. Avoid this by limiting the valid parameters
to sane values. In fact anything exceeding the convert buffer size
is also pointless. While at it also forbid
The test case uses block devices with driver=file, which causes the test
to fail after commit 230ff73904 added a deprecation warning for this.
Fix the test case to use driver=host_device and update the reference
output accordingly.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/149 | 2 +
Am 13.07.2018 um 00:12 hat John Snow geschrieben:
> This test doesn't actually care about the format anyway, it just
> supports "all formats" as a convenience. LUKS however does not use a
> simple image filename which confuses this iotest.
>
> We can simply remove the LUKS "support" and be happier
23 matches
Mail list logo
