Re: [Qemu-block] [Qemu-devel] [PATCH 1/1 V2] Add vhost-pci-blk driver

2018-11-08 Thread Dongli Zhang
On 11/09/2018 12:47 AM, Michael S. Tsirkin wrote: > On Thu, Nov 08, 2018 at 10:09:00PM +0800, Dongli Zhang wrote: >> It looks the kernel space vhost-blk can only process raw image. >> >> How about to verify that only raw image is used in the drive command line >> when >> vhost-blk-pci is

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-08 Thread Cleber Rosa
On 11/8/18 1:26 PM, Eduardo Habkost wrote: > On Thu, Nov 08, 2018 at 12:36:37PM -0500, Cleber Rosa wrote: >> >> >> On 11/8/18 11:51 AM, Eduardo Habkost wrote: >> >>> I'm not sure I agree with the "is an important thing to keep >>> track of" part. I don't think we'll have any need to keep track

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-08 Thread Eduardo Habkost
On Thu, Nov 08, 2018 at 12:36:37PM -0500, Cleber Rosa wrote: > > > On 11/8/18 11:51 AM, Eduardo Habkost wrote: > > > I'm not sure I agree with the "is an important thing to keep > > track of" part. I don't think we'll have any need to keep track > > of the Python version in shell script or

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-08 Thread Cleber Rosa
On 11/8/18 11:51 AM, Eduardo Habkost wrote: > I'm not sure I agree with the "is an important thing to keep > track of" part. I don't think we'll have any need to keep track > of the Python version in shell script or makefiles after we start > requiring Python 3. > Well, "Python 3" is not a

Re: [Qemu-block] [Qemu-devel] xen_disk qdevification

2018-11-08 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 08 November 2018 15:44 > To: 'Kevin Wolf' > Cc: Stefano Stabellini ; qemu-block@nongnu.org; > Tim Smith ; qemu-de...@nongnu.org; 'Markus > Armbruster' ; Anthony

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-08 Thread Eduardo Habkost
On Thu, Nov 08, 2018 at 11:06:45AM -0500, Cleber Rosa wrote: > > > On 11/8/18 3:45 AM, Markus Armbruster wrote: > > Cleber Rosa writes: > > > >> On 11/7/18 1:05 AM, Markus Armbruster wrote: > >>> Eduardo Habkost writes: > >>> > The $(SHELLSTATUS) variable requires GNU make >= 4.2, but

Re: [Qemu-block] [Qemu-devel] [PATCH 1/1 V2] Add vhost-pci-blk driver

2018-11-08 Thread Michael S. Tsirkin
On Thu, Nov 08, 2018 at 10:09:00PM +0800, Dongli Zhang wrote: > It looks the kernel space vhost-blk can only process raw image. > > How about to verify that only raw image is used in the drive command line when > vhost-blk-pci is paired with it? > > Otherwise, vhost-blk-pci might be working with

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-08 Thread Cleber Rosa
On 11/8/18 3:45 AM, Markus Armbruster wrote: > Cleber Rosa writes: > >> On 11/7/18 1:05 AM, Markus Armbruster wrote: >>> Eduardo Habkost writes: >>> The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis seems to provide an older version. Change the existing rules to

Re: [Qemu-block] [Qemu-devel] xen_disk qdevification

2018-11-08 Thread Paul Durrant
> -Original Message- > From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: 08 November 2018 15:21 > To: Paul Durrant > Cc: 'Markus Armbruster' ; Anthony Perard > ; Tim Smith ; Stefano > Stabellini ; qemu-block@nongnu.org; qemu- > de...@nongnu.org; Max Reitz ; xen- >

Re: [Qemu-block] [Qemu-devel] xen_disk qdevification

2018-11-08 Thread Kevin Wolf
Am 08.11.2018 um 15:00 hat Paul Durrant geschrieben: > > -Original Message- > > From: Markus Armbruster [mailto:arm...@redhat.com] > > Sent: 05 November 2018 15:58 > > To: Paul Durrant > > Cc: 'Kevin Wolf' ; Tim Smith ; > > Stefano Stabellini ; qemu-block@nongnu.org; qemu- > >

Re: [Qemu-block] [PATCH 1/1 V2] Add vhost-pci-blk driver

2018-11-08 Thread Kevin Wolf
Am 05.11.2018 um 21:56 hat Vitaly Mayatskikh geschrieben: > This driver uses the kernel-mode acceleration for virtio-blk and > allows to get a near bare metal disk performance inside a VM. > > Signed-off-by: Vitaly Mayatskikh > --- > configure | 10 + >

Re: [Qemu-block] [Qemu-devel] [PATCH 1/1 V2] Add vhost-pci-blk driver

2018-11-08 Thread Dongli Zhang
It looks the kernel space vhost-blk can only process raw image. How about to verify that only raw image is used in the drive command line when vhost-blk-pci is paired with it? Otherwise, vhost-blk-pci might be working with qcow2 image without any warning on qemu side. Dongli Zhang On

Re: [Qemu-block] [Qemu-devel] xen_disk qdevification

2018-11-08 Thread Paul Durrant
> -Original Message- > From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: 05 November 2018 15:58 > To: Paul Durrant > Cc: 'Kevin Wolf' ; Tim Smith ; > Stefano Stabellini ; qemu-block@nongnu.org; qemu- > de...@nongnu.org; Max Reitz ; Anthony Perard > ;

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-08 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Hi Markus, > > > Le jeu. 8 nov. 2018 09:46, Markus Armbruster a écrit : > >> Cleber Rosa writes: >> >> > On 11/7/18 1:05 AM, Markus Armbruster wrote: [...] >> >> PEP 394 recommends software distributions install Python 3 into the >> >> default path as python3,

Re: [Qemu-block] [PATCH 3/7] qcow2: split out reading normal clusters from qcow2_co_preadv

2018-11-08 Thread Vladimir Sementsov-Ogievskiy
08.11.2018 13:33, Kevin Wolf wrote: > Am 08.11.2018 um 11:02 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 07.11.2018 21:16, Kevin Wolf wrote: >>> (Broken quoting in text/plain again) >>> >>> Am 01.11.2018 um 13:17 hat Vladimir Sementsov-Ogievskiy geschrieben: 27.09.2018 20:35, Max Reitz

Re: [Qemu-block] [PATCH 3/7] qcow2: split out reading normal clusters from qcow2_co_preadv

2018-11-08 Thread Kevin Wolf
Am 08.11.2018 um 11:02 hat Vladimir Sementsov-Ogievskiy geschrieben: > 07.11.2018 21:16, Kevin Wolf wrote: > > (Broken quoting in text/plain again) > > > > Am 01.11.2018 um 13:17 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> 27.09.2018 20:35, Max Reitz wrote: > >> > >> On 07.08.18 19:43,

Re: [Qemu-block] [PATCH 3/7] qcow2: split out reading normal clusters from qcow2_co_preadv

2018-11-08 Thread Vladimir Sementsov-Ogievskiy
07.11.2018 21:16, Kevin Wolf wrote: > (Broken quoting in text/plain again) > > Am 01.11.2018 um 13:17 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 27.09.2018 20:35, Max Reitz wrote: >> >> On 07.08.18 19:43, Vladimir Sementsov-Ogievskiy wrote: >> >> Memory allocation may become

Re: [Qemu-block] [PATCH v5 0/3] file-posix: Simplifications on image locking

2018-11-08 Thread Kevin Wolf
Am 11.10.2018 um 09:21 hat Fam Zheng geschrieben: > v5: Address Max's comments (Thanks for reviewing): > - Clean up after test done. > - Add rev-by to patch 1 and 2. > > v4: Fix test on systems without OFD. [Patchew] > > The first patch reduces chances of QEMU crash in unusual (but not

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-08 Thread Philippe Mathieu-Daudé
Hi Markus, Le jeu. 8 nov. 2018 09:46, Markus Armbruster a écrit : > Cleber Rosa writes: > > > On 11/7/18 1:05 AM, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >>> The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis > >>> seems to provide an older version. Change

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-08 Thread Markus Armbruster
Cleber Rosa writes: > On 11/7/18 1:05 AM, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >>> The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis >>> seems to provide an older version. Change the existing rules to >>> use command output instead of exit code, to make it