Re: [Qemu-block] [Qemu-devel] [RFC] nvme: how to support multiple namespaces

Laszlo Ersek writes: > On 06/24/19 12:18, Kevin Wolf wrote: >> Am 24.06.2019 um 10:01 hat Klaus Birkelund geschrieben: >>> On Thu, Jun 20, 2019 at 05:37:24PM +0200, Laszlo Ersek wrote: On 06/17/19 10:12, Klaus Birkelund wrote: > Hi all, > > I'm thinking about how to support

Re: [Qemu-block] [Qemu-devel] [RFC] nvme: how to support multiple namespaces

On 06/24/19 12:18, Kevin Wolf wrote: > Am 24.06.2019 um 10:01 hat Klaus Birkelund geschrieben: >> On Thu, Jun 20, 2019 at 05:37:24PM +0200, Laszlo Ersek wrote: >>> On 06/17/19 10:12, Klaus Birkelund wrote: Hi all, I'm thinking about how to support multiple namespaces in the NVMe

Re: [Qemu-block] [Qemu-devel] [PATCH v4 04/10] block/pflash_cfi02: Implement intereleaved flash devices

> On Jun 24, 2019, at 12:05, Philippe Mathieu-Daudé wrote: > >> On 6/22/19 2:25 PM, Philippe Mathieu-Daudé wrote: >> Hi Stephen, >> >> This series haven't fall through the cracks, however it is taking me >> longer than expected to review it. >> >>> On 4/26/19 6:26 PM, Stephen Checkoway

Re: [Qemu-block] [PATCH v4 11/14] block: Try to create well typed json:{} filenames

On 24.06.19 19:39, Max Reitz wrote: > By applying qdict_flatten(), the flat-confused input visitor, and the > output visitor, we can at least try to bring bs->full_open_options into > accordance with the QAPI schema. This may not always work (there are > some options left that have not been

Re: [Qemu-block] [PATCH v8 03/10] dp8393x: manage big endian bus

Hi, Jason, Can I have an Acked-by from you (as network devices maintainer)? Thanks, Laurent Le 20/06/2019 à 00:19, Laurent Vivier a écrit : > This is needed by Quadra 800, this card can run on little-endian > or big-endian bus. > > Signed-off-by: Laurent Vivier > Tested-by: Hervé Poussineau

Re: [Qemu-block] [Qemu-devel] [PATCH v4 00/14] block: Try to create well-typed json:{} filenames

On 24.06.19 21:00, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20190624173935.25747-1-mre...@redhat.com/ > > > > Hi, > > This series failed the asan build test. Please find the testing commands and > their output below. If you have Docker installed, you can probably

Re: [Qemu-block] [PATCH v8 02/10] esp: add pseudo-DMA as used by Macintosh

Hi, Paolo, can I have an "Acked-by" from you (as SCSI maintainer)? The new PDMA states are not migrated, but as this is only used by q800 emulation, and q800 doesn't support migration too, I think it could be added later. Thanks, Laurent Le 20/06/2019 à 00:19, Laurent Vivier a écrit : > There

Re: [Qemu-block] [PATCH v8 01/10] escc: introduce a selector for the register bit

Hi, Marc-André, can I have an Acked-by from you (as character devices maintainer)? Thanks, Laurent Le 20/06/2019 à 00:19, Laurent Vivier a écrit : > On Sparc and PowerMac, the bit 0 of the address > selects the register type (control or data) and > bit 1 selects the channel (B or A). > > On

Re: [Qemu-block] [Qemu-devel] [PATCH v4 04/10] block/pflash_cfi02: Implement intereleaved flash devices

On 6/22/19 2:25 PM, Philippe Mathieu-Daudé wrote: > Hi Stephen, > > This series haven't fall through the cracks, however it is taking me > longer than expected to review it. > > On 4/26/19 6:26 PM, Stephen Checkoway wrote: >> It's common for multiple narrow flash chips to be hooked up in

Re: [Qemu-block] [Qemu-devel] [PATCH v4 00/14] block: Try to create well-typed json:{} filenames

On 24.06.19 21:04, Max Reitz wrote: > On 24.06.19 20:35, no-re...@patchew.org wrote: >> Patchew URL: >> https://patchew.org/QEMU/20190624173935.25747-1-mre...@redhat.com/ >> >> >> >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: >> >>

Re: [Qemu-block] [Qemu-devel] [PATCH v4 00/14] block: Try to create well-typed json:{} filenames

On 24.06.19 20:35, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20190624173935.25747-1-mre...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Message-id:

Re: [Qemu-block] [Qemu-devel] [PATCH v4 00/14] block: Try to create well-typed json:{} filenames

Patchew URL: https://patchew.org/QEMU/20190624173935.25747-1-mre...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make

Re: [Qemu-block] [Qemu-devel] [PATCH v4 00/14] block: Try to create well-typed json:{} filenames

Patchew URL: https://patchew.org/QEMU/20190624173935.25747-1-mre...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190624173935.25747-1-mre...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v4 00/14] block: Try

[Qemu-block] [PATCH v4 14/14] block: Make use of QAPI defaults

This changes most of block-core.json to use QAPI defaults where possible. Notably omitted is everything around BlockdevOptions*, because that would change json:{} filenames (which is technically not an incompatible change, it would just break many iotests). Signed-off-by: Max Reitz ---

[Qemu-block] [PATCH v4 07/14] tests: Test QAPI default values for struct members

This patch adds a number of tests for how not to specify a default for an optional struct member, and one rather large test on how to do it right (in qapi-schema-test.json). As a side effect, this patch tests the QAPI code generator's integer and float parsing capability. Signed-off-by: Max

[Qemu-block] [PATCH v4 06/14] test-qapi: Print struct members' default values

Signed-off-by: Max Reitz --- tests/qapi-schema/test-qapi.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py index b0f770b9bd..320e027d28 100644 --- a/tests/qapi-schema/test-qapi.py +++

[Qemu-block] [PATCH v4 11/14] block: Try to create well typed json:{} filenames

By applying qdict_flatten(), the flat-confused input visitor, and the output visitor, we can at least try to bring bs->full_open_options into accordance with the QAPI schema. This may not always work (there are some options left that have not been QAPI-fied yet), but in practice it usually will.

[Qemu-block] [PATCH v4 08/14] tests: Add QAPI optional discriminator tests

There already is an optional discriminator test, although it also noted the discriminator name itself as optional. This already gives us one error test case, to which this patch adds one other, namely whether that using an optional discriminator requires the respective field to have a default

[Qemu-block] [PATCH v4 12/14] iotests: Test internal option typing

It would be nice if qemu used the correct types for blockdev options internally, even if the user specified string values (either through -drive or by being not so nice and using json:{} with string values). This patch adds a test verifying that fact. Signed-off-by: Max Reitz Reviewed-by: Eric

[Qemu-block] [PATCH v4 13/14] iotests: qcow2's encrypt.format is now optional

Remove the encrypt.format option from the two blockdev-add test cases for encrypted qcow2 images in 087 to explicitly test that this parameter is now optional. Additionally, show that explicitly specifying encrypt.format=auto works just as well, the same for specifying the correct format

[Qemu-block] [PATCH v4 05/14] qapi: Document default values for struct members

Signed-off-by: Max Reitz --- docs/devel/qapi-code-gen.txt | 81 ++-- 1 file changed, 69 insertions(+), 12 deletions(-) diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt index e8ec8ac1de..9dd7816701 100644 --- a/docs/devel/qapi-code-gen.txt

[Qemu-block] [PATCH v4 03/14] qapi: Introduce default values for struct members

With this change, it is possible to give default values for struct members, as follows: What you had to do so far: # @member: Some description, defaults to 42. { 'struct': 'Foo', 'data': { '*member': 'int' } } What you can do now: { 'struct': 'Foo', 'data': {

[Qemu-block] [PATCH v4 09/14] qapi: Formalize qcow2 encryption probing

Currently, you can give no encryption format for a qcow2 file while still passing a key-secret. That does not conform to the schema, so this patch changes the schema to allow it. Signed-off-by: Max Reitz --- qapi/block-core.json | 32 +--- block/qcow2.c| 3

[Qemu-block] [PATCH v4 00/14] block: Try to create well-typed json:{} filenames

Hi, There are two explanations of this cover letter, a relative one (to v3) and an absolute one. *** Important note *** The final patch in this series is an example that converts most of block-core.json to use default values where possible. We may decide to take it or not. It isn’t important

[Qemu-block] [PATCH v4 10/14] qapi: Formalize qcow encryption probing

qcow only supports a single encryption (and there is no reason why that would change in the future), so we can make it the default. Signed-off-by: Max Reitz --- qapi/block-core.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json

[Qemu-block] [PATCH v4 02/14] qapi: Move to_c_string() to common.py

This function will be useful for code generation once we allow default values, so move it to the other "C helper functions". In the process, rewrite it so it supports all nonprintable and non-ASCII characters. Signed-off-by: Max Reitz --- scripts/qapi/common.py | 26

[Qemu-block] [PATCH v4 04/14] qapi: Allow optional discriminators

Optional discriminators are fine, as long as there is a default value. Signed-off-by: Max Reitz --- scripts/qapi/common.py | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index 8c57d0c67a..203623795b 100644 ---

[Qemu-block] [PATCH v4 01/14] qapi: Parse numeric values

Signed-off-by: Max Reitz --- tests/qapi-schema/bad-type-int.json | 1 - tests/qapi-schema/enum-int-member.json | 1 - scripts/qapi/common.py | 25 scripts/qapi/introspect.py | 2 ++ tests/qapi-schema/bad-type-int.err | 2

Re: [Qemu-block] [Qemu-devel] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors

On 24/06/2019 20:09, Eric Blake wrote: > On 6/24/19 11:55 AM, Andrey Shinkevich wrote: > +++ b/tests/qemu-iotests/common.rc @@ -17,6 +17,8 @@ # along with this program. If not, see . # +readonly

Re: [Qemu-block] [Qemu-devel] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors

On 6/24/19 11:55 AM, Andrey Shinkevich wrote: >>> +++ b/tests/qemu-iotests/common.rc >>> @@ -17,6 +17,8 @@ >>># along with this program. If not, see . >>># >>> >>> +readonly VALGRIND_SUPPRESS_ERRORS=./valgrind.supp >> >> Why readonly? >> >> I think it

Re: [Qemu-block] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors

On 17/06/2019 14:45, Kevin Wolf wrote: > Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben: >> The Valgrind tool reports about an uninitialised memory usage when the >> initialization is actually not needed. For example, the buffer 'buf' >> instantiated on a stack of the function

Re: [Qemu-block] [PATCH v2 2/7] iotests: exclude killed processes from running under Valgrind

On 17/06/2019 17:51, Kevin Wolf wrote: > Am 17.06.2019 um 15:20 hat Roman Kagan geschrieben: >> On Mon, Jun 17, 2019 at 02:53:55PM +0200, Kevin Wolf wrote: >>> Am 17.06.2019 um 14:18 hat Roman Kagan geschrieben: On Mon, Jun 17, 2019 at 01:15:04PM +0200, Kevin Wolf wrote: > Am 11.06.2019

Re: [Qemu-block] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors

On 13/06/2019 13:06, Vladimir Sementsov-Ogievskiy wrote: > 11.06.2019 21:02, Andrey Shinkevich wrote: >> The Valgrind tool reports about an uninitialised memory usage when the >> initialization is actually not needed. For example, the buffer 'buf' >> instantiated on a stack of the function

Re: [Qemu-block] [PULL 0/8] Block patches

On 24.06.19 15:15, Pino Toscano wrote: > On Monday, 24 June 2019 14:20:11 CEST Max Reitz wrote: >> On 23.06.19 19:18, Peter Maydell wrote: >>> On Fri, 21 Jun 2019 at 14:23, Max Reitz wrote: The following changes since commit 33d609990621dea6c7d056c86f707b8811320ac1:

[Qemu-block] [PULL v2 7/8] ssh: switch from libssh2 to libssh

From: Pino Toscano Rewrite the implementation of the ssh block driver to use libssh instead of libssh2. The libssh library has various advantages over libssh2: - easier API for authentication (for example for using ssh-agent) - easier API for known_hosts handling - supports newer types of keys

[Qemu-block] [PULL v2 6/8] vmdk: Add read-only support for seSparse snapshots

From: Sam Eiderman Until ESXi 6.5 VMware used the vmfsSparse format for snapshots (VMDK3 in QEMU). This format was lacking in the following: * Grain directory (L1) and grain table (L2) entries were 32-bit, allowing access to only 2TB (slightly less) of data. * The grain size

[Qemu-block] [PULL v2 8/8] iotests: Fix 205 for concurrent runs

Tests should place their files into the test directory. This includes Unix sockets. 205 currently fails to do so, which prevents it from being run concurrently. Signed-off-by: Max Reitz Message-id: 20190618210238.9524-1-mre...@redhat.com Reviewed-by: Eric Blake Signed-off-by: Max Reitz ---

[Qemu-block] [PULL v2 0/8] Block patches

The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde: Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 15:40:50 +0100) are available in the Git repository at: https://github.com/XanClic/qemu.git

[Qemu-block] [PULL v2 5/8] vmdk: Reduce the max bound for L1 table size

From: Sam Eiderman 512M of L1 entries is a very loose bound, only 32M are required to store the maximal supported VMDK file size of 2TB. Fixed qemu-iotest 59# - now failure occures before on impossible L1 table size. Reviewed-by: Karl Heubaum Reviewed-by: Eyal Moscovici Reviewed-by: Liran

[Qemu-block] [PULL v2 2/8] blockdev: enable non-root nodes for transaction drive-backup source

From: Vladimir Sementsov-Ogievskiy We forget to enable it for transaction .prepare, while it is already enabled in do_drive_backup since commit a2d665c1bc362 "blockdev: loosen restrictions on drive-backup source node" Signed-off-by: Vladimir Sementsov-Ogievskiy Message-id:

[Qemu-block] [PULL v2 1/8] nvme: do not advertise support for unsupported arbitration mechanism

From: Klaus Birkelund Jensen The device mistakenly reports that the Weighted Round Robin with Urgent Priority Class arbitration mechanism is supported. It is not. Signed-off-by: Klaus Birkelund Jensen Message-id: 20190606092530.14206-1-kl...@birkelund.eu Acked-by: Maxim Levitsky

[Qemu-block] [PULL v2 4/8] vmdk: Fix comment regarding max l1_size coverage

From: Sam Eiderman Commit b0651b8c246d ("vmdk: Move l1_size check into vmdk_add_extent") extended the l1_size check from VMDK4 to VMDK3 but did not update the default coverage in the moved comment. The previous vmdk4 calculation: (512 * 1024 * 1024) * 512(l2 entries) * 65536(grain) = 16PB

[Qemu-block] [PULL v2 3/8] iotest 134: test cluster-misaligned encrypted write

From: Anton Nefedov COW (even empty/zero) areas require encryption too Signed-off-by: Anton Nefedov Reviewed-by: Eric Blake Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Message-id: 20190516143028.81155-1-anton.nefe...@virtuozzo.com Signed-off-by: Max Reitz --- tests/qemu-iotests/134

Re: [Qemu-block] [PULL 0/8] Block patches

On Monday, 24 June 2019 14:20:11 CEST Max Reitz wrote: > On 23.06.19 19:18, Peter Maydell wrote: > > On Fri, 21 Jun 2019 at 14:23, Max Reitz wrote: > >> > >> The following changes since commit > >> 33d609990621dea6c7d056c86f707b8811320ac1: > >> > >> Merge remote-tracking branch

Re: [Qemu-block] [PULL 0/8] Block patches

On 23.06.19 19:18, Peter Maydell wrote: > On Fri, 21 Jun 2019 at 14:23, Max Reitz wrote: >> >> The following changes since commit 33d609990621dea6c7d056c86f707b8811320ac1: >> >> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into >> staging (2019-06-18 17:00:52 +0100) >> >> are

Re: [Qemu-block] [Qemu-devel] [RFC] nvme: how to support multiple namespaces

Am 24.06.2019 um 10:01 hat Klaus Birkelund geschrieben: > On Thu, Jun 20, 2019 at 05:37:24PM +0200, Laszlo Ersek wrote: > > On 06/17/19 10:12, Klaus Birkelund wrote: > > > Hi all, > > > > > > I'm thinking about how to support multiple namespaces in the NVMe > > > device. My first idea was to add

Re: [Qemu-block] [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section"

On 21.06.2019 12:59, Vladimir Sementsov-Ogievskiy wrote: > 21.06.2019 12:16, Kevin Wolf wrote: >> Am 09.04.2019 um 12:01 hat Kevin Wolf geschrieben: >>> Am 02.04.2019 um 10:35 hat Denis Plotnikov geschrieben: On 13.03.2019 19:04, Kevin Wolf wrote: > Am 14.12.2018 um 12:54 hat Denis

Re: [Qemu-block] [PATCH v7 1/3] block: include base when checking image chain for block allocation

On 19/06/2019 22:27, Max Reitz wrote: > On 29.05.19 19:56, Andrey Shinkevich wrote: >> This patch is used in the 'block/stream: introduce a bottom node' >> that is following. Instead of the base node, the caller may pass >> the node that has the base as its backing image to the function >>

Re: [Qemu-block] [PATCH] block/null: Expose read-zeroes option in QAPI schema

On 17/06/2019 14:57, Kevin Wolf wrote: > Commit cd219eb1e55 added the read-zeroes option for the null-co and > null-aio block driver, but forgot to add them to the QAPI schema. > Therefore, this option wasn't available in -blockdev and blockdev-add > until now. > > Add the missing option in the

Re: [Qemu-block] [Qemu-devel] [RFC] nvme: how to support multiple namespaces

On Thu, Jun 20, 2019 at 05:37:24PM +0200, Laszlo Ersek wrote: > On 06/17/19 10:12, Klaus Birkelund wrote: > > Hi all, > > > > I'm thinking about how to support multiple namespaces in the NVMe > > device. My first idea was to add a "namespaces" property array to the > > device that references

[Qemu-block] [PATCH V2 3/3] qapi: make block histogram interface common

Modify command 'block-latency-histogram-set' to 'block-histogram-set' and modify struct 'BlockLatencyHistogramInfo' to struct 'BlockHistogramInfo', this makes block histogram interface common to use. Currently 'BlockHistogramType' supports 'latency', it works as same as the old command

[Qemu-block] [PATCH V2 1/3] block/accounting: rename struct BlockLatencyHistogram

Rename struct BlockLatencyHistogram to BlockHistogram, and rename related functions. Make this struct and functions be common, they can be used widely. Signed-off-by: zhenwei pi Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/accounting.c | 44

[Qemu-block] [PATCH V2 0/3] Add block size histogram qapi interface

Modify command 'block-latency-histogram-set' to make block histogram interface common to use. And support block size histogram. Thanks to Eric Blake Sementsov-Ogievskiy for the suggestions. This command has been tested for half year on QEMU-2.12, and we found that 3K+ virtual machines write

[Qemu-block] [PATCH V2 2/3] block/accounting: introduce block size histogram

Introduce block size histogram statics for block devices. For read/write/flush operation type, the block size region [0, +inf) is divided into subregions by several points. It works like block latency histogram. Signed-off-by: zhenwei pi Reviewed-by: Vladimir Sementsov-Ogievskiy ---