Re: [Qemu-block] [PATCH] cutils: Move size_to_str() from "qemu-common.h" to "qemu/cutils.h"

On Tue, Sep 03, 2019 at 02:57:31PM -0400, John Snow wrote: [...] > Seems proper. It must be an oversight to begin with that we declared it > in qemu-common but defined it in cutils. Porbably true.. > > Reviewed-by: John Snow Reviewed-by: Peter Xu Thanks, -- Peter Xu

Re: [Qemu-block] [Libguestfs] [PATCH 0/1] NBD protocol change to add fast zero support

On 8/23/19 9:34 AM, Eric Blake wrote: > See the cross-post cover letter for details: > https://www.redhat.com/archives/libguestfs/2019-August/msg00322.html > > Eric Blake (1): > protocol: Add NBD_CMD_FLAG_FAST_ZERO > > doc/proto.md | 50 +- > 1

Re: [Qemu-block] [PATCH] block/nfs: add support for nfs_umount

> Am 03.09.2019 um 16:56 schrieb Kevin Wolf : > > Am 03.09.2019 um 15:44 hat Peter Lieven geschrieben: >> libnfs recently added support for unmounting. Add support >> in Qemu too. >> >> Signed-off-by: Peter Lieven > > Looks trivial enough to review even for me. :-) > > Thanks, applied to

Re: [Qemu-block] [PATCH] docs: Update preferred NBD device syntax

On 9/3/19 3:02 PM, Eric Blake wrote: > [adding libvirt list] > > On 9/3/19 1:50 PM, John Snow wrote: >> >> >> On 9/3/19 10:56 AM, Eric Blake wrote: >>> Mention the preferred URI form, especially since NBD is trying to >>> standardize that form:

Re: [Qemu-block] [PATCH] docs: Update preferred NBD device syntax

[adding libvirt list] On 9/3/19 1:50 PM, John Snow wrote: > > > On 9/3/19 10:56 AM, Eric Blake wrote: >> Mention the preferred URI form, especially since NBD is trying to >> standardize that form: https://lists.debian.org/nbd/2019/06/msg00012.html >> >> Signed-off-by: Eric Blake >> --- >>

Re: [Qemu-block] [PATCH] cutils: Move size_to_str() from "qemu-common.h" to "qemu/cutils.h"

On 9/3/19 8:05 AM, Philippe Mathieu-Daudé wrote: > "qemu/cutils.h" contains various qemu_strtosz_*() functions > useful to convert strings to size. It seems natural to have > the opposite usage (from size to string) there too. > > The function definition is already in util/cutils.c. > >

Re: [Qemu-block] [PATCH] docs: Update preferred NBD device syntax

On 9/3/19 10:56 AM, Eric Blake wrote: > Mention the preferred URI form, especially since NBD is trying to > standardize that form: https://lists.debian.org/nbd/2019/06/msg00012.html > > Signed-off-by: Eric Blake > --- > qemu-doc.texi | 16 +++- > 1 file changed, 11 insertions(+),

Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] nbd: Prepare for NBD_CMD_FLAG_FAST_ZERO

On 8/30/19 1:07 PM, Vladimir Sementsov-Ogievskiy wrote: > 23.08.2019 17:37, Eric Blake wrote: >> Commit fe0480d6 and friends added BDRV_REQ_NO_FALLBACK as a way to >> avoid wasting time on a preliminary write-zero request that will later >> be rewritten by actual data, if it is known that the

Re: [Qemu-block] [PATCH v7 0/6] Allow Valgrind checking all QEMU processes

On 03/09/2019 17:28, Kevin Wolf wrote: > Am 03.09.2019 um 16:22 hat Andrey Shinkevich geschrieben: >> >> >> On 03/09/2019 13:02, Kevin Wolf wrote: >>> Am 01.09.2019 um 13:53 hat Andrey Shinkevich geschrieben: In the current implementation of the QEMU bash iotests, only qemu-io

Re: [Qemu-block] [Qemu-devel] [PATCH 1/5] nbd: Improve per-export flag handling in server

On 8/30/19 6:32 PM, Eric Blake wrote: @@ -458,10 +458,13 @@ static int nbd_negotiate_handle_export_name(NBDClient *client, return -EINVAL; } -trace_nbd_negotiate_new_style_size_flags(client->exp->size, -

Re: [Qemu-block] [Qemu-devel] [PATCH v2] iotests: skip 232 when run tests as root

On 9/3/19 8:50 AM, Vladimir Sementsov-Ogievskiy wrote: > chmod a-w don't help under root, so skip the test in such case. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > v2: move new check under TEST_IMG=TEST_IMG_FILE workaround [Kevin] > > tests/qemu-iotests/232 | 6 ++ > 1 file

[Qemu-block] [PATCH] docs: Update preferred NBD device syntax

Mention the preferred URI form, especially since NBD is trying to standardize that form: https://lists.debian.org/nbd/2019/06/msg00012.html Signed-off-by: Eric Blake --- qemu-doc.texi | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/qemu-doc.texi

Re: [Qemu-block] [PATCH] block/nfs: add support for nfs_umount

Am 03.09.2019 um 15:44 hat Peter Lieven geschrieben: > libnfs recently added support for unmounting. Add support > in Qemu too. > > Signed-off-by: Peter Lieven Looks trivial enough to review even for me. :-) Thanks, applied to the block branch. Kevin

Re: [Qemu-block] [PATCH v7 0/6] Allow Valgrind checking all QEMU processes

Am 03.09.2019 um 16:22 hat Andrey Shinkevich geschrieben: > > > On 03/09/2019 13:02, Kevin Wolf wrote: > > Am 01.09.2019 um 13:53 hat Andrey Shinkevich geschrieben: > >> In the current implementation of the QEMU bash iotests, only qemu-io > >> processes may be run under the Valgrind with the

Re: [Qemu-block] [PATCH v7 0/6] Allow Valgrind checking all QEMU processes

On 03/09/2019 13:02, Kevin Wolf wrote: > Am 01.09.2019 um 13:53 hat Andrey Shinkevich geschrieben: >> In the current implementation of the QEMU bash iotests, only qemu-io >> processes may be run under the Valgrind with the switch '-valgrind'. >> Let's allow the common.rc bash script running all

Re: [Qemu-block] [PATCH v2] iotests: skip 232 when run tests as root

Am 03.09.2019 um 15:50 hat Vladimir Sementsov-Ogievskiy geschrieben: > chmod a-w don't help under root, so skip the test in such case. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Thanks, applied to the block branch. Kevin

Re: [Qemu-block] [PATCH v4 3/3] qcow2: add zstd cluster compression

Am 28.08.2019 um 14:56 hat Denis Plotnikov geschrieben: > zstd significantly reduces cluster compression time. > It provides better compression performance maintaining > the same level of compression ratio in comparison with > zlib, which, at the moment, has been the only compression > method

Re: [Qemu-block] [PATCH] iotests: skip 232 when run tests as root

Am 03.09.2019 um 15:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > chmod a-w don't help under root, so skip the test in such case. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > tests/qemu-iotests/232 | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

[Qemu-block] [PULL v2 15/16] tests/check-block: Skip iotests when sanitizers are enabled

From: Thomas Huth The sanitizers (especially the address sanitizer from Clang) are sometimes printing out warnings or false positives - this spoils the output of the iotests, causing some of the tests to fail. Thus let's skip the automatic iotests during "make check" when the user configured

[Qemu-block] [PULL v2 13/16] iotests: Add -display none to the qemu options

Without this argument, qemu will print an angry message about not being able to connect to a display server if $DISPLAY is not set. For me, that breaks iotests.supported_formats() because it thus only sees ["Could", "not", "connect"] as the supported formats. Signed-off-by: Max Reitz

[Qemu-block] [PULL v2 10/16] iotests: Disable 110 for vmdk.twoGbMaxExtentSparse

The error message for the test case where we have a quorum node for which no directory name can be generated is different: For twoGbMaxExtentSparse, it complains that it cannot open the extent file. For other (sub)formats, it just notes that it cannot determine the backing file path. Both are

Re: [Qemu-block] [PATCH v4 2/3] qcow2: rework the cluster compression routine

Am 28.08.2019 um 14:56 hat Denis Plotnikov geschrieben: > The patch allow to process image compression type defined > in the image header and choose an appropriate method for > image clusters (de)compression. > > Signed-off-by: Denis Plotnikov > --- > block/qcow2-threads.c | 78

Re: [Qemu-block] [PATCH] iotests: skip 232 when run tests as root

03.09.2019 16:38, Kevin Wolf wrote: > Am 03.09.2019 um 15:21 hat Vladimir Sementsov-Ogievskiy geschrieben: >> chmod a-w don't help under root, so skip the test in such case. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> >> tests/qemu-iotests/232 | 6 ++ >> 1 file changed, 6

[Qemu-block] [PATCH v2] iotests: skip 232 when run tests as root

chmod a-w don't help under root, so skip the test in such case. Signed-off-by: Vladimir Sementsov-Ogievskiy --- v2: move new check under TEST_IMG=TEST_IMG_FILE workaround [Kevin] tests/qemu-iotests/232 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/232

[Qemu-block] [PULL v2 08/16] vmdk: Reject invalid compressed writes

Compressed writes generally have to write full clusters, not just in theory but also in practice when it comes to vmdk's streamOptimized subformat. It currently is just silently broken for writes with non-zero in-cluster offsets: $ qemu-img create -f vmdk -o subformat=streamOptimized foo.vmdk 1M

[Qemu-block] [PULL v2 14/16] iotests: Check for enabled drivers before testing them

From: Thomas Huth It is possible to enable only a subset of the block drivers with the "--block-drv-rw-whitelist" option of the "configure" script. All other drivers are marked as unusable (or only included as read-only with the "--block-drv-ro-whitelist" option). If an iotest is now using such

[Qemu-block] [PULL v2 11/16] iotests: Disable 126 for flat vmdk subformats

iotest 126 requires backing file support, which flat vmdks cannot offer. Skip this test for such subformats. Signed-off-by: Max Reitz Message-id: 20190815153638.4600-8-mre...@redhat.com Reviewed-by: John Snow Signed-off-by: Max Reitz --- tests/qemu-iotests/126 | 2 ++ 1 file changed, 2

[Qemu-block] [PULL v2 16/16] iotests: Unify cache mode quoting

From: Nir Soffer Quoting cache mode is not needed, and most tests use unquoted values. Unify all test to use the same style. Message-id: 20190827173432.7656-1-nsof...@redhat.com Signed-off-by: Nir Soffer Signed-off-by: Max Reitz --- tests/qemu-iotests/026 | 4 ++-- tests/qemu-iotests/039 | 4

[Qemu-block] [PULL v2 01/16] qemu-io: add pattern file for write command

From: Denis Plotnikov The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov Message-id: 20190820164616.4072-1-dplotni...@virtuozzo.com Reviewed-by: Eric Blake [mreitz: Keep optstring in alphabetical order]

Re: [Qemu-block] [PATCH v4 1/3] qcow2: introduce compression type feature

Am 28.08.2019 um 14:56 hat Denis Plotnikov geschrieben: > The patch adds some preparation parts for incompatible compression type > feature to QCOW2 header that indicates that *all* compressed clusters > must be (de)compressed using a certain compression type. > > It is implied that the

[Qemu-block] [PATCH] block/nfs: add support for nfs_umount

libnfs recently added support for unmounting. Add support in Qemu too. Signed-off-by: Peter Lieven --- block/nfs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/block/nfs.c b/block/nfs.c index 0ec50953e4..9d30963fd8 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -1,7

[Qemu-block] [PULL v2 12/16] file-posix: fix request_alignment typo

From: Stefan Hajnoczi Fixes: a6b257a08e3d72219f03e461a52152672fec0612 ("file-posix: Handle undetectable alignment") Signed-off-by: Stefan Hajnoczi Message-id: 20190827101328.4062-1-stefa...@redhat.com Reviewed-by: Thomas Huth Signed-off-by: Max Reitz --- block/file-posix.c | 2 +- 1

[Qemu-block] [PULL v2 09/16] iotests: Disable broken streamOptimized tests

streamOptimized does not support writes that do not span exactly one cluster. Furthermore, it cannot rewrite already allocated clusters. As such, many iotests do not work with it. Disable them. Signed-off-by: Max Reitz Message-id: 20190815153638.4600-6-mre...@redhat.com Reviewed-by: John Snow

[Qemu-block] [PULL v2 03/16] block: posix: Always allocate the first block

From: Nir Soffer When creating an image with preallocation "off" or "falloc", the first block of the image is typically not allocated. When using Gluster storage backed by XFS filesystem, reading this block using direct I/O succeeds regardless of request length, fooling alignment detection. In

[Qemu-block] [PULL v2 06/16] vmdk: Use bdrv_dirname() for relative extent paths

This makes iotest 033 pass with e.g. subformat=monolithicFlat. It also turns a former error in 059 into success. Signed-off-by: Max Reitz Message-id: 20190815153638.4600-3-mre...@redhat.com Reviewed-by: John Snow Signed-off-by: Max Reitz --- block/vmdk.c | 54

[Qemu-block] [PULL v2 07/16] iotests: Keep testing broken relative extent paths

We had a test for a case where relative extent paths did not work, but unfortunately we just fixed the underlying problem, so it works now. This patch adds a new test case that still fails. Signed-off-by: Max Reitz Reviewed-by: John Snow Message-id: 20190815153638.4600-4-mre...@redhat.com

[Qemu-block] [PULL v2 00/16] Block patches

The following changes since commit 54b89db5309d5fa8b5d3fe5fe56f81704e2f9706: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-09-03 09:43:26 +0100) are available in the Git repository at: https://github.com/XanClic/qemu.git

[Qemu-block] [PULL v2 05/16] iotests: Fix _filter_img_create()

fe646693acc changed qemu-img create's output so that it no longer prints single quotes around parameter values. The subformat and adapter_type filters in _filter_img_create() have never been adapted to that change. Fixes: fe646693acc13ac48b98435d14149ab04dc597bc Signed-off-by: Max Reitz

Re: [Qemu-block] [PATCH V2] block/vhdx: add check for truncated image files

Am 03.09.2019 um 15:10 hat Peter Lieven geschrieben: > Am 03.09.19 um 15:02 schrieb Kevin Wolf: > > Am 02.09.2019 um 17:24 hat Peter Lieven geschrieben: > > > qemu is currently not able to detect truncated vhdx image files. > > > Add a basic check if all allocated blocks are reachable at open and

[Qemu-block] [PULL v2 04/16] iotests: Test allocate_first_block() with O_DIRECT

From: Nir Soffer Using block_resize we can test allocate_first_block() with file descriptor opened with O_DIRECT, ensuring that it works for any size larger than 4096 bytes. Testing smaller sizes is tricky as the result depends on the filesystem used for testing. For example on NFS any size

[Qemu-block] [PULL v2 02/16] block: fix permission update in bdrv_replace_node

From: Vladimir Sementsov-Ogievskiy It's wrong to OR shared permissions. It may lead to crash on further permission updates. Also, no needs to consider previously calculated permissions, as at this point we already bind all new parents and bdrv_get_cumulative_perm result is enough. So fix the bug

[Qemu-block] [PATCH V3] block/vhdx: add check for truncated image files

qemu is currently not able to detect truncated vhdx image files. Add a basic check if all allocated blocks are reachable at open and report all errors during bdrv_co_check. Signed-off-by: Peter Lieven --- V3: - check for bdrv_getlength failure [Kevin] - use uint32_t for i [Kevin] - check

[Qemu-block] [PATCH] iotests: skip 232 when run tests as root

chmod a-w don't help under root, so skip the test in such case. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/232 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/232 b/tests/qemu-iotests/232 index 2063f78876..da35a63d85 100755 ---

Re: [Qemu-block] [PATCH v2] iotests: Check for enabled drivers before testing them

On 03/09/2019 14.55, Max Reitz wrote: > On 23.08.19 15:35, Thomas Huth wrote: >> It is possible to enable only a subset of the block drivers with the >> "--block-drv-rw-whitelist" option of the "configure" script. All other >> drivers are marked as unusable (or only included as read-only with the

Re: [Qemu-block] [PATCH V2] block/vhdx: add check for truncated image files

Am 03.09.19 um 15:02 schrieb Kevin Wolf: Am 02.09.2019 um 17:24 hat Peter Lieven geschrieben: qemu is currently not able to detect truncated vhdx image files. Add a basic check if all allocated blocks are reachable at open and report all errors during bdrv_co_check. Signed-off-by: Peter Lieven

Re: [Qemu-block] [PATCH V2] block/vhdx: add check for truncated image files

Am 02.09.2019 um 17:24 hat Peter Lieven geschrieben: > qemu is currently not able to detect truncated vhdx image files. > Add a basic check if all allocated blocks are reachable at open and > report all errors during bdrv_co_check. > > Signed-off-by: Peter Lieven > --- > V2: - add error

Re: [Qemu-block] [PATCH v2] iotests: Check for enabled drivers before testing them

On 23.08.19 15:35, Thomas Huth wrote: > It is possible to enable only a subset of the block drivers with the > "--block-drv-rw-whitelist" option of the "configure" script. All other > drivers are marked as unusable (or only included as read-only with the > "--block-drv-ro-whitelist" option). If an

Re: [Qemu-block] [PULL 00/15] Block patches

On 03.09.19 10:39, Peter Maydell wrote: > On Tue, 27 Aug 2019 at 19:23, Max Reitz wrote: >> >> The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4: >> >> Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into >> staging (2019-08-27 15:52:36 +0100) >>

Re: [Qemu-block] [PATCH v4 0/5] qcow2: async handling of fragmented io

Pinging, as Stefan's branch merged into master and now these series based on master. 16.08.2019 18:30, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is an asynchronous scheme for handling fragmented qcow2 > reads and writes. Both qcow2 read and write functions loops through >

[Qemu-block] [PATCH] cutils: Move size_to_str() from "qemu-common.h" to "qemu/cutils.h"

"qemu/cutils.h" contains various qemu_strtosz_*() functions useful to convert strings to size. It seems natural to have the opposite usage (from size to string) there too. The function definition is already in util/cutils.c. Signed-off-by: Philippe Mathieu-Daudé --- There are only 5 users, is

Re: [Qemu-block] [PATCH v7 0/6] Allow Valgrind checking all QEMU processes

On 03/09/2019 13:02, Kevin Wolf wrote: > Am 01.09.2019 um 13:53 hat Andrey Shinkevich geschrieben: >> In the current implementation of the QEMU bash iotests, only qemu-io >> processes may be run under the Valgrind with the switch '-valgrind'. >> Let's allow the common.rc bash script running all

Re: [Qemu-block] [PATCH] block: qcow2: free 'refcount_table' in error path

Am 31.08.2019 um 04:04 hat Li Qiang geschrieben: > Currently, when doing './check -qcow2 098'. We can get following > asan output: > > qemu-img: Could not empty blkdebug:TEST_DIR/blkdebug.conf:TEST_DIR/t.IMGFMT: > Input/output error > + >

Re: [Qemu-block] [PULL 00/12] Block patches

On Tue, 27 Aug 2019 at 21:16, Stefan Hajnoczi wrote: > > The following changes since commit dac03af5d5482ec7ee9c23db467bb7230b33c0d9: > > Merge remote-tracking branch 'remotes/rth/tags/pull-axp-20190825' into > staging (2019-08-27 10:00:51 +0100) > > are available in the Git repository at: > >

Re: [Qemu-block] [PATCH v7 0/6] Allow Valgrind checking all QEMU processes

Am 01.09.2019 um 13:53 hat Andrey Shinkevich geschrieben: > In the current implementation of the QEMU bash iotests, only qemu-io > processes may be run under the Valgrind with the switch '-valgrind'. > Let's allow the common.rc bash script running all other QEMU processes, > such as qemu-kvm,

Re: [Qemu-block] [PATCH v6 42/42] iotests: Test committing to overridden backing

09.08.2019 19:14, Max Reitz wrote: > Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [Qemu-block] [PATCH V2] block/vhdx: add check for truncated image files

Am 02.09.19 um 17:24 schrieb Peter Lieven: qemu is currently not able to detect truncated vhdx image files. Add a basic check if all allocated blocks are reachable at open and report all errors during bdrv_co_check. Signed-off-by: Peter Lieven --- V2: - add error reporting [Kevin] - use

Re: [Qemu-block] [PATCH v2 0/5] vpc: Return 0 from vpc_co_create() on success

Am 02.09.2019 um 21:33 hat Max Reitz geschrieben: > (v2 for “block: Let blockdev-create return 0 on success”) > > Jobs are expected to return 0 on success, so this extends to > .bdrv_co_create(). After some inspection, it turns out that vpc is the > only block driver that may return a positive

Re: [Qemu-block] [PULL 00/15] Block patches

On Tue, 27 Aug 2019 at 19:23, Max Reitz wrote: > > The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4: > > Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into > staging (2019-08-27 15:52:36 +0100) > > are available in the Git repository at: > >

Re: [Qemu-block] [PATCH v6 25/42] mirror: Deal with filters

02.09.2019 17:35, Max Reitz wrote: > On 31.08.19 11:57, Vladimir Sementsov-Ogievskiy wrote: >> 09.08.2019 19:13, Max Reitz wrote: >>> This includes some permission limiting (for example, we only need to >>> take the RESIZE permission for active commits where the base is smaller >>> than the top).

Re: [Qemu-block] [PATCH v9 13/13] block/backup: use backup-top instead of write notifiers

02.09.2019 19:34, Max Reitz wrote: > On 29.08.19 16:55, Vladimir Sementsov-Ogievskiy wrote: >> 28.08.2019 22:50, Max Reitz wrote: >>> On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: Drop write notifiers and use filter node instead. = Changes = 1. add