21.04.2020 19:56, Kevin Wolf wrote:
Am 21.04.2020 um 09:35 hat Vladimir Sementsov-Ogievskiy geschrieben:
Add python script with new logic of searching for tests:
Current ./check behavior:
- tests are named [0-9][0-9][0-9]
- tests must be registered in group file (even if test doesn't
21.04.2020 19:03, Kevin Wolf wrote:
Am 21.04.2020 um 09:35 hat Vladimir Sementsov-Ogievskiy geschrieben:
QEMU_VXHS_PROG is used only in common.rc. So, move it to common.rc,
simplifying a bit further conversion of check into python
Signed-off-by: Vladimir Sementsov-Ogievskiy
This feels
Signed-off-by: Eric Blake
---
Squash this into patch 3/6 to fix docker-test-mingw@fedora
qemu-img.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-img.c b/qemu-img.c
index 6cfc1f52ef98..cc87eaf12778 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -4529,7 +4529,7 @@ static
Patchew URL: https://patchew.org/QEMU/20200421212019.170707-1-ebl...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
On 4/1/20 10:01 AM, Vladimir Sementsov-Ogievskiy wrote:
NBD spec is updated, so that max_block doesn't relate to
NBD_CMD_TRIM. So, drop the restriction.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/nbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric
On 4/17/20 11:34 AM, Eric Blake wrote:
It's useful to know how much space can be occupied by qcow2 persistent
bitmaps, even though such metadata is unrelated to the guest-visible
data. Report this value as an additional field. Update iotest 190 to
cover it.
The addition of a new field
Upcoming patches want to add some basic bitmap manipulation abilities
to qemu-img. But blockdev.o is too heavyweight to link into qemu-img
(among other things, it would drag in block jobs and transaction
support - qemu-img does offline manipulation, where atomicity is less
important because there
Add a new test covering the 'qemu-img bitmap' subcommand, as well as
'qemu-img convert --bitmaps', both added in recent patches.
Signed-off-by: Eric Blake
---
tests/qemu-iotests/291 | 103 +
tests/qemu-iotests/291.out | 78
Make it easier to copy all the persistent bitmaps of a source image
along with the contents, by adding a boolean flag for use with
qemu-img convert. This is basically shorthand, as the same effect
could be accomplished with a series of 'qemu-img bitmap --add' and
'qemu-img bitmap --merge -b
It's useful to know how much space can be occupied by qcow2 persistent
bitmaps, even though such metadata is unrelated to the guest-visible
data. Report this value as an additional field. Update iotest 190 to
cover it and a portion of the just-added qemu-img bitmap command.
The addition of a
Include actions for --add, --remove, --clear, --enable, --disable, and
--merge (note that --clear is a bit of fluff, because the same can be
accomplished by removing a bitmap and then adding a new one in its
place, but it matches what QMP commands exist). Listing is omitted,
because it does not
We already list the subcommand summaries alphabetically, we should do
the same for the documentation related to subcommand-specific
parameters.
Signed-off-by: Eric Blake
---
docs/tools/qemu-img.rst | 48 -
1 file changed, 24 insertions(+), 24 deletions(-)
Without this series, the process for copying one qcow2 image to
another including all of its bitmaps involves running qemu and doing
the copying by hand with a series of QMP commands. This makes the
process a bit more convenient.
Series can also be downloaded at:
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote:
> Add a command to display current devices temperature in the monitor:
>
> (qemu) info temp
> Temperatures (in C):
> videocore 25.00
> bcm2835-thermal-0 25.00
>
> Signed-off-by: Philippe
Am 21.04.2020 um 09:35 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Add python script with new logic of searching for tests:
>
> Current ./check behavior:
> - tests are named [0-9][0-9][0-9]
> - tests must be registered in group file (even if test doesn't belong
>to any group, like 142)
On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Changes since v1
>
> * nvme: fix pci doorbell size calculation
> - added some defines and a better comment (Philippe)
>
> * nvme: rename trace events to pci_nvme
> - changed the prefix from
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote:
> Add a command to query current temperature from all sensors able
> to report it:
>
> { "execute": "query-temperature-sensors" }
> {
> "return": [
> {
> "temperature": 25,
> "name": "videocore"
>
On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Signed-off-by: Klaus Jensen
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/block/nvme.c | 52 +++--
> 1 file changed, 29 insertions(+), 23 deletions(-)
>
> diff --git
On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Signed-off-by: Klaus Jensen
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/block/nvme.c | 49 +++--
> 1 file changed, 27 insertions(+), 22 deletions(-)
>
> diff --git
Am 21.04.2020 um 09:35 hat Vladimir Sementsov-Ogievskiy geschrieben:
> QEMU_VXHS_PROG is used only in common.rc. So, move it to common.rc,
> simplifying a bit further conversion of check into python
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
This feels inconsistent when every other
On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme.c | 30 ++
> 1 file changed, 18 insertions(+), 12 deletions(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index
On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme.c | 46 ++
> 1 file changed, 26 insertions(+), 20 deletions(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
>
Am 21.04.2020 um 08:38 hat Klaus Birkelund Jensen geschrieben:
> On Apr 21 02:38, Keith Busch wrote:
> > The series looks good to me.
> >
> > Reviewed-by: Keith Busch
>
> Thanks for the review Keith!
>
> Kevin, should I rebase this on block-next? I think it might have some
> conflicts with the
On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Introduce some small helpers to make the next patches easier on the eye.
>
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme.c | 3 +--
> hw/block/nvme.h | 16
> 2 files changed, 17
On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme.c | 13 ++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 45a352b63d89..80da0825d295
On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Signed-off-by: Klaus Jensen
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/block/nvme.c | 22 +-
> 1 file changed, 13 insertions(+), 9 deletions(-)
>
> diff --git a/hw/block/nvme.c
On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme.c | 43 ---
> 1 file changed, 28 insertions(+), 15 deletions(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index
Vladimir Sementsov-Ogievskiy wrote on
04/20/2020 11:04:33 AM:
> Yes, the problem is that copy_range subsystem handles block-status,
> when generic backup copying loop doesn't. I'm not sure that adding
> fallback into copy-range is a correct thing to do, at least it
> should be optional,
20.04.2020 21:36, Andrey Shinkevich wrote:
Note: this series is based on the one "block: Deal with filters"
by Max Reitz that can be found in the branches:
https://git.xanclic.moe/XanClic/qemu child-access-functions-v6
https://github.com/XanClic/qemu
21.04.2020 15:54, Eric Blake wrote:
On 4/21/20 2:35 AM, Vladimir Sementsov-Ogievskiy wrote:
Somehow, this doesn't work if you just call ./277. But check 277 works.
We are going to new iotests running framework, which will consider test
files as self-executable, so let's just change it now.
20.04.2020 21:36, Andrey Shinkevich wrote:
The patch completes the series with the COR-filter insertion to any
block-stream operation. It also makes changes to the iotests 030, 141
and 245.
Signed-off-by: Andrey Shinkevich
---
block/stream.c | 151
On 4/21/20 2:35 AM, Vladimir Sementsov-Ogievskiy wrote:
All other test files are executable, except for this one. Fix that.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/283 | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755
On 4/21/20 2:35 AM, Vladimir Sementsov-Ogievskiy wrote:
Somehow, this doesn't work if you just call ./277. But check 277 works.
We are going to new iotests running framework, which will consider test
files as self-executable, so let's just change it now.
This is a rather vague explanation.
21.04.2020 15:40, Vladimir Sementsov-Ogievskiy wrote:
20.04.2020 21:36, Andrey Shinkevich wrote:
Provide the possibility to pass the 'filter-node-name' parameter to the
block-stream job as it is done for the commit block job.
So, you add it, but it actually do nothing for now. I'd prefer to
20.04.2020 21:36, Andrey Shinkevich wrote:
Provide the possibility to pass the 'filter-node-name' parameter to the
block-stream job as it is done for the commit block job.
So, you add it, but it actually do nothing for now. I'd prefer to make this
patch the last one, so it actually make the
Some information about why we need it would be nice.
Still I see same function in commit.c, so most probably it's OK.
20.04.2020 21:36, Andrey Shinkevich wrote:
Signed-off-by: Andrey Shinkevich
---
block/copy-on-read.c | 7 +++
1 file changed, 7 insertions(+)
diff --git
20.04.2020 21:36, Andrey Shinkevich wrote:
When it comes to the check for the blocked operations, the node may be
a filter linked to blk.
"blk" commonly refers to BlockBackend, which is unrelated here. You mean just a
filter.
In that case, do not miss to set blocked
operations for the
Since we are going to reuse this code, extract it first.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/tmp421.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/hw/misc/tmp421.c b/hw/misc/tmp421.c
index 04c3b3ca6e..8003356307 100644
--- a/hw/misc/tmp421.c
20.04.2020 21:36, Andrey Shinkevich wrote:
A node above the base can be the filter of the concurrent job. In that
case, the filter cannot be removed being a part of the frozen chain.
Exclude the link to filter node from freezing and provide the safety
check for a concurrent job.
Signed-off-by:
20.04.2020 21:36, Andrey Shinkevich wrote:
This patch is the first one in the series where the COR-filter node
will be hard-coded for using in the block-stream job. The job may
be run with a block-commit job in parallel. Set the condition to
avoid the job conflicts.
I think, just skipping all
The qmp_tmp105_set_temperature() call will trigger
TempSensorClass::set_temperature(), then hmp_info_temperature()
triggers TempSensorClass::get_temperature().
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/tmp105-test.c | 18 ++
1 file changed, 18 insertions(+)
diff
The BCM2835 has a block that reports its temperature.
Let it implement the 'temperature-sensor' interface.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/bcm2835_thermal.c | 24
1 file changed, 24 insertions(+)
diff --git a/hw/misc/bcm2835_thermal.c
The BCM2835 'property' QEMU device models the serialized responses
from the VideoCore firmware. As we can query the VC for its current
temperatyre, let this model implement the 'temperature-sensor'
interface.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/bcm2835_property.c | 31
IDE drives exposing a SMART interface report the air flow
temperature. Let them implement the 'temperature-sensor'
interface.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ide/qdev.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index
The 4-wire ADS7846 Touch Screen Controller is able to report a
pair of temperatures. Let it implement the 'temperature-sensor'
interface.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/ads7846.c | 38 ++
1 file changed, 38 insertions(+)
diff --git
The IMX6UL Clock Control Module can report few temperatures.
While the model doesn't implement it, we can still let it
implement the 'temperature-sensor' interface.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/imx6ul_ccm.c | 7 +++
1 file changed, 7 insertions(+)
diff --git
Since we are going to reuse this code, extract it as helpers.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/tmp105.c | 31 ---
1 file changed, 20 insertions(+), 11 deletions(-)
diff --git a/hw/misc/tmp105.c b/hw/misc/tmp105.c
index 75ddad3a12..754c8a6eb4 100644
We are going to modify this variable, move it to the device state.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/misc/bcm2835_property.h | 1 +
hw/misc/bcm2835_property.c | 8 +---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git
We are going to modify this variable, move it to the device state.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/misc/bcm2835_thermal.h | 1 +
hw/misc/bcm2835_thermal.c | 18 +-
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git
The TMP105 is an I2C temperature sensor.
Let it implement the 'temperature-sensor' interface.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/tmp105.c | 20
1 file changed, 20 insertions(+)
diff --git a/hw/misc/tmp105.c b/hw/misc/tmp105.c
index 754c8a6eb4..1f0cb28012
The TMP421 is an I2C device with multiple temperature sensors.
Let it implement the 'temperature-sensor' interface.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/tmp421.c | 24
1 file changed, 24 insertions(+)
diff --git a/hw/misc/tmp421.c b/hw/misc/tmp421.c
index
Since we are going to reuse this code, extract it first.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/tmp421.c | 27 +--
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/hw/misc/tmp421.c b/hw/misc/tmp421.c
index 8003356307..270e7d5510 100644
---
Add a command to display current devices temperature in the monitor:
(qemu) info temp
Temperatures (in C):
videocore 25.00
bcm2835-thermal-0 25.00
Signed-off-by: Philippe Mathieu-Daudé
---
include/monitor/hmp.h | 1 +
hw/misc/temp-sensor.c |
Introduce an interface to set and get temperature from devices.
A device can have multiple temperature sensors.
Each sensor might have a custom name.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/misc/temp-sensor.h | 69 +++
hw/misc/temp-sensor.c
Add a command to query current temperature from all sensors able
to report it:
{ "execute": "query-temperature-sensors" }
{
"return": [
{
"temperature": 25,
"name": "videocore"
},
{
"temperature": 25,
Use a definition instead of a magic value.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/tmp421.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/misc/tmp421.c b/hw/misc/tmp421.c
index c0bc150bca..04c3b3ca6e 100644
--- a/hw/misc/tmp421.c
+++ b/hw/misc/tmp421.c
Hi,
This series is part of a bigger one I was preparing for a GSoC
project, but unfortunately no student got interested.
The idea is to allow device with temperature sensors to use a
common API with temperature operations.
While guest are running, you can modify the temperatures to check
the
21.04.2020 11:11, Denis Plotnikov wrote:
The test checks fulfilling qcow2 requirements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Tested-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
* Andrey Shinkevich (andrey.shinkev...@virtuozzo.com) wrote:
> Provide the possibility to pass the 'filter-node-name' parameter to the
> block-stream job as it is done for the commit block job.
>
> Signed-off-by: Andrey Shinkevich
> ---
> block/stream.c| 5 +++--
> blockdev.c
On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Signed-off-by: Klaus Jensen
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/block/nvme.c | 7 ++-
> hw/block/nvme.h | 2 --
> 2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/hw/block/nvme.c
20.04.2020 16:32, Kevin Wolf wrote:
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Tested-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/274 | 152
tests/qemu-iotests/274.out | 202
20.04.2020 16:32, Kevin Wolf wrote:
This changes the output of some files where instead of filter_img_info()
now filter_testfiles() takes precedence, so update the reference output.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/iotests.py | 5 -
tests/qemu-iotests/206.out| 12
21.04.2020 13:50, Alberto Garcia wrote:
On Tue 21 Apr 2020 10:47:17 AM CEST, Vladimir Sementsov-Ogievskiy
wrote:
+if ((flags & BDRV_REQ_ZERO_WRITE) && offset > old_length) {
+ret = qcow2_cluster_zeroize(bs, old_length, offset - old_length, 0);
Hmm. As I understand,
20.04.2020 16:32, Kevin Wolf wrote:
When extending the size of an image that has a backing file larger than
its old size, make sure that the backing file data doesn't become
visible in the guest, but the added area is properly zeroed out.
Consider the following scenario where the overlay is
20.04.2020 16:32, Kevin Wolf wrote:
For regular files, we always get BDRV_REQ_ZERO_WRITE behaviour from the
OS, so we can advertise the flag and just ignore it.
Signed-off-by: Kevin Wolf
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On Tue 21 Apr 2020 10:47:17 AM CEST, Vladimir Sementsov-Ogievskiy
wrote:
>> +if ((flags & BDRV_REQ_ZERO_WRITE) && offset > old_length) {
>> +ret = qcow2_cluster_zeroize(bs, old_length, offset - old_length, 0);
>
> Hmm. As I understand, qcow2_cluster_zeroize is unprepared to
>
Philippe Mathieu-Daudé writes:
> These scripts are loaded as plugin by GDB (and they don't
> have any __main__ entry point). Remove the shebang header.
>
> Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Alex Bennée
> ---
> scripts/qemugdb/__init__.py | 3 +--
> scripts/qemugdb/aio.py
Philippe Mathieu-Daudé writes:
> Keep an eye on these "same same, but different" files.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Cc: "Alex Bennée"
Acked-by: Alex Bennée
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index
On Tue 21 Apr 2020 10:11:14 AM CEST, Denis Plotnikov
wrote:
> The patch adds some preparation parts for incompatible compression type
> feature to qcow2 allowing the use different compression methods for
> image clusters (de)compressing.
>
> It is implied that the compression type is set on the
On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Pull the controller memory buffer check to its own function. The check
> will be used on its own in later patches.
>
> Signed-off-by: Klaus Jensen
> Acked-by: Keith Busch
> Reviewed-by: Philippe Mathieu-Daudé
>
Keep an eye on these "same same, but different" files.
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: "Alex Bennée"
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8cbc1fac2b..7a7f2b9c31 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2083,6
On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Change the prefix of all nvme device related trace events to 'pci_nvme'
> to not clash with trace events from the nvme block driver.
>
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme.c | 190
These scripts are loaded as plugin by GDB (and they don't
have any __main__ entry point). Remove the shebang header.
Signed-off-by: Philippe Mathieu-Daudé
---
scripts/qemugdb/__init__.py | 3 +--
scripts/qemugdb/aio.py | 3 +--
scripts/qemugdb/coroutine.py | 3 +--
Signed-off-by: Philippe Mathieu-Daudé
---
scripts/qmp/qom-get | 2 +-
scripts/qmp/qom-list | 2 +-
scripts/qmp/qom-set | 2 +-
scripts/qmp/qom-tree | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/qmp/qom-get b/scripts/qmp/qom-get
index 007b4cd442..72ccd79330
QEMU Python scripts have been moved in commit 8f8fd9edba4 ("Introduce
Python module structure"). Use the same sys.path modification used
in the referenced commit to be able to use these scripts again.
Signed-off-by: Philippe Mathieu-Daudé
---
scripts/qmp/qmp | 4 +++-
scripts/qmp/qom-fuse
Trivial Python3 fixes, again...
Philippe Mathieu-Daudé (4):
MAINTAINERS: Cover the GDB Python scripts in the gdbstub section
scripts/qemugdb: Remove shebang header
scripts/qmp: Use Python 3 interpreter
scripts/qmp: Fix QEMU Python scripts path
MAINTAINERS | 1 +
On Wed, 2020-04-15 at 15:13 +0200, Philippe Mathieu-Daudé wrote:
> On 4/15/20 3:01 PM, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > The size of the BAR is 0x1000 (main registers) + 8 bytes for each
> > queue. Currently, the size of the BAR is calculated like so:
> >
> > n->reg_size =
On Wed, Apr 15, 2020 at 07:51:38AM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> The emulated nvme device (hw/block/nvme.c) is currently using an
> internal Intel device id.
>
> Prepare to change that by allocating a device id under the 1b36 (Red
> Hat, Inc.) vendor id.
>
>
20.04.2020 16:32, Kevin Wolf wrote:
If BDRV_REQ_ZERO_WRITE is set and we're extending the image, calling
qcow2_cluster_zeroize() with flags=0 does the right thing: It doesn't
undo any previous preallocation, but just adds the zero flag to all
relevant L2 entries. If an external data file is in
On 20/04/2020 17:55, Kevin Wolf wrote:
> Am 20.04.2020 um 12:41 hat Laurent Vivier geschrieben:
>> This series introduces new QMP/HMP commands to dump the status
>> of a a virtio device at different levels.
>
> What is the intended use case for these commands?
>
> If it's just for debugging,
20.04.2020 16:32, Kevin Wolf wrote:
Now that node level interface bdrv_truncate() supports passing request
flags to the block driver, expose this on the BlockBackend level, too.
Signed-off-by: Kevin Wolf
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
20.04.2020 16:32, Kevin Wolf wrote:
Now that block drivers can support flags for .bdrv_co_truncate, expose
the parameter in the node level interfaces bdrv_co_truncate() and
bdrv_truncate().
Signed-off-by: Kevin Wolf
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
[..]
@@ -4169,7 +4170,7
20.04.2020 16:32, Kevin Wolf wrote:
This adds a new BdrvRequestFlags parameter to the .bdrv_co_truncate()
driver callbacks, and a supported_truncate_flags field in
BlockDriverState that allows drivers to advertise support for request
flags in the context of truncate.
For now, we always pass 0
zstd significantly reduces cluster compression time.
It provides better compression performance maintaining
the same level of the compression ratio in comparison with
zlib, which, at the moment, is the only compression
method available.
The performance test results:
Test compresses and
v20:
04: fix a number of flaws [Vladimir]
* don't use $RAND_FILE passing to qemu-io,
so check $TEST_DIR is redundant
* re-arrage $RAND_FILE writing
* fix a typo
v19:
04: fix a number of flaws [Eric]
* remove rudundant test case descriptions
* fix
The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different compression methods for
image clusters (de)compressing.
It is implied that the compression type is set on the image creation and
can be changed only later by image conversion, thus
The patch enables processing the image compression type defined
for the image and chooses an appropriate method for image clusters
(de)compression.
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
---
block/qcow2-threads.c | 71
The test checks fulfilling qcow2 requirements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov
---
tests/qemu-iotests/287 | 146 +
tests/qemu-iotests/287.out | 67 +
All other test files are executable, except for this one. Fix that.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/283 | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 tests/qemu-iotests/283
diff --git a/tests/qemu-iotests/283
21.04.2020 10:36, Vladimir Sementsov-Ogievskiy wrote:
Just use classes introduced in previous three commits. Behavior
difference is described in these three commits.
Drop group file, as it becomes unused.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/check | 965
We are going to drop group file. Define group in tests as a preparatory
step.
The patch is generated by
cd tests/qemu-iotests
grep '^[0-9]\{3\} ' group | while read line; do
file=$(awk '{print $1}' <<< "$line");
groups=$(sed -e 's/^... //' <<< "$line");
awk
Add TestRunner class, which will run tests in a new python iotests
running framework.
There are some differences with current ./check behavior, most
significant are:
- Consider all tests self-executable, just run them, don't run python
by hand.
- Elapsed time is cached in json file
- Elapsed
Just use classes introduced in previous three commits. Behavior
difference is described in these three commits.
Drop group file, as it becomes unused.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/check | 965 ++-
Add python script with new logic of searching for tests:
Current ./check behavior:
- tests are named [0-9][0-9][0-9]
- tests must be registered in group file (even if test doesn't belong
to any group, like 142)
Behavior of new test:
- group file is dropped
- tests are searched by
Rename bitmaps migration tests to demonstrate new test naming
convention.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/{199 => migrate-bitmaps-postcopy-test} | 0
tests/qemu-iotests/{199.out => migrate-bitmaps-postcopy-test.out} | 0
tests/qemu-iotests/{169 =>
QEMU_VXHS_PROG is used only in common.rc. So, move it to common.rc,
simplifying a bit further conversion of check into python
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/check | 15 ---
tests/qemu-iotests/common.rc | 14 ++
2 files changed, 14
Somehow, this doesn't work if you just call ./277. But check 277 works.
We are going to new iotests running framework, which will consider test
files as self-executable, so let's just change it now.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/277 | 2 +-
1 file changed, 1
We are going to be stricter about comparing test result with .out
files. So, fix some whitespaces now.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/175.out | 2 +-
tests/qemu-iotests/267.out | 48 +++---
2 files changed, 25 insertions(+),
Add TestEnv class, which will handle test environment in a new python
iotests running framework.
Difference with current ./check interface:
- -v (verbose) option dropped, as it is unused
- -xdiff option is dropped, until somebody complains that it is needed
- same for -n option
Signed-off-by:
Hi all!
This is a continuation for "[PATCH v2 0/2] Rework iotests finding",
so main user-visible feature here is removing tests/qemu-iotests/group
file, define groups in tests and allow human-readable names for iotests.
While being here, rewrite check into python :) I tried to keep most of
its
1 - 100 of 101 matches
Mail list logo
