19.06.2020 22:56, Eric Blake wrote:
From: John Snow
This job copies the allocation map into a bitmap. It's a job because
there's no guarantee that allocation interrogation will be quick (or
won't hang), so it cannot be retrofitted into block-dirty-bitmap-merge.
It was designed with different p
19.06.2020 13:07, Denis V. Lunev wrote:
bdrv_save_vmstate() returns either error with negative return value or
size. Thus this check is useless.
Signed-off-by: Denis V. Lunev
Suggested-by: Eric Blake
CC: Kevin Wolf
CC: Max Reitz
CC: Stefan Hajnoczi
CC: Fam Zheng
CC: Juan Quintela
CC: "Dr. David
Give ourselves an out if we need to tweak the interface, in order to
gain more experience with what works when libvirt experiments with
using it.
Signed-off-by: Eric Blake
---
qapi/block-core.json | 6 +-
qapi/transaction.json | 4 +-
blockdev.c | 14 ++--
tests/q
From: John Snow
They have the same fields -- rename it BlockJobActionState.
Signed-off-by: John Snow
Signed-off-by: Eric Blake
---
blockdev.c | 30 --
1 file changed, 12 insertions(+), 18 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 72df193ca73b..6d80af
From: John Snow
Signed-off-by: John Snow
Message-Id: <20200514034922.24834-5-js...@redhat.com>
Signed-off-by: Eric Blake
---
tests/qemu-iotests/257| 110 +---
tests/qemu-iotests/bitmaps.py | 131 ++
2 files changed, 132 insertions
From: John Snow
This is a new job-creating command.
Signed-off-by: John Snow
Signed-off-by: Eric Blake
---
qapi/block-core.json | 18 +++
qapi/transaction.json | 2 ++
blockdev.c| 74 +++
3 files changed, 94 insertions(+)
diff --g
From: John Snow
This job copies the allocation map into a bitmap. It's a job because
there's no guarantee that allocation interrogation will be quick (or
won't hang), so it cannot be retrofitted into block-dirty-bitmap-merge.
It was designed with different possible population patterns in mind,
b
[From John's original cover letter:]
This is a new (very small) block job that writes a pattern into a
bitmap. The only pattern implemented is the top allocation information.
This can be used to "recover" an incremental bitmap chain if an external
snapshot was taken without creating a new bitmap f
On Wed, 17 Jun 2020 16:09:09 +0100
Stefan Hajnoczi wrote:
> On Mon, May 25, 2020 at 05:44:26PM +0200, Lukas Straub wrote:
> > @@ -1395,6 +1407,15 @@ static int nbd_client_reopen_prepare(BDRVReopenState
> > *state,
> > return 0;
> > }
> >
> > +static void nbd_yank(void *opaque)
> > +{
> >
On 6/18/20 2:25 AM, Klaus Jensen wrote:
> On Jun 16 22:18, Andrzej Jakowski wrote:
>> So far it was not possible to have CMB and PMR emulated on the same
>> device, because BAR2 was used exclusively either of PMR or CMB. This
>> patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors
On 6/19/20 12:44 PM, Kevin Wolf wrote:
> Am 19.06.2020 um 17:04 hat John Snow geschrieben:
>> On 6/18/20 5:23 AM, Kevin Wolf wrote:
>>> Am 17.06.2020 um 22:27 hat John Snow geschrieben:
> In the Avocado project, we have a `make develop` rule that does that
> for the main setup.py file, a
On Fri, 19 Jun 2020 17:52:40 +0100
Daniel P. Berrangé wrote:
> On Fri, Jun 19, 2020 at 06:29:24PM +0200, Lukas Straub wrote:
> > On Wed, 17 Jun 2020 16:12:40 +0100
> > Stefan Hajnoczi wrote:
> >
> > > On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub wrote:
> > > > +static struct YankI
On Fri, Jun 19, 2020 at 04:23:50PM +0200, Lukas Straub wrote:
> On Tue, 16 Jun 2020 15:39:57 +0100
> Daniel P. Berrangé wrote:
>
> > On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub wrote:
> > > The yank feature allows to recover from hanging qemu by "yanking"
> > > at various parts. Other
On Fri, Jun 19, 2020 at 06:29:24PM +0200, Lukas Straub wrote:
> On Wed, 17 Jun 2020 16:12:40 +0100
> Stefan Hajnoczi wrote:
>
> > On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub wrote:
> > > +static struct YankInstance *yank_find_instance(char *name)
> >
> > There are const char * -> ch
On Fri 19 Jun 2020 12:40:11 PM CEST, Max Reitz wrote:
> +if (qcow2_opts->data_file_raw &&
> +qcow2_opts->preallocation == PREALLOC_MODE_OFF)
> +{
> +/*
> + * data-file-raw means that "the external data file can be
> + * read as a consistent standalone raw ima
Am 19.06.2020 um 17:04 hat John Snow geschrieben:
> On 6/18/20 5:23 AM, Kevin Wolf wrote:
> > Am 17.06.2020 um 22:27 hat John Snow geschrieben:
> >>> In the Avocado project, we have a `make develop` rule that does that
> >>> for the main setup.py file, and for all plugins we carry on the same
> >>>
On 6/19/20 7:20 PM, Eduardo Habkost wrote:
> On Thu, Jun 11, 2020 at 08:16:06PM +0300, Denis V. Lunev wrote:
>> Nowaday SCSI drivers in guests are able to align UNMAP requests before
>> sending to the device. Right now QEMU provides an ability to set
>> this via "discard_granularity" property of th
On Wed, 17 Jun 2020 16:12:40 +0100
Stefan Hajnoczi wrote:
> On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub wrote:
> > +static struct YankInstance *yank_find_instance(char *name)
>
> There are const char * -> char * casts in later patches. Please use
> const char * where possible. Calle
On Wed, 17 Jun 2020 15:39:36 +0100
Stefan Hajnoczi wrote:
> On Thu, May 21, 2020 at 04:48:06PM +0100, Daniel P. Berrangé wrote:
> > On Thu, May 21, 2020 at 05:42:41PM +0200, Lukas Straub wrote:
> > > On Thu, 21 May 2020 16:03:35 +0100
> > > Stefan Hajnoczi wrote:
> > >
> > > > On Wed, May 2
On Tue, 16 Jun 2020 15:44:06 +0100
Daniel P. Berrangé wrote:
> On Mon, May 25, 2020 at 05:44:26PM +0200, Lukas Straub wrote:
> > Register a yank function which shuts down the socket and sets
> > s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an
> > error occured.
> >
> > Signed-off
On Thu, Jun 11, 2020 at 08:16:06PM +0300, Denis V. Lunev wrote:
> Nowaday SCSI drivers in guests are able to align UNMAP requests before
> sending to the device. Right now QEMU provides an ability to set
> this via "discard_granularity" property of the block device which could
> be used by manageme
On 6/19/20 11:15 AM, Philippe Mathieu-Daudé wrote:
> On 6/17/20 10:27 PM, John Snow wrote:
>>
>>
>> On 6/17/20 3:52 PM, Cleber Rosa wrote:
>>> On Tue, Jun 02, 2020 at 08:15:16PM -0400, John Snow wrote:
> [...]
>>> Are you proposing that we have, say, "python-qemu" version 10, being
>>> the 10th
On 6/17/20 10:27 PM, John Snow wrote:
>
>
> On 6/17/20 3:52 PM, Cleber Rosa wrote:
>> On Tue, Jun 02, 2020 at 08:15:16PM -0400, John Snow wrote:
[...]
>> Are you proposing that we have, say, "python-qemu" version 10, being
>> the 10th API version, without any regard to the QEMU version
>> support
On 6/18/20 11:23 AM, Kevin Wolf wrote:
> Am 17.06.2020 um 22:27 hat John Snow geschrieben:
>>> In the Avocado project, we have a `make develop` rule that does that
>>> for the main setup.py file, and for all plugins we carry on the same
>>> tree, which is similar in some regards to the "not at the
On 6/18/20 5:23 AM, Kevin Wolf wrote:
> Am 17.06.2020 um 22:27 hat John Snow geschrieben:
>>> In the Avocado project, we have a `make develop` rule that does that
>>> for the main setup.py file, and for all plugins we carry on the same
>>> tree, which is similar in some regards to the "not at th
On Tue, 16 Jun 2020 15:39:57 +0100
Daniel P. Berrangé wrote:
> On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub wrote:
> > The yank feature allows to recover from hanging qemu by "yanking"
> > at various parts. Other qemu systems can register themselves and
> > multiple yank functions. Then
On 6/19/20 5:11 AM, Stefan Hajnoczi wrote:
Small fixes for qemu-storage-daemon.
Stefan Hajnoczi (2):
qemu-storage-daemon: remember to add qemu_object_opts
qemu-storage-daemon: add missing cleanup calls
For both patches,
Reviewed-by: Eric Blake
qemu-storage-daemon.c | 5 +
1 fi
On Thu, Jun 11, 2020 at 10:36:22AM +0200, Sergio Lopez wrote:
> Hi,
>
> While debugging BZ#1844343, I managed to reproduce the issue which
> leads to crash with a backtrace like this one:
>
> < snip >
> Thread 2 (Thread 0x7fe208463f00 (LWP 1659571)):
> #0 0x7fe2033b78ed in __lll_lock
On Fri, Jun 19, 2020 at 12:15 PM wrote:
> /tmp/qemu-test/src/tests/qht-bench.c:287:29: error: implicit conversion from
> 'unsigned long' to 'double' changes value from 18446744073709551615 to
> 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion]
> *threshold = rate * UINT64_MA
Patchew URL: https://patchew.org/QEMU/20200619104012.235977-1-mre...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
expor
On Fri, Jun 19, 2020 at 02:51:51AM -0700, no-re...@patchew.org wrote:
> Patchew URL:
> https://patchew.org/QEMU/20200619091905.21676-1-kra...@redhat.com/
>
>
>
> Hi,
>
> This series failed the asan build test. Please find the testing commands and
> their output below. If you have Docker instal
Patchew URL:
https://patchew.org/QEMU/20200619101132.2401756-1-stefa...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
e
On Fri 19 Jun 2020 09:57:27 AM CEST, Max Reitz wrote:
>> If two images have the same contents but then you compare them
>> changing the backing file of one of them you can also get a content
>> mismatch. How is this different?
>
> It’s different in that files with data-file-raw can’t have backing
>
Patchew URL: https://patchew.org/QEMU/20200619100708.30440-1-...@openvz.org/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export AR
Setting the qcow2 data-file-raw bit means that you can ignore the
qcow2 metadata when reading from the external data file. It does not
mean that you have to ignore it, though. Therefore, the data read must
be the same regardless of whether you interpret the metadata or whether
you ignore it, and
Hi,
As discussed here:
https://lists.nongnu.org/archive/html/qemu-block/2020-02/msg00644.html
https://lists.nongnu.org/archive/html/qemu-block/2020-04/msg00329.html
https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00240.html
I think that qcow2 images with data-file-raw should always h
Signed-off-by: Max Reitz
---
tests/qemu-iotests/244 | 65 ++
tests/qemu-iotests/244.out | 23 ++
2 files changed, 88 insertions(+)
diff --git a/tests/qemu-iotests/244 b/tests/qemu-iotests/244
index efe3c0428b..c2fdeab0c7 100755
--- a/tests/qemu
Several components used by qemu-storage-daemon have cleanup functions
that aren't called. Keep the "valgrind --leak-check=full" as clean as
possible by invoking the necessary cleanup functions.
Signed-off-by: Stefan Hajnoczi
---
qemu-storage-daemon.c | 4
1 file changed, 4 insertions(+)
di
The --object option is supported by qemu-storage-daemon but the
qemu_object_opts QemuOptsList wasn't being added. As a result calls to
qemu_find_opts("object") failed with "There is no option group
'object'".
This patch fixes the object-del QMP command.
Signed-off-by: Stefan Hajnoczi
---
qemu-s
Small fixes for qemu-storage-daemon.
Stefan Hajnoczi (2):
qemu-storage-daemon: remember to add qemu_object_opts
qemu-storage-daemon: add missing cleanup calls
qemu-storage-daemon.c | 5 +
1 file changed, 5 insertions(+)
--
2.26.2
This series do standard basic things:
- it creates intermediate buffer for all writes from QEMU migration code
to QCOW2 image,
- this buffer is sent to disk asynchronously, allowing several writes to
run in parallel.
In general, migration code is fantastically inefficent (by observation),
buff
It is not used outside the module.
Actually there are 2 kind of waiters:
- for a slot and
- for all tasks to finish
This patch limits external API to listed types.
Signed-off-by: Denis V. Lunev
Suggested-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Vladimir Sementsov-Ogievskiy
CC: Kevin Wolf
From: Vladimir Sementsov-Ogievskiy
Currently, aio task pool assumes that there is a main coroutine, which
creates tasks and wait for them. Let's remove the restriction by using
CoQueue. Code becomes clearer, interface more obvious.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Deni
qemu_fclose() could return error, f.e. if bdrv_co_flush() will return
the error.
This validation will become more important once we will start waiting of
asynchronous IO operations, started from bdrv_write_vmstate(), which are
coming soon.
Signed-off-by: Denis V. Lunev
Reviewed-by: "Dr. David Al
This patch does 2 standard basic things:
- it creates intermediate buffer for all writes from QEMU migration code
to block driver,
- this buffer is sent to disk asynchronously, allowing several writes to
run in parallel.
Thus bdrv_vmstate_write() is becoming asynchronous. All pending operation
bdrv_save_vmstate() returns either error with negative return value or
size. Thus this check is useless.
Signed-off-by: Denis V. Lunev
Suggested-by: Eric Blake
CC: Kevin Wolf
CC: Max Reitz
CC: Stefan Hajnoczi
CC: Fam Zheng
CC: Juan Quintela
CC: "Dr. David Alan Gilbert"
CC: Vladimir Sements
Right now bdrv_fclose() is just calling bdrv_flush().
The problem is that migration code is working inefficiently from block
layer terms and are frequently called for very small pieces of
unaligned data. Block layer is capable to work this way, but this is very
slow.
This patch is a preparation f
Patchew URL: https://patchew.org/QEMU/20200619091905.21676-1-kra...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Acked-by: John Snow
---
include/hw/block/fdc.h | 1 +
include/hw/i386/pc.h | 1 -
hw/block/fdc.c | 26 +-
hw/i386/pc.c | 25 -
4 files changed, 26 insertions(+)
Seems to be unused.
ich9 DSDT changes:
Scope (_SB.PCI0)
{
Device (ISA)
{
Name (_ADR, 0x001F) // _ADR: Address
OperationRegion (PIRQ, PCI_Config, 0x60, 0x0C)
-OperationRegion (LPCD, PCI_Config, 0x80, 0x02)
-Field (L
x86 machines can have a single ISA bus only.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i386/acpi-build.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
in
Signed-off-by: Gerd Hoffmann
---
tests/data/acpi/pc/DSDT | Bin 5014 -> 4934 bytes
tests/data/acpi/pc/DSDT.acpihmat | Bin 6338 -> 6258 bytes
tests/data/acpi/pc/DSDT.bridge| Bin 6873 -> 6793 bytes
tests/data/acpi/pc/DSDT.cphp | Bin 5477 -> 5397 bytes
tests/data/acpi/pc/DSDT.
DSDT change: isa device order changes in case MI1 (ipmi) is present.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
---
hw/block/fdc.c | 83
hw/i386/acpi-build.c | 83
stubs/cmos.c |
The _SB.PCI0.PX13.P13C opregion (holds isa device enable bits)
is not used any more, remove it from DSDT.
piix4 DSDT changes:
Scope (_SB.PCI0)
{
-Device (PX13)
-{
-Name (_ADR, 0x00010003) // _ADR: Address
-OperationRegion (P13C, PCI_Config, Zero,
Add helper function to add fw_cfg device,
also move code to hw/i386/fw_cfg.c.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Igor Mammedov
---
hw/i386/fw_cfg.h | 1 +
hw/i386/acpi-build.c | 24 +---
hw/i386/fw_cfg.c | 28 +
The _STA methods for COM+LPT used to reference them,
but that isn't the case any more.
piix4 DSDT changes:
Scope (_SB.PCI0)
{
Device (ISA)
{
Name (_ADR, 0x0001) // _ADR: Address
OperationRegion (P40C, PCI_Config, 0x60, 0x04)
-
DSDT change: isa device order changes in case MI1 (ipmi) is present.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Igor Mammedov
---
hw/i386/acpi-build.c | 39 ---
hw/input/pckbd.c | 31 +++
2 f
acpi aml generator needs this, but it is in floppy code now
so we can make the function static.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
Reviewed-by: Philippe Mathieu-Daudé
Acked-by: John Snow
---
include/hw/block/fdc.h | 2 --
hw/block/fdc.c | 4 ++--
2 files changed,
Makes it easier to create good commit messages from the logs.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
---
tests/qtest/bios-tables-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
i
Signed-off-by: Gerd Hoffmann
---
tests/qtest/bios-tables-test-allowed-diff.h | 18 ++
1 file changed, 18 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8bf4..8992f1f12b77 100644
--- a/tests/qtest
First batch of microvm patches, some generic acpi stuff.
Split the acpi-build.c monster, specifically split the
pc and q35 and pci bits into a separate file which we
can skip building at some point in the future.
v2 changes: leave acpi-build.c largely as-is, move useful
bits to other places to all
On 6/11/20 8:21 PM, Denis V. Lunev wrote:
> On 6/11/20 8:16 PM, Denis V. Lunev wrote:
>> Nowaday SCSI drivers in guests are able to align UNMAP requests before
>> sending to the device. Right now QEMU provides an ability to set
>> this via "discard_granularity" property of the block device which co
On 18.06.20 14:03, Alberto Garcia wrote:
> On Wed 03 Jun 2020 03:53:03 PM CEST, Max Reitz wrote:
>> Sorry for the long delay. :/
>
> And sorry for my long delay as well.
>
>> The patch itself looks good, but I’m not sure whether it is extensive
>> enough. Let me just jump straight to the problem
63 matches
Mail list logo
