Re: [PATCH v5 0/7] vhost-user-blk: fix the migration issue and enhance qtests

2020-09-26 Thread Dima Stepanov
On Thu, Sep 24, 2020 at 07:26:14AM -0400, Michael S. Tsirkin wrote: > On Fri, Sep 11, 2020 at 11:39:42AM +0300, Dima Stepanov wrote: > > v4 -> v5: > > - vhost: check queue state in the vhost_dev_set_log routine > > tests/qtest/vhost-user-test: prepare the tests for adding new > > dev clas

Re: [PATCH 3/3] nbd: Add 'qemu-nbd -A' to expose allocation depth

2020-09-26 Thread Vladimir Sementsov-Ogievskiy
25.09.2020 23:32, Eric Blake wrote: Allow the server to expose an additional metacontext to be requested by savvy clients. qemu-nbd adds a new option -A to expose the qemu:allocation-depth metacontext through NBD_CMD_BLOCK_STATUS; this can also be set via QMP when using nbd-server-add. qemu as

Re: [PATCH 2/3] nbd: Add new qemu:allocation-depth metacontext

2020-09-26 Thread Vladimir Sementsov-Ogievskiy
26.09.2020 10:33, Richard W.M. Jones wrote: On Fri, Sep 25, 2020 at 03:32:48PM -0500, Eric Blake wrote: +The second is related to exposing the source of various extents within +the image, with a single context named: + +qemu:allocation-depth + +In the allocation depth context, bits 0 and 1 f

Re: [PATCH 2/3] nbd: Add new qemu:allocation-depth metacontext

2020-09-26 Thread Vladimir Sementsov-Ogievskiy
25.09.2020 23:32, Eric Blake wrote: 'qemu-img map' provides a way to determine which extents of an image come from the top layer vs. inherited from a backing chain. This is useful information worth exposing over NBD. There is a proposal to add a QMP command block-dirty-bitmap-populate which can

Re: [PATCH 1/3] nbd: Simplify meta-context parsing

2020-09-26 Thread Vladimir Sementsov-Ogievskiy
25.09.2020 23:32, Eric Blake wrote: We had a premature optimization of trying to read as little from the wire as possible while handling NBD_OPT_SET_META_CONTEXT in phases. But in reality, we HAVE to read the entire string from the client before we can get to the next command, and it is easier to

Re: [PATCH 3/3] nbd: Add 'qemu-nbd -A' to expose allocation depth

2020-09-26 Thread Richard W.M. Jones
On Fri, Sep 25, 2020 at 03:32:49PM -0500, Eric Blake wrote: > Allow the server to expose an additional metacontext to be requested > by savvy clients. qemu-nbd adds a new option -A to expose the > qemu:allocation-depth metacontext through NBD_CMD_BLOCK_STATUS; this > can also be set via QMP when u

Re: [PATCH 2/3] nbd: Add new qemu:allocation-depth metacontext

2020-09-26 Thread Richard W.M. Jones
On Fri, Sep 25, 2020 at 03:32:48PM -0500, Eric Blake wrote: > +The second is related to exposing the source of various extents within > +the image, with a single context named: > + > +qemu:allocation-depth > + > +In the allocation depth context, bits 0 and 1 form a tri-state value: > + > +b