[PATCH v6 2/3] nvme: add namespace I/O optimization fields to shared header

2020-10-25 Thread Klaus Jensen
From: Klaus Jensen This adds the NPWG, NPWA, NPDG, NPDA and NOWS family of fields to the shared nvme.h header for use by later patches. Signed-off-by: Klaus Jensen Cc: Stefan Hajnoczi Cc: Fam Zheng --- include/block/nvme.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --g

[PATCH v6 1/3] hw/block/nvme: add dulbe support

2020-10-25 Thread Klaus Jensen
From: Klaus Jensen Add support for reporting the Deallocated or Unwritten Logical Block Error (DULBE). Rely on the block status flags reported by the block layer and consider any block with the BDRV_BLOCK_ZERO flag to be deallocated. Multiple factors affect when a Write Zeroes command result in

[PATCH v6 0/3] hw/block/nvme: dulbe and dsm support

2020-10-25 Thread Klaus Jensen
From: Klaus Jensen This adds support for the Deallocated or Unwritten Logical Block error recovery feature as well as the Dataset Management command. I wanted to add support for the NPDG and NPDA fields such that the host could get a hint on how many blocks to request deallocation of for the dea

[PATCH v6 3/3] hw/block/nvme: add the dataset management command

2020-10-25 Thread Klaus Jensen
From: Klaus Jensen Add support for the Dataset Management command and the Deallocate attribute. Deallocation results in discards being sent to the underlying block device. Whether of not the blocks are actually deallocated is affected by the same factors as Write Zeroes (see previous commit).

Re: [PATCH] hw/sd: Fix 2 GiB card CSD register values

2020-10-25 Thread Bin Meng
Hi Philippe, On Mon, Oct 26, 2020 at 2:56 AM Philippe Mathieu-Daudé wrote: > > On 10/25/20 4:23 PM, Bin Meng wrote: > > From: Bin Meng > > > > Per the SD spec, to indicate a 2 GiB card, BLOCK_LEN shall be 1024 > > bytes, hence the READ_BL_LEN field in the CSD register shall be 10 > > instead of

Re: [PATCH] hw/sd: Fix 2 GiB card CSD register values

2020-10-25 Thread Philippe Mathieu-Daudé
On 10/25/20 7:56 PM, Philippe Mathieu-Daudé wrote: On 10/25/20 4:23 PM, Bin Meng wrote: From: Bin Meng Per the SD spec, to indicate a 2 GiB card, BLOCK_LEN shall be 1024 bytes, hence the READ_BL_LEN field in the CSD register shall be 10 instead of 9. This fixes the acceptance test error for t

Re: [RFC PATCH 4/4] tests/acceptance: Test U-Boot/Linux from Armbian 20.08 on Orange Pi PC

2020-10-25 Thread Philippe Mathieu-Daudé
Cc'ing avocado-devel@ On 10/26/20 12:35 AM, Niek Linnenbank wrote: On Sun, Oct 25, 2020 at 3:17 AM Bin Meng > wrote: On Sun, Oct 25, 2020 at 5:01 AM Niek Linnenbank mailto:nieklinnenb...@gmail.com>> wrote: ... > After applying that change, all Orange Pi

Re: [PATCH] hw/sd: Fix 2 GiB card CSD register values

2020-10-25 Thread Philippe Mathieu-Daudé
On 10/25/20 4:23 PM, Bin Meng wrote: From: Bin Meng Per the SD spec, to indicate a 2 GiB card, BLOCK_LEN shall be 1024 bytes, hence the READ_BL_LEN field in the CSD register shall be 10 instead of 9. This fixes the acceptance test error for the NetBSD 9.0 test of the Orange Pi PC that has an e

Re: [PATCH 0/6] qemu-storage-daemon: QAPIfy --chardev

2020-10-25 Thread Markus Armbruster
Paolo Bonzini writes: > On 23/10/20 15:40, Markus Armbruster wrote: >>> >>> The benefit of the user creatable object approach is that we dont >>> have to add custom CLI args for different types of object, nor write >>> code to populate QOM from QAPI. The downside is that we're divorced >>> from t

Re: [PATCH] hw/sd: Fix 2 GiB card CSD register values

2020-10-25 Thread Niek Linnenbank
Hello Bin, On Sun, Oct 25, 2020 at 4:25 PM Bin Meng wrote: > From: Bin Meng > > Per the SD spec, to indicate a 2 GiB card, BLOCK_LEN shall be 1024 > bytes, hence the READ_BL_LEN field in the CSD register shall be 10 > instead of 9. > > This fixes the acceptance test error for the NetBSD 9.0 tes

Re: [RFC PATCH 4/4] tests/acceptance: Test U-Boot/Linux from Armbian 20.08 on Orange Pi PC

2020-10-25 Thread Niek Linnenbank
Hi Bin, On Sun, Oct 25, 2020 at 3:17 AM Bin Meng wrote: > Hi Niek, > > On Sun, Oct 25, 2020 at 5:01 AM Niek Linnenbank > wrote: > > > > Hi Philippe, > > > > I have ran this series with the new Armbian 20.08 test and noticed this > failure: > > > > -console: /dev/mmcblk0p1: The filesystem size (

Allocation change in qemu-img convert (since 5.1?)

2020-10-25 Thread Nir Soffer
We have tests for vdsm qemuimg wrapper module converting images and verifying the operation using "qemu-img compare". I found that tests using "qemu-img compare -s" started to fail recently on RHEL 8.3.0 nightly (qemu-img-5.1.0-10.module+el8.3.0+8254+568ca30d.x86_6) and Fedora 32 using virt-previe

[PATCH] hw/sd: Fix 2 GiB card CSD register values

2020-10-25 Thread Bin Meng
From: Bin Meng Per the SD spec, to indicate a 2 GiB card, BLOCK_LEN shall be 1024 bytes, hence the READ_BL_LEN field in the CSD register shall be 10 instead of 9. This fixes the acceptance test error for the NetBSD 9.0 test of the Orange Pi PC that has an expanded SD card image of 2 GiB size. F

Re: [PATCH v2 3/6] qapi: Remove wrapper struct for simple unions

2020-10-25 Thread Markus Armbruster
I apologize for writing so much. It's the only way I know to figure out how things work. This may feel like I'm trying to shoot down your patch. I'm not! I'm merely trying to understand and maybe improve it. I'd love to get rid of implicit wrapper objects, actually. They complicate things in