RE: [PATCH v4 30/32] qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr()

2020-12-13 Thread Paul Durrant
> -Original Message- > From: Eduardo Habkost > Sent: 11 December 2020 22:05 > To: qemu-de...@nongnu.org > Cc: Markus Armbruster ; Igor Mammedov > ; Stefan Berger > ; Marc-André Lureau ; > Daniel P. Berrange > ; Philippe Mathieu-Daudé ; John Snow > ; Kevin > Wolf ; Eric Blake ; Paolo

RE: [PATCH v4 23/32] qdev: Move dev->realized check to qdev_property_set()

2020-12-13 Thread Paul Durrant
> -Original Message- > From: Eduardo Habkost > Sent: 11 December 2020 22:05 > To: qemu-de...@nongnu.org > Cc: Markus Armbruster ; Igor Mammedov > ; Stefan Berger > ; Marc-André Lureau ; > Daniel P. Berrange > ; Philippe Mathieu-Daudé ; John Snow > ; Kevin > Wolf ; Eric Blake ; Paolo

RE: [PATCH v4 09/32] qdev: Make qdev_get_prop_ptr() get Object* arg

2020-12-13 Thread Paul Durrant
> -Original Message- > From: Eduardo Habkost > Sent: 11 December 2020 22:05 > To: qemu-de...@nongnu.org > Cc: Markus Armbruster ; Igor Mammedov > ; Stefan Berger > ; Marc-André Lureau ; > Daniel P. Berrange > ; Philippe Mathieu-Daudé ; John Snow > ; Kevin > Wolf ; Eric Blake ; Paolo

[PATCH v3] hw/block/nand: Decommission the NAND museum

2020-12-13 Thread Philippe Mathieu-Daudé
This is the QEMU equivalent of this Linux commit (but 7 years later): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f7025a43a9da2 The MTD subsystem has its own small museum of ancient NANDs in a form of the CONFIG_MTD_NAND_MUSEUM_IDS configuration option.

Re: [PATCH v2] hw/block/nand: Decommission the NAND museum

2020-12-13 Thread Philippe Mathieu-Daudé
On 12/14/20 1:11 AM, Philippe Mathieu-Daudé wrote: > On 10/19/20 6:05 PM, Peter Maydell wrote: >> On Tue, 15 Sep 2020 at 18:52, Philippe Mathieu-Daudé wrote: >>> >>> This is the QEMU equivalent of this Linux commit (but 7 years later): >>>

Re: [PATCH v2] hw/block/nand: Decommission the NAND museum

2020-12-13 Thread Philippe Mathieu-Daudé
On 10/19/20 6:05 PM, Peter Maydell wrote: > On Tue, 15 Sep 2020 at 18:52, Philippe Mathieu-Daudé wrote: >> >> This is the QEMU equivalent of this Linux commit (but 7 years later): >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f7025a43a9da2 >> >> The MTD

Re: [PATCH v2] hw/block/nand: Decommission the NAND museum

2020-12-13 Thread Laurent Vivier
Le 13/12/2020 à 20:01, Peter Maydell a écrit : > On Sun, 13 Dec 2020 at 17:21, Laurent Vivier wrote: >> >> Le 16/10/2020 à 18:52, Philippe Mathieu-Daudé a écrit : >>> Cc'ing qemu-trivial@ since this patch is reviewed. >>> >>> On 10/15/20 8:12 PM, Philippe Mathieu-Daudé wrote: ping^2...

Re: [PATCH v2] hw/block/nand: Decommission the NAND museum

2020-12-13 Thread Peter Maydell
On Sun, 13 Dec 2020 at 17:21, Laurent Vivier wrote: > > Le 16/10/2020 à 18:52, Philippe Mathieu-Daudé a écrit : > > Cc'ing qemu-trivial@ since this patch is reviewed. > > > > On 10/15/20 8:12 PM, Philippe Mathieu-Daudé wrote: > >> ping^2... > >> > >> On 10/1/20 7:31 PM, Philippe Mathieu-Daudé

Re: [PATCH v2] hw/block/nand: Decommission the NAND museum

2020-12-13 Thread Laurent Vivier
Le 16/10/2020 à 18:52, Philippe Mathieu-Daudé a écrit : > Cc'ing qemu-trivial@ since this patch is reviewed. > > On 10/15/20 8:12 PM, Philippe Mathieu-Daudé wrote: >> ping^2... >> >> On 10/1/20 7:31 PM, Philippe Mathieu-Daudé wrote: >>> ping qemu-block or qemu-arm? >>> >>> On 9/15/20 7:16 PM,

[PATCH v12 5/7] io/channel-tls.c: make qio_channel_tls_shutdown thread-safe

2020-12-13 Thread Lukas Straub
Make qio_channel_tls_shutdown thread-safe by using atomics when accessing tioc->shutdown. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé --- io/channel-tls.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/io/channel-tls.c

[PATCH v12 7/7] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test

2020-12-13 Thread Lukas Straub
A connecting chardev object has an additional reference by the connecting thread, so if the chardev is still connecting by the end of the test, then the chardev object won't be freed. This in turn means that the yank instance won't be unregistered and when running the next test-case

[PATCH v12 6/7] io: Document qmp oob suitability of qio_channel_shutdown and io_shutdown

2020-12-13 Thread Lukas Straub
Migration and yank code assume that qio_channel_shutdown is thread -safe and can be called from qmp oob handler. Document this after checking the code. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé --- include/io/channel.h | 5 - 1 file changed, 4

[PATCH v12 3/7] chardev/char-socket.c: Add yank feature

2020-12-13 Thread Lukas Straub
Register a yank function to shutdown the socket on yank. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi --- chardev/char-socket.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index

[PATCH v12 4/7] migration: Add yank feature

2020-12-13 Thread Lukas Straub
Register yank functions on sockets to shut them down. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Acked-by: Dr. David Alan Gilbert --- migration/channel.c | 13 + migration/migration.c | 24 migration/multifd.c | 10

[PATCH v12 1/7] Introduce yank feature

2020-12-13 Thread Lukas Straub
The yank feature allows to recover from hanging qemu by "yanking" at various parts. Other qemu systems can register themselves and multiple yank functions. Then all yank functions for selected instances can be called by the 'yank' out-of-band qmp command. Available instances can be queried by a

[PATCH v12 0/7] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-12-13 Thread Lukas Straub
Hello Everyone, So here is v12. @Marc-André Lureau, We still need an ACK for the chardev patch. Changes: v12: -rebase onto master -minor change to migration (removal of "defer" branch in qemu_start_incoming_migration) -add Reviewed-by tags v11: -squashed MAINTAINERS update into patch 1

[PATCH v12 2/7] block/nbd.c: Add yank feature

2020-12-13 Thread Lukas Straub
Register a yank function which shuts down the socket and sets s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an error occured. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- block/nbd.c | 154 +++-