Re: [PATCH v2 2/4] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

Am 16.12.2020 um 15:55 hat Sergio Lopez geschrieben: > On Wed, Dec 16, 2020 at 01:35:14PM +0100, Kevin Wolf wrote: > > Am 15.12.2020 um 18:23 hat Sergio Lopez geschrieben: > > > On Tue, Dec 15, 2020 at 04:01:19PM +0100, Kevin Wolf wrote: > > > > Am 15.12.2020 um 14:15 hat Sergio Lopez geschrieben:

Re: [PATCH v3 1/3] docs: generate qemu-storage-daemon-qmp-ref(7) man page

Am 16.12.2020 um 17:21 hat Stefan Hajnoczi geschrieben: > On Tue, Dec 15, 2020 at 05:11:06PM +0100, Kevin Wolf wrote: > > > diff --git a/docs/interop/qemu-storage-daemon-qmp-ref.rst > > > b/docs/interop/qemu-storage-daemon-qmp-ref.rst > > > new file mode 100644 > > > index 00..caf9dad23a >

Re: [PATCH v2 14/36] block: inline bdrv_child_*() permission functions calls

On Fri 27 Nov 2020 03:45:00 PM CET, Vladimir Sementsov-Ogievskiy wrote: > Each of them has only one caller. Open-coding simplifies further > pemission-update system changes. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

Re: [PATCH v3 1/3] docs: generate qemu-storage-daemon-qmp-ref(7) man page

On Wed, 16 Dec 2020 at 16:21, Stefan Hajnoczi wrote: > > On Tue, Dec 15, 2020 at 05:11:06PM +0100, Kevin Wolf wrote: > > > diff --git a/docs/interop/qemu-storage-daemon-qmp-ref.rst > > > b/docs/interop/qemu-storage-daemon-qmp-ref.rst > > > new file mode 100644 > > > index 00..caf9dad23a >

Re: [PATCH v3 1/3] docs: generate qemu-storage-daemon-qmp-ref(7) man page

On Tue, Dec 15, 2020 at 05:11:06PM +0100, Kevin Wolf wrote: > > diff --git a/docs/interop/qemu-storage-daemon-qmp-ref.rst > > b/docs/interop/qemu-storage-daemon-qmp-ref.rst > > new file mode 100644 > > index 00..caf9dad23a > > --- /dev/null > > +++ b/docs/interop/qemu-storage-daemon-qmp-re

Re: [PATCH v2 2/4] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

On Wed, Dec 16, 2020 at 01:35:14PM +0100, Kevin Wolf wrote: > Am 15.12.2020 um 18:23 hat Sergio Lopez geschrieben: > > On Tue, Dec 15, 2020 at 04:01:19PM +0100, Kevin Wolf wrote: > > > Am 15.12.2020 um 14:15 hat Sergio Lopez geschrieben: > > > > On Tue, Dec 15, 2020 at 01:12:33PM +0100, Kevin Wolf

Re: [PATCH] block: report errno when flock fcntl fails

16.12.2020 16:53, Kevin Wolf wrote: Am 16.12.2020 um 14:06 hat David Edmondson geschrieben: On Wednesday, 2020-12-16 at 12:57:46 +01, Kevin Wolf wrote: Am 16.12.2020 um 12:38 hat David Edmondson geschrieben: On Wednesday, 2020-12-16 at 12:29:40 +01, Kevin Wolf wrote: Am 15.12.2020 um 20:01

Re: [PATCH] block: report errno when flock fcntl fails

Am 16.12.2020 um 14:06 hat David Edmondson geschrieben: > On Wednesday, 2020-12-16 at 12:57:46 +01, Kevin Wolf wrote: > > > Am 16.12.2020 um 12:38 hat David Edmondson geschrieben: > >> On Wednesday, 2020-12-16 at 12:29:40 +01, Kevin Wolf wrote: > >> > >> > Am 15.12.2020 um 20:01 hat David Edmonds

Re: [PATCH v5] file-posix: detect the lock using the real file

16.12.2020 15:57, Daniel P. Berrangé wrote: On Wed, Dec 16, 2020 at 03:03:08PM +0300, Vladimir Sementsov-Ogievskiy wrote: 16.12.2020 13:41, Daniel P. Berrangé wrote: On Wed, Dec 16, 2020 at 01:25:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: 16.12.2020 12:49, Daniel P. Berrangé wrote: On We

Re: [PATCH] block: report errno when flock fcntl fails

On Wednesday, 2020-12-16 at 12:57:46 +01, Kevin Wolf wrote: > Am 16.12.2020 um 12:38 hat David Edmondson geschrieben: >> On Wednesday, 2020-12-16 at 12:29:40 +01, Kevin Wolf wrote: >> >> > Am 15.12.2020 um 20:01 hat David Edmondson geschrieben: >> >> When a call to fcntl(2) for the purpose of man

Re: [PATCH v5] file-posix: detect the lock using the real file

On Wed, Dec 16, 2020 at 03:03:08PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 16.12.2020 13:41, Daniel P. Berrangé wrote: > > On Wed, Dec 16, 2020 at 01:25:36PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > 16.12.2020 12:49, Daniel P. Berrangé wrote: > > > > On Wed, Dec 16, 2020 at 11:22:

Re: [PATCH v2 2/4] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

Am 15.12.2020 um 18:23 hat Sergio Lopez geschrieben: > On Tue, Dec 15, 2020 at 04:01:19PM +0100, Kevin Wolf wrote: > > Am 15.12.2020 um 14:15 hat Sergio Lopez geschrieben: > > > On Tue, Dec 15, 2020 at 01:12:33PM +0100, Kevin Wolf wrote: > > > > Am 14.12.2020 um 18:05 hat Sergio Lopez geschrieben:

Re: [PATCH v5] file-posix: detect the lock using the real file

16.12.2020 13:41, Daniel P. Berrangé wrote: On Wed, Dec 16, 2020 at 01:25:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: 16.12.2020 12:49, Daniel P. Berrangé wrote: On Wed, Dec 16, 2020 at 11:22:38AM +0300, Vladimir Sementsov-Ogievskiy wrote: 15.12.2020 13:53, Li Feng wrote: This patch addre

Re: [PATCH] block: report errno when flock fcntl fails

Am 16.12.2020 um 12:38 hat David Edmondson geschrieben: > On Wednesday, 2020-12-16 at 12:29:40 +01, Kevin Wolf wrote: > > > Am 15.12.2020 um 20:01 hat David Edmondson geschrieben: > >> When a call to fcntl(2) for the purpose of manipulating file locks > >> fails, report the error returned by fcntl

Re: [PATCH] block: report errno when flock fcntl fails

On Wednesday, 2020-12-16 at 12:29:40 +01, Kevin Wolf wrote: > Am 15.12.2020 um 20:01 hat David Edmondson geschrieben: >> When a call to fcntl(2) for the purpose of manipulating file locks >> fails, report the error returned by fcntl. >> >> Signed-off-by: David Edmondson > > Is appending "Resourc

Re: [PATCH] block: report errno when flock fcntl fails

Am 15.12.2020 um 20:01 hat David Edmondson geschrieben: > When a call to fcntl(2) for the purpose of manipulating file locks > fails, report the error returned by fcntl. > > Signed-off-by: David Edmondson Is appending "Resource temporarily unavailable" in the common case (a file locked by anothe

Re: [PATCH 0/2] iotests: filter qom path in 172

Am 16.12.2020 um 10:52 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > Here are two small patches to improve _filter_qom_path filter and reuse > it for 172 iotest Thanks, applied to the block branch. Kevin

Re: [PATCH v5] file-posix: detect the lock using the real file

On Wed, Dec 16, 2020 at 01:25:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 16.12.2020 12:49, Daniel P. Berrangé wrote: > > On Wed, Dec 16, 2020 at 11:22:38AM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > 15.12.2020 13:53, Li Feng wrote: > > > > This patch addresses this issue: > > > >

Re: [PATCH v5] file-posix: detect the lock using the real file

16.12.2020 12:49, Daniel P. Berrangé wrote: On Wed, Dec 16, 2020 at 11:22:38AM +0300, Vladimir Sementsov-Ogievskiy wrote: 15.12.2020 13:53, Li Feng wrote: This patch addresses this issue: When accessing a volume on an NFS filesystem without supporting the file lock, tools, like qemu-img, will c

Re: [PATCH] hw/block: m25p80: Fix fast read for SST flashes

Hi Francisco, On Wed, Dec 16, 2020 at 12:40 AM Francisco Iglesias wrote: > > Hello Bin, > > On [2020 Dec 12] Sat 17:44:27, Bin Meng wrote: > > Hi Francisco, > > > > On Sat, Dec 12, 2020 at 5:24 PM Francisco Iglesias > > wrote: > > > > > > Hi bin, > > > > > > On [2020 Dec 12] Sat 16:16:59, Bin Me

[PATCH 2/2] iotests:172: use _filter_qom_path

device[NUMBER] thing in QOM path is not stable and tracking it during code modifications is not fun. Let's filter it like it's already done in iotest 186. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/172 | 2 +- tests/qemu-iotests/172.out | 152 ++-

[PATCH 0/2] iotests: filter qom path in 172

Hi all! Here are two small patches to improve _filter_qom_path filter and reuse it for 172 iotest Vladimir Sementsov-Ogievskiy (2): iotests: make _filter_qom_path more strict iotests:172: use _filter_qom_path tests/qemu-iotests/172 | 2 +- tests/qemu-iotests/172.out | 152

[PATCH 1/2] iotests: make _filter_qom_path more strict

According to original commit, that added this filter (627f607e3dddb2), the problematic thing in qom path is device[NUMBER], not the whole path. Seems that tracking the other parts of the path in iotest output is not bad. Let's make _filter_qom_path stricter. Signed-off-by: Vladimir Sementsov-Ogiev

Re: [PATCH v5] file-posix: detect the lock using the real file

On Wed, Dec 16, 2020 at 11:22:38AM +0300, Vladimir Sementsov-Ogievskiy wrote: > 15.12.2020 13:53, Li Feng wrote: > > This patch addresses this issue: > > When accessing a volume on an NFS filesystem without supporting the file > > lock, > > tools, like qemu-img, will complain "Failed to lock byte

Re: [PATCH v5] file-posix: detect the lock using the real file

15.12.2020 13:53, Li Feng wrote: This patch addresses this issue: When accessing a volume on an NFS filesystem without supporting the file lock, tools, like qemu-img, will complain "Failed to lock byte 100". In the original code, the qemu_has_ofd_lock will test the lock on the "/dev/null" pseudo