On Thu, Feb 11, 2021 at 01:58:50PM -0500, John Snow wrote:
> This adds the python qemu packages themselves to the pipenv manifest.
> 'pipenv sync' will create a virtual environment sufficient to use the SDK.
> 'pipenv sync --dev' will create a virtual environment sufficient to use
> and test the
On Thu, Feb 11, 2021 at 01:58:49PM -0500, John Snow wrote:
> isort 5.0.0 through 5.0.4 has a bug that causes it to misinterpret
> certain "from ..." clauses that are not related to imports.
>
> Require 5.0.5 or greater.
>
> isort can be run with 'isort -c qemu' from the python root.
>
>
On Thu, Feb 11, 2021 at 01:58:48PM -0500, John Snow wrote:
> Signed-off-by: John Snow
> ---
> python/.isort.cfg | 7 ---
> python/setup.cfg | 8
> 2 files changed, 8 insertions(+), 7 deletions(-)
> delete mode 100644 python/.isort.cfg
>
Reviewed-by: Cleber Rosa
signature.asc
On Thu, Feb 11, 2021 at 01:58:47PM -0500, John Snow wrote:
> 0.730 appears to be about the oldest version that works with the
> features we want, including nice human readable output (to make sure
> iotest 297 passes), and type-parameterized Popen generics.
>
> 0.770, however, supports adding
On Thu, Feb 11, 2021 at 01:58:45PM -0500, John Snow wrote:
> flake8 3.5.x does not support the --extend-ignore syntax used in the
> .flake8 file to gracefully extend default ignores, so 3.6.x is our
> minimum requirement. There is no known upper bound.
>
> flake8 can be run from the python/
On Thu, Feb 11, 2021 at 01:58:44PM -0500, John Snow wrote:
> Update the comment concerning the flake8 exception to match commit
> 42c0dd12, whose commit message stated:
>
> A note on the flake8 exception: flake8 will warn on *any* bare except,
> but pylint's is context-aware and will suppress the
On Thu, Feb 11, 2021 at 01:58:43PM -0500, John Snow wrote:
> We are specifying >= pylint 2.6.x for two reasons:
>
> 1. For setup.cfg support, added in pylint 2.5.x
> 2. To clarify that we are using a version that has incompatibly dropped
> bad-whitespace checks.
>
> Signed-off-by: John Snow
>
On 2/16/21 10:07 PM, Cleber Rosa wrote:
On Thu, Feb 11, 2021 at 01:58:41PM -0500, John Snow wrote:
Pylint 2.5.x and 2.6.x have regressions that make import checking
inconsistent, see:
https://github.com/PyCQA/pylint/issues/3609
https://github.com/PyCQA/pylint/issues/3624
On 2/16/21 9:59 PM, Cleber Rosa wrote:
On Thu, Feb 11, 2021 at 01:58:40PM -0500, John Snow wrote:
pipenv is a tool used for managing virtual environments with pinned,
explicit dependencies. It is used for precisely recreating python
virtual environments.
pipenv uses two files to do this:
(1)
On 2/16/21 9:23 PM, Cleber Rosa wrote:
On Thu, Feb 11, 2021 at 01:58:37PM -0500, John Snow wrote:
Add setup.cfg and setup.py, necessary for installing a package via
pip. Add a rst document explaining the basics of what this package is
Nitpick 1: setup.cfg and setup.py are indeed used by pip,
On Mon, Feb 15, 2021 at 04:32:29PM -0500, John Snow wrote:
> On 2/11/21 9:52 PM, Cleber Rosa wrote:
> > On Thu, Feb 11, 2021 at 01:58:32PM -0500, John Snow wrote:
> > > This series factors the python/qemu directory as an installable
> > > package. It does not yet actually change the mechanics of
On Thu, Feb 11, 2021 at 01:58:42PM -0500, John Snow wrote:
> Delete the empty settings now that it's sharing a home with settings for
> other tools.
>
> pylint can now be run from this folder as "pylint qemu".
>
> Signed-off-by: John Snow
> ---
> python/qemu/machine/pylintrc | 58
On Thu, Feb 11, 2021 at 01:58:41PM -0500, John Snow wrote:
> Pylint 2.5.x and 2.6.x have regressions that make import checking
> inconsistent, see:
>
> https://github.com/PyCQA/pylint/issues/3609
> https://github.com/PyCQA/pylint/issues/3624
> https://github.com/PyCQA/pylint/issues/3651
>
>
On Tue, Feb 16, 2021 at 09:59:47PM -0500, Cleber Rosa wrote:
> On Thu, Feb 11, 2021 at 01:58:40PM -0500, John Snow wrote:
> > pipenv is a tool used for managing virtual environments with pinned,
> > explicit dependencies. It is used for precisely recreating python
> > virtual environments.
> >
>
On Thu, Feb 11, 2021 at 01:58:40PM -0500, John Snow wrote:
> pipenv is a tool used for managing virtual environments with pinned,
> explicit dependencies. It is used for precisely recreating python
> virtual environments.
>
> pipenv uses two files to do this:
>
> (1) Pipfile, which is similar in
On Thu, Feb 11, 2021 at 01:58:38PM -0500, John Snow wrote:
> Python infrastructure as it exists today is not capable reliably of
> single-sourcing a package version from a parent directory. The authors
> of pip are working to correct this, but as of today this is not possible.
>
> The problem is
On Thu, Feb 11, 2021 at 01:58:37PM -0500, John Snow wrote:
> Add setup.cfg and setup.py, necessary for installing a package via
> pip. Add a rst document explaining the basics of what this package is
Nitpick 1: setup.cfg and setup.py are indeed used by pip, your
statement is correct. But, it
On Thu, Feb 11, 2021 at 01:58:36PM -0500, John Snow wrote:
> Create a space for miscellaneous things that don't belong strictly in
> "qemu.machine" nor "qemu.qmp" packages.
>
> Signed-off-by: John Snow
> ---
> python/qemu/machine/__init__.py | 8
>
On Mon, Feb 15, 2021 at 12:02:28AM +0100, Klaus Jensen wrote:
> From: Klaus Jensen
>
> This is RFC v3 of a series that adds support for metadata and end-to-end data
> protection.
>
> First, on the subject of metadata, in v1, support was restricted to
> extended logical blocks, which was pretty
On Mon, Feb 15, 2021 at 12:02:40AM +0100, Klaus Jensen wrote:
> From: Minwoo Im
>
> Format NVM admin command can make a namespace or namespaces to be
> with different LBA size and metadata size with protection information
> types.
>
> This patch introduces Format NVM command with LBA format,
On Mon, Feb 15, 2021 at 12:02:39AM +0100, Klaus Jensen wrote:
> From: Minwoo Im
>
> This patch introduces multiple LBA formats supported with the typical
> logical block sizes of 512 bytes and 4096 bytes as well as metadata
> sizes of 0, 8, 16 and 64 bytes. The format will be chosed based on the
On Mon, Feb 15, 2021 at 12:02:37AM +0100, Klaus Jensen wrote:
> From: Gollu Appalanaidu
>
> See NVM Express 1.4, section 6.14 ("Verify Command").
>
> Signed-off-by: Gollu Appalanaidu
> [k.jensen: rebased, refactored for e2e]
> Signed-off-by: Klaus Jensen
Verify is a generic block command
On Mon, Feb 15, 2021 at 12:02:36AM +0100, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add support for namespaces formatted with protection information. The
> type of end-to-end data protection (i.e. Type 1, Type 2 or Type 3) is
> selected with the `pi` nvme-ns device parameter. If the number of
On 2/16/21 10:45 AM, Vladimir Sementsov-Ogievskiy wrote:
> Rename bytes_covered_by_bitmap_cluster() to
> bdrv_dirty_bitmap_serialization_coverage() and make it public. It is
> needed as we are going to make load_bitmap_data() public in the next
> commit.
>
> Signed-off-by: Vladimir
On 2/4/21 7:48 AM, Daniel P. Berrangé wrote:
savevm, loadvm and delvm are some of the few HMP commands that have never
been converted to use QMP. The reasons for the lack of conversion are
that they blocked execution of the event thread, and the semantics
around choice of disks were ill-defined.
Am 16.02.2021 um 18:25 hat Alberto Garcia geschrieben:
> On Tue 16 Feb 2021 05:48:07 PM CET, Kevin Wolf wrote:
>
> >> There is no problem with removing the filter anymore. See here for a
> >> description of the original problem:
> >>
> >>
On Tue 16 Feb 2021 05:48:07 PM CET, Kevin Wolf wrote:
>> There is no problem with removing the filter anymore. See here for a
>> description of the original problem:
>>
>> https://lists.gnu.org/archive/html/qemu-block/2020-12/msg00090.html
>
> Ah, nice. Can we just add removing the filter again
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/087 | 8 ++--
tests/qemu-iotests/184 | 18 ++
tests/qemu-iotests/218 | 2 +-
tests/qemu-iotests/235 | 2 +-
tests/qemu-iotests/245 | 4 ++--
tests/qemu-iotests/258 | 7 +++
Rename bytes_covered_by_bitmap_cluster() to
bdrv_dirty_bitmap_serialization_coverage() and make it public. It is
needed as we are going to make load_bitmap_data() public in the next
commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/dirty-bitmap.h | 2 ++
Am 16.02.2021 um 17:36 hat Alberto Garcia geschrieben:
> On Wed 10 Feb 2021 06:26:57 PM CET, Kevin Wolf wrote:
>
> > You have a test case for adding a throttling filter. Can we also
> > remove it again or is there still a problem with that? I seem to
> > remember that that was a bit trickier,
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Follow the inclusive terminology from the "Conscious Language in your
> Open Source Projects" guidelines [*] and replace the words "whitelist"
> appropriately.
>
> [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md
>
>
Hi all!
Suddenly we need to load bitmaps from parallels image in our product.
So here is a feature.
Vladimir Sementsov-Ogievskiy (5):
qcow2-bitmap: make bytes_covered_by_bitmap_cluster() public
parallels.txt: fix bitmap L1 table description
parallels: support bitmap extension for read-only
Actually L1 table entry offset is in 512 bytes sectors. Fix the spec.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
docs/interop/parallels.txt | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/docs/interop/parallels.txt b/docs/interop/parallels.txt
index
Test support for reading bitmap from parallels image format.
parallels-with-bitmap.bz2 is generated on Virtuozzo by
parallels-with-bitmap.sh
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
.../sample_images/parallels-with-bitmap.bz2 | Bin 0 -> 203 bytes
On Wed 10 Feb 2021 06:26:57 PM CET, Kevin Wolf wrote:
> You have a test case for adding a throttling filter. Can we also
> remove it again or is there still a problem with that? I seem to
> remember that that was a bit trickier, though I'm not sure what it
> was. Was it that we can't have the
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/parallels.h | 6 +-
block/parallels-ext.c | 286 ++
block/parallels.c | 18 +++
block/meson.build | 3 +-
4 files changed, 311 insertions(+), 2 deletions(-)
create mode 100644
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 10 ++
1 file changed, 10 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 00be68eca3..ea6238f242 100644
--- a/tests/qemu-iotests/iotests.py
+++
On Tue 09 Feb 2021 09:03:02 AM CET, Vladimir Sementsov-Ogievskiy wrote:
>> { 'command': 'x-blockdev-reopen',
>> - 'data': 'BlockdevOptions', 'boxed': true }
>> + 'data': { 'options': ['BlockdevOptions'] } }
>
> Do we also want to drop x- prefix?
I think we can drop it once it's clear the the
Hi Bin,
For this series,
Tested-by: Alexander Bulekov
Thank you
-Alex
On 210216 1146, Bin Meng wrote:
> This series includes several fixes to CVE-2020-17380, CVE-2020-25085
> and CVE-2021-3409 that are heap-based buffer overflow issues existing
> in the sdhci model.
>
> These CVEs are pretty
On Tuesday, 2021-02-16 at 16:44:58 +01, Philippe Mathieu-Daudé wrote:
> On 2/16/21 4:22 PM, David Edmondson wrote:
>> On Tuesday, 2021-02-16 at 16:03:05 +01, Philippe Mathieu-Daudé wrote:
>>
>>> I am not a block expert, but I wonder if something like this could
>>> be used:
>>>
>>> - create a
On 2/16/21 4:22 PM, David Edmondson wrote:
> On Tuesday, 2021-02-16 at 16:03:05 +01, Philippe Mathieu-Daudé wrote:
>
>> I am not a block expert, but I wonder if something like this could
>> be used:
>>
>> - create a raw (parent) block image of 64MiB
>>
>> - add a raw (child) block with your 768kB
On 2/16/21 4:02 PM, Bin Meng wrote:
> From: Bin Meng
>
> Per the "Physical Layer Specification Version 8.00", table 4-26
> (SD mode) and table 7-3 (SPI mode) command descriptions, the
> following commands:
>
> - CMD28 (SET_WRITE_PROT)
> - CMD29 (CLR_WRITE_PROT)
> - CMD30 (SEND_WRITE_PROT)
>
>
On 2/16/21 4:02 PM, Bin Meng wrote:
> From: Bin Meng
>
> Unlike SD mode, when SD card is working in SPI mode, the argument
> of CMD13 is stuff bits. Hence we should bypass the RCA check.
>
> See "Physical Layer Specification Version 8.00", chapter 7.3.1.3
> Detailed Command Description (SPI
On Tuesday, 2021-02-16 at 16:03:05 +01, Philippe Mathieu-Daudé wrote:
> I am not a block expert, but I wonder if something like this could
> be used:
>
> - create a raw (parent) block image of 64MiB
>
> - add a raw (child) block with your 768kB of VARS file
>
> - add a null-co (child) block of
From: Bin Meng
At present the sd_erase() does not erase the requested range of card
data to 0xFFs. Let's make the erase operation actually happen.
Signed-off-by: Bin Meng
---
Changes in v2:
- honor the write protection bits for SDSC cards
hw/sd/sd.c | 22 ++
1 file
From: Bin Meng
Per the "Physical Layer Specification Version 8.00", table 4-26
(SD mode) and table 7-3 (SPI mode) command descriptions, CMD30
response type is R1, not R1b.
Fixes: a1bb27b1e98a ("SD card emulation initial implementation")
Signed-off-by: Bin Meng
---
Changes in v2:
- new patch:
From: Bin Meng
Per the "Physical Layer Specification Version 8.00", table 4-26
(SD mode) and table 7-3 (SPI mode) command descriptions, the
following commands:
- CMD28 (SET_WRITE_PROT)
- CMD29 (CLR_WRITE_PROT)
- CMD30 (SEND_WRITE_PROT)
are only supported by SDSC cards.
Signed-off-by: Bin Meng
From: Bin Meng
High capacity cards don't support write protection hence we should
not preform the write protect groups check in CMD24/25 for them.
Signed-off-by: Bin Meng
---
Changes in v2:
- new patch: sd: Skip write protect groups check in CMD24/25 for high capacity
cards
hw/sd/sd.c |
On 2/16/21 3:27 PM, David Edmondson wrote:
> As described in
> https://lore.kernel.org/r/20201116104216.439650-1-david.edmond...@oracle.com,
> I'd like to reduce the amount of memory consumed by QEMU mapping UEFI
> images on aarch64.
>
> To recap:
>
>> Currently ARM UEFI images are typically
From: Bin Meng
These APIs and macros may be referenced by functions that are
currently before them. Move them ahead a little bit.
Signed-off-by: Bin Meng
Reviewed-by: Philippe Mathieu-Daudé
---
(no changes since v1)
hw/sd/sd.c | 42 +-
1 file
From: Bin Meng
Unlike SD mode, when SD card is working in SPI mode, the argument
of CMD13 is stuff bits. Hence we should bypass the RCA check.
See "Physical Layer Specification Version 8.00", chapter 7.3.1.3
Detailed Command Description (SPI mode):
"The card shall ignore stuff bits and
From: Bin Meng
High capacity cards don't support write protection hence we should
not preform the write protect groups check in sd_erase() for them.
Signed-off-by: Bin Meng
---
Changes in v2:
- new patch: sd: Skip write protect groups check in sd_erase() for high
capacity card
hw/sd/sd.c
From: Bin Meng
For high capacity memory cards, the erase start address and end
address are multiplied by 512, but the address check is still
based on the original block number in sd->erase_{start, end}.
Fixes: 1bd6fd8ed593 ("hw/sd/sdcard: Do not attempt to erase out of range
addresses")
From: Bin Meng
This includes several fixes related to erase operation of a SD card.
Currently sd_erase() does not perform the actual erase operation to
reset the requested block contents to 0xFFs. When trying to add such
functionality, one issue was spotted that the write protection is
only
As described in
https://lore.kernel.org/r/20201116104216.439650-1-david.edmond...@oracle.com,
I'd like to reduce the amount of memory consumed by QEMU mapping UEFI
images on aarch64.
To recap:
> Currently ARM UEFI images are typically built as 2MB/768kB flash
> images for code and variables
Rather than having a device specific debug implementation in
pflash_cfi01.c and pflash_cfi02.c, use the standard tracing facility.
Signed-off-by: David Edmondson
---
hw/block/pflash_cfi01.c | 78 +
hw/block/pflash_cfi02.c | 75
If a flash device is to be read-only, allow the backing device to be
smaller than the extent of the flash device by mapping it as a
subregion of the flash device region.
Return zeroes for all reads of the flash device beyond the extent of
the backing device.
Writes beyond the extent of the
PFlashCFI01.ro is a bool, declare it as such.
Signed-off-by: David Edmondson
---
hw/block/pflash_cfi01.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
index 9e1f3b42c6..6b21b4af52 100644
--- a/hw/block/pflash_cfi01.c
On 2/16/21 12:53 PM, Bin Meng wrote:
> On Wed, Feb 10, 2021 at 1:36 AM Philippe Mathieu-Daudé
> wrote:
>>
>> On 2/9/21 3:32 PM, Bin Meng wrote:
>>> Hi Philippe,
>>>
>>> On Thu, Feb 4, 2021 at 2:02 PM Bin Meng wrote:
On Thu, Jan 28, 2021 at 2:30 PM Bin Meng wrote:
>
> From:
On Tue, Feb 16, 2021 at 9:28 PM Philippe Mathieu-Daudé wrote:
>
> There is new interest in the SD/MMC device emulation, so it
> would be good to have more than only one maintainer / reviewer
> for it.
>
> Bin Meng proved by his contributions a deep understanding of the
> SD cards internals, so
There is new interest in the SD/MMC device emulation, so it
would be good to have more than only one maintainer / reviewer
for it.
Bin Meng proved by his contributions a deep understanding of the
SD cards internals, so let's add him to the corresponding section
in the MAINTAINERS file.
On 16/02/2021 02.49, John Snow wrote:
On 1/26/21 10:15 AM, Vladimir Sementsov-Ogievskiy wrote:
OK, thanks for handling it!
When will we move to python 3.7?
[...]
As for RHEL/CentOS, I think it's in the same shape right now. It's
3.6-based, but I don't know if there's an optional 3.7+
On Wed 10 Feb 2021 05:52:47 PM CET, Kevin Wolf wrote:
>> +/* The 'file' option only allows strings */
>> +assert(qobject_type(value) == QTYPE_QSTRING);
>
> This is true, but not entirely obvious: The QAPI schema has
> BlockdevRef, which can be either a string or a dict. However, we're
>
On Wed, Feb 10, 2021 at 1:36 AM Philippe Mathieu-Daudé wrote:
>
> On 2/9/21 3:32 PM, Bin Meng wrote:
> > Hi Philippe,
> >
> > On Thu, Feb 4, 2021 at 2:02 PM Bin Meng wrote:
> >>
> >> On Thu, Jan 28, 2021 at 2:30 PM Bin Meng wrote:
> >>>
> >>> From: Bin Meng
> >>>
> >>> This includes the
Hi Luc,
> -Original Message-
> From: Luc Michel
> Sent: Saturday, February 13, 2021 6:26 PM
> To: Sai Pavan Boddu ; Markus Armbruster
> ; Kevin Wolf ; Max Reitz
> ; Vladimir Sementsov-Ogievskiy
> ; Eric Blake ; Joel Stanley
> ; Cédric Le Goater ; Vincent Palatin
> ; Dr. David Alan Gilbert
Hi Alistair
> -Original Message-
> From: Alistair Francis
> Sent: Saturday, February 13, 2021 3:41 AM
> To: Sai Pavan Boddu
> Cc: Markus Armbruster ; Kevin Wolf
> ; Max Reitz ; Vladimir Sementsov-
> Ogievskiy ; Eric Blake ;
> Joel Stanley ; Cédric Le Goater ; Vincent
> Palatin ; Dr.
Hi Alistair,
> -Original Message-
> From: Alistair Francis
> Sent: Saturday, February 13, 2021 3:38 AM
> To: Sai Pavan Boddu
> Cc: Markus Armbruster ; Kevin Wolf
> ; Max Reitz ; Vladimir Sementsov-
> Ogievskiy ; Eric Blake ;
> Joel Stanley ; Cédric Le Goater ; Vincent
> Palatin ; Dr.
Am 16.02.2021 um 06:03 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 15.02.2021 23:04, Eric Blake wrote:
> > On 2/15/21 3:22 AM, Kevin Wolf wrote:
> >
> > > > With this patch applied, 'check unit-test' fails with:
> > > >
> > > > Running test test-replication
> > > > Unexpected error in
68 matches
Mail list logo
