Re: [PATCH V3 1/8] hw/block/nvme: support namespace detach

2021-03-14 Thread Keqian Zhu
Hi, I don't dig into code logic, just some nit below. On 2021/3/1 0:10, Minwoo Im wrote: > Given that now we have nvme-subsys device supported, we can manage > namespace allocated, but not attached: detached. This patch introduced s/introduced/introduces > a parameter for nvme-ns device named

Re: [RFC] nbd: decouple reconnect from drain

2021-03-14 Thread Roman Kagan
On Fri, Mar 12, 2021 at 03:35:25PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 10.03.2021 12:32, Roman Kagan wrote: > > NBD connect coroutine takes an extra in_flight reference as if it's a > > request handler. This prevents drain from completion until the > > connection coroutine is releases

RE: [PATCH v5 01/13] hw/block/nvme: fix zone management receive reporting too many zones

2021-03-14 Thread Dmitry Fomichev
LGTM, Reviewed-by: Dmitry Fomichev > -Original Message- > From: Klaus Jensen > Sent: Wednesday, March 10, 2021 4:54 AM > To: qemu-de...@nongnu.org > Cc: Stefan Hajnoczi ; Klaus Jensen > ; Fam Zheng ; Max Reitz > ; Kevin Wolf ; qemu- > bl...@nongnu.org; Gollu Appalanaidu ; Keith > Busch