On Mon, Mar 15, 2021 at 11:03 AM Joelle van Dyne wrote:
>
> Some BSD platforms do not have this header.
>
> Reviewed-by: Peter Maydell
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Joelle van Dyne
Please bear with me as I am still new to this, but what happens to the
three patches
On 3/31/21 9:27 AM, Stefan Hajnoczi wrote:
> The checks in vu_blk_sect_range_ok() assume VIRTIO_BLK_SECTOR_SIZE is
> equal to BDRV_SECTOR_SIZE. This is true, but let's add a
> QEMU_BUILD_BUG_ON() to make it explicit.
>
> We might as well check that the request buffer size is a multiple of
>
On 3/31/21 7:28 AM, Max Reitz wrote:
> Add a test accompanying commit 53431b9086b2832ca1aeff0c55e186e9ed79bd11
> ("block/mirror: Fix mirror_top's permissions").
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/tests/mirror-top-perms | 121 ++
>
On Wed, 31 Mar 2021 15:47:45 +0100
Stefan Hajnoczi wrote:
> On Tue, Mar 30, 2021 at 04:17:32PM +0200, Greg Kurz wrote:
> > On Tue, 30 Mar 2021 14:55:42 +0100
> > Stefan Hajnoczi wrote:
> >
> > > On Tue, Mar 30, 2021 at 12:17:40PM +0200, Greg Kurz wrote:
> > > > On Mon, 29 Mar 2021 18:10:57
On Tue, Mar 30, 2021 at 04:17:32PM +0200, Greg Kurz wrote:
> On Tue, 30 Mar 2021 14:55:42 +0100
> Stefan Hajnoczi wrote:
>
> > On Tue, Mar 30, 2021 at 12:17:40PM +0200, Greg Kurz wrote:
> > > On Mon, 29 Mar 2021 18:10:57 +0100
> > > Stefan Hajnoczi wrote:
> > > > On Thu, Mar 25, 2021 at
The checks in vu_blk_sect_range_ok() assume VIRTIO_BLK_SECTOR_SIZE is
equal to BDRV_SECTOR_SIZE. This is true, but let's add a
QEMU_BUILD_BUG_ON() to make it explicit.
We might as well check that the request buffer size is a multiple of
VIRTIO_BLK_SECTOR_SIZE while we're at it.
Suggested-by: Max
Add a test accompanying commit 53431b9086b2832ca1aeff0c55e186e9ed79bd11
("block/mirror: Fix mirror_top's permissions").
Signed-off-by: Max Reitz
---
tests/qemu-iotests/tests/mirror-top-perms | 121 ++
tests/qemu-iotests/tests/mirror-top-perms.out | 5 +
2 files changed,
From: David Edmondson
Test that downgrading an rwlock does not result in a failure to
schedule coroutines queued on the rwlock.
The diagram associated with test_co_rwlock_downgrade() describes the
intended behaviour, but what was observed previously corresponds to:
| c1 | c2 | c3
From: Paolo Bonzini
Test that rwlock upgrade is fair, and that readers go back to sleep if
a writer is in line.
Signed-off-by: Paolo Bonzini
Message-id: 20210325112941.365238-6-pbonz...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
tests/unit/test-coroutine.c | 62
From: Paolo Bonzini
An invariant of the current rwlock is that if multiple coroutines hold a
reader lock, all must be runnable. The unlock implementation relies on
this, choosing to wake a single coroutine when the final read lock
holder exits the critical section, assuming that it will wake a
From: David Edmondson
If a new bitmap entry is allocated, requiring the entire block to be
written, avoiding leaking the buffer allocated for the block should
the write fail.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: David Edmondson
Signed-off-by: Paolo Bonzini
Acked-by: Max Reitz
From: David Edmondson
When taking the slow path for mutex acquisition, set the coroutine
value in the CoWaitRecord in push_waiter(), rather than both there and
in the caller.
Reviewed-by: Paolo Bonzini
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: David Edmondson
Signed-off-by: Paolo
From: David Edmondson
Given that the block size is read from the header of the VDI file, a
wide variety of sizes might be seen. Rather than re-using a block
sized memory region when writing the VDI header, allocate an
appropriately sized buffer.
Signed-off-by: David Edmondson
Signed-off-by:
The following changes since commit 6d40ce00c1166c317e298ad82ecf10e650c4f87d:
Update version for v6.0.0-rc1 release (2021-03-30 18:19:07 +0100)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to
This is to add support for Device Self Test Command (DST) and
DST Log Page. Refer NVM Express specification 1.4b section 5.8
("Device Self-test command")
Signed-off-by: Gollu Appalanaidu
---
changes:
-v3: removed unwanted patch file added
-v2: addressed style fixes in hw/block/nvme.h
Patchew URL:
https://patchew.org/QEMU/20210331083306.12461-1-anaidu.go...@samsung.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210331083306.12461-1-anaidu.go...@samsung.com
Subject: [PATCH v2] hw/block/nvme:
This is to add support for Device Self Test Command (DST) and
DST Log Page. Refer NVM Express specification 1.4b section 5.8
("Device Self-test command")
Signed-off-by: Gollu Appalanaidu
---
changes:
-v2: addressed style fixes in hw/block/nvme.h
hw/block/nvme.c |
Patchew URL:
https://patchew.org/QEMU/20210331073233.11198-1-anaidu.go...@samsung.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210331073233.11198-1-anaidu.go...@samsung.com
Subject: [PATCH] hw/block/nvme: add
This is to add support for Device Self Test Command (DST) and
DST Log Page. Refer NVM Express specification 1.4b section 5.8
("Device Self-test command")
Signed-off-by: Gollu Appalanaidu
---
hw/block/nvme.c | 118 +-
hw/block/nvme.h | 13
30.03.2021 19:39, Max Reitz wrote:
==
OK, I think now that you didn't mean qcow2_alloc_clusters(). So, we are saying about only
functions returning an offset to cluster with "guest data", not to any kind of
host cluster. Than what you propose looks like this to me:
- take my v5
- rename
20 matches
Mail list logo
