In commit commit 0da9856851dcca09222a1467e16ddd05dc66e460
nbd: server: Report holes for raw images
we changed the way holes are reported for raw images, but also how
known-zero portions of qcow2 files are reported. This was not covered by
iotests, and revealed recently by libnbd tests[1].
Ad
On Tue, 13 Apr 2021 at 14:39, Max Reitz wrote:
>
> The following changes since commit dce628a97fde2594f99d738883a157f05aa0a14f:
>
> Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.0-20210412'
> into staging (2021-04-13 13:05:07 +0100)
>
> are available in the Git repository at:
>
On Tue, Apr 13, 2021 at 06:56:54PM +0200, Kevin Wolf wrote:
> virtio_add_queue() aborts when queue_size > VIRTQUEUE_MAX_SIZE, so
> vhost_user_blk_device_realize() should check this before calling it.
>
> Simple reproducer:
>
> qemu-system-x86_64 \
> -chardev null,id=foo \
> -device vhost-
On 4/13/21 6:56 PM, Kevin Wolf wrote:
> virtio_add_queue() aborts when queue_size > VIRTQUEUE_MAX_SIZE, so
> vhost_user_blk_device_realize() should check this before calling it.
>
> Simple reproducer:
>
> qemu-system-x86_64 \
> -chardev null,id=foo \
> -device vhost-user-blk-pci,queue-siz
Am 13.04.2021 um 18:52 hat Kevin Wolf geschrieben:
> virtio_add_queue() aborts when queue_size > VIRTQUEUE_MAX_SIZE, so
> vhost_user_blk_device_realize() should check this before calling it.
>
> Simple reproducer:
>
> qemu-system-x86_64 \
> -chardev null,id=foo \
> -device vhost-user-blk-
virtio_add_queue() aborts when queue_size > VIRTQUEUE_MAX_SIZE, so
vhost_user_blk_device_realize() should check this before calling it.
Simple reproducer:
qemu-system-x86_64 \
-chardev null,id=foo \
-device vhost-user-blk-pci,queue-size=4096,chardev=foo
Fixes: https://bugzilla.redhat.com
virtio_add_queue() aborts when queue_size > VIRTQUEUE_MAX_SIZE, so
vhost_user_blk_device_realize() should check this before calling it.
Simple reproducer:
qemu-system-x86_64 \
-chardev null,id=foo \
-device vhost-user-blk-pci,queue-size=4096,chardev=foo
Fixes: https://bugzilla.redhat.com
On 4/13/21 8:23 AM, Kevin Wolf wrote:
> Normally, blk_new_open() just shares all permissions. This was fine
> originally when permissions only protected against uses in the same
> process because no other part of the code would actually get to access
> the block nodes opened with blk_new_open(). Ho
On 4/13/21 8:23 AM, Kevin Wolf wrote:
> For a successful conversion of an image, we must make sure that its
> content doesn't change during the conversion.
>
> A special case of this is using the same image file both as the source
> and as the destination. If both input and output format are raw,
From: Vladimir Sementsov-Ogievskiy
If on nbd_close() we detach the thread (in
nbd_co_establish_connection_cancel() thr->state becomes
CONNECT_THREAD_RUNNING_DETACHED), after that point we should not use
s->connect_thread (which is set to NULL), as running thread may free it
at any time.
Still nb
The following changes since commit dce628a97fde2594f99d738883a157f05aa0a14f:
Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.0-20210412'
into staging (2021-04-13 13:05:07 +0100)
are available in the Git repository at:
https://github.com/XanClic/qemu.git tags/pull-block-2021-0
On 13.04.21 14:19, Vladimir Sementsov-Ogievskiy wrote:
13.04.2021 14:53, Max Reitz wrote:
On 06.04.21 17:51, Vladimir Sementsov-Ogievskiy wrote:
If on nbd_close() we detach the thread (in
nbd_co_establish_connection_cancel() thr->state becomes
CONNECT_THREAD_RUNNING_DETACHED), after that point
For a successful conversion of an image, we must make sure that its
content doesn't change during the conversion.
A special case of this is using the same image file both as the source
and as the destination. If both input and output format are raw, the
operation would just be useless work, with o
Normally, blk_new_open() just shares all permissions. This was fine
originally when permissions only protected against uses in the same
process because no other part of the code would actually get to access
the block nodes opened with blk_new_open(). However, since we use it for
file locking now, u
Kevin Wolf (2):
block: Add BDRV_O_NO_SHARE for blk_new_open()
qemu-img convert: Unshare write permission for source
include/block/block.h | 1 +
block/block-backend.c | 19 +--
qemu-img.c| 2 +-
3 files changed, 15 insertions(+), 7 deletions(-)
--
2.30.2
Right now, rate limiting is protected by the AioContext mutex, which is
taken for example both by the block jobs and by qmp_block_job_set_speed
(via find_block_job).
We would like to remove the dependency of block layer code on the
AioContext mutex, since most drivers and the core I/O code are alr
13.04.2021 14:53, Max Reitz wrote:
On 06.04.21 17:51, Vladimir Sementsov-Ogievskiy wrote:
If on nbd_close() we detach the thread (in
nbd_co_establish_connection_cancel() thr->state becomes
CONNECT_THREAD_RUNNING_DETACHED), after that point we should not use
s->connect_thread (which is set to NUL
On 06.04.21 17:51, Vladimir Sementsov-Ogievskiy wrote:
If on nbd_close() we detach the thread (in
nbd_co_establish_connection_cancel() thr->state becomes
CONNECT_THREAD_RUNNING_DETACHED), after that point we should not use
s->connect_thread (which is set to NULL), as running thread may free it
at
On Tue, 13 Apr 2021 at 07:47, Vladimir Sementsov-Ogievskiy
wrote:
>
> 12.04.2021 18:48, Peter Maydell wrote:
> > On Mon, 12 Apr 2021 at 13:19, Vladimir Sementsov-Ogievskiy
> > wrote:
> >>
> >> The following changes since commit
> >> 555249a59e9cdd6b58da103aba5cf3a2d45c899f:
> >>
> >>Merge re
On 08/04/21 17:59, Emanuele Giuseppe Esposito wrote:
When qemu_coroutine_enter is executed in a loop
(even QEMU_FOREACH_SAFE), the new routine can modify the list,
for example removing an element, causing problem when control
is given back to the caller that continues iterating on the same list.
On 08/04/21 17:59, Emanuele Giuseppe Esposito wrote:
Perhaps insert here:
That would be unsafe in case a rule other than the current one is
removed while the coroutine has yielded. Keep FOREACH_SAFE because
suspend_request deletes the current rule.
After this patch, *all* matching rules are
21 matches
Mail list logo
