Re: [PATCH v2] nbd/server: Add --selinux-label option

Ping On Wed, Aug 25, 2021 at 02:35:04PM -0500, Eric Blake wrote: > On Fri, Jul 23, 2021 at 05:38:06PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jul 23, 2021 at 06:18:55PM +0200, Kevin Wolf wrote: > > > Am 23.07.2021 um 12:33 hat Richard W.M. Jones geschrieben: > > > > Under SELinux, Unix

Re: [PATCH v3 1/9] nbd/client-connection: nbd_co_establish_connection(): fix non set errp

On Tue, Sep 07, 2021 at 12:44:53PM -0500, Eric Blake wrote: > On Mon, Sep 06, 2021 at 10:06:46PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > When we don't have a connection and blocking is false, we return NULL > > but don't set errp. That's wrong. > > Oops... > > > > > We have two paths for

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

On Fri, Sep 24, 2021 at 11:04:27AM +0200, Kevin Wolf wrote: > We want to switch both from QemuOpts to the keyval parser in the future, > which results in some incompatibilities, mainly around list handling. > Mark the non-JSON version of both as unstable syntax so that management > tools switch to

Re: [PATCH] nbd/server: Allow LIST_META_CONTEXT without STRUCTURED_REPLY

On Tue, Sep 14, 2021 at 05:19:42PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 07.09.2021 20:35, Eric Blake wrote: > > The NBD protocol just relaxed the requirements on > > NBD_OPT_LIST_META_CONTEXT: > > > > https://github.com/NetworkBlockDevice/nbd/commit/13a4e33a87 > > > > Since listing is

Re: [PATCH 10/11] vl: Enable JSON syntax for -device

On Fri, Sep 24, 2021 at 11:04:26AM +0200, Kevin Wolf wrote: > Like we already do for -object, introduce support for JSON syntax in > -device, which can be kept stable in the long term and guarantees that a > single code path with identical behaviour is used for both QMP and the > command line.

Re: [PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add

On Fri, Sep 24, 2021 at 11:04:25AM +0200, Kevin Wolf wrote: > Directly call qdev_device_add_from_qdict() for QMP device_add instead of > first going through QemuOpts and converting back to QDict. > > Note that this changes the behaviour of device_add, though in ways that > should be considered

Re: [PATCH 08/11] qdev: Base object creation on QDict rather than QemuOpts

On Fri, Sep 24, 2021 at 11:04:24AM +0200, Kevin Wolf wrote: > QDicts are both what QMP natively uses and what the keyval parser > produces. Going through QemuOpts isn't useful for either one, so switch > the main device creation function to QDicts. By sharing more code with > the

Re: [PATCH 04/11] qdev: Avoid using string visitor for properties

On Fri, Sep 24, 2021 at 11:04:20AM +0200, Kevin Wolf wrote: > The only thing the string visitor adds compared to a keyval visitor is > list support. git grep for 'visit_start_list' and 'visit.*List' shows > that devices don't make use of this. > > In a world with a QAPIfied command line

Re: [PATCH v2 0/6] iotests: update environment and linting configuration

On Thu, Sep 23, 2021 at 2:07 PM John Snow wrote: > GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-package-iotest-pt1 > CI: https://gitlab.com/jsnow/qemu/-/pipelines/376236687 > > This series partially supersedes: > [PATCH v3 00/16] python/iotests: Run iotest linters during Python CI' >

Re: [PATCH v2 2/6] iotests: add warning for rogue 'qemu' packages

On Thu, Sep 23, 2021 at 4:27 PM Vladimir Sementsov-Ogievskiy < vsement...@virtuozzo.com> wrote: > 23.09.2021 21:44, John Snow wrote: > > > > > > On Thu, Sep 23, 2021 at 2:32 PM Vladimir Sementsov-Ogievskiy < > vsement...@virtuozzo.com > wrote: > > > >

Re: [PATCH 01/11] qom: Reduce use of error_propagate()

On Fri, Sep 24, 2021 at 11:04:17AM +0200, Kevin Wolf wrote: > ERRP_GUARD() makes debugging easier by making sure that _abort > still fails at the real origin of the error instead of > error_propagate(). > > Signed-off-by: Kevin Wolf > --- > qom/object.c| 7 +++ >

Re: [PATCH v6 4/5] block/nbd: drop connection_co

On Thu, Sep 02, 2021 at 01:38:04PM +0300, Vladimir Sementsov-Ogievskiy wrote: > OK, that's a big rewrite of the logic. And a time-consuming review on my part! > > Pre-patch we have an always running coroutine - connection_co. It does > reply receiving and reconnecting. And it leads to a lot of

Re: [PATCH 05/11] qdev: Make DeviceState.id independent of QemuOpts

24.09.2021 18:10, Kevin Wolf wrote: Am 24.09.2021 um 16:02 hat Vladimir Sementsov-Ogievskiy geschrieben: 24.09.2021 12:04, Kevin Wolf wrote: DeviceState.id is a pointer to a string that is stored in the QemuOpts object DeviceState.opts and freed together with it. We want to create devices

Re: [PATCH 05/11] qdev: Make DeviceState.id independent of QemuOpts

Am 24.09.2021 um 16:02 hat Vladimir Sementsov-Ogievskiy geschrieben: > 24.09.2021 12:04, Kevin Wolf wrote: > > DeviceState.id is a pointer to a string that is stored in the QemuOpts > > object DeviceState.opts and freed together with it. We want to create > > devices without going through QemuOpts

Re: [PATCH] block: introduce max_hw_iov for use in scsi-generic

On Fri, Sep 24, 2021 at 08:50:05AM +0200, Christian Borntraeger wrote: > Peter, Michael, > > do we still do stable releases for QEMU or has this stopped? Hi Christian, Yes, it's just been a perfect storm of job moves / bad timing / much-needed testing rework. I plan to restart the stable

Re: [PATCH 07/11] qemu-option: Allow deleting opts during qemu_opts_foreach()

24.09.2021 12:04, Kevin Wolf wrote: Use QTAILQ_FOREACH_SAFE() so that the current QemuOpts can be deleted while iterating through the whole list. Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PULL 0/3] hw/nvme updates

On Fri, 24 Sept 2021 at 07:47, Klaus Jensen wrote: > > From: Klaus Jensen > > Hi Peter, > > The following changes since commit 2c3e83f92d93fbab071b8a96b8ab769b01902475: > > Merge remote-tracking branch > 'remotes/alistair23/tags/pull-riscv-to-apply-20210921' into staging > (2021-09-21

Re: [PATCH 01/11] qom: Reduce use of error_propagate()

Kevin Wolf writes: > ERRP_GUARD() makes debugging easier by making sure that _abort > still fails at the real origin of the error instead of > error_propagate(). > > Signed-off-by: Kevin Wolf Yes. The code you patch uses error_propagate() to work around functions not returning distinct error

Re: [PATCH 06/11] qdev: Add Error parameter to qdev_set_id()

24.09.2021 12:04, Kevin Wolf wrote: object_property_add_child() fails (with _abort) if an object with the same name already exists. As long as QemuOpts is in use for -device and device_add, it catches duplicate IDs before qdev_set_id() is even called. However, for enabling non-QemuOpts code

Re: [PATCH 05/11] qdev: Make DeviceState.id independent of QemuOpts

24.09.2021 12:04, Kevin Wolf wrote: DeviceState.id is a pointer to a string that is stored in the QemuOpts object DeviceState.opts and freed together with it. We want to create devices without going through QemuOpts in the future, so make this a separately allocated string. Signed-off-by: Kevin

Re: [PATCH 03/11] iotests/051: Fix typo

24.09.2021 12:04, Kevin Wolf wrote: The iothread isn't called 'iothread0', but 'thread0'. Depending on the order that properties are parsed, the error message may change from the expected one to another one saying that the iothread doesn't exist. Signed-off-by: Kevin Wolf Reviewed-by:

Re: [PATCH 02/11] iotests/245: Fix type for iothread property

24.09.2021 12:04, Kevin Wolf wrote: iothread is a string property, so None (= JSON null) is not a valid value for it. Pass the empty string instead to get the default iothread. Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 01/11] qom: Reduce use of error_propagate()

24.09.2021 12:04, Kevin Wolf wrote: ERRP_GUARD() makes debugging easier by making sure that _abort still fails at the real origin of the error instead of error_propagate(). Signed-off-by: Kevin Wolf --- qom/object.c| 7 +++ qom/object_interfaces.c | 17 ++--- 2

Re: [PATCH] block: introduce max_hw_iov for use in scsi-generic

Am 23.09.2021 um 15:04 hat Paolo Bonzini geschrieben: > Linux limits the size of iovecs to 1024 (UIO_MAXIOV in the kernel > sources, IOV_MAX in POSIX). Because of this, on some host adapters > requests with many iovecs are rejected with -EINVAL by the > io_submit() or readv()/writev() system

[PATCH 11/11] Deprecate stable non-JSON -device and -object

We want to switch both from QemuOpts to the keyval parser in the future, which results in some incompatibilities, mainly around list handling. Mark the non-JSON version of both as unstable syntax so that management tools switch to JSON and we can later make the change without breaking things.

[PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add

Directly call qdev_device_add_from_qdict() for QMP device_add instead of first going through QemuOpts and converting back to QDict. Note that this changes the behaviour of device_add, though in ways that should be considered bug fixes: QemuOpts ignores differences between data types, so you

[PATCH 06/11] qdev: Add Error parameter to qdev_set_id()

object_property_add_child() fails (with _abort) if an object with the same name already exists. As long as QemuOpts is in use for -device and device_add, it catches duplicate IDs before qdev_set_id() is even called. However, for enabling non-QemuOpts code paths, we need to make sure that the

[PATCH 05/11] qdev: Make DeviceState.id independent of QemuOpts

DeviceState.id is a pointer to a string that is stored in the QemuOpts object DeviceState.opts and freed together with it. We want to create devices without going through QemuOpts in the future, so make this a separately allocated string. Signed-off-by: Kevin Wolf --- include/hw/qdev-core.h

[PATCH 07/11] qemu-option: Allow deleting opts during qemu_opts_foreach()

Use QTAILQ_FOREACH_SAFE() so that the current QemuOpts can be deleted while iterating through the whole list. Signed-off-by: Kevin Wolf --- util/qemu-option.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/qemu-option.c b/util/qemu-option.c index

[PATCH 04/11] qdev: Avoid using string visitor for properties

The only thing the string visitor adds compared to a keyval visitor is list support. git grep for 'visit_start_list' and 'visit.*List' shows that devices don't make use of this. In a world with a QAPIfied command line interface, the keyval visitor is used to parse the command line. In order to

[PATCH 10/11] vl: Enable JSON syntax for -device

Like we already do for -object, introduce support for JSON syntax in -device, which can be kept stable in the long term and guarantees that a single code path with identical behaviour is used for both QMP and the command line. Compared to the QemuOpts based code, the parser contains less surprises

[PATCH 02/11] iotests/245: Fix type for iothread property

iothread is a string property, so None (= JSON null) is not a valid value for it. Pass the empty string instead to get the default iothread. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/245 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/245

[PATCH 00/11] qdev: Add JSON -device and fix QMP device_add

It's still a long way until we'll have QAPIfied devices, but there are some improvements that we can already make now to make the future switch easier. One important part of this is having code paths without QemuOpts, which we want to get rid of and replace with the keyval parser in the long run.

[PATCH 08/11] qdev: Base object creation on QDict rather than QemuOpts

QDicts are both what QMP natively uses and what the keyval parser produces. Going through QemuOpts isn't useful for either one, so switch the main device creation function to QDicts. By sharing more code with the -object/object-add code path, we can even reduce the code size a bit. This commit

[PATCH 01/11] qom: Reduce use of error_propagate()

ERRP_GUARD() makes debugging easier by making sure that _abort still fails at the real origin of the error instead of error_propagate(). Signed-off-by: Kevin Wolf --- qom/object.c| 7 +++ qom/object_interfaces.c | 17 ++--- 2 files changed, 9 insertions(+), 15

[PATCH 03/11] iotests/051: Fix typo

The iothread isn't called 'iothread0', but 'thread0'. Depending on the order that properties are parsed, the error message may change from the expected one to another one saying that the iothread doesn't exist. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/051| 2 +-

Re: [PATCH] hw/nvme: reattach subsystem namespaces on hotplug

On Sep 24 08:05, Hannes Reinecke wrote: > On 9/23/21 10:09 PM, Klaus Jensen wrote: > > On Sep 9 13:37, Hannes Reinecke wrote: > > > On 9/9/21 12:47 PM, Klaus Jensen wrote: > > > > On Sep 9 11:43, Hannes Reinecke wrote: > > > > > With commit 5ffbaeed16 ("hw/nvme: fix controller hot unplugging") >

[PATCH 0/2] hw/nvme: fix namespace attachment on controller hotplug

From: Klaus Jensen First patch from Hannes fixes the subsystem registration process such that shared (but non-detached) namespaces are automatically attached to hotplugged controllers. The second patch changes the default for 'shared' such that namespaces are shared by default and will thus by

[PATCH 2/2] hw/nvme: change nvme-ns 'shared' default

From: Klaus Jensen Change namespaces to be shared namespaces by default (parameter shared=on). Keep shared=off for older machine types. Signed-off-by: Klaus Jensen --- docs/system/devices/nvme.rst | 24 ++-- hw/core/machine.c| 4 +++- hw/nvme/ns.c

[PATCH 1/2] hw/nvme: reattach subsystem namespaces on hotplug

From: Hannes Reinecke With commit 5ffbaeed16 ("hw/nvme: fix controller hot unplugging") namespaces get moved from the controller to the subsystem if one is specified. That keeps the namespaces alive after a controller hot-unplug, but after a controller hotplug we have to reconnect the namespaces

Re: [PATCH] block: introduce max_hw_iov for use in scsi-generic

Peter, Michael, do we still do stable releases for QEMU or has this stopped? Am 24.09.21 um 07:27 schrieb Paolo Bonzini: Yes, the question is whether it still exists... Paolo El jue., 23 sept. 2021 16:48, Christian Borntraeger escribió: Am 23.09.21 um 15:04 schrieb Paolo Bonzini: > Linux

[PULL 0/3] hw/nvme updates

From: Klaus Jensen Hi Peter, The following changes since commit 2c3e83f92d93fbab071b8a96b8ab769b01902475: Merge remote-tracking branch 'remotes/alistair23/tags/pull-riscv-to-apply-20210921' into staging (2021-09-21 10:57:48 -0700) are available in the Git repository at:

[PULL 2/3] hw/nvme: fix verification of select field in namespace attachment

From: Naveen Nagar Fix is added to check for reserved value in select field for namespace attachment CC: Minwoo Im Signed-off-by: Naveen Nagar Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 15 --- include/block/nvme.h | 5 + 2 files changed, 17 insertions(+), 3

[PULL 3/3] hw/nvme: Return error for fused operations

From: Pankaj Raghav Currently, FUSED operations are not supported by QEMU. As per the 1.4 SPEC, controller should abort the command that requested a fused operation with an INVALID FIELD error code if they are not supported. Changes from v1: Added FUSE flag check also to the admin cmd

[PULL 1/3] hw/nvme: fix validation of ASQ and ACQ

From: Klaus Jensen Address 0x0 is a valid address. Fix the admin submission and completion queue address validation to not error out on this. Signed-off-by: Klaus Jensen Reviewed-by: Keith Busch --- hw/nvme/ctrl.c | 8 hw/nvme/trace-events | 2 -- 2 files changed, 10

Re: [PATCH] hw/nvme: reattach subsystem namespaces on hotplug

On 9/23/21 10:09 PM, Klaus Jensen wrote: On Sep 9 13:37, Hannes Reinecke wrote: On 9/9/21 12:47 PM, Klaus Jensen wrote: On Sep 9 11:43, Hannes Reinecke wrote: With commit 5ffbaeed16 ("hw/nvme: fix controller hot unplugging") namespaces get moved from the controller to the subsystem if one