[PATCH v2] pci: Assert that capabilities never overlap

2022-08-30 Thread Akihiko Odaki
pci_add_capability appears most PCI devices. Its error handling required lots of code, and led to inconsistent behaviors such as: - passing error_abort - passing error_fatal - asserting the returned value - propagating the error to the caller - skipping the rest of the function - just ignoring

Re: [RFC v4 01/11] blkio: add libblkio block driver

2022-08-30 Thread Stefan Hajnoczi
On Tue, Aug 30, 2022 at 09:30:16AM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > libblkio (https://gitlab.com/libblkio/libblkio/) is a library for > > high-performance disk I/O. It currently supports io_uring, > > virtio-blk-vhost-user, and virtio-blk-vhost-vdpa with additional

Re: [RFC v4 11/11] virtio-blk: use BDRV_REQ_REGISTERED_BUF optimization hint

2022-08-30 Thread Stefan Hajnoczi
On Thu, Aug 25, 2022 at 09:43:16AM +0200, David Hildenbrand wrote: > On 23.08.22 21:22, Stefan Hajnoczi wrote: > > On Tue, Aug 23, 2022 at 10:01:59AM +0200, David Hildenbrand wrote: > >> On 23.08.22 00:24, Stefan Hajnoczi wrote: > >>> Register guest RAM using BlockRAMRegistrar and set the > >>>

Re: [PATCH] pci: Abort if pci_add_capability fails

2022-08-30 Thread Alex Williamson
On Tue, 30 Aug 2022 13:37:35 +0200 Markus Armbruster wrote: >if (!offset) { >offset = pci_find_space(pdev, size); >/* out of PCI config space is programming error */ >assert(offset); >} else { >/* Verify that capabilities don't

Re: [PATCH v8 3/7] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-08-30 Thread Sam Li
Markus Armbruster 于2022年8月30日周二 23:09写道: > > Sam Li writes: > > > Markus Armbruster 于2022年8月30日周二 19:57写道: > >> > >> Sam Li writes: > >> > >> > By adding zone management operations in BlockDriver, storage controller > >> > emulation can use the new block layer APIs including Report Zone and >

Re: [PATCH v8 3/7] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-08-30 Thread Markus Armbruster
Sam Li writes: > Markus Armbruster 于2022年8月30日周二 19:57写道: >> >> Sam Li writes: >> >> > By adding zone management operations in BlockDriver, storage controller >> > emulation can use the new block layer APIs including Report Zone and >> > four zone management operations (open, close, finish,

Re: [PATCH v8 3/7] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-08-30 Thread Sam Li
Markus Armbruster 于2022年8月30日周二 19:57写道: > > Sam Li writes: > > > By adding zone management operations in BlockDriver, storage controller > > emulation can use the new block layer APIs including Report Zone and > > four zone management operations (open, close, finish, reset). > > > > Add zoned

Re: [PATCH v3 3/3] util/aio-win32: Correct the event array size in aio_poll()

2022-08-30 Thread Philippe Mathieu-Daudé via
On 24/8/22 10:52, Bin Meng wrote: From: Bin Meng WaitForMultipleObjects() can only wait for MAXIMUM_WAIT_OBJECTS object handles. Correct the event array size in aio_poll() and add a assert() to ensure it does not cause out of bound access. Signed-off-by: Bin Meng Reviewed-by: Stefan Weil

Re: [PATCH v8 3/7] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-08-30 Thread Markus Armbruster
Sam Li writes: > By adding zone management operations in BlockDriver, storage controller > emulation can use the new block layer APIs including Report Zone and > four zone management operations (open, close, finish, reset). > > Add zoned storage commands of the device: zone_report(zrp),

Re: [PATCH] pci: Abort if pci_add_capability fails

2022-08-30 Thread Markus Armbruster
Alex, got a question for you below. 小田喜陽彦 writes: > From: Akihiko Odaki > > pci_add_capability appears most PCI devices. The error handling required > lots of code, and led to inconsistent behaviors such as: > - passing error_abort > - passing error_fatal > - asserting the returned value > -

Re: [RFC v4 01/11] blkio: add libblkio block driver

2022-08-30 Thread Markus Armbruster
Stefan Hajnoczi writes: > libblkio (https://gitlab.com/libblkio/libblkio/) is a library for > high-performance disk I/O. It currently supports io_uring, > virtio-blk-vhost-user, and virtio-blk-vhost-vdpa with additional drivers > under development. > > One of the reasons for developing libblkio