Re: [PATCH 3/6] parallels: Add checking and repairing duplicate offsets in BAT

2022-09-08 Thread Denis V. Lunev
On 9/8/22 19:15, Denis V. Lunev wrote: On 9/2/22 10:52, Alexander Ivanov wrote: Cluster offsets must be unique among all BAT entries. Find duplicate offsets in the BAT. If a duplicated offset is found fix it by copying the content of the relevant cluster to a new allocated cluster and set the n

Re: [PATCH 3/6] parallels: Add checking and repairing duplicate offsets in BAT

2022-09-08 Thread Denis V. Lunev
On 9/2/22 10:52, Alexander Ivanov wrote: Cluster offsets must be unique among all BAT entries. Find duplicate offsets in the BAT. If a duplicated offset is found fix it by copying the content of the relevant cluster to a new allocated cluster and set the new cluster offset to the duplicated entr

[PATCH] block: use the request length for iov alignment

2022-09-08 Thread Keith Busch
From: Keith Busch An iov length needs to be aligned to the logical block size, which may be larger than the memory alignment. Signed-off-by: Keith Busch --- block/io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/io.c b/block/io.c index 0a8cbefe86..296d4b49a7 100

[PATCH] migrate block dirty bitmap: Fix the block dirty bitmap can't to migration_completion when pending size larger than threshold size : 1、dirty bitmap size big enough (such as 8MB) when block si

2022-09-08 Thread liuhaiwei
From: liuhaiwei so we set the fake pending size when pending size > threshold size Signed-off-by: liuhaiwei Signed-off-by: liuhaiwei --- migration/block-dirty-bitmap.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirt

[PATCH] migrate block dirty bitmap: Fix the block dirty bitmap can't to migration_completion when pending size larger than threshold size

2022-09-08 Thread liuhaiwei
From: liuhaiwei 1、dirty bitmap size big enough (such as 8MB) when block size 1T ; 2、we set the migrate speed or the bandwith is small enough(such as 4MB/s) so we set the fake pending size when pending size > threshold size Signed-off-by: liuhaiwei Signed-off-by: liuhaiwei --- migration/block-

Re: [PATCH 6/6] parallels: Image repairing in parallels_open()

2022-09-08 Thread Denis V. Lunev
On 9/2/22 10:53, Alexander Ivanov wrote: Repair an image at opening if the image is unclean or out-of-image corruption was detected. Signed-off-by: Alexander Ivanov --- block/parallels.c | 95 --- 1 file changed, 65 insertions(+), 30 deletions(-)

Re: [PATCH v3] 9pfs: use GHashTable for fid table

2022-09-08 Thread Greg Kurz
On Thu, 08 Sep 2022 18:10:28 +0200 Linus Heckemann wrote: > (sorry for the dup @Greg, forgot to reply-all) > > Greg Kurz writes: > >> > g_hash_table_steal_extended() [1] actually allows to do just that. > >> > >> g_hash_table_steal_extended unfortunately isn't available since it was > >> intro

Re: [PATCH v3] 9pfs: use GHashTable for fid table

2022-09-08 Thread Linus Heckemann
(sorry for the dup @Greg, forgot to reply-all) Greg Kurz writes: >> > g_hash_table_steal_extended() [1] actually allows to do just that. >> >> g_hash_table_steal_extended unfortunately isn't available since it was >> introduced in glib 2.58 and we're maintaining compatibility to 2.56. >> > > Ha

Re: [PATCH] migrate block dirty bitmap: Fix the block dirty bitmap can't to migration_completion when pending size larger than threshold size : 1、dirty bitmap size big enough (such as 8MB) when bloc

2022-09-08 Thread Markus Armbruster
Your subject line is way too long.

[PATCH 5/7] block/nfs: Fix 32-bit Windows build

2022-09-08 Thread Bin Meng
From: Bin Meng libnfs.h declares nfs_fstat() as the following for win32: int nfs_fstat(struct nfs_context *nfs, struct nfsfh *nfsfh, struct __stat64 *st); The 'st' parameter should be of type 'struct __stat64'. The codes happen to build successfully for 64-bit Windows, but it

[PATCH 0/7] nsis: gitlab-ci: Improve QEMU Windows installer packaging

2022-09-08 Thread Bin Meng
At present packaging the required DLLs of QEMU executables is a manual process, and error prone. Improve scripts/nsis.py by adding a logic to automatically package required DLLs of QEMU executables. 'make installer' is tested in the cross-build on Linux in CI, but not in the Windows native build.

[PATCH] qemu-img: Wean documentation and help output off '?' for help

2022-09-08 Thread Markus Armbruster
'?' for help is deprecated since commit c8057f951d "Support 'help' as a synonym for '?' in command line options", v1.2.0. We neglected to update output of qemu-img --help and the manual. Do that now. Signed-off-by: Markus Armbruster --- docs/tools/qemu-img.rst | 2 +- qemu-img.c |

Re: [PATCH v3] 9pfs: use GHashTable for fid table

2022-09-08 Thread Greg Kurz
On Thu, 8 Sep 2022 13:23:53 +0200 Linus Heckemann wrote: > The previous implementation would iterate over the fid table for > lookup operations, resulting in an operation with O(n) complexity on > the number of open files and poor cache locality -- for every open, > stat, read, write, etc operat

[PATCH v3] 9pfs: use GHashTable for fid table

2022-09-08 Thread Linus Heckemann
The previous implementation would iterate over the fid table for lookup operations, resulting in an operation with O(n) complexity on the number of open files and poor cache locality -- for every open, stat, read, write, etc operation. This change uses a hashtable for this instead, significantly i

Re: [PATCH v5 00/13] Instantiate VT82xx functions in host device

2022-09-08 Thread Daniel Henrique Barboza
On 9/8/22 05:34, Bernhard Beschow wrote: Am 1. September 2022 11:41:14 UTC schrieb Bernhard Beschow : v5: * Add patch "Inline vt82c686b_southbridge_init() and remove it" (Zoltan) * Use machine parameter when creating rtc-time alias (Zoltan) Testing done: Same as in v3. v4: * Fix in c

Re: [PATCH v5 13/13] hw/isa/vt82c686: Create rtc-time alias in boards instead

2022-09-08 Thread Daniel Henrique Barboza
On 9/1/22 08:41, Bernhard Beschow wrote: According to good QOM practice, an object should only deal with objects of its own sub tree. Having devices create an alias on the machine object doesn't respect this good practice. To resolve this, create the alias in the machine's code. Signed-off-by

Re: [PATCH v5 10/13] hw/isa/vt82c686: Instantiate AC97 and MC97 functions in host device

2022-09-08 Thread Daniel Henrique Barboza
On 9/1/22 08:41, Bernhard Beschow wrote: The AC97 function's wakeup status is wired to the PM function and both the AC97 and MC97 interrupt routing is determined by the ISA function. Signed-off-by: Bernhard Beschow --- Acked-by: Daniel Henrique Barboza hw/isa/vt82c686.c | 16 +++

Re: [PATCH v5 00/13] Instantiate VT82xx functions in host device

2022-09-08 Thread BALATON Zoltan
On Thu, 8 Sep 2022, Bernhard Beschow wrote: Am 1. September 2022 11:41:14 UTC schrieb Bernhard Beschow : v5: * Add patch "Inline vt82c686b_southbridge_init() and remove it" (Zoltan) * Use machine parameter when creating rtc-time alias (Zoltan) Testing done: Same as in v3. v4: * Fix in c

Re: [PATCH v5 09/13] hw/isa/vt82c686: Instantiate PM function in host device

2022-09-08 Thread Daniel Henrique Barboza
On 9/1/22 08:41, Bernhard Beschow wrote: The PM controller has activity bits which monitor activity of other built-in devices in the host device. Signed-off-by: Bernhard Beschow --- Acked-by: Daniel Henrique Barboza hw/isa/vt82c686.c | 13 + hw/mips/fuloong2e.c

Re: [PATCH v5 07/13] hw/isa/vt82c686: Introduce TYPE_VT82C686B_USB_UHCI define

2022-09-08 Thread Daniel Henrique Barboza
On 9/1/22 08:41, Bernhard Beschow wrote: Suggested-by: BALATON Zoltan Signed-off-by: Bernhard Beschow --- Acked-by: Daniel Henrique Barboza hw/mips/fuloong2e.c| 4 ++-- hw/ppc/pegasos2.c | 4 ++-- hw/usb/vt82c686-uhci-pci.c | 4 ++-- include/hw/isa/vt82c686.h | 1

Re: [PATCH v5 08/13] hw/isa/vt82c686: Instantiate USB functions in host device

2022-09-08 Thread Daniel Henrique Barboza
On 9/1/22 08:41, Bernhard Beschow wrote: The USB functions can be enabled/disabled through the ISA function. Also its interrupt routing can be influenced there. Signed-off-by: Bernhard Beschow --- Acked-by: Daniel Henrique Barboza hw/isa/vt82c686.c | 12 hw/mips/fuloon

Re: [PATCH v5 06/13] hw/isa/vt82c686: Instantiate IDE function in host device

2022-09-08 Thread Daniel Henrique Barboza
On 9/1/22 08:41, Bernhard Beschow wrote: The IDE function is closely tied to the ISA function (e.g. the IDE interrupt routing happens there), so it makes sense that the IDE function is instantiated within the south bridge itself. Signed-off-by: Bernhard Beschow --- Acked-by: Daniel Henriqu

Re: [PATCH v5 05/13] hw/isa/vt82c686: Introduce TYPE_VIA_IDE define

2022-09-08 Thread Daniel Henrique Barboza
On 9/1/22 08:41, Bernhard Beschow wrote: Establishes consistency with other (VIA) devices. Signed-off-by: Bernhard Beschow --- Acked-by: Daniel Henrique Barboza hw/ide/via.c | 2 +- hw/mips/fuloong2e.c | 2 +- hw/ppc/pegasos2.c | 2 +- include/hw/isa/vt82

Re: [PATCH v5 0/2] block: add missed block_acct_setup with new block device init procedure

2022-09-08 Thread Kevin Wolf
Am 07.09.2022 um 19:25 hat Denis V. Lunev geschrieben: > ping I'll get to it (and quite a few other small series on the list that should be quick to review), but probably only after KVM Forum. So I'll have to ask you to be patient for a little longer. Kevin

Re: [PATCH v5 00/13] Instantiate VT82xx functions in host device

2022-09-08 Thread Bernhard Beschow
Am 1. September 2022 11:41:14 UTC schrieb Bernhard Beschow : >v5: > >* Add patch "Inline vt82c686b_southbridge_init() and remove it" (Zoltan) > >* Use machine parameter when creating rtc-time alias (Zoltan) > > > >Testing done: Same as in v3. > > > >v4: > >* Fix in comment: AC97 Modem -> MC97 Modem