Re: [PATCH v8 3/7] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-09-28 Thread Markus Armbruster
Damien Le Moal writes: > On 9/1/22 23:57, Markus Armbruster wrote: >> Sam Li writes: >> >>> Markus Armbruster 于2022年8月31日周三 16:35写道: Sam Li writes: > Markus Armbruster 于2022年8月30日周二 19:57写道: [...] > Zoned_host_device is basically host_device + zone operations. It >>>

Re: [PATCH 2/2] virtio-blk: add zoned storage emulation for zoned devices

2022-09-28 Thread Damien Le Moal
On 2022/09/29 4:55, Sam Li wrote: > Stefan Hajnoczi 于2022年9月20日周二 05:31写道: [...] >>> +static void virtio_blk_zone_append_complete(void *opaque, int ret) { >>> +ZoneCmdData *data = opaque; >>> +VirtIOBlockReq *req = data->req; >>> +VirtIOBlock *s = req->dev; >>> +VirtIODevice *vdev

Re: [PATCH v5 11/12] blkio: implement BDRV_REQ_REGISTERED_BUF optimization

2022-09-28 Thread Alberto Campinho Faria
On Wed, Sep 28, 2022 at 8:21 PM Stefan Hajnoczi wrote: > On Tue, Sep 27, 2022 at 03:34:30PM -0400, Stefan Hajnoczi wrote: > > +ret = blkio_get_bool(s->blkio, > > + "mem-regions-pinned", > > + &s->mem_regions_pinned); > > +if (ret < 0) { > > +

Re: [PATCH v5 02/12] blkio: add libblkio block driver

2022-09-28 Thread Stefan Hajnoczi
On Wed, Sep 28, 2022 at 07:27:34AM +0200, Markus Armbruster wrote: > > +## > > +# @BlockdevOptionsVirtioBlkVhostVdpa: > > +# > > +# Driver specific block device options for the virtio-blk-vhost-vdpa > > backend. > > +# > > +# @path: path to the vhost-vdpa character device. > > +# > > +# Since: 7.2

Re: [PATCH 2/2] virtio-blk: add zoned storage emulation for zoned devices

2022-09-28 Thread Sam Li
Stefan Hajnoczi 于2022年9月20日周二 05:31写道: > > On Sat, Sep 10, 2022 at 02:50:57PM +0800, Sam Li wrote: > > This patch extends virtio-blk emulation to handle zoned device commands > > by calling the new block layer APIs to perform zoned device I/O on > > behalf of the guest. It supports Report Zone, fo

Re: [PATCH v5 11/12] blkio: implement BDRV_REQ_REGISTERED_BUF optimization

2022-09-28 Thread Stefan Hajnoczi
On Tue, Sep 27, 2022 at 03:34:30PM -0400, Stefan Hajnoczi wrote: > +ret = blkio_get_bool(s->blkio, > + "mem-regions-pinned", > + &s->mem_regions_pinned); > +if (ret < 0) { > +/* Be conservative (assume pinning) if the property is not s

Re: Question regarding live-migration with drive-mirror

2022-09-28 Thread Dr. David Alan Gilbert
* Fiona Ebner (f.eb...@proxmox.com) wrote: > Hi, > recently one of our users provided a backtrace[0] for the following > assertion failure during a live migration that uses drive-mirror to sync > a local disk: > > bdrv_co_write_req_prepare: Assertion `!(bs->open_flags & BDRV_O_INACTIVE)' > > faile

Re: [PATCH 1/1] 9pfs: avoid iterator invalidation in v9fs_mark_fids_unreclaim

2022-09-28 Thread Christian Schoenebeck
On Dienstag, 27. September 2022 21:47:02 CEST Greg Kurz wrote: > On Tue, 27 Sep 2022 19:14:33 +0200 > > Christian Schoenebeck wrote: > > On Dienstag, 27. September 2022 15:05:13 CEST Linus Heckemann wrote: > > > One more thing has occurred to me. I think the reclaiming/reopening > > > logic will

[PATCH v5 2/2] block: Refactor get_tmp_filename()

2022-09-28 Thread Bin Meng
From: Bin Meng At present there are two callers of get_tmp_filename() and they are inconsistent. One does: /* TODO: extra byte is a hack to ensure MAX_PATH space on Windows. */ char *tmp_filename = g_malloc0(PATH_MAX + 1); ... ret = get_tmp_filename(tmp_filename, PATH_MAX + 1);

Question regarding live-migration with drive-mirror

2022-09-28 Thread Fiona Ebner
Hi, recently one of our users provided a backtrace[0] for the following assertion failure during a live migration that uses drive-mirror to sync a local disk: > bdrv_co_write_req_prepare: Assertion `!(bs->open_flags & BDRV_O_INACTIVE)' > failed The way we do migration with a local disk is essenti

[PATCH v5 1/2] block: Ignore close() failure in get_tmp_filename()

2022-09-28 Thread Bin Meng
From: Bin Meng The temporary file has been created and is ready for use. Checking return value of close() does not seem useful. The file descriptor is almost certainly closed; see close(2) under "Dealing with error returns from close()". Let's simply ignore close() failure here. Suggested-by: M

Re: [PATCH v4 00/54] tests/qtest: Enable running qtest on Windows

2022-09-28 Thread Thomas Huth
On 27/09/2022 13.05, Bin Meng wrote: In preparation to adding virtio-9p support on Windows, this series enables running qtest on Windows, so that we can run the virtio-9p tests on Windows to make sure it does not break accidently. Thanks for your patches - I've picked many of them for my pull r

Re: [PATCH v4] block: Refactor get_tmp_filename()

2022-09-28 Thread Markus Armbruster
Bin Meng writes: > From: Bin Meng > > At present there are two callers of get_tmp_filename() and they are > inconsistent. > > One does: > > /* TODO: extra byte is a hack to ensure MAX_PATH space on Windows. */ > char *tmp_filename = g_malloc0(PATH_MAX + 1); > ... > ret = get_tmp_