Re: [PATCH v2 0/4] bulk: Replace TARGET_FMT_plx by HWADDR_PRIx

2023-01-19 Thread Thomas Huth
On 11/01/2023 09.39, Philippe Mathieu-Daudé wrote: Since v1: - Fix checkpatch style violations - Use HWADDR_PRIx instead of HWADDR_FMT_plx (Zoltan) Supersedes: <20230110212947.34557-1-phi...@linaro.org> "bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx" Philippe Mathieu-Daudé (4):

Re: [PATCH v4 12/19] target/hexagon: Clean up includes

2023-01-19 Thread Markus Armbruster
Taylor Simpson writes: >> -Original Message- >> From: Markus Armbruster >> Sent: Thursday, January 19, 2023 1:00 AM >> To: qemu-de...@nongnu.org >> Cc: richard.hender...@linaro.org; pbonz...@redhat.com; >> kw...@redhat.com; hre...@redhat.com; i...@bsdimp.com; >> kev...@freebsd.org;

Re: [PATCH v4 10/19] migration: Clean up includes

2023-01-19 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Markus Armbruster (arm...@redhat.com) wrote: >> >> Clean up includes so that osdep.h is included first and headers >> >> which it implies are not included manually.

Re: [PATCH v4 13/19] riscv: Clean up includes

2023-01-19 Thread Alistair Francis
On Thu, Jan 19, 2023 at 5:10 PM Markus Armbruster wrote: > > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > Signed-off-by: Markus Armbruster Reviewed-by: Alistair Francis

RE: [PATCH v4 12/19] target/hexagon: Clean up includes

2023-01-19 Thread Taylor Simpson
> -Original Message- > From: Markus Armbruster > Sent: Thursday, January 19, 2023 1:00 AM > To: qemu-de...@nongnu.org > Cc: richard.hender...@linaro.org; pbonz...@redhat.com; > kw...@redhat.com; hre...@redhat.com; i...@bsdimp.com; > kev...@freebsd.org; berra...@redhat.com;

[PATCH] virtio-scsi: reset SCSI devices from main loop thread

2023-01-19 Thread Stefan Hajnoczi
When an IOThread is configured, the ctrl virtqueue is processed in the IOThread. TMFs that reset SCSI devices are currently called directly from the IOThread and trigger an assertion failure in blk_drain(): ../block/block-backend.c:1780: void blk_drain(BlockBackend *): Assertion

Re: [PATCH v2 00/12] qemu-img info: Show protocol-level information

2023-01-19 Thread Kevin Wolf
Am 08.12.2022 um 13:24 hat Hanna Reitz geschrieben: > On 20.06.22 18:26, Hanna Reitz wrote: > > Hi, > > > > This series is a v2 to: > > > > https://lists.nongnu.org/archive/html/qemu-block/2022-05/msg00042.html > > Ping, it looks like this still applies (to the master branch and kevin’s >

Re: [PATCH v4 04/19] bsd-user: Clean up includes

2023-01-19 Thread Warner Losh
On Thu, Jan 19, 2023 at 9:42 AM Markus Armbruster wrote: > Warner Losh writes: > > > On Thu, Jan 19, 2023 at 12:00 AM Markus Armbruster > > wrote: > > > >> Clean up includes so that osdep.h is included first and headers > >> which it implies are not included manually. > >> > >> This commit was

Re: [PATCH v4 04/19] bsd-user: Clean up includes

2023-01-19 Thread Markus Armbruster
Warner Losh writes: > On Thu, Jan 19, 2023 at 12:00 AM Markus Armbruster > wrote: > >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. >> >> This commit was created with scripts/clean-includes. >> >> Signed-off-by: Markus Armbruster

Re: [PATCH v2 03/12] block/vmdk: Change extent info type

2023-01-19 Thread Kevin Wolf
Am 20.06.2022 um 18:26 hat Hanna Reitz geschrieben: > VMDK's implementation of .bdrv_get_specific_info() returns information > about its extent files, ostensibly in the form of ImageInfo objects. > However, it does not get this information through > bdrv_query_image_info(), but fills only a select

Re: [PATCH v4 04/19] bsd-user: Clean up includes

2023-01-19 Thread Warner Losh
On Thu, Jan 19, 2023 at 12:00 AM Markus Armbruster wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > Signed-off-by: Markus Armbruster > --- > bsd-user/bsd-proc.h

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

2023-01-19 Thread Guenter Roeck
On 1/19/23 00:02, Klaus Jensen wrote: On Jan 19 08:28, Klaus Jensen wrote: On Jan 18 21:03, Keith Busch wrote: On Thu, Jan 19, 2023 at 01:10:57PM +1000, Alistair Francis wrote: On Thu, Jan 19, 2023 at 12:44 PM Keith Busch wrote: Further up, it says the "interrupt gateway" is responsible

Re: [PATCH v4 19/19] Drop duplicate #include

2023-01-19 Thread Greg Kurz
On Thu, 19 Jan 2023 07:59:59 +0100 Markus Armbruster wrote: > Tracked down with the help of scripts/clean-includes. > > Signed-off-by: Markus Armbruster > --- For ppc changes. Reviewed-by: Greg Kurz > include/hw/arm/fsl-imx6ul.h | 1 - > include/hw/arm/fsl-imx7.h | 1 - >

Re: [PATCH v2 01/12] block: Improve empty format-specific info dump

2023-01-19 Thread Kevin Wolf
Am 20.06.2022 um 18:26 hat Hanna Reitz geschrieben: > When a block driver supports obtaining format-specific information, but > that object only contains optional fields, it is possible that none of > them are present, so that dump_qobject() (called by > bdrv_image_info_specific_dump()) will not

Re: [PATCH 2/3] block: do not check bdrv_file_open

2023-01-19 Thread Kevin Wolf
Am 12.12.2022 um 14:16 hat Paolo Bonzini geschrieben: > The set of BlockDrivers that have .bdrv_file_open coincides with those > that have .protocol_name and guess what---checking drv->bdrv_file_open > is done to see if the driver is a protocol. So check drv->protocol_name > instead. > >

Re: [PATCH-for-8.0] block/nbd: Add missing include

2023-01-19 Thread Kevin Wolf
Am 25.11.2022 um 18:53 hat Philippe Mathieu-Daudé geschrieben: > The inlined nbd_readXX() functions call beXX_to_cpu(), themselves > declared in . This fixes when refactoring: > > In file included from ../../block/nbd.c:44: > include/block/nbd.h: In function 'nbd_read16': >

Re: [PATCH v4 16/19] Fix non-first inclusions of qemu/osdep.h

2023-01-19 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 19/1/23 12:41, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 19/1/23 07:59, Markus Armbruster wrote: This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster >> [...] >> >>> Up to here: >>> >>>

Re: [PATCH v4 17/19] Don't include headers already included by qemu/osdep.h

2023-01-19 Thread Christian Schoenebeck
On Thursday, January 19, 2023 7:59:57 AM CET Markus Armbruster wrote: > This commit was created with scripts/clean-includes. > > Signed-off-by: Markus Armbruster > --- For 9p changes: Acked-by: Christian Schoenebeck > backends/tpm/tpm_ioctl.h | 2 -- > fsdev/p9array.h

Re: [PATCH v4 18/19] 9p: Drop superfluous include of linux/limits.h

2023-01-19 Thread Christian Schoenebeck
On Thursday, January 19, 2023 11:37:00 AM CET Markus Armbruster wrote: > Christian Schoenebeck writes: > > > On Thursday, January 19, 2023 7:59:58 AM CET Markus Armbruster wrote: > >> Signed-off-by: Markus Armbruster > >> --- > >> hw/9pfs/9p.c | 3 --- > >> 1 file changed, 3 deletions(-) > >>

Re: [PATCH v4 16/19] Fix non-first inclusions of qemu/osdep.h

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 12:41, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 19/1/23 07:59, Markus Armbruster wrote: This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster [...] Up to here: Reviewed-by: Philippe Mathieu-Daudé diff --git

Re: [PATCH v4 00/19] Clean up includes

2023-01-19 Thread Michael S. Tsirkin
On Thu, Jan 19, 2023 at 07:59:40AM +0100, Markus Armbruster wrote: > Back in 2016, we discussed[1] rules for headers, and these were > generally liked: > > 1. Have a carefully curated header that's included everywhere first. We >got that already thanks to Peter: osdep.h. > > 2. Headers

Re: [PATCH v4 10/19] migration: Clean up includes

2023-01-19 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> Clean up includes so that osdep.h is included first and headers > >> which it implies are not included manually. > > > > That change doesn't seem to match

Re: [PATCH v4 16/19] Fix non-first inclusions of qemu/osdep.h

2023-01-19 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 19/1/23 07:59, Markus Armbruster wrote: >> This commit was created with scripts/clean-includes. >> Signed-off-by: Markus Armbruster [...] > Up to here: > > Reviewed-by: Philippe Mathieu-Daudé > >> diff --git a/util/async-teardown.c b/util/async-teardown.c

Re: [PATCH v4 16/19] Fix non-first inclusions of qemu/osdep.h

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 07:59, Markus Armbruster wrote: This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster --- audio/sndioaudio.c | 2 +- backends/hostmem-epc.c | 2 +- block/export/vduse-blk.c | 2 +- hw/hyperv/syndbg.c | 2 +-

Re: [PATCH v4 13/19] riscv: Clean up includes

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 07:59, Markus Armbruster wrote: Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster --- target/riscv/pmu.h | 1 - 1 file changed, 1

Re: [PATCH v4 15/19] accel: Clean up includes

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 07:59, Markus Armbruster wrote: Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster --- include/sysemu/accel-blocker.h | 1 - 1 file

Re: [PATCH v4 18/19] 9p: Drop superfluous include of linux/limits.h

2023-01-19 Thread Markus Armbruster
Christian Schoenebeck writes: > On Thursday, January 19, 2023 7:59:58 AM CET Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> hw/9pfs/9p.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c >> index 9621ec1341..aa736af380 100644 >>

Re: [PATCH v4 11/19] net: Clean up includes

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 07:59, Markus Armbruster wrote: Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster --- net/vmnet_int.h | 1 - 1 file changed, 1

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

2023-01-19 Thread Peter Maydell
On Thu, 19 Jan 2023 at 04:03, Keith Busch wrote: > > On Thu, Jan 19, 2023 at 01:10:57PM +1000, Alistair Francis wrote: > > On Thu, Jan 19, 2023 at 12:44 PM Keith Busch wrote: > > > > > > Further up, it says the "interrupt gateway" is responsible for > > > forwarding new interrupt requests while

Re: [PATCH v4 05/19] crypto: Clean up includes

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 07:59, Markus Armbruster wrote: Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster --- crypto/block-luks-priv.h | 1 - 1 file changed, 1

Re: [PATCH v4 08/19] hw/tricore: Clean up includes

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 07:59, Markus Armbruster wrote: Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster --- include/hw/tricore/triboard.h | 1 - 1 file

Re: [PATCH v4 10/19] migration: Clean up includes

2023-01-19 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. > > That change doesn't seem to match the message; the patch is removing the > osdep.h include.

[PATCH] MAINTAINERS: Cover RCU documentation

2023-01-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0fe50d01e3..73e9cb33f5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2812,6 +2812,8 @@ F: qapi/run-state.json Read, Copy, Update (RCU) M: Paolo Bonzini

Re: [PATCH v4 19/19] Drop duplicate #include

2023-01-19 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Tracked down with the help of scripts/clean-includes. > > Signed-off-by: Markus Armbruster > --- > include/hw/arm/fsl-imx6ul.h | 1 - > include/hw/arm/fsl-imx7.h | 1 - > backends/tpm/tpm_emulator.c | 1 - > hw/acpi/piix4.c

Re: [PATCH v4 18/19] 9p: Drop superfluous include of linux/limits.h

2023-01-19 Thread Christian Schoenebeck
On Thursday, January 19, 2023 7:59:58 AM CET Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hw/9pfs/9p.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c > index 9621ec1341..aa736af380 100644 > --- a/hw/9pfs/9p.c > +++ b/hw/9pfs/9p.c >

Re: [PATCH v4 10/19] migration: Clean up includes

2023-01-19 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. That change doesn't seem to match the message; the patch is removing the osdep.h include. Dave > This commit was created with

Re: [PATCH v4 00/19] Clean up includes

2023-01-19 Thread Markus Armbruster
Markus Armbruster writes: > Back in 2016, we discussed[1] rules for headers, and these were > generally liked: > > 1. Have a carefully curated header that's included everywhere first. We >got that already thanks to Peter: osdep.h. > > 2. Headers should normally include everything they need

Re: [PATCH v4 09/19] qga: Clean up includes

2023-01-19 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Thu, Jan 19, 2023 at 9:00 AM Markus Armbruster wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > Signed-off-by: Markus

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

2023-01-19 Thread Klaus Jensen
On Jan 19 08:28, Klaus Jensen wrote: > On Jan 18 21:03, Keith Busch wrote: > > On Thu, Jan 19, 2023 at 01:10:57PM +1000, Alistair Francis wrote: > > > On Thu, Jan 19, 2023 at 12:44 PM Keith Busch wrote: > > > > > > > > Further up, it says the "interrupt gateway" is responsible for > > > >