Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

On 7/3/23 22:33, Bernhard Beschow wrote: Paolo, Peter: Should we switch to pci_device_reset() in pci_xen_ide_unplug()? Or is device_cold_reset() supposed to do everything? device_cold_reset() does not reset state that is part of the bus, so I think it's consistent that it doesn't call pci_do_d

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

Am 3. Juli 2023 07:59:29 UTC schrieb Olaf Hering : >Sun, 02 Jul 2023 22:18:50 + Bernhard Beschow : > >> Do you know if that command calls pci_device_reset() (which would eventually >> call piix_ide_reset())? > >The function is pci_xen_ide_unplug, which calls device_cold_reset. I think this

Re: [PATCH v2 02/10] block: Remove unnecessary variable in bdrv_block_device_info

On 9/6/23 22:19, Fabiano Rosas wrote: The commit 5d8813593f ("block/qapi: Let bdrv_query_image_info() recurse") removed the loop where we set the 'bs0' variable, so now it is just the same as 'bs'. Signed-off-by: Fabiano Rosas --- block/qapi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 de

Re: [PATCH v2 00/10] block: Make raw_co_get_allocated_file_size asynchronous

Fabiano Rosas writes: > Hi, > > The major change from the last version is that this time I'm moving > all of the callers of bdrv_get_allocated_file_size() into > coroutines. I had to make some temporary changes to avoid asserts > while not all the callers were converted. > > I tried my best to ex

Re: [PATCH] block/blkio: fix module_block.py parsing

On Mon, Jul 03, 2023 at 12:35:24PM +0200, Stefan Hajnoczi wrote: When QEMU is built with --enable-modules, the module_block.py script parses block/*.c to find block drivers that are built as modules. The script generates a table of block drivers called block_driver_modules[]. This table is used f

[PATCH] block/blkio: fix module_block.py parsing

When QEMU is built with --enable-modules, the module_block.py script parses block/*.c to find block drivers that are built as modules. The script generates a table of block drivers called block_driver_modules[]. This table is used for block driver module loading. The blkio.c driver uses macros to

Re: [PATCH v2 4/5] test-throttle: test read only and write only

On Tue 27 Jun 2023 03:24:30 PM +08, zhenwei pi wrote: > Signed-off-by: zhenwei pi Reviewed-by: Alberto Garcia Berto

Re: [PATCH v2 5/5] cryptodev: use NULL throttle timer cb for read direction

On Tue 27 Jun 2023 03:24:31 PM +08, zhenwei pi wrote: > Operations on a crytpodev are considered as *write* only, the callback > of read direction is never invoked. Use NULL instead of an unreachable > path(cryptodev_backend_throttle_timer_cb on read direction). > > Signed-off-by: zhenwei pi Revi

Re: [PATCH v2 3/5] throttle: support read-only and write-only

On Tue 27 Jun 2023 03:24:29 PM +08, zhenwei pi wrote: > Only one direction is necessary in several scenarios: > - a read-only disk > - operations on a device are considered as *write* only. For example, > encrypt/decrypt/sign/verify operations on a cryptodev use a single > *write* timer(read ti

Re: [PATCH v2 2/5] test-throttle: use enum ThrottleType

On Tue 27 Jun 2023 03:24:28 PM +08, zhenwei pi wrote: > Use enum ThrottleType instead in the throttle test codes. > > Signed-off-by: zhenwei pi Reviewed-by: Alberto Garcia Berto

Re: [PATCH v2 1/5] throttle: introduce enum ThrottleType

On Tue 27 Jun 2023 03:24:27 PM +08, zhenwei pi wrote: > Use enum ThrottleType instead of number index. > > Signed-off-by: zhenwei pi Reviewed-by: Alberto Garcia Berto

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

Sun, 02 Jul 2023 22:18:50 + Bernhard Beschow : > Do you know if that command calls pci_device_reset() (which would eventually > call piix_ide_reset())? The function is pci_xen_ide_unplug, which calls device_cold_reset. Olaf pgpACvJNVWPYZ.pgp Description: Digitale Signatur von OpenPGP