[PATCH v5 1/2] pcie: Use common ARI next function number

2023-07-04 Thread Akihiko Odaki
Currently the only implementers of ARI is SR-IOV devices, and they behave similar. Share the ARI next function number. Signed-off-by: Akihiko Odaki --- docs/pcie_sriov.txt | 4 ++-- include/hw/pci/pcie.h | 2 +- hw/net/igb.c | 2 +- hw/net/igbvf.c| 2 +- hw/nvme/ctrl.c

[PATCH v5 2/2] pcie: Specify 0 for ARI next function numbers

2023-07-04 Thread Akihiko Odaki
The current implementers of ARI are all SR-IOV devices. The ARI next function number field is undefined for VF according to PCI Express Base Specification Revision 5.0 Version 1.0 section 9.3.7.7. The PF should end the linked list formed with the field by specifying 0 according to section 7.8.7.2.

[PATCH v5 0/2] pcie: Fix ARI next function numbers

2023-07-04 Thread Akihiko Odaki
The ARI next function number field is undefined for VF. The PF should end the linked list formed with the field by specifying 0. Supersedes: <20230701070133.24877-1-akihiko.od...@daynix.com> ("[PATCH 0/4] pci: Compare function number and ARI next function number") V4 -> V5: Added references to

Re: [PATCH] xen-block: Avoid leaks on new error path

2023-07-04 Thread Peter Maydell
On Tue, 4 Jul 2023 at 18:19, Anthony PERARD wrote: > > From: Anthony PERARD > > Commit 189829399070 ("xen-block: Use specific blockdev driver") > introduced a new error path, without taking care of allocated > resources. > > So only allocate the qdicts after the error check, and free both >

[PATCH] xen-block: Avoid leaks on new error path

2023-07-04 Thread Anthony PERARD via
From: Anthony PERARD Commit 189829399070 ("xen-block: Use specific blockdev driver") introduced a new error path, without taking care of allocated resources. So only allocate the qdicts after the error check, and free both `filename` and `driver` when we are about to return and thus taking care

[PULL 0/1] Block patches

2023-07-04 Thread Stefan Hajnoczi
The following changes since commit d145c0da22cde391d8c6672d33146ce306e8bf75: Merge tag 'pull-tcg-20230701' of https://gitlab.com/rth7680/qemu into staging (2023-07-01 08:55:37 +0200) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for

[PULL 1/1] block/blkio: fix module_block.py parsing

2023-07-04 Thread Stefan Hajnoczi
When QEMU is built with --enable-modules, the module_block.py script parses block/*.c to find block drivers that are built as modules. The script generates a table of block drivers called block_driver_modules[]. This table is used for block driver module loading. The blkio.c driver uses macros to

[PATCH] virtio-blk: fix host notifier issues during dataplane start/stop

2023-07-04 Thread Stefan Hajnoczi
The main loop thread can consume 100% CPU when using --device virtio-blk-pci,iothread=. ppoll() constantly returns but reading virtqueue host notifiers fails with EAGAIN. The file descriptors are stale and remain registered with the AioContext because of bugs in the virtio-blk dataplane start/stop

Re: [PATCH v4 2/2] pcie: Specify 0 for ARI next function numbers

2023-07-04 Thread Igor Mammedov
On Tue, 4 Jul 2023 21:22:14 +0900 Akihiko Odaki wrote: > The current implementers of ARI are all SR-IOV devices. The ARI next > function number field is undefined for VF . ^ add a reference to a spec (spec name, rev, chapter) where it's declared so

[PATCH v4 3/3] hw/ufs: Support for UFS logical unit

2023-07-04 Thread Jeuk Kim
From: Jeuk Kim This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim --- hw/ufs/lu.c | 1441

[PATCH v4 2/3] hw/ufs: Support for Query Transfer Requests

2023-07-04 Thread Jeuk Kim
From: Jeuk Kim This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim --- hw/ufs/trace-events |1 + hw/ufs/ufs.c| 1005

[PATCH v4 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-07-04 Thread Jeuk Kim
From: Jeuk Kim Universal Flash Storage (UFS) is a high-performance mass storage device with a serial interface. It is primarily used as a high-performance data storage device for embedded applications. This commit contains code for UFS device to be recognized as a UFS PCI device. Patches to

[PATCH v4 0/3] hw/ufs: Add Universal Flash Storage (UFS) support

2023-07-04 Thread Jeuk Kim
From: Jeuk Kim Since v3: - Replace softmmu_ss -> system_ss in meson Since v2: Addressed review comment from Stefan Hajnoczi. The main fixes are as follows. - Use of SPDX licence identifiers - fixed endianness error - removed memory leak - fixed DMA error handling logic Since v1: - use macros

Re: [PATCH v2] block/blkio: fix module_block.py parsing

2023-07-04 Thread Stefano Garzarella
On Tue, Jul 04, 2023 at 02:34:36PM +0200, Stefan Hajnoczi wrote: When QEMU is built with --enable-modules, the module_block.py script parses block/*.c to find block drivers that are built as modules. The script generates a table of block drivers called block_driver_modules[]. This table is used

Re: [PATCH] block/blkio: fix module_block.py parsing

2023-07-04 Thread Stefan Hajnoczi
On Mon, 3 Jul 2023 at 12:55, Stefano Garzarella wrote: > > On Mon, Jul 03, 2023 at 12:35:24PM +0200, Stefan Hajnoczi wrote: > >When QEMU is built with --enable-modules, the module_block.py script > >parses block/*.c to find block drivers that are built as modules. The > >script generates a table

[PATCH v2] block/blkio: fix module_block.py parsing

2023-07-04 Thread Stefan Hajnoczi
When QEMU is built with --enable-modules, the module_block.py script parses block/*.c to find block drivers that are built as modules. The script generates a table of block drivers called block_driver_modules[]. This table is used for block driver module loading. The blkio.c driver uses macros to

[PATCH v4 1/2] pcie: Use common ARI next function number

2023-07-04 Thread Akihiko Odaki
Currently the only implementers of ARI is SR-IOV devices, and they behave similar. Share the ARI next function number. Signed-off-by: Akihiko Odaki --- docs/pcie_sriov.txt | 4 ++-- include/hw/pci/pcie.h | 2 +- hw/net/igb.c | 2 +- hw/net/igbvf.c| 2 +- hw/nvme/ctrl.c

[PATCH v4 2/2] pcie: Specify 0 for ARI next function numbers

2023-07-04 Thread Akihiko Odaki
The current implementers of ARI are all SR-IOV devices. The ARI next function number field is undefined for VF. The PF should end the linked list formed with the field by specifying 0. For migration, the field will keep having 1 as its value on the old virt models. Fixes: 2503461691 ("pcie: Add

[PATCH v4 0/2] pcie: Fix ARI next function numbers

2023-07-04 Thread Akihiko Odaki
The ARI next function number field is undefined for VF. The PF should end the linked list formed with the field by specifying 0. Supersedes: <20230701070133.24877-1-akihiko.od...@daynix.com> ("[PATCH 0/4] pci: Compare function number and ARI next function number") V3 -> V4: Corrected the

Re: [PATCH v3 2/2] pcie: Specify 0 for ARI next function numbers

2023-07-04 Thread Igor Mammedov
On Sun, 2 Jul 2023 21:02:27 +0900 Akihiko Odaki wrote: > The current implementers of ARI are all SR-IOV devices. The ARI next > function number field is undefined for VF. The PF should end the linked > list formed with the field by specifying 0. this should also describe compat behavior

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-04 Thread Paolo Bonzini
On 7/3/23 22:33, Bernhard Beschow wrote: Paolo, Peter: Should we switch to pci_device_reset() in pci_xen_ide_unplug()? Or is device_cold_reset() supposed to do everything? device_cold_reset() does not reset state that is part of the bus, so I think it's consistent that it doesn't call