On Fri, Jun 09, 2023 at 10:33:16AM +0200, Hanna Czenczek wrote:
> bdrv_pad_request() relies on requests' lengths not to exceed SIZE_MAX,
> which bdrv_check_qiov_request() does not guarantee.
>
> bdrv_check_request32() however will guarantee this, and both of
> bdrv_pad_request()'s callers (bdrv_co
Am 11. Juli 2023 09:11:33 UTC schrieb Olaf Hering :
>Wed, 05 Jul 2023 21:52:05 + Bernhard Beschow :
>
>> I wonder if we should fix this line rather than dropping it.
>
>I think this needs to be fixed, just to fix the initial commit which
>added this bug. This will allow backporting this onel
Am 1. Juli 2023 17:46:59 UTC schrieb Olaf Hering :
>According to the 82371FB documentation (82371FB.pdf, 2.3.9. BMIBA—BUS
>MASTER INTERFACE BASE ADDRESS REGISTER, April 1997), the register is
>32bit wide. To properly reset it to default values, all 32bit need to be
>cleared. Bit #0 "Resource Typ
On 7/10/23 22:47, Eric Blake wrote:
> On Mon, Jun 26, 2023 at 07:08:33PM +0300, Andrey Drobyshev via wrote:
>> When target image is using subclusters, and we align the request during
>> copy-on-read, it makes sense to align to subcluster_size rather than
>> cluster_size. Otherwise we end up with u
v1 --> v2:
* Fixed line indentation;
* Fixed wording in a comment;
* Added R-b.
v1: https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html
Andrey Drobyshev (3):
block: add subcluster_size field to BlockDriverInfo
block/io: align requests to subcluster_size
tests/qemu-iote
Add testcase which checks that allocations during copy-on-read are
performed on the subcluster basis when subclusters are enabled in target
image.
This testcase also triggers the following assert with previous commit
not being applied, so we check that as well:
qemu-io: ../block/io.c:1236: bdrv_c
This is going to be used in the subsequent commit as requests alignment
(in particular, during copy-on-read). This value only makes sense for
the formats which support subclusters (currently QCOW2 only). If this
field isn't set by driver's own bdrv_get_info() implementation, we
simply set it equa
When target image is using subclusters, and we align the request during
copy-on-read, it makes sense to align to subcluster_size rather than
cluster_size. Otherwise we end up with unnecessary allocations.
This commit renames bdrv_round_to_clusters() to bdrv_round_to_subclusters()
and utilizes sub
On 6/26/23 18:08, Andrey Drobyshev wrote:
Add testcase which checks that allocations during copy-on-read are
performed on the subcluster basis when subclusters are enabled in target
image.
This testcase also triggers the following assert with previous commit
not being applied, so we check that a
On 6/26/23 18:08, Andrey Drobyshev wrote:
When target image is using subclusters, and we align the request during
copy-on-read, it makes sense to align to subcluster_size rather than
cluster_size. Otherwise we end up with unnecessary allocations.
This commit renames bdrv_round_to_clusters() to
On 6/26/23 18:08, Andrey Drobyshev wrote:
This is going to be used in the subsequent commit as requests alignment
(in particular, during copy-on-read). This value only makes sense for
the formats which support subclusters (currently QCOW2 only). If this
field isn't set by driver's own bdrv_get_
Hi,
Any more reviews...?
Dear Stefan
If you don't mind, Could you give it "reviewed-by"?
And is there anything else I should do...?
Thanks,
Jeuk
On 2023-07-04 오후 5:33, Jeuk Kim wrote:
From: Jeuk Kim
Since v3:
- Replace softmmu_ss -> system_ss in meson
Since v2:
Addressed review comment from
Wed, 05 Jul 2023 21:52:05 + Bernhard Beschow :
> I wonder if we should fix this line rather than dropping it.
I think this needs to be fixed, just to fix the initial commit which
added this bug. This will allow backporting this oneliner.
Further changes to pci_xen_ide_unplug will be done in
On Tue, Jul 11, 2023 at 12:40:47PM +0530, Ani Sinha wrote:
>
>
> > On 01-Jul-2023, at 12:31 PM, Akihiko Odaki wrote:
> >
> > The function number must be lower than the next function number
> > advertised with ARI.
> >
> > Signed-off-by: Akihiko Odaki
> > ---
> > hw/pci/pci.c | 15
> On 01-Jul-2023, at 12:31 PM, Akihiko Odaki wrote:
>
> The function number must be lower than the next function number
> advertised with ARI.
>
> Signed-off-by: Akihiko Odaki
> ---
> hw/pci/pci.c | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/hw/pci/pci.c b/hw/pci
15 matches
Mail list logo
