Re: [PATCH v2 3/6] python/console_socket: accept existing FD in initializer

2023-07-26 Thread Ani Sinha
> On 25-Jul-2023, at 11:33 PM, John Snow wrote: > > Useful if we want to use ConsoleSocket() for a socket created by > socketpair(). > > Signed-off-by: John Snow Reviewed-by: Ani Sinha > --- > python/qemu/machine/console_socket.py | 29 +++ > 1 file changed, 21

Re: [PATCH v7 0/4] hw/ufs: Add Universal Flash Storage (UFS) support

2023-07-26 Thread Jeuk Kim
On 7/27/2023 4:36 AM, Stefan Hajnoczi wrote: On Wed, Jul 26, 2023 at 02:30:49PM +0900, Jeuk Kim wrote: Since v6: - Add tests/qtest/ufs-test.c to test ufs initialisation and I/O - Add struct UtpTaskReqDesc to include/block/ufs.h - Fix ufs_log2() logic - Fix ufs-lu to use 4K as default block size

Re: [PATCH v7 4/4] tests/qtest: Introduce tests for UFS

2023-07-26 Thread Stefan Hajnoczi
On Wed, Jul 26, 2023 at 02:30:53PM +0900, Jeuk Kim wrote: > +static void *ufs_blk_test_setup(GString *cmd_line, void *arg) > +{ > +char *tmp_path = drive_create(); > + > +g_string_append_printf(cmd_line, > + " -drive if=none,id=drv1,file=%s," > +

Re: [PATCH v7 0/4] hw/ufs: Add Universal Flash Storage (UFS) support

2023-07-26 Thread Stefan Hajnoczi
On Wed, Jul 26, 2023 at 02:30:49PM +0900, Jeuk Kim wrote: > Since v6: > - Add tests/qtest/ufs-test.c to test ufs initialisation and I/O > - Add struct UtpTaskReqDesc to include/block/ufs.h > - Fix ufs_log2() logic > - Fix ufs-lu to use 4K as default block size to match the ufs spec > > Since I

Re: [PATCH v2 4/6] python/machine: use socketpair() for console connections

2023-07-26 Thread John Snow
On Wed, Jul 26, 2023, 6:50 AM Ani Sinha wrote: > > > > On 25-Jul-2023, at 11:33 PM, John Snow wrote: > > > > Create a socketpair for the console output. This should help eliminate > > race conditions around console text early in the boot process that might > > otherwise have been dropped on the

Re: [PATCH 1/1] qemu-nbd: regression with arguments passing into nbd_client_thread()

2023-07-26 Thread Eric Blake
On Wed, Jul 26, 2023 at 04:52:47PM +0200, Denis V. Lunev wrote: > Unfortunately > commit 03b67621445d601c9cdc7dfe25812e9f19b81488 > Author: Denis V. Lunev > Date: Mon Jul 17 16:55:40 2023 +0200 > qemu-nbd: pass structure into nbd_client_thread instead of plain char* > has

Re: [PATCH 1/2] block/blkio: fix opening virtio-blk drivers

2023-07-26 Thread Stefano Garzarella
On Wed, Jul 26, 2023 at 11:32:10AM -0400, Stefan Hajnoczi wrote: On Wed, Jul 26, 2023 at 09:26:45AM +0200, Stefano Garzarella wrote: On Tue, Jul 25, 2023 at 04:00:38PM -0400, Stefan Hajnoczi wrote: > On Mon, Jul 24, 2023 at 05:46:10PM +0200, Stefano Garzarella wrote: > > libblkio 1.3.0 added

Re: [PATCH 1/2] block/blkio: fix opening virtio-blk drivers

2023-07-26 Thread Stefan Hajnoczi
On Wed, Jul 26, 2023 at 09:26:45AM +0200, Stefano Garzarella wrote: > On Tue, Jul 25, 2023 at 04:00:38PM -0400, Stefan Hajnoczi wrote: > > On Mon, Jul 24, 2023 at 05:46:10PM +0200, Stefano Garzarella wrote: > > > libblkio 1.3.0 added support of "fd" property for virtio-blk-vhost-vdpa > > > driver.

[PATCH 1/1] qemu-nbd: regression with arguments passing into nbd_client_thread()

2023-07-26 Thread Denis V. Lunev
Unfortunately commit 03b67621445d601c9cdc7dfe25812e9f19b81488 Author: Denis V. Lunev Date: Mon Jul 17 16:55:40 2023 +0200 qemu-nbd: pass structure into nbd_client_thread instead of plain char* has introduced a regression. struct NbdClientOpts resides on stack inside 'if' block.

Re: [PATCH v2] block/blkio: do not use open flags in qemu_open()

2023-07-26 Thread Stefan Hajnoczi
On Wed, Jul 26, 2023 at 09:48:07AM +0200, Stefano Garzarella wrote: > qemu_open() in blkio_virtio_blk_common_open() is used to open the > character device (e.g. /dev/vhost-vdpa-0 or /dev/vfio/vfio) or in > the future eventually the unix socket. > > In all these cases we cannot open the path in

Re: How to tame CI?

2023-07-26 Thread Thomas Huth
On 26/07/2023 15.00, Peter Maydell wrote: On Wed, 26 Jul 2023 at 13:06, Juan Quintela wrote: To make things easier, this is the part that show how it breaks (this is the gcov test): 357/423 qemu:block / io-qcow2-copy-before-write ERROR 6.38s exit status

Re: [PATCH v2 4/6] python/machine: use socketpair() for console connections

2023-07-26 Thread Ani Sinha
> On 25-Jul-2023, at 11:33 PM, John Snow wrote: > > Create a socketpair for the console output. This should help eliminate > race conditions around console text early in the boot process that might > otherwise have been dropped on the floor before being able to connect to > QEMU under

Re: [PATCH v8 01/10] parallels: Fix comments formatting inside parallels driver

2023-07-26 Thread Denis V. Lunev
On 7/18/23 12:44, Alexander Ivanov wrote: This patch is technically necessary as git patch rendering could result in moving some code from one place to the another and that hits checkpatch.pl warning. This problem specifically happens within next series. Signed-off-by: Alexander Ivanov ---

Re: [PATCH v2 3/3] tests/qemu-iotests/197: add testcase for CoR with subclusters

2023-07-26 Thread Vladimir Sementsov-Ogievskiy
On 11.07.23 20:25, Andrey Drobyshev via wrote: Add testcase which checks that allocations during copy-on-read are performed on the subcluster basis when subclusters are enabled in target image. This testcase also triggers the following assert with previous commit not being applied, so we check

Re: [PATCH v2 2/3] block/io: align requests to subcluster_size

2023-07-26 Thread Vladimir Sementsov-Ogievskiy
On 11.07.23 20:25, Andrey Drobyshev wrote: When target image is using subclusters, and we align the request during copy-on-read, it makes sense to align to subcluster_size rather than cluster_size. Otherwise we end up with unnecessary allocations. This commit renames bdrv_round_to_clusters()

Re: [PATCH v2 1/3] block: add subcluster_size field to BlockDriverInfo

2023-07-26 Thread Vladimir Sementsov-Ogievskiy
On 11.07.23 20:25, Andrey Drobyshev wrote: This is going to be used in the subsequent commit as requests alignment (in particular, during copy-on-read). This value only makes sense for the formats which support subclusters (currently QCOW2 only). If this field isn't set by driver's own

Re: [PATCH v4] block-jobs: flush target at the end of .run()

2023-07-26 Thread Denis V. Lunev
On 7/25/23 19:40, Vladimir Sementsov-Ogievskiy wrote: From: Vladimir Sementsov-Ogievskiy Actually block job is not completed without this final flush. It's rather unexpected to have broken target when job was successfully completed long ago and now we fail to flush or process just

Re: [PATCH v2] block/blkio: do not use open flags in qemu_open()

2023-07-26 Thread Daniel P . Berrangé
On Wed, Jul 26, 2023 at 09:48:07AM +0200, Stefano Garzarella wrote: > qemu_open() in blkio_virtio_blk_common_open() is used to open the > character device (e.g. /dev/vhost-vdpa-0 or /dev/vfio/vfio) or in > the future eventually the unix socket. > > In all these cases we cannot open the path in

Re: [PATCH v7 4/4] tests/qtest: Introduce tests for UFS

2023-07-26 Thread Jeuk Kim
On 7/26/2023 4:21 PM, Thomas Huth wrote:  Hi! On 26/07/2023 07.30, Jeuk Kim wrote: This patch includes the following tests    Test mmio read    Test ufs device initialization and ufs-lu recognition    Test I/O (Performs a write followed by a read to verify) Signed-off-by: Jeuk Kim --- ...

Re: s390 intermittent test failure in qemu:block / io-qcow2-copy-before-write

2023-07-26 Thread Christian Borntraeger
Am 25.07.23 um 18:45 schrieb Peter Maydell: There seems to be an intermittent failure on the s390 host in the qemu:block / io-qcow2-copy-before-write test: https://gitlab.com/qemu-project/qemu/-/jobs/4737819873 The log says the test was expecting to do some reading and writing but got an

[PATCH v2] block/blkio: do not use open flags in qemu_open()

2023-07-26 Thread Stefano Garzarella
qemu_open() in blkio_virtio_blk_common_open() is used to open the character device (e.g. /dev/vhost-vdpa-0 or /dev/vfio/vfio) or in the future eventually the unix socket. In all these cases we cannot open the path in read-only mode, when the `read-only` option of blockdev is on, because the

Re: [PATCH 2/2] block/blkio: use blkio_set_int("fd") to check fd support

2023-07-26 Thread Stefano Garzarella
On Tue, Jul 25, 2023 at 04:05:38PM -0400, Stefan Hajnoczi wrote: On Mon, Jul 24, 2023 at 05:46:11PM +0200, Stefano Garzarella wrote: The way the virtio-blk driver is implemented in libblkio, it's much easier to use blkio_set_int() instead of blkio_get_int() and have it fail right away to see if

Re: [PATCH 1/2] block/blkio: fix opening virtio-blk drivers

2023-07-26 Thread Stefano Garzarella
On Tue, Jul 25, 2023 at 04:00:38PM -0400, Stefan Hajnoczi wrote: On Mon, Jul 24, 2023 at 05:46:10PM +0200, Stefano Garzarella wrote: libblkio 1.3.0 added support of "fd" property for virtio-blk-vhost-vdpa driver. In QEMU, starting from commit cad2ccc395 ("block/blkio: use qemu_open() to support

Re: [PATCH v2 2/6] python/machine: close sock_pair in cleanup path

2023-07-26 Thread Ani Sinha
> On 25-Jul-2023, at 11:48 PM, Daniel P. Berrangé wrote: > > On Tue, Jul 25, 2023 at 02:03:33PM -0400, John Snow wrote: >> If everything has gone smoothly, we'll already have closed the socket we >> gave to the child during post_launch. The other half of the pair that we >> gave to the QMP

Re: [PATCH v7 4/4] tests/qtest: Introduce tests for UFS

2023-07-26 Thread Thomas Huth
Hi! On 26/07/2023 07.30, Jeuk Kim wrote: This patch includes the following tests Test mmio read Test ufs device initialization and ufs-lu recognition Test I/O (Performs a write followed by a read to verify) Signed-off-by: Jeuk Kim --- ... diff --git a/tests/qtest/ufs-test.c

回复: [PATCH v1] block/stream:add flush l2_table_cache,ensure data integrity

2023-07-26 Thread 张承
>On 25.07.23 18:13, Denis V. Lunev wrote: >>On 7/25/23 16:25, Vladimir Sementsov-Ogievskiy wrote: >>>On 24.07.23 10:30, Evanzhang wrote: On 7/26/23 01:41, Vladimir Sementsov-Ogievskiy wrote: block_stream will not actively flush l2_table_cache,when qemu process exception exit,causing

Re: [PATCH v2 1/6] python/machine: move socket setup out of _base_args property

2023-07-26 Thread Ani Sinha
> On 25-Jul-2023, at 11:33 PM, John Snow wrote: > > This property isn't meant to do much else besides return a list of > strings, so move this setup back out into _pre_launch(). > > Signed-off-by: John Snow Reviewed-by: Ani Sinha > --- > python/qemu/machine/machine.py | 5 ++--- > 1 file