Re: [PATCH v2 4/4] vhost-user-scsi: support reconnect to backend

I don’t think we should be changing any vhost-scsi-common code here. I’d rather implement wrappers around vhost_user_scsi_start/stop() around vhost_user_scsi_common_start/stop() and check started_vu there. Otherwise I think this is looking good. Glad to see you caught the

Re: [PATCH v2 2/4] vhost-user-common: send get_inflight_fd once

> On Jul 28, 2023, at 3:49 AM, Li Feng wrote: > > > >> 2023年7月28日 下午2:04，Michael S. Tsirkin 写道： >> >> On Tue, Jul 25, 2023 at 06:42:45PM +0800, Li Feng wrote: >>> Get_inflight_fd is sent only once. When reconnecting to the backend, >>> qemu sent set_inflight_fd to the backend. >> >> I

Re: [PATCH v2 3/4] vhost: move and rename the conn retry times

> On Jul 25, 2023, at 6:42 AM, Li Feng wrote: > > Multile devices need this macro, move it to a common header. > > Signed-off-by: Li Feng Reviewed-by: Raphael Norwitz > --- > hw/block/vhost-user-blk.c | 4 +--- > hw/virtio/vhost-user-gpio.c | 3 +-- > include/hw/virtio/vhost.h | 2 ++ >

Re: [PATCH] vhost-user-scsi: support reconnect to backend

> On Jul 28, 2023, at 3:48 AM, Li Feng wrote: > > Thanks for your reply. > >> 2023年7月28日 上午5:21，Raphael Norwitz 写道： >> >> >> >>> On Jul 25, 2023, at 6:19 AM, Li Feng wrote: >>> >>> Thanks for your comments. >>> 2023年7月25日 上午1:21，Raphael Norwitz 写道： Very excited to see

Re: [PATCH v2 1/4] vhost: fix the fd leak

> On Jul 25, 2023, at 6:42 AM, Li Feng wrote: > > When the vhost-user reconnect to the backend, the notifer should be > cleanup. Otherwise, the fd resource will be exhausted. > > Fixes: f9a09ca3ea ("vhost: add support for configure interrupt") > > Signed-off-by: Li Feng Reviewed-by:

[PULL 1/1] hw/nvme: use stl/ldl pci dma api

From: Klaus Jensen Use the stl/ldl pci dma api for writing/reading doorbells. This removes the explicit endian conversions. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Tested-by: Cédric Le Goater Reviewed-by: Thomas Huth Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c

[PULL 0/1] hw/nvme fixes

From: Klaus Jensen Hi, This should also fix coverity cid 1518067 and 1518066. The following changes since commit ccb86f079a9e4d94918086a9df18c1844347aff8: Merge tag 'pull-nbd-2023-07-28' of https://repo.or.cz/qemu/ericb into staging (2023-07-28 09:56:57 -0700) are available in the Git

[PATCH] Fix some typos in documentation and comments

Signed-off-by: Stefan Weil --- This patch was triggered by a spelling check for the generated QEMU documentation using codespell. It does not try to fix all typos which still exist in the QEMU code, but has a focus on those required to fix the documentation. Nevertheless some code comments with