On Wed, 2023-10-18 at 10:52 +0200, Kevin Wolf wrote:
> Am 16.10.2023 um 17:19 hat David Woodhouse geschrieben:
> > From: David Woodhouse
> >
> > There's no need to force the user to assign a vdev. We can automatically
> > assign one, starting at xvda and searching until we find the first disk
>
Am 13.10.2023 um 11:21 hat Fiona Ebner geschrieben:
> which allows switching the @copy-mode from 'background' to
> 'write-blocking'.
>
> This is useful for management applications, so they can start out in
> background mode to avoid limiting guest write speed and switch to
> active mode when
From: Li Feng
When the vhost-user is reconnecting to the backend, and if the vhost-user fails
at the get_features in vhost_dev_init(), then the reconnect will fail
and it will not be retriggered forever.
The reason is:
When the vhost-user fails at get_features, the vhost_dev_cleanup will be
From: Li Feng
Multiple devices need this macro, move it to a common header.
Signed-off-by: Li Feng
Reviewed-by: Raphael Norwitz
Message-Id: <20231009044735.941655-3-fen...@smartx.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/virtio/vhost.h | 2 ++
Am 13.10.2023 um 11:21 hat Fiona Ebner geschrieben:
> which will allow changing job-type-specific options after job
> creation.
>
> In the JobVerbTable, the same allow bits as for set-speed are used,
> because set-speed can be considered an existing change command.
>
> Signed-off-by: Fiona Ebner
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Wed, Oct 18, 2023 at 02:02:08PM +0200, Markus Armbruster wrote:
> > Daniel P. Berrangé writes:
> >
> > > On Wed, Oct 18, 2023 at 06:51:41AM -0400, Michael S. Tsirkin wrote:
> > >> On Wed, Oct 18, 2023 at 12:36:10PM +0200, Markus Armbruster
Vladimir Sementsov-Ogievskiy writes:
> On 18.10.23 13:45, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> Add a command that can replace bs in following BdrvChild structures:
>>>
>>> - qdev blk root child
>>> - block-export blk root child
>>> - any child of
On 18.10.23 15:02, Markus Armbruster wrote:
Daniel P. Berrangé writes:
On Wed, Oct 18, 2023 at 06:51:41AM -0400, Michael S. Tsirkin wrote:
On Wed, Oct 18, 2023 at 12:36:10PM +0200, Markus Armbruster wrote:
x- seems safer for management tool that doesn't know about "unstable"
properties..
On Wed, Oct 18, 2023 at 02:02:08PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Wed, Oct 18, 2023 at 06:51:41AM -0400, Michael S. Tsirkin wrote:
> >> On Wed, Oct 18, 2023 at 12:36:10PM +0200, Markus Armbruster wrote:
> >> > > x- seems safer for management tool that
On 18.10.23 13:45, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Add a command that can replace bs in following BdrvChild structures:
- qdev blk root child
- block-export blk root child
- any child of BlockDriverState selected by child-name
Signed-off-by: Vladimir
Daniel P. Berrangé writes:
> On Wed, Oct 18, 2023 at 06:51:41AM -0400, Michael S. Tsirkin wrote:
>> On Wed, Oct 18, 2023 at 12:36:10PM +0200, Markus Armbruster wrote:
>> > > x- seems safer for management tool that doesn't know about "unstable"
>> > > properties..
>> >
>> > Easy, traditional,
It is obsolete. It is better to use driver-mirror with NBD instead.
CC: Kevin Wolf
CC: Eric Blake
CC: Stefan Hajnoczi
CC: Hanna Czenczek
Acked-by: Stefan Hajnoczi
Reviewed-by: Markus Armbruster
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 10 ++
Acked-by: Stefan Hajnoczi
Acked-by: Peter Xu
Reviewed-by: Markus Armbruster
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 8 +
qapi/migration.json | 63 ++-
migration/options.c | 13
3 files changed, 64
Use blockdev-mirror with NBD instead.
Reviewed-by: Thomas Huth
Acked-by: Stefan Hajnoczi
Reviewed-by: Markus Armbruster
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 8
qapi/migration.json| 8 +++-
migration/migration-hmp-cmds.c | 5 +
Use blocked-mirror with NBD instead.
Acked-by: Stefan Hajnoczi
Reviewed-by: Thomas Huth
Reviewed-by: Markus Armbruster
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 9 +
qapi/migration.json| 7 ---
migration/migration-hmp-cmds.c | 5 +
Create a new filter that removes the two warnings for test 183.
Signed-off-by: Juan Quintela
---
tests/qemu-iotests/183 | 2 +-
tests/qemu-iotests/common.filter | 7 +++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/183 b/tests/qemu-iotests/183
Based on: Message-ID: <20231018100651.32674-1-quint...@redhat.com>
[PULL 00/11] Migration 20231018 patches
v8 now:
- drop changes to 183.out
- create _filter_migration_block_deprecated
And now it passes the iotests.
Please review patch 1.
Rest are unchanged from v6.
Later
Daniel P. Berrangé wrote:
> On Wed, Oct 18, 2023 at 12:38:10PM +0200, Juan Quintela wrote:
>> Juan Quintela wrote:
>> > Based on: Message-ID: <20231018100651.32674-1-quint...@redhat.com>
>> > [PULL 00/11] Migration 20231018 patches
>> >
>
On Wed, Oct 18, 2023 at 06:51:41AM -0400, Michael S. Tsirkin wrote:
> On Wed, Oct 18, 2023 at 12:36:10PM +0200, Markus Armbruster wrote:
> > > x- seems safer for management tool that doesn't know about "unstable"
> > > properties..
> >
> > Easy, traditional, and unreliable :)
>
> > > But on the
On Wed, 2023-10-18 at 10:52 +0200, Kevin Wolf wrote:
> Am 16.10.2023 um 17:19 hat David Woodhouse geschrieben:
> > From: David Woodhouse
> >
> > There's no need to force the user to assign a vdev. We can automatically
> > assign one, starting at xvda and searching until we find the first disk
>
On Wed, Oct 18, 2023 at 12:38:10PM +0200, Juan Quintela wrote:
> Juan Quintela wrote:
> > Based on: Message-ID: <20231018100651.32674-1-quint...@redhat.com>
> > [PULL 00/11] Migration 20231018 patches
> >
> > And here we are, at v7:
> > - drop
On Wed, Oct 18, 2023 at 12:36:10PM +0200, Markus Armbruster wrote:
> > x- seems safer for management tool that doesn't know about "unstable"
> > properties..
>
> Easy, traditional, and unreliable :)
> > But on the other hand, changing from x- to no-prefix is already done when
> > the feature
Vladimir Sementsov-Ogievskiy writes:
> Add a command that can replace bs in following BdrvChild structures:
>
> - qdev blk root child
> - block-export blk root child
> - any child of BlockDriverState selected by child-name
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
[...]
> diff
Juan Quintela wrote:
> Based on: Message-ID: <20231018100651.32674-1-quint...@redhat.com>
> [PULL 00/11] Migration 20231018 patches
>
> And here we are, at v7:
> - drop black line at the end of deprecated.rst
> - change qemu-iotest output due to warnings for d
Vladimir Sementsov-Ogievskiy writes:
> On 18.10.23 09:47, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> On 17.10.23 18:00, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
> Send a new event when guest reads virtio-pci config after
>
Use blockdev-mirror with NBD instead.
Reviewed-by: Thomas Huth
Acked-by: Stefan Hajnoczi
Reviewed-by: Markus Armbruster
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 8
qapi/migration.json| 8 +++-
migration/migration-hmp-cmds.c | 5 +
Use blocked-mirror with NBD instead.
Acked-by: Stefan Hajnoczi
Reviewed-by: Thomas Huth
Reviewed-by: Markus Armbruster
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 9 +
qapi/migration.json| 7 ---
migration/migration-hmp-cmds.c | 5 +
Acked-by: Stefan Hajnoczi
Acked-by: Peter Xu
Reviewed-by: Markus Armbruster
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 8 +
qapi/migration.json | 63 ++-
migration/options.c | 13
3 files changed, 64
Based on: Message-ID: <20231018100651.32674-1-quint...@redhat.com>
[PULL 00/11] Migration 20231018 patches
And here we are, at v7:
- drop black line at the end of deprecated.rst
- change qemu-iotest output due to warnings for deprecation.
The only real change is the output of th
It is obsolete. It is better to use driver-mirror with NBD instead.
CC: Kevin Wolf
CC: Eric Blake
CC: Stefan Hajnoczi
CC: Hanna Czenczek
Acked-by: Stefan Hajnoczi
Reviewed-by: Markus Armbruster
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 10 ++
Markus Armbruster wrote:
> Juan Quintela writes:
>
>> Use blockdev-mirror with NBD instead.
>>
>> Reviewed-by: Thomas Huth
>> Acked-by: Stefan Hajnoczi
>> Reviewed-by: Markus Armbruster
>> Signed-off-by: Juan Quintela
>> ---
>> docs/about/deprecated.rst | 9 +
>>
Am 18.10.23 um 11:41 schrieb Markus Armbruster:
> Fiona Ebner writes:
>>
>> Initially, I tried to go for a more general 'job-change' command, but
>> to avoid mutual inclusion of block-core.json and job.json, more
>> preparation would be required.
>
> Can you elaborate a bit? A more generic
Am 17.10.23 um 16:20 schrieb Kevin Wolf:
> Am 17.10.2023 um 15:37 hat Fiona Ebner geschrieben:
>> Am 17.10.23 um 14:12 schrieb Kevin Wolf:
>>> Am 17.10.2023 um 12:18 hat Fiona Ebner geschrieben:
I ran into similar issues now with mirror, (both deadlocks and stuck
guest IO at other
Fiona Ebner writes:
> Changes in v3:
> * unlock the job mutex when calling the new block job driver
> 'query' handler
> * squash patch adapting iotest output into patch that changes the
> output
> * turn accesses to copy_mode and actively_synced atomic
> * slightly
Fiona Ebner writes:
> which allows switching the @copy-mode from 'background' to
> 'write-blocking'.
>
> This is useful for management applications, so they can start out in
> background mode to avoid limiting guest write speed and switch to
> active mode when certain criteria are fulfilled.
>
>
Fiona Ebner writes:
> In preparation to turn BlockJobInfo into a union with @type as the
> discriminator. That requires it to be an enum.
>
> No functional change is intended.
>
> Signed-off-by: Fiona Ebner
> Reviewed-by: Vladimir Sementsov-Ogievskiy
Replacing str by enum makes sense whether
Am 16.10.2023 um 17:19 hat David Woodhouse geschrieben:
> From: David Woodhouse
>
> There's no need to force the user to assign a vdev. We can automatically
> assign one, starting at xvda and searching until we find the first disk
> name that's unused.
>
> This means we can now allow '-drive
On 18.10.23 09:47, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
On 17.10.23 18:00, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Send a new event when guest reads virtio-pci config after
virtio_notify_config() call.
That's useful to check that guest
Queued. Thanks!
On Wed, Oct 18, 2023 at 04:26:10PM +0800, Li Feng wrote:
> Hello Guys,
>
> Ping…
>
> These patches have been waiting for a long time. Can they be merged?
>
>
> Best Regards,
>
> li
>
>
> On 9 Oct 2023, at 12:46 PM, Li Feng wrote:
>
> Changes for v8:
> -
Juan Quintela writes:
> Use blockdev-mirror with NBD instead.
>
> Reviewed-by: Thomas Huth
> Acked-by: Stefan Hajnoczi
> Reviewed-by: Markus Armbruster
> Signed-off-by: Juan Quintela
> ---
> docs/about/deprecated.rst | 9 +
> qapi/migration.json| 8 +++-
>
Hello Guys,
Ping…
These patches have been waiting for a long time. Can they be merged?
Best Regards,
li
> On 9 Oct 2023, at 12:46 PM, Li Feng wrote:
>
> Changes for v8:
> - [PATCH 3/5] vhost-user-scsi: support reconnect to backend
> - Fix code style suggested by Manos Pitsidianakis
> -
If the backend crashes and restarts, the device is broken.
This patch adds reconnect for vhost-user-scsi.
This patch also improves the error messages, and reports some silent
errors.
Tested with spdk backend.
Signed-off-by: Li Feng
---
Reviewed-by: Manos Pitsidianakis
On Wed, 2023-10-18 at 09:32 +0200, Igor Mammedov wrote:
> On Mon, 16 Oct 2023 16:19:08 +0100
> David Woodhouse wrote:
>
> > From: David Woodhouse
> >
>
> is this index a user (guest) visible?
Yes. It defines what block device (e.g. /dev/xvda) the disk appears as
in the guest. In the common
On Mon, 16 Oct 2023 16:19:08 +0100
David Woodhouse wrote:
> From: David Woodhouse
>
is this index a user (guest) visible?
> There's no need to force the user to assign a vdev. We can automatically
> assign one, starting at xvda and searching until we find the first disk
> name that's unused.
Juan Quintela writes:
> Markus Armbruster wrote:
>> Juan Quintela writes:
>>
>>> Signed-off-by: Juan Quintela
>>> Acked-by: Stefan Hajnoczi
>>> Acked-by: Peter Xu
>
>
>>> # @deprecated: Member @disk is deprecated because block migration is.
>>> +# Member @compression is deprecated
Juan Quintela writes:
> Markus Armbruster wrote:
>> Juan Quintela writes:
>>
>>> Use blockdev-mirror with NBD instead.
>>>
>>> Reviewed-by: Thomas Huth
>>> Acked-by: Stefan Hajnoczi
>>> Signed-off-by: Juan Quintela
>>>
>>> ---
>>>
>>> Improve documentation and style (thanks Markus)
>>> ---
Vladimir Sementsov-Ogievskiy writes:
> On 17.10.23 18:00, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> Send a new event when guest reads virtio-pci config after
>>> virtio_notify_config() call.
>>>
>>> That's useful to check that guest fetched modified config, for
Vladimir Sementsov-Ogievskiy writes:
> On 17.10.23 17:57, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> Add command to sync config from vhost-user backend to the device. It
>>> may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not
>>> triggered
48 matches
Mail list logo