Re: [PATCH v3 0/4] ide: implement simple legacy/native mode switching for PCI IDE controllers

2023-11-16 Thread BALATON Zoltan
On Thu, 16 Nov 2023, Kevin Wolf wrote: Am 16.11.2023 um 11:33 hat Mark Cave-Ayland geschrieben: This series adds a simple implementation of legacy/native mode switching for PCI IDE controllers and updates the via-ide device to use it. The approach I take here is to add a new

Re: [PATCH v5 2/4] qcow2: add configurations for zoned format extension

2023-11-16 Thread Sam Li
Hi Eric, Eric Blake 于2023年10月30日周一 22:53写道: > > On Mon, Oct 30, 2023 at 08:18:45PM +0800, Sam Li wrote: > > To configure the zoned format feature on the qcow2 driver, it > > requires settings as: the device size, zone model, zone size, > > zone capacity, number of conventional zones, limits on

Re: [PATCH v5 2/4] qcow2: add configurations for zoned format extension

2023-11-16 Thread Sam Li
Markus Armbruster 于2023年11月3日周五 17:08写道: > > Eric Blake writes: > > > On Mon, Oct 30, 2023 at 08:18:45PM +0800, Sam Li wrote: > >> To configure the zoned format feature on the qcow2 driver, it > >> requires settings as: the device size, zone model, zone size, > >> zone capacity, number of

Re: [PATCH v5 2/4] qcow2: add configurations for zoned format extension

2023-11-16 Thread Sam Li
Stefan Hajnoczi 于2023年11月3日周五 11:24写道: > > On Mon, Oct 30, 2023 at 08:18:45PM +0800, Sam Li wrote: > > +typedef struct Qcow2ZoneListEntry { > > +QLIST_ENTRY(Qcow2ZoneListEntry) exp_open_zone_entry; > > +QLIST_ENTRY(Qcow2ZoneListEntry) imp_open_zone_entry; > > +

Converting images to stdout

2023-11-16 Thread Alberto Garcia
Hi, I haven't written here in a while :) but I have something small that I would like to discuss. Using qemu-img to convert an image and writing the result directly to stdout is a question that has already been raised in the past (see [1] for an example) and it's clear that it's generally not

Re: [PATCH v3 0/4] ide: implement simple legacy/native mode switching for PCI IDE controllers

2023-11-16 Thread Kevin Wolf
Am 16.11.2023 um 11:33 hat Mark Cave-Ayland geschrieben: > This series adds a simple implementation of legacy/native mode switching for > PCI > IDE controllers and updates the via-ide device to use it. > > The approach I take here is to add a new pci_ide_update_mode() function which > handles >

Re: [PATCH v3 3/4] ide/via: don't attempt to set default BAR addresses

2023-11-16 Thread Philippe Mathieu-Daudé
On 16/11/23 11:33, Mark Cave-Ayland wrote: The via-ide device currently attempts to set the default BAR addresses to the values shown in the datasheet, but this doesn't work for 2 reasons: firstly BARS 1-4 do not set the bottom 2 bits to PCI_BASE_ADDRESS_SPACE_IO, and secondly the initial PCI

Re: [PATCH v3 1/4] ide/ioport: move ide_portio_list[] and ide_portio_list2[] definitions to IDE core

2023-11-16 Thread Philippe Mathieu-Daudé
On 16/11/23 11:33, Mark Cave-Ayland wrote: These definitions are present in ioport.c which is currently only available when CONFIG_IDE_ISA is enabled. Move them to the IDE core so that they can be made available to PCI IDE controllers that support switching to legacy mode. Signed-off-by: Mark

Re: [PATCH v3 4/4] hw/ide/via: implement legacy/native mode switching

2023-11-16 Thread BALATON Zoltan
On Thu, 16 Nov 2023, Mark Cave-Ayland wrote: Allow the VIA IDE controller to switch between both legacy and native modes by calling pci_ide_update_mode() to reconfigure the device whenever PCI_CLASS_PROG is updated. This patch moves the initial setting of PCI_CLASS_PROG from via_ide_realize()

[PATCH v3 0/4] ide: implement simple legacy/native mode switching for PCI IDE controllers

2023-11-16 Thread Mark Cave-Ayland
This series adds a simple implementation of legacy/native mode switching for PCI IDE controllers and updates the via-ide device to use it. The approach I take here is to add a new pci_ide_update_mode() function which handles management of the PCI BARs and legacy IDE ioports for each mode to

[PATCH v3 1/4] ide/ioport: move ide_portio_list[] and ide_portio_list2[] definitions to IDE core

2023-11-16 Thread Mark Cave-Ayland
These definitions are present in ioport.c which is currently only available when CONFIG_IDE_ISA is enabled. Move them to the IDE core so that they can be made available to PCI IDE controllers that support switching to legacy mode. Signed-off-by: Mark Cave-Ayland --- hw/ide/core.c |

[PATCH v3 3/4] ide/via: don't attempt to set default BAR addresses

2023-11-16 Thread Mark Cave-Ayland
The via-ide device currently attempts to set the default BAR addresses to the values shown in the datasheet, but this doesn't work for 2 reasons: firstly BARS 1-4 do not set the bottom 2 bits to PCI_BASE_ADDRESS_SPACE_IO, and secondly the initial PCI bus reset clears the values of all PCI device

[PATCH v3 4/4] hw/ide/via: implement legacy/native mode switching

2023-11-16 Thread Mark Cave-Ayland
Allow the VIA IDE controller to switch between both legacy and native modes by calling pci_ide_update_mode() to reconfigure the device whenever PCI_CLASS_PROG is updated. This patch moves the initial setting of PCI_CLASS_PROG from via_ide_realize() to via_ide_reset(), and removes the direct

[PATCH v3 2/4] ide/pci: introduce pci_ide_update_mode() function

2023-11-16 Thread Mark Cave-Ayland
This function reads the value of the PCI_CLASS_PROG register for PCI IDE controllers and configures the PCI BARs and/or IDE ioports accordingly. In the case where we switch to legacy mode, the PCI BARs are set to return zero (as suggested in the "PCI IDE Controller" specification), the legacy IDE

Re: [PATCH] block-backend: per-device throttling of BLOCK_IO_ERROR reports

2023-11-16 Thread Vladimir Sementsov-Ogievskiy
On 15.11.23 16:46, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: From: Leonid Kaplan BLOCK_IO_ERROR events comes from guest, so we must throttle them. Really? Can you describe how a guest can trigger these errors? When disk (for examaple vhost-user) is unavailable, every