Re: [PATCH 3/3] cli: Remove deprecated '-singlestep' command line option

2024-01-17 Thread Thomas Huth
On 17/01/2024 16.14, Philippe Mathieu-Daudé wrote: This option has been deprecated before the 8.1 release, in commit 12fd0f41d0 ("Document that -singlestep command line option is deprecated"). Time to drop it. Inspired-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH 2/3] hmp: Remove deprecated 'singlestep' command

2024-01-17 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@linaro.org) wrote: > This command has been deprecated before the 8.1 release, > in commit e9ccfdd91d ("hmp: Add 'one-insn-per-tb' command > equivalent to 'singlestep'"). Time to drop it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan

Re: [PATCH 3/3] monitor: only run coroutine commands in qemu_aio_context

2024-01-17 Thread Kevin Wolf
Am 16.01.2024 um 20:00 hat Stefan Hajnoczi geschrieben: > monitor_qmp_dispatcher_co() runs in the iohandler AioContext that is not > polled during nested event loops. The coroutine currently reschedules > itself in the main loop's qemu_aio_context AioContext, which is polled > during nested event

Re: [PATCH 2/3] iotests: port 141 to Python for reliable QMP testing

2024-01-17 Thread Kevin Wolf
Am 16.01.2024 um 20:00 hat Stefan Hajnoczi geschrieben: > The common.qemu bash functions allow tests to interact with the QMP > monitor of a QEMU process. I spent two days trying to update 141 when > the order of the test output changed, but found it would still fail > occassionally because

Re: double free or corruption (out) in iscsi virtual machine

2024-01-17 Thread Peter Maydell
On Wed, 17 Jan 2024 at 07:24, M_O_Bz wrote: > > Basic Info: > 1. Issue: I got a " double free or corruption (out)", head for attachment > debug.log for details, the debug.log print the backtrace of one virtual > machine > 2. Reproduce: currently I cann't destribe how to reproduce this bug,

Re: [PATCH 1/3] iotests: add filter_qmp_generated_node_ids()

2024-01-17 Thread Kevin Wolf
Am 16.01.2024 um 20:00 hat Stefan Hajnoczi geschrieben: > Add a filter function for QMP responses that contain QEMU's > automatically generated node ids. The ids change between runs and must > be masked in the reference output. > > The next commit will use this new function. > > Signed-off-by:

Re: [PATCH 2/3] iotests: port 141 to Python for reliable QMP testing

2024-01-17 Thread Kevin Wolf
Am 16.01.2024 um 20:00 hat Stefan Hajnoczi geschrieben: > The common.qemu bash functions allow tests to interact with the QMP > monitor of a QEMU process. I spent two days trying to update 141 when > the order of the test output changed, but found it would still fail > occassionally because

[PATCH v2 4/4] iotests: add backup-discard-source

2024-01-17 Thread Vladimir Sementsov-Ogievskiy
Add test for a new backup option: discard-source. Signed-off-by: Vladimir Sementsov-Ogievskiy --- .../qemu-iotests/tests/backup-discard-source | 151 ++ .../tests/backup-discard-source.out | 5 + 2 files changed, 156 insertions(+) create mode 100755

[PATCH v2 0/4] backup: discard-source parameter

2024-01-17 Thread Vladimir Sementsov-Ogievskiy
v2: - now, based on master - CBW permissions a bit reworked - clamp down length to discard (thanks to Fiona) - use modern vm.cmd() in test instead of vm.qmp() Vladimir Sementsov-Ogievskiy (4): block/copy-before-write: fix permission block/copy-before-write: create block_copy

[PATCH v2 2/4] block/copy-before-write: create block_copy bitmap in filter node

2024-01-17 Thread Vladimir Sementsov-Ogievskiy
Currently block_copy creates copy_bitmap in source node. But that is in bad relation with .independent_close=true of copy-before-write filter: source node may be detached and removed before .bdrv_close() handler called, which should call block_copy_state_free(), which in turn should remove

[PATCH v2 3/4] qapi: blockdev-backup: add discard-source parameter

2024-01-17 Thread Vladimir Sementsov-Ogievskiy
Add a parameter that enables discard-after-copy. That is mostly useful in "push backup with fleecing" scheme, when source is snapshot-access format driver node, based on copy-before-write filter snapshot-access API: [guest] [snapshot-access] ~~ blockdev-backup ~~> [backup target] |

[PATCH v2 1/4] block/copy-before-write: fix permission

2024-01-17 Thread Vladimir Sementsov-Ogievskiy
In case when source node does not have any parents, the condition still works as required: backup job do create the parent by block_job_create -> block_job_add_bdrv -> bdrv_root_attach_child Still, in this case checking @perm variable doesn't work, as backup job creates the root blk with empty

[PATCH 3/3] cli: Remove deprecated '-singlestep' command line option

2024-01-17 Thread Philippe Mathieu-Daudé
This option has been deprecated before the 8.1 release, in commit 12fd0f41d0 ("Document that -singlestep command line option is deprecated"). Time to drop it. Inspired-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 17 -

[PATCH 2/3] hmp: Remove deprecated 'singlestep' command

2024-01-17 Thread Philippe Mathieu-Daudé
This command has been deprecated before the 8.1 release, in commit e9ccfdd91d ("hmp: Add 'one-insn-per-tb' command equivalent to 'singlestep'"). Time to drop it. Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 9 - docs/about/removed-features.rst | 6 ++

[PATCH 1/3] qapi: Remove deprecated 'singlestep' member of StatusInfo

2024-01-17 Thread Philippe Mathieu-Daudé
This member has been deprecated before the 8.1 release, in commit 34c18203d4 ("qmp: Deprecate 'singlestep' member of StatusInfo"). Time to drop it. Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 14 -- qapi/run-state.json| 11 ---

[PATCH 0/3] qapi/hmp/cli: Remove the deprecated 'singlestep'

2024-01-17 Thread Philippe Mathieu-Daudé
Deprecated for 8.1, good to go for 9.0. Based-on: <20240112100059.965041-5-th...@redhat.com> "Remove deprecated command line options" Philippe Mathieu-Daudé (3): qapi: Remove deprecated 'singlestep' member of StatusInfo hmp: Remove deprecated 'singlestep' command cli: Remove

Re: [PATCH] block/io: clear BDRV_BLOCK_RECURSE flag after recursing in bdrv_co_block_status

2024-01-17 Thread Stefan Hajnoczi
On Tue, Jan 16, 2024 at 04:48:39PM +0100, Fiona Ebner wrote: > Using fleecing backup like in [0] on a qcow2 image (with metadata > preallocation) can lead to the following assertion failure: > > > bdrv_co_do_block_status: Assertion `!(ret & BDRV_BLOCK_ZERO)' failed. > > In the reproducer [0], it

Re: [PATCH] block/io: clear BDRV_BLOCK_RECURSE flag after recursing in bdrv_co_block_status

2024-01-17 Thread Vladimir Sementsov-Ogievskiy
On 16.01.24 18:48, Fiona Ebner wrote: Using fleecing backup like in [0] on a qcow2 image (with metadata preallocation) can lead to the following assertion failure: bdrv_co_do_block_status: Assertion `!(ret & BDRV_BLOCK_ZERO)' failed. In the reproducer [0], it happens because the

Re: [PATCH] string-output-visitor: Fix (pseudo) struct handling

2024-01-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 11.01.2024 um 12:45 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Commit ff32bb53 tried to get minimal struct support into the string >> > output visitor by just making it return "". Unfortunately, it >> > forgot that the caller will still make more

Re: [PATCH v2 0/3] hw/pflash: implement update buffer for block writes

2024-01-17 Thread Philippe Mathieu-Daudé
On 8/1/24 17:08, Gerd Hoffmann wrote: Gerd Hoffmann (3): hw/pflash: refactor pflash_data_write() hw/pflash: use ldn_{be,le}_p and stn_{be,le}_p hw/pflash: implement update buffer for block writes Series: Reviewed-by: Philippe Mathieu-Daudé and queued, thanks!

Re: [PATCH v3 0/6] sysemu/replay: Restrict icount to TCG system emulation

2024-01-17 Thread Philippe Mathieu-Daudé
On 8/12/23 12:35, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (6): sysemu/cpu-timers: Have icount_configure() return a boolean system/vl: Evaluate icount after accelerator options are parsed sysemu/cpu-timers: Introduce ICountMode enumerator target/arm: Ensure icount is