Re: [Qemu-block] [PATCH v5 01/10] qom: add helpers for UserCreatable object types

Am 03.02.2016 um 00:38 schrieb Eric Blake: > On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: >> The QMP monitor code has two helper methods object_add >> and qmp_object_del that are called from several places >> in the code (QMP, HMP and main emulator startup). >> >> The HMP and main emulator

[Qemu-block] [PULL v2 3/4] tests: Use proper functions types instead of void (*fn)

gt; Reviewed-by: Eric Blake <ebl...@redhat.com> [AF/armbru: Inline GTestFunc/GTestDataFunc typedef for old GLib] Signed-off-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- tests/ide-test.c| 4 ++-- tests/libqtest.c| 14 ++

[Qemu-block] [PULL 3/4] tests: Use proper functions types instead of void (*fn)

gt; Reviewed-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- tests/ide-test.c| 4 ++-- tests/libqtest.c| 13 + tests/libqtest.h| 6 +++--- tests/vhost-user-test.c | 3 ++- 4 files changed, 16 insertions(+), 10

Re: [Qemu-block] [PATCH v11 18/28] qerror: more error_setg() usage

ERIC_ERROR, > - "Path '%s' does not uniquely identify an object", path); > +error_setg(errp, "Path '%s' does not uniquely identify an object", > + path); > } else if (!target) { > target = object_resolve_path(path, )

Re: [Qemu-block] [Qemu-devel] [PATCH v11 18/28] qerror: more error_setg() usage

Am 11.11.2015 um 15:21 schrieb Markus Armbruster: > Eric Blake writes: > >> A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) have snuck in >> since c6bd8c706. Nuke them. > > Doesn't really belong to this series, but that's okay. It seemed to avoid a GENERIC_ERROR ->

Re: [Qemu-block] [PATCH v11 19/28] qapi: Change munging of CamelCase enum values

t; + error_set(errp, ERROR_CLASS_DEVICENOTFOUND, >"Device '%s' not found", path); > } > target = NULL; That spelling is not exactly an improvement, but well, Reviewed-by: Andreas Färber <afaer...@suse.de> Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

[Qemu-block] [PULL v3 03/14] tests: Use qtest_add_data_func() consistently

Replace uses of g_test_add_data_func() for QTest test cases. It is still valid to use it for any non-QTest test cases, which are not run for multiple target binaries. Suggested-by: John Snow js...@redhat.com Reviewed-by: John Snow js...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de

[Qemu-block] [PULL v2 03/12] tests: Use qtest_add_data_func() consistently

Replace uses of g_test_add_data_func() for QTest test cases. It is still valid to use it for any non-QTest test cases, which are not run for multiple target binaries. Suggested-by: John Snow js...@redhat.com Reviewed-by: John Snow js...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de

[Qemu-block] [PULL 03/12] tests: Use qtest_add_data_func() consistently

Replace uses of g_test_add_data_func() for QTest test cases. It is still valid to use it for any non-QTest test cases, which are not run for multiple target binaries. Suggested-by: John Snow js...@redhat.com Reviewed-by: John Snow js...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de

Re: [Qemu-block] [Qemu-devel] [PATCH RFC for-2.3? 5/8] fdb: Move FDCtrlISABus to header

Am 31.03.2015 um 03:38 schrieb John Snow: You probably meant 'fdc' ! On 03/29/2015 01:53 PM, Andreas Färber wrote: To be used for embedding the device. Add gtk-doc private/public markers for parent field. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/block/fdc.c | 87

Re: [Qemu-block] [Qemu-devel] [PATCH v2 4/4] tests: Use qtest_add_data_func() consistently

Am 27.03.2015 um 19:46 schrieb John Snow: On 03/26/2015 11:41 AM, Andreas Färber wrote: Am 25.03.2015 um 23:14 schrieb John Snow: On 03/25/2015 02:20 PM, Andreas Färber wrote: Replace uses of g_test_add_data_func() for QTest test cases. It is still valid to use it for any non-QTest test

Re: [Qemu-block] [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage

David, Am 29.03.2015 um 19:53 schrieb Andreas Färber: Hello Markus et al., This series attempts to fix the -device pc87312 issues you reported. I can't add alias properties for devices that don't get created before realize. Therefore this involves moving code for various ISA devices

Re: [Qemu-block] [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage

Am 30.03.2015 um 18:12 schrieb Paolo Bonzini: On 30/03/2015 16:25, Markus Armbruster wrote: Andreas Färber afaer...@suse.de writes: Hello Markus et al., This series attempts to fix the -device pc87312 issues you reported. I can't add alias properties for devices that don't get created

[Qemu-block] [PATCH RFC for-2.3? 7/8] ide: Move ISAIDEState to header

To be used for embedding the device. Add gtk-doc private/public markers for parent fields. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/ide/internal.h | 155 hw/ide/isa.c | 13 include/hw/ide.h | 173

[Qemu-block] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage

...@redhat.com Andreas Färber (8): parallel: Factor out header for ISAParallelState struct pc87312: Create isa-parallel in-place and add alias par0-chardev property serial: Move ISASerialState to header pc87312: Create UARTs in-place and add alias properties fdb: Move FDCtrlISABus to header