Re: [PATCH 1/9] tests/qtest/arm-cpu-features: Remove Cortex-A15 check

On Fri, Feb 05, 2021 at 05:03:08PM +0100, Philippe Mathieu-Daudé wrote: > On 2/5/21 4:33 PM, Andrew Jones wrote: > > On Fri, Feb 05, 2021 at 04:15:45PM +0100, Philippe Mathieu-Daudé wrote: > >> Hi Drew, > >> > >> On 2/5/21 3:59 PM, Andrew Jones wrote: > >&

Re: [PATCH 1/9] tests/qtest/arm-cpu-features: Remove Cortex-A15 check

On Fri, Feb 05, 2021 at 04:15:45PM +0100, Philippe Mathieu-Daudé wrote: > Hi Drew, > > On 2/5/21 3:59 PM, Andrew Jones wrote: > > On Fri, Feb 05, 2021 at 03:43:37PM +0100, Philippe Mathieu-Daudé wrote: > >> Support for ARMv7 has been dropped in commit 82bf7ae84ce >

Re: [RFC PATCH 9/9] tests/qtest/arm-cpu-features: Restrict TCG-only tests

On Fri, Feb 05, 2021 at 03:43:45PM +0100, Philippe Mathieu-Daudé wrote: > Some tests explicitly request the TCG accelerator. As these > tests will obviously fails if TCG is not present, disable > them in such case. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Roman Bolshakov > Cc:

Re: [PATCH 8/9] hw/arm/virt: Restrict 32-bit CPUs to TCG

ARM_CPU_TYPE_NAME("cortex-a57"), > -- > 2.26.2 > So this filters the cpus out of KVM only builds, which seems reasonable to do. Of course, if the build is for both KVM and TCG, then the cpus won't be filtered out and we'll have to rely on the runtime checks to error out if one where to try a 32-bit cpu with KVM. But that's fine too, so Reviewed-by: Andrew Jones Thanks, drew

Re: [PATCH 7/9] hw/arm/virt: Do not include 64-bit CPUs in 32-bit build

-a53"), > ARM_CPU_TYPE_NAME("cortex-a57"), > ARM_CPU_TYPE_NAME("cortex-a72"), > +#endif /* TARGET_AARCH64 */ > ARM_CPU_TYPE_NAME("host"), > ARM_CPU_TYPE_NAME("max"), > }; > -- > 2.26.2 > Reviewed-by: Andrew Jones

Re: [PATCH 6/9] hw/arm/virt: Display list of valid CPUs for the Virt machine

On Fri, Feb 05, 2021 at 03:43:42PM +0100, Philippe Mathieu-Daudé wrote: > The Virt machine is restricted to a subset of the CPU provided > by QEMU. Instead of having the user run '--cpu help' and try > each CPUs until finding a match, display the list from start: > > $ qemu-system-aarch64 -M

Re: [PATCH 4/9] tests/qtest/cdrom-test: Only allow the Virt machine under KVM

On Fri, Feb 05, 2021 at 03:43:40PM +0100, Philippe Mathieu-Daudé wrote: > Only the Virt and Versal machines are supported under KVM. > Restrict the other ones to TCG. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/qtest/cdrom-test.c | 5 - > 1 file changed, 4 insertions(+), 1

Re: [PATCH 5/9] hw/arm/virt: Improve CPU name in help message

FIX); > + > +error_report("mach-virt: CPU type %.*s not supported", > + len, machine->cpu_type); > exit(1); > } > > -- > 2.26.2 > Reviewed-by: Andrew Jones

Re: [PATCH 3/9] tests/qtest/boot-serial-test: Test Virt machine with 'max'

rt", "-cpu cortex-a57", "TT", sizeof(kernel_aarch64), > +{ "aarch64", "virt", "-cpu max", "TT", sizeof(kernel_aarch64), >kernel_aarch64 }, > { "arm", "microbit", "", "T", sizeof(kernel_nrf51), kernel_nrf51 }, > > -- > 2.26.2 > > Reviewed-by: Andrew Jones

Re: [PATCH 1/9] tests/qtest/arm-cpu-features: Remove Cortex-A15 check

On Fri, Feb 05, 2021 at 03:43:37PM +0100, Philippe Mathieu-Daudé wrote: > Support for ARMv7 has been dropped in commit 82bf7ae84ce > ("target/arm: Remove KVM support for 32-bit Arm hosts"), > no need to check for Cortex A15 host cpu anymore. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PULL 13/13] qemu/atomic.h: rename atomic_ to qatomic_

On Wed, Sep 23, 2020 at 05:10:31PM +0100, Stefan Hajnoczi wrote: > clang's C11 atomic_fetch_*() functions only take a C11 atomic type > pointer argument. QEMU uses direct types (int, etc) and this causes a > compiler error when a QEMU code calls these functions in a source file > that also

Re: [PATCH v10 12/12] tests/acpi: update expected data files

On Fri, Jun 19, 2020 at 11:19:05AM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > tests/data/acpi/pc/DSDT | Bin 5014 -> 4934 bytes > tests/data/acpi/pc/DSDT.acpihmat | Bin 6338 -> 6258 bytes > tests/data/acpi/pc/DSDT.bridge| Bin 6873 -> 6793 bytes >

Re: [Qemu-block] [Qemu-devel] [PATCH v3 3/5] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays

On Wed, Dec 19, 2018 at 01:43:40PM +0100, Philippe Mathieu-Daudé wrote: > Hi Drew, > > On 12/19/18 11:10 AM, Andrew Jones wrote: > > On Tue, Dec 18, 2018 at 06:51:20PM +0100, Philippe Mathieu-Daudé wrote: > >> GCC 8 added a -Wstringop-truncation warning: > >>

Re: [Qemu-block] [Qemu-devel] [PATCH v3 3/5] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays

On Tue, Dec 18, 2018 at 06:51:20PM +0100, Philippe Mathieu-Daudé wrote: > GCC 8 added a -Wstringop-truncation warning: > > The -Wstringop-truncation warning added in GCC 8.0 via r254630 for > bug 81117 is specifically intended to highlight likely unintended > uses of the strncpy function

Re: [Qemu-block] [Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

On Fri, Jan 27, 2017 at 02:54:20PM +, Peter Maydell wrote: > On 27 January 2017 at 14:31, Peter Maydell <peter.mayd...@linaro.org> wrote: > > On 12 January 2017 at 11:36, Andrew Jones <drjo...@redhat.com> wrote: > >> On Thu, Jan 12, 2017 at 10:42:41AM +, Pet

Re: [Qemu-block] [Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

On Thu, Jan 12, 2017 at 10:42:41AM +, Peter Maydell wrote: > On 12 January 2017 at 10:35, David Engraf wrote: > > The CFI entry for sector length must be set to sector length per device. > > This is important for boards using multiple devices like the ARM Vexpress > >