Re: [PATCH v7 01/47] block: Add child access functions

QLIST_FOREACH(c, >children, next) { > if (c->role & BDRV_CHILD_PRIMARY) { > -return c; > +assert(!found); > +found = c; > } > } > > -return NULL; > +return c; Shouldn't that be "return found"? > } > > > with or without: > Reviewed-by: Vladimir Sementsov-Ogievskiy -- Cheers, Christophe de Dinechin (IRC c3d)

[PATCH] trivial: Remove trailing whitespaces

. Signed-off-by: Christophe de Dinechin --- block/iscsi.c | 2 +- disas/cris.c | 2 +- disas/microblaze.c| 80 +++--- disas/nios2.c | 256 +- hmp

[PATCH] scsi/qemu-pr-helper: Fix out-of-bounds access to trnptid_list[]

-off-by: Christophe de Dinechin --- scsi/qemu-pr-helper.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/scsi/qemu-pr-helper.c b/scsi/qemu-pr-helper.c index 0659ceef09..01013221b3 100644 --- a/scsi/qemu-pr-helper.c +++ b/scsi/qemu-pr-helper.c @@ -421,7

Re: Priority of -accel

> On 13 Jan 2020, at 17:25, Paolo Bonzini wrote: > > On 13/01/20 17:17, Markus Armbruster wrote: >> Perfect opportunity to change the default to something more useful. > > I am not sure acutally if it's that more useful, now that we have > sanctioned qemu-kvm as the fast alternative. OK,

Re: Priority of -accel

> On 13 Jan 2020, at 15:39, Markus Armbruster wrote: > > Thomas Huth writes: 'any' is a russian roulette, you don't want it to return 'qtest' ;) >>> >>> We could make it return "qtest" only on April 1st ;-P >> >> ... or we finally dare to let QEMU chose the "best" accelerator by

Re: Priority of -accel (was: [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option)

> On 7 Jan 2020, at 15:37, Paolo Bonzini wrote: > > On 07/01/20 14:55, Christophe de Dinechin wrote: >> So what about ranking the accelerators, so that all combinaisons >> -accel=kvm:tcg, -accel=tcg:kvm, -accel kvm -accel tcg, etc would > > (I assume you m

Re: Priority of -accel (was: [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option)

> On 7 Jan 2020, at 11:14, Paolo Bonzini wrote: > > On 07/01/20 11:03, Thomas Huth wrote: >>> >>> vm = QEMUMachine(iotests.qemu_prog) >>> -vm.add_args('-machine', 'accel=kvm:tcg') >>> +vm.add_args('-accel', 'kvm', '-accel', 'tcg') >> Looking at this, I wonder whether we really want the

Re: [Qemu-devel] [libvirt] [PATCH 2/2] qapi: deprecate implicit filters

> On 22 Nov 2019, at 09:41, Markus Armbruster wrote: > > Reviving this old thread, because I'd like to connect it to more recent > discussions. > > Christophe de Dinechin mailto:dinec...@redhat.com>> > writes: > >> Markus Armbruster

Re: [PATCH v3 09/16] libqos: access VIRTIO 1.0 vring in little-endian

; { For my education, I was wondering why tests use the (1ull << FEATURE) notation and not an equivalent of virtio_has_feature()? Is this intentional, or just legacy? -- Cheers, Christophe de Dinechin (IRC c3d)

Re: [Qemu-block] [Qemu-devel] [libvirt] [PATCH 2/2] qapi: deprecate implicit filters

John Snow writes: > On 8/29/19 12:45 PM, Christophe de Dinechin wrote: >> [...] >> Sorry for catching up late, this mail thread happened during my PTO. >> >> I remember bringing up at the time [1] that the correct solution needs >> to take into ac

Re: [Qemu-block] [Qemu-devel] [libvirt] [PATCH 2/2] qapi: deprecate implicit filters

Connect warn_report() and all the error_vprintf output to QAPI, e.g. using John's suggestion of adding the messages using some "warning" or "deprecated" tag? 3. Teach libvirt how to consume that new tag and pass it along? [1] https://lists.nongnu.org/archive/html/qemu-devel/2018-10/msg06131.html -- Cheers, Christophe de Dinechin (IRC c3d)

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

lready at the BoF seemed like a really big hammer to kill a fly. CC'ing Andrea as well, because we discussed recently about how to deal with error checking in general, and if a new error checking framework is being put in place, adding deprecation to the thinking could be a good idea. -- Cheers, Christophe de Dinechin (IRC c3d)

Re: [Qemu-block] [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

> On 1 Aug 2019, at 11:19, Damien Hedde wrote: > > > On 7/31/19 12:17 PM, Christophe de Dinechin wrote: >> >> Peter Maydell writes: >> >>> On Tue, 30 Jul 2019 at 14:56, Cornelia Huck wrote: >>>> >>>> On Tue, 30 Jul 2019 14:44

Re: [Qemu-block] [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

cept of locality associated with warm reset? For example, you'd expect a cold reset to happen on the whole system, but I guess a warm reset could be restricted to a single bus. The documentation should give examples of how warm reset could be triggered, and what it could do differently from cold reset. > > thanks > -- PMM -- Cheers, Christophe de Dinechin (IRC c3d)

Re: [Qemu-block] [Qemu-devel] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call

;xsave_buf, 0, sizeof(struct kvm_xsave)); >> >> OK >> >>> } >>> >>> max_nested_state_len = kvm_max_nested_state_length(); >>> @@ -3477,6 +3479,7 @@ static int kvm_put_debugregs(X86CPU *cpu) >>> return 0; >>> } >>> >>> +memset(, 0, sizeof(dbgregs)); >> >> OK >> >>> for (i = 0; i < 4; i++) { >>> dbgregs.db[i] = env->dr[i]; >>> } >> >> We could remove 'dbgregs.flags = 0;' >> >> Reviewed-by: Philippe Mathieu-Daudé >> -- Cheers, Christophe de Dinechin (IRC c3d)

Re: [Qemu-block] [Qemu-devel] [PATCH for-4.1] scsi-cd: Fix inserting read-only media in empty drive

If not, why not make it a "else"? > + > + if (!blkconf_apply_backend_options(>conf, read_only, > dev->type == TYPE_DISK, errp)) { > return; > } -- Cheers, Christophe de Dinechin (IRC c3d)