Hello,
pretty much the $Subject.
We had reports of very bad performance with the default options when running:
$ time qemu-img convert -c -p -O qcow2 file.qcow2 file.disk
real7m13.220s
user6m56.682s
sys 0m13.038s
I studied this and noticed that for every coroutine a thread was
Hi all,
we currently have to maintain something downstream for this, since the current
behavior can compound problems on top of existing bad NFS latency,
could someone continue to help reviewing this work?
Thanks,
Claudio
On 6/9/23 22:19, Fabiano Rosas wrote:
> Hi,
>
> The major change from
On 8/8/23 19:08, Stefan Hajnoczi wrote:
> On Mon, Jul 31, 2023 at 05:33:38PM -0300, Fabiano Rosas wrote:
>> We can fail the blk_insert_bs() at init_blk_migration(), leaving the
>> BlkMigDevState without a dirty_bitmap and BlockDriverState. Account
>> for the possibly missing elements when doing
added Kevin and Hanna for block, since this seems still untouched?
Thanks,
Claudio
On 7/31/23 22:33, Fabiano Rosas wrote:
> We can fail the blk_insert_bs() at init_blk_migration(), leaving the
> BlkMigDevState without a dirty_bitmap and BlockDriverState. Account
> for the possibly missing
On 5/24/23 11:24, Lin Ma wrote:
> The query-named-block-nodes is only availabe for qmp, not support hmp yet.
>
> Lin
Ok, makes sense.
T0x0200
> #define QEMU_AIO_ZONE_APPEND 0x0400
> +#define QEMU_AIO_FSTAT0x0800
> #define QEMU_AIO_TYPE_MASK \
> (QEMU_AIO_READ | \
> QEMU_AIO_WRITE | \
> @@ -42,7 +43,8 @@
> QEMU_AIO_TRUNCATE | \
> QEMU_AIO_ZONE_REPORT | \
> QEMU_AIO_ZONE_MGMT | \
> - QEMU_AIO_ZONE_APPEND)
> + QEMU_AIO_ZONE_APPEND | \
> + QEMU_AIO_FSTAT)
>
> /* AIO flags */
> #define QEMU_AIO_MISALIGNED 0x1000
Reviewed-by: Claudio Fontana
On 5/23/23 23:39, Fabiano Rosas wrote:
> From: Lin Ma
>
> Sometimes the query-block performs time-consuming I/O(say waiting for
> the fstat of NFS complete), So let's make this QMP handler runs in a
> coroutine.
>
> The following patch moves the fstat() into a thread pool.
>
> Signed-off-by:
On 5/23/23 23:39, Fabiano Rosas wrote:
> From: Lin Ma
>
> Sometimes the query-block performs time-consuming I/O(say waiting for
> the fstat of NFS complete), So let's make this QMP handler runs in a
> coroutine.
>
> The following patch moves the fstat() into a thread pool.
Hi, this message
Error **errp);
> void bdrv_query_image_info(BlockDriverState *bs,
> ImageInfo **p_info,
> bool flat,
Reviewed-by: Claudio Fontana
On 11/10/22 14:51, Claudio Fontana wrote:
> On 11/10/22 14:50, Kevin Wolf wrote:
>> Am 07.11.2022 um 14:36 hat Claudio Fontana geschrieben:
>>> Hello Kevin and all,
>>>
>>> I seem to be getting intermittent failures with mainline iotest 108. Is
>>
On 11/10/22 14:50, Kevin Wolf wrote:
> Am 07.11.2022 um 14:36 hat Claudio Fontana geschrieben:
>> Hello Kevin and all,
>>
>> I seem to be getting intermittent failures with mainline iotest 108. Is this
>> already known?
>>
>> ../configure --enable-tcg --ena
Hello Kevin and all,
I seem to be getting intermittent failures with mainline iotest 108. Is this
already known?
../configure --enable-tcg --enable-kvm --enable-modules --enable-debug
make -j
make -j check
▶ 614/634 qcow2 108
On 5/9/22 2:31 PM, Philippe Mathieu-Daudé wrote:
> On 3/5/22 11:40, Claudio Fontana wrote:
>> On 3/7/22 12:17 AM, Philippe Mathieu-Daudé wrote:
>>> From: Philippe Mathieu-Daudé
>>>
>>> Few patches to be able to build QEMU on macOS 12 (Monterey).
>>&g
On 3/7/22 12:17 AM, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé
>
> Few patches to be able to build QEMU on macOS 12 (Monterey).
>
> Missing review:
> 0006-hvf-Fix-OOB-write-in-RDTSCP-instruction-decode.patch
> 0013-osdep-Avoid-using-Clang-specific-__builtin_available.patch
>
On 6/10/21 11:54 AM, Gerd Hoffmann wrote:
> On Thu, Jun 10, 2021 at 10:32:39AM +0200, Claudio Fontana wrote:
>> On 6/10/21 7:57 AM, Gerd Hoffmann wrote:
>>> This patch series adds support for module metadata. Here are the pieces
>>> of the puzzle:
>>>
>>
On 6/10/21 4:03 PM, Gerd Hoffmann wrote:
> Hi,
>
>> Is the JSON file completely static, listing all modules that were built
>> regardless of whether they are currently installed, or would it need to
>> be refreshed when installing/uninstalling RPMs with modules ? I would
>> think we can do the
On 6/10/21 2:35 PM, Daniel P. Berrangé wrote:
> On Thu, Jun 10, 2021 at 07:57:54AM +0200, Gerd Hoffmann wrote:
>> Add module_allow_arch() to set the target architecture.
>> In case a module is limited to some arch verify arches
>> match and ignore the module if not.
>>
>> Signed-off-by: Gerd
On 6/10/21 7:57 AM, Gerd Hoffmann wrote:
> This patch series adds support for module metadata. Here are the pieces
> of the puzzle:
>
> (1) Macros are added to store metadata in a .modinfo elf section
> (idea stolen from the linux kernel).
> (2) A utility to scan modules, collect
On 3/18/21 11:03 AM, Paolo Bonzini wrote:
> On 18/03/21 10:16, Claudio Fontana wrote:
>> my experience with the new build system (meson-based), is that I have to do:
>>
>> make
>>
>> first, and then
>>
>> make check
>>
>> later, or bugs
On 3/16/21 2:28 PM, Markus Armbruster wrote:
> Watch this:
>
> $ mkdir bld-tools
> $ cd bld-tools
> $ ../configure --disable-system --disable-user --enable-tools
> $ make check
> [...]
> make: *** No rule to make target 'tests/qemu-iotests/socket_scm_helper',
> needed by
Hi all, where are we with this series?
I am trying to figure out how to apply the whole thing,
in order to build only compatible ARM boards and devices for KVM-only builds.
Ie, I would like to combine this with:
"arm cleanup experiment for kvm-only build"
Hi,
I am trying to take these patches,
in the hope that they help with some of the test issues I am having with the
kvm-only build,
but they fail with:
target/arm/Kconfig: does not exist in index
so I guess I need the "target/arm/Kconfig" series right, how can I find that
one?
Thanks,
Hi Peter,
what do you think of the following patch? We messaged yesterday about
cortex-a15 being the default cpu for virt,
this patch would need also changing the default CPU for virt under KVM I would
think.
Or, we could change the virt default cpu to "max"?
Thanks,
Claudio
On 2/5/21
On 2/5/21 3:43 PM, Philippe Mathieu-Daudé wrote:
> Yet again bugfixes and cleanup patches noticed while
> rebasing my "Support disabling TCG on ARM (part 2)" series.
>
> Sending them independently as they aren't directly dependent
> of it so don't have to be delayed by other unanswered
On 2/5/21 4:30 PM, Philippe Mathieu-Daudé wrote:
> On 2/5/21 4:20 PM, Claudio Fontana wrote:
>> On 2/5/21 3:43 PM, Philippe Mathieu-Daudé wrote:
>>> Some tests explicitly request the TCG accelerator. As these
>>> tests will obviously fails if TCG is not present, di
On 2/5/21 3:43 PM, Philippe Mathieu-Daudé wrote:
> Some tests explicitly request the TCG accelerator. As these
> tests will obviously fails if TCG is not present, disable
> them in such case.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Cc: Roman Bolshakov
> Cc: C
Just in case it helps,
I started getting this error only when I rebased to latest master a couple days
ago, after regular rebasing and testing with full make check every 1 or 2 days.
Ciao,
Claudio
On 2/5/21 12:10 PM, Vladimir Sementsov-Ogievskiy wrote:
> I reproduced the following crash fast
On 2/4/21 11:38 PM, Vladimir Sementsov-Ogievskiy wrote:
> 04.02.2021 20:51, Peter Maydell wrote:
>> On Thu, 4 Feb 2021 at 17:48, Philippe Mathieu-Daudé
>> wrote:
>>>
>>> Hi,
>>>
>>> Based on commit 1ed9228f63e (ericb/tags/pull-nbd-2021-02-02-v2)
>>> I got:
>>>
>>>TEST iotest-qcow2: 030
On 1/31/21 4:23 PM, Philippe Mathieu-Daudé wrote:
> On 1/31/21 3:18 PM, Claudio Fontana wrote:
>> On 1/31/21 12:50 PM, Philippe Mathieu-Daudé wrote:
>>> Modules are registered early with type_register_static().
>>>
>>> We would like to call tcg_enabled() whe
On 1/31/21 12:50 PM, Philippe Mathieu-Daudé wrote:
> Cover from Samuel Ortiz from (part 1) [1]:
>
> This patchset allows for building and running ARM targets with TCG
> disabled. [...]
>
> The rationale behind this work comes from the NEMU project where
> we're trying to only support x86
select ARMSSE
> select LAN9118
> select MPS2_FPGAIO
> @@ -496,6 +502,7 @@ config NRF51_SOC
>
> config EMCRAFT_SF2
> bool
> +default y if TCG && ARM
> select MSF2
> select SSI_M25P80
>
> diff --git a/target/arm/Kconfig b/target/arm/Kconfig
> index 4dc96c46520..07a2fad7a2b 100644
> --- a/target/arm/Kconfig
> +++ b/target/arm/Kconfig
> @@ -24,4 +24,5 @@ config ARM_V7R
>
> config ARM_V7M
> bool
> +depends on TCG && ARM
> select PTIMER
>
Acked-by: Claudio Fontana
t DDC
> select DPCD
> diff --git a/target/arm/Kconfig b/target/arm/Kconfig
> index fbb7bba9018..4dc96c46520 100644
> --- a/target/arm/Kconfig
> +++ b/target/arm/Kconfig
> @@ -18,6 +18,10 @@ config ARM_V6
> bool
> depends on TCG && ARM
>
> +config ARM_V7R
> +bool
> +depends on TCG && ARM
> +
> config ARM_V7M
> bool
> select PTIMER
>
Acked-by: Claudio Fontana
482,13 @@ config FSL_IMX6UL
>
> config MICROBIT
> bool
> +default y if TCG && ARM
> select NRF51_SOC
>
> config NRF51_SOC
> bool
> select I2C
> +select ARM_V6
> select ARM_V7M
> select UNIMP
>
>
elect WM8750
> select PL011 # UART
> @@ -245,6 +257,7 @@ config STRONGARM
>
> config COLLIE
> bool
> +default y if TCG && ARM
> select PFLASH_CFI01
> select ZAURUS # scoop
> select STRONGARM
> @@ -257,6 +270,8 @@ config SX1
>
> config VERSATILE
> bool
> +default y if TCG && ARM
> +select ARM_V5
> select ARM_TIMER # sp804
> select PFLASH_CFI01
> select LSI_SCSI_PCI
> @@ -376,6 +391,8 @@ config NPCM7XX
>
> config FSL_IMX25
> bool
> +default y if TCG && ARM
> +select ARM_V5
> select IMX
> select IMX_FEC
> select IMX_I2C
> @@ -402,6 +419,8 @@ config FSL_IMX6
>
> config ASPEED_SOC
> bool
> +default y if TCG && ARM
> +select ARM_V5
> select DS1338
> select FTGMAC100
> select I2C
> diff --git a/target/arm/Kconfig b/target/arm/Kconfig
> index 811e1e81652..9b3635617dc 100644
> --- a/target/arm/Kconfig
> +++ b/target/arm/Kconfig
> @@ -10,6 +10,10 @@ config ARM_V4
> bool
> depends on TCG && ARM
>
> +config ARM_V5
> +bool
> +depends on TCG && ARM
> +
> config ARM_V7M
> bool
> select PTIMER
>
Looks good to me
Acked-by: Claudio Fontana
b/target/arm/Kconfig
> @@ -6,6 +6,10 @@ config AARCH64
> bool
> select ARM
>
> +config ARM_V4
> +bool
> +depends on TCG && ARM
> +
> config ARM_V7M
> bool
> select PTIMER
>
Looks good to me
Acked-by: Claudio Fontana
"
> +#ifdef CONFIG_TCG
> #include "tcg-runtime.h"
> #include "plugin-helpers.h"
> +#endif /* CONFIG_TCG */
>
> #undef IN_HELPER_PROTO
>
>
Ok, this would go away when applying the refactoring to ARM though right?
Ie the file should not need including at all later on right?
Anyway:
Reviewed-by: Claudio Fontana
On 1/31/21 12:50 PM, Philippe Mathieu-Daudé wrote:
> Modules are registered early with type_register_static().
>
> We would like to call tcg_enabled() when registering QOM types,
Hi Philippe,
could this not be controlled by meson at this stage?
On X86, I register the tcg-specific types in
On 9/3/20 7:21 PM, Kevin Wolf wrote:
> Am 03.09.2020 um 14:54 hat Max Reitz geschrieben:
>> On 02.09.20 13:03, Kevin Wolf wrote:
>>> It is convenient to be able to edit the tests and run them without
>>> changing the current working directory back and forth. Instead of
>>> assuming that $PWD is
ree name from check symlink"
> fi
> source_iotests=$(cd "$source_iotests"; pwd) || _init_error "failed to
> enter source tree"
> -build_iotests=$PWD
> +build_iotests=$(dirname "$0")
> else
> # called from the source tree
> source_iotests=$PWD
>
Like it, thanks!
Reviewed-by: Claudio Fontana
Tested-by: Claudio Fontana
On 7/28/20 2:08 PM, Max Reitz wrote:
> Since these functions take a @qiov_offset, they must always take it into
> account when working with @qiov. There are a couple of places where
> they do not, but they should.
>
> Fixes: 65cd4424b9df03bb5195351c3
Tested-by: Claudio Fontana
On 7/28/20 2:08 PM, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/028 | 19 +++
> tests/qemu-iotests/028.out | 11 +++
> 2 files changed, 30 insertions(+)
>
> diff --git a/tests/qemu-iot
41 matches
Mail list logo
