t_features in ->get_features() although the
> features argument already contains host_features. Make all devices
> consistent by dropping the unnecessary code.
>
> Cc: Cornelia Huck
> Signed-off-by: Stefan Hajnoczi
> ---
> hw/block/virtio-blk.c | 3 ---
> hw/char/virti
On Mon, Nov 21 2022, Stefan Hajnoczi wrote:
> Suggested-by: Cornelia Huck
> Signed-off-by: Stefan Hajnoczi
> ---
> include/hw/virtio/virtio.h | 7 +++
> 1 file changed, 7 insertions(+)
Reviewed-by: Cornelia Huck
On Wed, Aug 03 2022, Stefan Hajnoczi wrote:
> Suggested-by: Cornelia Huck
> Signed-off-by: Stefan Hajnoczi
> ---
> include/hw/virtio/virtio.h | 20
> 1 file changed, 20 insertions(+)
>
> diff --git a/include/hw/virtio/virtio.h b/include/hw/vi
t_features in ->get_features() although the
> features argument already contains host_features. Make all devices
> consistent by dropping the unnecessary code.
>
> Cc: Cornelia Huck
> Signed-off-by: Stefan Hajnoczi
> ---
> hw/block/virtio-blk.c | 3 ---
> hw/char/virti
t_features in ->get_features() although the
> features argument already contains host_features. Make all devices
> consistent by dropping the unnecessary code.
I wonder whether we should add that explicitly to the contract for
get_features()?
>
> Cc: Cornelia Huck
> Signed-off-by: S
; Cc: Vikram Garhwal
> Cc: Jason Wang
> Cc: Keith Busch
> Cc: Klaus Jensen
> Cc: "Michael S. Tsirkin"
> Cc: Richard Henderson
> Cc: David Hildenbrand
> Cc: Cornelia Huck
> Cc: Halil Pasic
> Cc: Christian Borntraeger
> Cc: Gerd Hoffmann
> Cc: Vi
---
> Cc: "Marc-André Lureau"
> Cc: Paolo Bonzini
> Cc: Patrick Venture
> Cc: Thomas Huth
> Cc: "Michael S. Tsirkin"
> Cc: Igor Mammedov
> Cc: Alexander Bulekov
> Cc: Bandan Das
> Cc: Stefan Hajnoczi
> Cc: Keith Busch
> Cc: Klaus Jense
h]')
>
> Signed-off-by: Eduardo Habkost
> ---
> Cc: "Marc-André Lureau"
> Cc: Paolo Bonzini
> Cc: Patrick Venture
> Cc: Thomas Huth
> Cc: Keith Busch
> Cc: Klaus Jensen
> Cc: "Michael S. Tsirkin"
> Cc: Cornelia Huck
> Cc: Halil Pasic
>
t;
> Cc: Igor Mammedov
> Cc: Alexander Bulekov
> Cc: Bandan Das
> Cc: Stefan Hajnoczi
> Cc: Huacai Chen
> Cc: Jiaxun Yang
> Cc: Aurelien Jarno
> Cc: Aleksandar Rikalo
> Cc: Havard Skinnemoen
> Cc: Tyrone Ting
> Cc: Pavel Pisa
> Cc: Vikram Garhwal
>
ckend doesn't have multiqueue support.
>
> Fixes: c90bd505a3e8210c23d69fecab9ee6f56ec4a161
> Signed-off-by: Kevin Wolf
> ---
> hw/virtio/vhost-user.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Cornelia Huck
mgfmt: str, imgproto: str, aiomode:
> str,
> ('arm', 'virt'),
> ('aarch64', 'virt'),
> ('avr', 'mega2560'),
> +('m68k', 'virt'),
> ('rx', 'gdbsim-r5f562n8'),
> ('tricore', 'tricore_testboard')
> )
Reviewed-by: Cornelia Huck
use the correct
> virtio interface according to the machine type.
>
> This patch removes all virtio-*-pci and virtio-*-ccw to use virtio-*
> instead. This also enables virtio-mmio devices (virtio-*-device)
>
> Signed-off-by: Laurent Vivier
> cc: Cornelia Huck
> --
MMIO (-device) interfaces.
>
> Signed-off-by: Laurent Vivier
> ---
> include/sysemu/arch_init.h | 1 +
> softmmu/qdev-monitor.c | 12
> 2 files changed, 13 insertions(+)
Reviewed-by: Cornelia Huck
define QEMU_ARCH_VIRTIO_CCW (QEMU_ARCH_S390X)
> +
> #endif
Reviewed-by: Cornelia Huck
On Fri, 19 Mar 2021 14:25:34 +0100
Laurent Vivier wrote:
> Rather than checking if the machine is an s390x to use virtio-blk-ccw
> instead of virtio-blk-pci, use the alias virtio-blk that is set to
> the expected target.
One side effect: if we add a new architecture and don't define the
aliases
On Fri, 19 Mar 2021 15:27:24 +0100
Laurent Vivier wrote:
> Le 19/03/2021 à 15:23, Cornelia Huck a écrit :
> > On Fri, 19 Mar 2021 14:51:59 +0100
> > Laurent Vivier wrote:
> >
> >> Le 19/03/2021 à 14:36, Philippe Mathieu-Daudé a écrit :
> >>>
On Fri, 19 Mar 2021 14:51:59 +0100
Laurent Vivier wrote:
> Le 19/03/2021 à 14:36, Philippe Mathieu-Daudé a écrit :
> > On 3/19/21 2:25 PM, Laurent Vivier wrote:
> >> And ioeventfd are only available with virtio-scsi-pci or virtio-scsi-ccw,
> >> use the alias but add a rule to require
aliases to use the correct
> virtio interface according to the machine type.
Maybe add a comment that this also enables virtio-mmio?
>
> This patch removes all virtio-*-pci and virtio-*-ccw to use virtio-*
> instead.
>
> Signed-off-by: Laurent Vivier
> cc
On Thu, 18 Mar 2021 23:39:04 +0100
Laurent Vivier wrote:
> Similarly to 5f629d943cb0 ("s390x: fix s390 virtio aliases"),
> define the virtio aliases.
>
> This allows to start machines with virtio devices without
> knowledge of the implementation type.
>
> For instance, we can use "-device
On Fri, 19 Mar 2021 12:06:43 +0100
Paolo Bonzini wrote:
> On 18/03/21 23:39, Laurent Vivier wrote:
> > And ioeventfd are only available with virtio-scsi-pci, so don't use the
> > alias
> > and add a rule to require virtio-scsi-pci for the tests that use iothreads.
> >
> > Signed-off-by:
ct_field_prop_ptr() instead of object_static_prop_ptr()
> ---
> Cc: Stefan Berger
> Cc: Stefano Stabellini
> Cc: Anthony Perard
> Cc: Paul Durrant
> Cc: Kevin Wolf
> Cc: Max Reitz
> Cc: Paolo Bonzini
> Cc: "Daniel P. Berrangé"
> Cc: Eduardo Habkost
> ---
> Cc: Stefan Berger
> Cc: Stefano Stabellini
> Cc: Anthony Perard
> Cc: Paul Durrant
> Cc: Kevin Wolf
> Cc: Max Reitz
> Cc: Paolo Bonzini
> Cc: "Daniel P. Berrangé"
> Cc: Eduardo Habkost
> Cc: Cornelia Huck
> Cc: Halil Pasic
>
| 2 +-
> 6 files changed, 5 insertions(+), 5 deletions(-)
> rename include/sysemu/{arch_init.h => arch_type.h} (100%)
Reviewed-by: Cornelia Huck
took the liberty of keeping the Reviewed-by line from
> Marc-André as the build fix is a trivial one line change
> ---
> Cc: Stefan Berger
> Cc: Stefano Stabellini
> Cc: Anthony Perard
> Cc: Paul Durrant
> Cc: Kevin Wolf
> Cc: Max Reitz
> Cc: Paolo Bonzini
> Cc: "D
Berger
> Cc: Stefano Stabellini
> Cc: Anthony Perard
> Cc: Paul Durrant
> Cc: Kevin Wolf
> Cc: Max Reitz
> Cc: Paolo Bonzini
> Cc: "Daniel P. Berrangé"
> Cc: Eduardo Habkost
> Cc: Cornelia Huck
> Cc: Thomas Huth
> Cc: Halil Pasic
> Cc: Chri
; ---
> Cc: Stefan Berger
> Cc: Stefano Stabellini
> Cc: Anthony Perard
> Cc: Paul Durrant
> Cc: Kevin Wolf
> Cc: Max Reitz
> Cc: Paolo Bonzini
> Cc: "Daniel P. Berrangé"
> Cc: Eduardo Habkost
> Cc: Richard Henderson
> Cc: David Hildenbrand
&g
On Thu, 5 Nov 2020 13:43:51 +0100
Philippe Mathieu-Daudé wrote:
> Per [1] (Terminology):
>
> Legacy interfaces are not required; ie. don’t implement them
> unless you have a need for backwards compatibility!
>
> [2] (Version 1.0):
>
> The device configuration space uses the
; UPPERCASE);
>
> Signed-off-by: Eduardo Habkost
Acked-by: Cornelia Huck
On Fri, 21 Aug 2020 17:01:49 -0400
Eduardo Habkost wrote:
> On Fri, Aug 21, 2020 at 11:43:35AM +0200, Cornelia Huck wrote:
> > On Thu, 20 Aug 2020 17:55:29 -0400
> > Eduardo Habkost wrote:
> >
> > > While trying to convert TypeInfo declarations to the new
>
On Thu, 20 Aug 2020 17:55:29 -0400
Eduardo Habkost wrote:
> While trying to convert TypeInfo declarations to the new
> OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases
> where instance_size or class_size is not set, despite having type
> checker macros that use a specific type.
>
On Wed, 19 Aug 2020 14:54:25 +0200
Igor Mammedov wrote:
> On Tue, 18 Aug 2020 17:11:32 +0200
> Cornelia Huck wrote:
>
> > On Tue, 18 Aug 2020 15:33:43 +0100
> > Stefan Hajnoczi wrote:
> >
> > > arm, i386, ppc, and s390x have versioned machine type
On Tue, 18 Aug 2020 15:33:43 +0100
Stefan Hajnoczi wrote:
> arm, i386, ppc, and s390x have versioned machine types and associated
> compatibility options. Introduce new ones now that QEMU 5.1 has been
> released.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> include/hw/boards.h| 3 +++
>
On Thu, 6 Aug 2020 13:58:47 +0200
Thomas Huth wrote:
> On 06/08/2020 13.23, Cornelia Huck wrote:
> > On Thu, 6 Aug 2020 12:53:49 +0200
> > Thomas Huth wrote:
> >
> >> Let's add two new tests:
> >>
> >> 1) Booting with "bootindex" is
, 2 insertions(+), 4 deletions(-)
Reviewed-by: Cornelia Huck
ios/s390-ccw/virtio-scsi.c | 28
> pc-bios/s390-ccw/virtio-scsi.h | 2 +-
> 5 files changed, 37 insertions(+), 16 deletions(-)
Reviewed-by: Cornelia Huck
Huth
> ---
> pc-bios/s390-ccw/main.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Cornelia Huck
On Thu, 6 Aug 2020 12:53:49 +0200
Thomas Huth wrote:
> Let's add two new tests:
>
> 1) Booting with "bootindex" is the architected default behavior on the
> s390x target, so we should have at least one test that is using the
> "bootindex" property.
>
> 2) The s390-ccw bios used to fail when
0; i < 0x1; i++) {
> -blk_schid.sch_no = i;
> -r = stsch_err(blk_schid, );
> -if ((r == 3) || (r == -EIO)) {
> +r = is_dev_possibly_bootable(dev_no, i);
Maybe explicitly check for -ENODEV here? But no strong opinion.
> +if (r < 0) {
> break;
> }
(...)
Reviewed-by: Cornelia Huck
On Wed, 5 Aug 2020 11:08:02 +0100
Daniel P. Berrangé wrote:
> On Wed, Aug 05, 2020 at 11:11:55AM +0200, Cornelia Huck wrote:
> > On Wed, 5 Aug 2020 10:05:40 +0100
> > Daniel P. Berrangé wrote:
> >
> > > On Wed, Aug 05, 2020 at 10:49:35AM +0200, Paolo Bonzini w
On Wed, 5 Aug 2020 10:05:40 +0100
Daniel P. Berrangé wrote:
> On Wed, Aug 05, 2020 at 10:49:35AM +0200, Paolo Bonzini wrote:
> > On 05/08/20 10:39, Dr. David Alan Gilbert wrote:
> > >> Do you really use "git blame" that much? "git log -S" does more or less
> > >> the same function (in a
On Wed, 5 Aug 2020 10:25:30 +0200
Paolo Bonzini wrote:
> On 05/08/20 09:36, Markus Armbruster wrote:
> > There's also the longer term pain of having to work around git-blame
> > unable to see beyond the flag day.
>
> Do you really use "git blame" that much? "git log -S" does more or less
>
On Wed, 8 Jul 2020 14:05:26 +0100
Stefan Hajnoczi wrote:
> On Tue, Jul 07, 2020 at 05:44:53PM +0200, Cornelia Huck wrote:
> > On Mon, 6 Jul 2020 14:56:48 +0100
> > Stefan Hajnoczi wrote:
> > > diff --git a/hw/virtio/virtio-scsi-pci.c b/hw/virtio/virtio-scsi-pci.
pci.h | 9 +
> hw/virtio/virtio-pci.c | 32
> 2 files changed, 41 insertions(+)
I guess this should honour all relevant limits now.
Reviewed-by: Cornelia Huck
the
device suddenly ends up with more queues than vectors. But I don't see
a reason why you would want to specify nvectors but not num_queues in a
real word scenario, so I think we can ignore that corner case.
Reviewed-by: Cornelia Huck
On Mon, 6 Jul 2020 14:25:20 +0100
Stefan Hajnoczi wrote:
> On Thu, May 28, 2020 at 05:35:55PM +0200, Cornelia Huck wrote:
> > On Wed, 27 May 2020 11:29:21 +0100
> > Stefan Hajnoczi wrote:
> >
> > > Multi-queue devices achieve the best performance when each vC
way @zpci. Fix it anyway.
>
> Cc: Matthew Rosato
> Cc: Cornelia Huck
> Signed-off-by: Markus Armbruster
> ---
> hw/s390x/s390-pci-bus.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Cornelia Huck
On Wed, 27 May 2020 11:29:21 +0100
Stefan Hajnoczi wrote:
> Multi-queue devices achieve the best performance when each vCPU has a
> dedicated queue. This ensures that virtqueue used notifications are
> handled on the same vCPU that submitted virtqueue buffers. When another
> vCPU handles the
vevm.c | 1 +
> stubs/ram-block.c| 2 +-
> target/ppc/kvm.c | 1 -
> target/s390x/kvm.c | 1 -
> util/vfio-helpers.c | 2 +-
> 20 files changed, 145 insertions(+), 139 deletions(-)
Acked-by: Cornelia Huck
clude/exec/ram_addr.h| 3 ---
> include/qemu-common.h | 10 ++
> hw/ppc/spapr_caps.c| 2 +-
> hw/s390x/s390-virtio-ccw.c | 1 +
> hw/vfio/spapr.c| 2 +-
> 5 files changed, 13 insertions(+), 5 deletions(-)
Acked-by: Cornelia Huck
icroblaze/petalogix_ml605_mmu.c | 8
> hw/s390x/sclp.c | 2 +-
> monitor/misc.c | 3 +--
> qom/object.c| 4 ++--
> 7 files changed, 11 insertions(+), 12 deletions(-)
>
s390x part:
Acked-by: Cornelia Huck
| 4 ++--
> target/i386/cpu.c | 23 ++-
> target/s390x/cpu.c | 3 ++-
> tests/check-qom-proplist.c | 7 ---
> tests/test-qdev-global-props.c | 4 ++--
> 65 files changed, 155 insertions(+), 126 deletions(-)
>
s390 parts:
Acked-by: Cornelia Huck
On Fri, 20 Mar 2020 10:30:39 +
Stefan Hajnoczi wrote:
> Automatically size the number of virtio-scsi-pci, vhost-scsi-pci, and
> vhost-user-scsi-pci request virtqueues to match the number of vCPUs.
> Other transports continue to default to 1 request virtqueue.
>
> A 1:1 virtqueue:vCPU
46,7 @@ int s390_store_status(S390CPU *cpu, hwaddr addr, bool
> store_arch)
> hwaddr len = sizeof(*sa);
> int i;
>
> -sa = cpu_physical_memory_map(addr, , 1);
> +sa = cpu_physical_memory_map(addr, , true);
> if (!sa) {
> return -EFAULT;
> }
> @@ -298,7 +298,7 @@ int s390_store_adtl_status(S390CPU *cpu, hwaddr addr,
> hwaddr len)
> hwaddr save = len;
> int i;
>
> -sa = cpu_physical_memory_map(addr, , 1);
> +sa = cpu_physical_memory_map(addr, , true);
> if (!sa) {
> return -EFAULT;
> }
s390 parts
Acked-by: Cornelia Huck
rap them.
> */
> if (unlikely(address_space_read(cs->as, gaddr, MEMTXATTRS_UNSPECIFIED,
> -(uint8_t *)entry, sizeof(*entry)) !=
> +entry, sizeof(*entry)) !=
> MEMTX_OK)) {
> return false;
> }
s390 parts
Acked-by: Cornelia Huck
n 27, 2020 at 02:10:31PM +0100, Cornelia Huck wrote:
> > > >> On Fri, 24 Jan 2020 10:01:57 +
> > > >> Stefan Hajnoczi wrote:
> > > >>> @@ -47,10 +48,15 @@ static void vhost_scsi_pci_realize(VirtIOPCIProxy
> > > >>>
On Thu, 30 Jan 2020 10:52:35 +
Stefan Hajnoczi wrote:
> On Thu, Jan 30, 2020 at 01:29:16AM +0100, Paolo Bonzini wrote:
> > On 29/01/20 16:44, Stefan Hajnoczi wrote:
> > > On Mon, Jan 27, 2020 at 02:10:31PM +0100, Cornelia Huck wrote:
> > >> On F
On Wed, 29 Jan 2020 17:06:59 +0300
Denis Plotnikov wrote:
> Signed-off-by: Denis Plotnikov
> ---
> hw/block/virtio-blk.c | 6 --
> hw/scsi/virtio-scsi.c | 5 +++--
> include/hw/virtio/virtio.h | 1 +
> 3 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git
rtio/vhost-user-blk.h | 2 ++
> 4 files changed, 14 insertions(+), 1 deletion(-)
Reviewed-by: Cornelia Huck
io/virtio-blk.h | 2 ++
> 4 files changed, 16 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck
On Fri, 24 Jan 2020 10:01:57 +
Stefan Hajnoczi wrote:
> Automatically size the number of request virtqueues to match the number
"If the pci transport is used, ..." ?
> of vCPUs. This ensures that completion interrupts are handled on the
> same vCPU that submitted the request. No IPI is
gt; ---
> hw/scsi/vhost-user-scsi.c | 2 +-
> hw/scsi/virtio-scsi.c | 7 ---
> include/hw/virtio/virtio-scsi.h | 3 +++
> 3 files changed, 8 insertions(+), 4 deletions(-)
Reviewed-by: Cornelia Huck
On Thu, 16 Jan 2020 14:16:54 +
Stefan Hajnoczi wrote:
> On Thu, Jan 16, 2020 at 12:53:49PM +0100, Cornelia Huck wrote:
> > On Thu, 16 Jan 2020 10:58:40 +
> > Stefan Hajnoczi wrote:
> >
> > > Automatically size the number of request virtqueues to m
On Thu, 16 Jan 2020 10:58:40 +
Stefan Hajnoczi wrote:
> Automatically size the number of request virtqueues to match the number
> of vCPUs. This ensures that completion interrupts are handled on the
> same vCPU that submitted the request. No IPI is necessary to complete
> an I/O request
read(void *opaque, const uint8_t
> *buf, int size)
> }
> }
>
> -static void chr_event(void *opaque, int event)
> +static void chr_event(void *opaque, QEMUChrEvent event)
> {
> Terminal3270 *t = opaque;
> CcwDevice *ccw_dev = CCW_DEVICE(t);
Acked-by: Cornelia Huck
On Thu, 5 Dec 2019 18:19:58 +0300
Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> This is the first part of the bit series, which contains mostly simple
> cleanups.
What's the plan? Should subsystem maintainers pick up individual
patches, or will they be merged in one go?
On Fri, 8 Nov 2019 22:57:25 +0400
Marc-André Lureau wrote:
> Hi
>
> On Fri, Nov 8, 2019 at 7:31 PM Vladimir Sementsov-Ogievskiy
> wrote:
> >
> > Finally, what is the plan?
> >
> > Markus what do you think?
> >
> > Now a lot of patches are reviewed, but a lot of are not.
> >
> > Is there any
On Fri, 11 Oct 2019 19:04:12 +0300
Vladimir Sementsov-Ogievskiy wrote:
> Add script to automatically commit tree-wide changes per-subsystem.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
I think this still needs some notes as to the supposed usage.
On Mon, 7 Oct 2019 16:10:02 +
Vladimir Sementsov-Ogievskiy wrote:
> 07.10.2019 18:55, Cornelia Huck wrote:
> > On Tue, 1 Oct 2019 18:52:54 +0300
> > Vladimir Sementsov-Ogievskiy wrote:
> >> +def git_add(pattern):
> >> +subprocess.run(['git', 'add',
On Tue, 1 Oct 2019 18:52:54 +0300
Vladimir Sementsov-Ogievskiy wrote:
> Add script to automatically commit tree-wide changes per-subsystem.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
>
> CC: kw...@redhat.com
> CC: mre...@redhat.com
> CC: js...@redhat.com
> CC: f...@euphon.net
>
On Wed, 18 Sep 2019 12:46:42 -0500
Eric Blake wrote:
> On 9/18/19 5:26 AM, Cornelia Huck wrote:
> > On Tue, 17 Sep 2019 18:36:20 +0200
> > Greg Kurz wrote:
> >
> >> On Tue, 17 Sep 2019 13:24:12 +0200
> >> Cornelia Huck wrote:
> >>
> >
On Tue, 17 Sep 2019 18:36:20 +0200
Greg Kurz wrote:
> On Tue, 17 Sep 2019 13:24:12 +0200
> Cornelia Huck wrote:
>
> > On Tue, 17 Sep 2019 12:21:34 +0200
> > Greg Kurz wrote:
> >
> > > Ensure that hints are added even if errp is _fatal or _abort.
&
On Tue, 17 Sep 2019 12:22:18 +0200
Greg Kurz wrote:
> Passing errp from the argument list to error_append_hint()
> isn't recommended because it may cause unwanted behaviours
> when errp is equal to _fatal or _abort.
>
> First, error_append_hint() aborts QEMU when passed either of
> those.
>
>
tions(+), 8 deletions(-)
Reviewed-by: Cornelia Huck
On Tue, 17 Sep 2019 12:21:34 +0200
Greg Kurz wrote:
> Ensure that hints are added even if errp is _fatal or _abort.
>
> Signed-off-by: Greg Kurz
> ---
> hw/s390x/s390-ccw.c |6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck
Can
, but better safe than sorry.
Reviewed-by: Cornelia Huck
with
"Now that size_memop has been implemented properly, again hard code the
size but with..."
> MO_{8|16|32|64}. This is more expressive and avoid size_memop calls.
s/avoid/avoids/
>
> Signed-off-by: Tony Nguyen
> ---
> hw/s390x/s390-pci-inst.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Cornelia Huck
erson
> ---
> hw/vfio/pci-quirks.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck
on
> ---
> hw/virtio/virtio-pci.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck
Henderson
> ---
> hw/s390x/s390-pci-inst.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Cornelia Huck
; tcg/tcg-op.h| 86 ++---
> tcg/tcg.c | 2 +-
> tcg/tcg.h | 101 ++--
> trace/mem-internal.h| 4 +-
> trace/mem.h | 4 +-
> 39 files changed, 421 insertions(+), 399 deletions(-)
> create mode 100644 include/exec/memop.h
Acked-by: Cornelia Huck
-
> 11 files changed, 17 insertions(+), 17 deletions(-)
Reviewed-by: Cornelia Huck
On Mon, 29 Jul 2019 16:56:47 +0200
Damien Hedde wrote:
> Replace S390PCIBusDevice legacy reset by device_reset_warm.
>
> The new function propagates also the reset to the sub-buses tree.
> I'm not sure whether S390PCIBusDevice has bus children or not.
This should be fine, I think.
>
>
On Mon, 29 Jul 2019 16:56:35 +0200
Damien Hedde wrote:
> Replace deprecated qdev_reset_all by device_reset_warm.
>
> This does not impact the behavior.
Not so sure about that; see below.
>
> Signed-off-by: Damien Hedde
> ---
> hw/s390x/s390-virtio-ccw.c | 2 +-
> 1 file changed, 1
On Wed, 7 Aug 2019 16:24:30 +0100
Peter Maydell wrote:
> On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote:
> >
> > Replace deprecated qbus_reset_all by resettable_reset_cold_fn for
> > the ipl registration in the main reset handlers.
> >
> > This does not impact the behavior.
> >
> >
On Tue, 30 Jul 2019 16:08:59 +0200
Damien Hedde wrote:
> On 7/30/19 3:59 PM, Peter Maydell wrote:
> > On Tue, 30 Jul 2019 at 14:56, Cornelia Huck wrote:
> >>
> >> On Tue, 30 Jul 2019 14:44:21 +0100
> >> Peter Maydell wrote:
> >>
> >&g
On Tue, 30 Jul 2019 14:44:21 +0100
Peter Maydell wrote:
> On Tue, 30 Jul 2019 at 14:42, Cornelia Huck wrote:
> >
> > On Mon, 29 Jul 2019 16:56:22 +0200
> > Damien Hedde wrote:
> >
> > (...)
> >
> > > +/*
> > > + * Re
On Mon, 29 Jul 2019 16:56:22 +0200
Damien Hedde wrote:
(...)
> +/*
> + * ResettableClass:
> + * Interface for resettable objects.
> + *
> + * The reset operation is divided in several phases each represented by a
> + * method.
> + *
> + * Each Ressetable must maintain a reset counter in its
On Mon, 29 Jul 2019 16:56:21 +0200
Damien Hedde wrote:
(...)
> 2. old's device_reset
>
> There was a few call to this function, I renamed it *device_legacy_reset* to
> handle the transition. This function allowed to reset only a given device
> (and not its eventual qbus subtree). This
On Mon, 19 Nov 2018 20:07:58 +0800
Mao Zhongyi wrote:
> The SysBusDeviceClass::init() interface is considered
> as a legacy interface and there are currently some
> efforts going on to get rid of it. Thus convert
> SysBusDeviceClass::init to DeviceClass::realize.
In case my comment to the s390
On Thu, 12 Jul 2018 17:47:00 +0200
Thomas Huth wrote:
> On 12.07.2018 08:32, Markus Armbruster wrote:
> > Daniel P. Berrangé writes:
> [...]
> >> For libvirt, I think whenever something is proposed for deprecation
> >> we could just CC libvir-list, or ask one of the libvirt people to
> >>
On Thu, 12 Jul 2018 08:51:16 +0200
Markus Armbruster wrote:
> Markus Armbruster writes:
>
> > Kevin Wolf writes:
> >
> >> Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben:
> >>> On Tue, 10 Jul 2018 07:59:15 +0200
> >>> Markus Armbrust
On Wed, 11 Jul 2018 08:53:20 +0200
Thomas Huth wrote:
> On 10.07.2018 17:24, Peter Krempa wrote:
> > On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote:
> >> So, from that I gather that a hard failure would be the easiest for
> >> libvirt to detect (and e
On Tue, 10 Jul 2018 16:39:31 +0200
Peter Krempa wrote:
> On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote:
> > On Tue, 10 Jul 2018 07:59:15 +0200
> > Markus Armbruster wrote:
> >
> > > In addition to actively pulling libvirt developers into review of
On Tue, 10 Jul 2018 07:59:15 +0200
Markus Armbruster wrote:
> In addition to actively pulling libvirt developers into review of
> deprecation patches, we should pursue the idea to optionally let QEMU
> fail on use of deprecated features, then have libvirt run its test suite
> that way.
What
Hi,
I recently noticed that iotest 147 was hanging on my laptop, but worked
fine on my s390x LPAR. Turned out that the architecture was a red
herring; on both platforms, things fail with the 'simple' trace backend
and work with e.g. the 'log' trace backend. Some details on the
failures with the
On Mon, 9 Jul 2018 08:58:05 +0200
Thomas Huth wrote:
> On 06.07.2018 13:11, Cornelia Huck wrote:
> > On Wed, 4 Jul 2018 17:14:02 +0100
> > Peter Maydell wrote:
> >
> >> On 4 July 2018 at 14:34, Kevin Wolf wrote:
> >>> Essentially, what is i
On Mon, 09 Jul 2018 08:33:05 +0200
Markus Armbruster wrote:
> Peter Maydell writes:
>
> > On 6 July 2018 at 15:56, Kevin Wolf wrote:
> >> Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben:
> >>> That way, we can still easily remove old cruft (case
This reverts commit a7aff6dd10b16b67e8b142d0c94c5d92c3fe88f6.
Hold off removing this for one more QEMU release (current libvirt
release still uses it.)
Signed-off-by: Cornelia Huck
---
blockdev.c| 75 ++-
hmp-commands.hx
This reverts commit b0083267444a5e0f28391f6c2831a539f878d424.
Hold off removing this for one more QEMU release (current libvirt
release still uses it.)
Signed-off-by: Cornelia Huck
---
block/block-backend.c | 1 +
blockdev.c| 10 ++
hw/block/block.c | 13
This reverts commit eae3bd1eb7c6b105d30ec06008b3bc3dfc5f45bb.
Reverted to avoid conflicts for geometry options revert.
Signed-off-by: Cornelia Huck
---
blockdev.c| 17 -
device-hotplug.c | 4
include/sysemu/blockdev.h | 1 +
qemu-doc.texi
1 - 100 of 184 matches
Mail list logo
