sult in a different result to:
(x ? a: b) & FLAG_TEST.
The macros should wrap each of the parameters in brackets to ensure the
correct result on expansion.
Signed-off-by: Darren Kenny
---
include/block/nvme.h | 44 ++--
1 file changed, 22 insertion
For the series:
Reviewed-by: Darren Kenny
Thanks,
Darren.
On Friday, 2021-11-19 at 21:11:39 +01, Philippe Mathieu-Daudé wrote:
> Fix issue #521 reported by Alex some months ago:
> https://gitlab.com/qemu-project/qemu/-/issues/521
>
> Philippe Mathieu-Daudé (2):
> hw/scsi
On Thursday, 2021-11-18 at 15:34:01 +01, Philippe Mathieu-Daudé wrote:
> Replace Qemu -> QEMU.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Darren Kenny
> ---
> docs/devel/modules.rst| 2 +-
> docs/devel/multi-thread-tcg.rst | 2 +-
&g
On Thursday, 2021-11-18 at 15:43:17 +01, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Darren Kenny
> ---
> docs/about/removed-features.rst| 8
> docs/devel/build-system.rst| 6 +++---
> docs/devel/mu
Hi Philippe,
Apart from a nit on patch 1, all looks good, so:
Reviewed-by: Darren Kenny
Thanks,
Darren.
On Thursday, 2021-11-18 at 00:24:20 +01, Philippe Mathieu-Daudé wrote:
> I'm not sure what happened to v1 from Prasad, so since we are
> at rc2 I took a simpler approach to fix th
Hi Philippe,
A small nit below, but otherwise looks good.
On Thursday, 2021-11-18 at 00:24:21 +01, Philippe Mathieu-Daudé wrote:
> Guest might select another drive on the bus by setting the
> DRIVE_SEL bit of the DIGITAL OUTPUT REGISTER (DOR).
> The current controller model doesn't expect a
only for hard disk devices")
> BugLink: https://bugs.launchpad.net/qemu/+bug/1887309
> Signed-off-by: Philippe Mathieu-Daudé
The changes LGTM, presume the 'shrug' is OK to leave in ;)
Reviewed-by: Darren Kenny
Thanks,
Darren.
> ---
> Since v1:
> - Allow zero-sized drive ima
k the number of bytes prepared for the transfer
by the prepare_buf() handler. If it is not a multiple of 512 then end
the DMA transfer with an error.
That also fixes the I/O stall in guests after a DMA transfer request
for less than the size of a sector.
Signed-off-by: Alexander Popov
Rev
Should have said that this is subject to the typo that Eric pointed
out, of course.
Thanks,
Darren.
On Wed, Nov 15, 2017 at 11:04:19AM +, Darren Kenny wrote:
FWIW,
Reviewed-by: Darren Kenny <darren.ke...@oracle.com>
Thanks,
Darren.
On Tue, Nov 14, 2017 at 07:41:27PM +0100, Max
FWIW,
Reviewed-by: Darren Kenny <darren.ke...@oracle.com>
Thanks,
Darren.
On Tue, Nov 14, 2017 at 07:41:27PM +0100, Max Reitz wrote:
@mem_size and @offset are both size_t, thus subtracting them from one
another will just return a big size_t if mem_size < offset -- even more
obv
On Wed, Nov 08, 2017 at 08:26:57AM -0600, Eric Blake wrote:
On 11/08/2017 04:47 AM, Darren Kenny wrote:
Hi Jeff,
While I'm relatively new to this community, I do have some comments
about the styling in this file.
I don't see anything in the CODING_STYLE file that tells me I'm
wrong here
On Tue, Nov 07, 2017 at 05:27:21PM -0500, Jeff Cody wrote:
No functional changes, just whitespace manipulation.
Signed-off-by: Jeff Cody <jc...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Darren Kenny <darren.ke...@oracle.com>
---
bloc
, for clarity
- Change the name for clarity
- Make it a bool
Signed-off-by: Jeff Cody <jc...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Darren Kenny <darren.ke...@oracle.com>
---
block/curl.c | 18 --
1 file changed, 12 insertions(+), 6
On Tue, Nov 07, 2017 at 05:27:19PM -0500, Jeff Cody wrote:
Signed-off-by: Jeff Cody <jc...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Darren Kenny <darren.ke...@oracle.com>
---
block/ssh.c | 32 ++--
1 file changed, 18
edhat.com>
Reviewed-by: Darren Kenny <darren.ke...@oracle.com>
---
block/sheepdog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 696a714..459d93a 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -1632,7 +1632,7 @@
Hi Jeff,
While I'm relatively new to this community, I do have some comments
about the styling in this file.
I don't see anything in the CODING_STYLE file that tells me I'm
wrong here, but it's certainly possible...
More inline.
On Tue, Nov 07, 2017 at 05:27:24PM -0500, Jeff Cody wrote:
This
Hi Kevin,
Thanks for getting back to me so quickly.
Kevin Wolf wrote:
Am 13.09.2017 um 14:00 hat Darren Kenny geschrieben:
[Cross-posted from qemu-devel, meant to send here first]
Just keep both lists in the CC for the same email.
Will do.
There is an issue here, which is that you
[Cross-posted from qemu-devel, meant to send here first]
Hi,
It was observed during some testing of Qemu 2.9 that it appeared that if you
resized a qcow2 block device while the VM is running, that an qemu-img check
would report that there were leaked clusters.
The steps to reproduce are:
18 matches
Mail list logo
