Re: [Qemu-block] [PATCH v3 1/1] block/vmdk: Fix the endian problem of buf_len and lba

2017-02-13 Thread Hao QingFeng
在 2017-01-26 0:25, Max Reitz 写道: On 16.12.2016 06:20, QingFeng Hao wrote: The problem was triggered by qemu-iotests case 055. It failed when it was comparing the compressed vmdk image with original test.img. The cause is that buf_len in vmdk_write_extent wasn't converted to little-endian

Re: [Qemu-block] [PATCH v1 1/1] iotests: Fix a problem in common.filter

2016-12-18 Thread Hao QingFeng
在 2016-12-16 22:34, Eric Blake 写道: [adding qemu-devel, ALL patches should include the main list] On 12/15/2016 11:47 PM, QingFeng Hao wrote: If TEST_DIR is set to /tmp, test case 144 will fail. The reason is that TEST_DIR duplicates with 144's test image name tmp.qcow2. s/duplicates

Re: [Qemu-block] [PATCH v1 0/1] iotests: Fix a problem in common.filter

2016-12-18 Thread Hao QingFeng
Test case 144 will fail if I set TEST_DIR=/tmp. The cause is that TEST_DIR duplicates with 144's test image name tmp.qcow2 and common.filter will over replace the path name. Thanks! QingFeng Hao QingFeng Hao (1): iotests: Fix a problem in common.filter tests/qemu-iotests/common.filter | 2

Re: [Qemu-block] [PATCH v2 1/1] block/vmdk: Fix the endian problem of buf_len and lba

2016-11-28 Thread Hao QingFeng
在 2016-11-28 15:56, liujing 写道: Hi QingFeng, I just have a question that whether the marker->data need convert? I've no idea, just suddenly realized this question. nope, the data is type of char * for the compressed data stream, so no endian issue. thanks. Jing On 11/26/2016 01:46 PM,

Re: [Qemu-block] [Qemu-stable] [PATCH v2 1/1] block/vmdk: Fix the endian problem of buf_len and lba

2016-11-27 Thread Hao QingFeng
在 2016-11-26 19:46, Fam Zheng 写道: On Sat, 11/26 06:46, QingFeng Hao wrote: The problem was triggered by qemu-iotests case 055. It failed when it was comparing the compressed vmdk image with original test.img. The cause is that buf_len in vmdk_write_extent wasn't converted to little-endian

Re: [Qemu-block] [PATCH v2 0/1] qemu: fix the bug reported by qemu-iotests case 055

2016-11-25 Thread Hao QingFeng
Sorry, missed Cc qemu-stable in this patch. 在 2016-11-26 13:46, QingFeng Hao 写道: Hi all, v2 includes changes due to review comments by Kevin Wolf(thanks to Kevin). v2: * Add endian conversion for lba field in vmdk_write_extent. Based on master's commit: 00227fefd205: Update version for

Re: [Qemu-block] [PATCH for-2.8 v1 1/1] block/vmdk: Fix the endian problem of buf_len

2016-11-25 Thread Hao QingFeng
在 2016-11-25 18:21, Kevin Wolf 写道: [ Cc: Fam, qemu-stable ] Am 25.11.2016 um 11:06 hat QingFeng Hao geschrieben: The problem was triggered by qemu-iotests case 055. It failed when it was comparing the compressed vmdk image with original test.img. The cause is that buf_len in

Re: [Qemu-block] [PATCH 2/3] block: Emit modules in bdrv_iterate_format()

2016-11-02 Thread Hao QingFeng
在 2016-11-02 19:15, Kevin Wolf 写道: Am 02.11.2016 um 11:52 hat Hao QingFeng geschrieben: Sorry for a bit late response. The function looks fine but just some doubt on g_renew in this piece of code(and the legacy), does g_renew(realloc) has much performance impact if it's call many times since

Re: [Qemu-block] [PATCH v4 0/3] iotests: Fix test 162

2016-10-24 Thread Hao QingFeng
在 2016-10-16 1:27, Max Reitz 写道: On 13.10.2016 07:20, Hao QingFeng wrote: 在 2016-10-13 3:46, Max Reitz 写道: On 12.10.2016 10:55, Hao QingFeng wrote: Max, Just a common question for this case, if sshx block driver wasn't built into qemu-img, this case would fail as below: Good point

Re: [Qemu-block] [PATCH v4 0/3] iotests: Fix test 162

2016-10-12 Thread Hao QingFeng
在 2016-10-13 3:46, Max Reitz 写道: On 12.10.2016 10:55, Hao QingFeng wrote: Max, Just a common question for this case, if sshx block driver wasn't built into qemu-img, this case would fail as below: Good point, and thanks for bringing it up, but it's not directly linked to this series other

Re: [Qemu-block] [PATCH v4 0/3] iotests: Fix test 162

2016-10-12 Thread Hao QingFeng
{ while read driver + do + if [ "$driver"x = "sshx" ]; then + echo 1 + exit + fi + done + echo 0 + } +) + +#echo "ret:$found" +if [ "