Ping.
Le 12/08/2023 à 10:59, Hervé Poussineau a écrit :
I don't understand when SEEK must be set or not, but it seems to fix Minix...
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1522
Signed-off-by: Hervé Poussineau
---
hw/block/fdc.c | 1 -
1 file changed, 1 deletion(-)
diff
I don't understand when SEEK must be set or not, but it seems to fix Minix...
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1522
Signed-off-by: Hervé Poussineau
---
hw/block/fdc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index d7cc4d3ec19
'reserved1' field in bootsector is used to mark volume dirty, or need to verify.
Allow writes to bootsector which only changes the 'reserved1' field.
This fixes I/O errors on Windows guests.
Resolves: https://bugs.launchpad.net/qemu/+bug/1889421
Signed-off-by: Hervé Poussineau
---
block
In R/W mode, files with spaces were never created on host side.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1176
Fixes: c79e243ed67683d6d06692bd7040f7394da178b0
Signed-off-by: Hervé Poussineau
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Kevin Wolf
---
block/vvfat.c | 2 +-
1
allows creating file names with spaces.
Hervé
Changes since v1:
- updated patch 1 with remarks (modify in-memory copy, add comment about
FAT32)
Hervé Poussineau (2):
vvfat: allow some writes to bootsector
vvfat: allow spaces in file names
block/vvfat.c | 28 ++--
1
Le 29/09/2022 à 16:10, Kevin Wolf a écrit :
Am 03.09.2022 um 18:23 hat Hervé Poussineau geschrieben:
'reserved1' field in bootsector is used to mark volume dirty, or need to verify.
Allow writes to bootsector which only changes the 'reserved1' field.
This fixes I/O errors on Windows guests
In R/W mode, files with spaces were never created on host side.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1176
Fixes: c79e243ed67683d6d06692bd7040f7394da178b0
Signed-off-by: Hervé Poussineau
---
block/vvfat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
allows creating file names with spaces.
Hervé
Hervé Poussineau (2):
vvfat: allow some writes to bootsector
vvfat: allow spaces in file names
block/vvfat.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
--
2.36.2
'reserved1' field in bootsector is used to mark volume dirty, or need to verify.
Allow writes to bootsector which only changes the 'reserved1' field.
This fixes I/O errors on Windows guests.
Resolves: https://bugs.launchpad.net/qemu/+bug/1889421
Signed-off-by: Hervé Poussineau
---
block
Le 18/05/2021 à 09:14, Philippe Mathieu-Daudé a écrit :
Cc'ing Hervé, Aleksandar, Markus & Mark.
On 5/17/21 11:11 PM, John Snow wrote:
On 5/17/21 4:50 PM, Philippe Mathieu-Daudé wrote:
On 5/17/21 9:19 PM, John Snow wrote:
On 5/17/21 2:39 PM, Philippe Mathieu-Daudé wrote:
The floppy disc
Le 12/03/2021 à 07:45, John Snow a écrit :
On 1/8/21 6:01 PM, Alexander Bulekov wrote:
fdctrl_format_sector was added in
baca51faff ("updated floppy driver: formatting code, disk geometry auto detect
(Jocelyn Mayer)")
The single callsite is guarded by a check:
fdctrl->data_state &
as described
for transfer operations, except that no memory or I/O read/write control signals
will be generated.
Hervé proposed to remove all the dma_mode_ok stuff from fdc to have a more
clear boundary between DMA and FDC, so this patch also does that.
Suggested-by: Hervé Poussineau
Signed-off-by: Sven
as described
for transfer operations, except that no memory or I/O read/write control signals
will be generated.
Hervé proposed to remove all the dma_mode_ok stuff from fdc to have a more
clear boundary between DMA and FDC, so this patch also does that.
Suggested-by: Hervé Poussineau
Signed-off-by: Sven
Le 29/10/2019 à 12:00, John Snow a écrit :
>
>
> On 10/20/19 2:38 AM, Sven Schnelle wrote:
>> While working on the Tulip driver i tried to write some Teledisk images to
>> a floppy image which didn't work. Turned out that Teledisk checks the written
>> data by issuing a READ command to the FDC
erface reference and release method is only invoked if fdctrl->dma_chann
has been set.
(This issue was discovered by Martin testing a recent change in the NetBSD
installer under qemu-system-sparc)
Reported-by: Martin Husemann
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Hervé Poussineau
changed, 77 insertions(+)
Reviewed-by: Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit :
From: Laurent Vivier
This is needed by Quadra 800, this card can run on little-endian
or big-endian bus.
Signed-off-by: Laurent Vivier
Tested-by: Hervé Poussineau
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Hervé Poussineau
SWIM_H
+#define SWIM_H
+
+#include "qemu/osdep.h"
+#include "hw/sysbus.h"
+
+#define MAX_FD 2
Maybe rename MAX_FD to SWIM_MAX_FD, to prevent conflicts with MAX_FD in other
files?
Excepted that:
Reviewed-by: Hervé Poussineau
--
include/hw/char/escc.h | 1 +
2 files changed, 25 insertions(+), 6 deletions(-)
Reviewed-by: Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit :
From: Laurent Vivier
Co-developed-by: Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland
Signed-off-by: Laurent Vivier
---
hw/Makefile.objs| 1 +
hw/nubus/Makefile.objs | 4 +
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit :
From: Laurent Vivier
This is broken as the linux driver seems broken too...
Co-developed-by: Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland
Signed-off-by: Laurent Vivier
---
hw/audio/Makefile.objs | 1 +
hw/audio/asc.c | 446
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit :
From: Laurent Vivier
Co-developed-by: Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland
Signed-off-by: Laurent Vivier
---
hw/scsi/esp.c | 292 +-
include/hw/scsi/esp.h | 7 ++
2
++
include/hw/misc/mac_via.h | 107
3 files changed, 774 insertions(+)
create mode 100644 hw/misc/mac_via.c
create mode 100644 include/hw/misc/mac_via.h
Reviewed-by: Hervé Poussineau
Reviewed-by: Hervé Poussineau
++
2 files changed, 197 insertions(+)
Reviewed-by: Hervé Poussineau
Le 08/07/2018 à 23:11, Peter Maydell a écrit :
On 28 June 2018 at 00:29, Laurent Vivier wrote:
This is needed by Quadra 800, this card can run on little-endian
or big-endian bus.
Signed-off-by: Laurent Vivier
Tested-by: Hervé Poussineau
---
hw/net/dp8393x.c | 88
Le 28/06/2018 à 01:29, Laurent Vivier a écrit :
Co-developed-by: Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland
Signed-off-by: Laurent Vivier
---
hw/block/Makefile.objs | 1 +
hw/block/swim.c | 284
include/hw/block/swim.h |
deletions(-)
Works OK on NetBSD 5.1/arc on MIPS Magnum.
Tested-by: Hervé Poussineau
deletions(-)
Works OK on NetBSD 5.1/arc on MIPS Magnum.
Tested-by: Hervé Poussineau
deletions(-)
Works OK on NetBSD 5.1/arc on MIPS Magnum.
Tested-by: Hervé Poussineau
insertions(+), 15 deletions(-)
Works OK on NetBSD 5.1/arc on MIPS Magnum.
Tested-by: Hervé Poussineau
p8393x_reset(DeviceState *dev)
NACK. This breaks NetBSD 5.1/arc networking.
This seems to revert the following commit and change the function return value.
commit 409b52bfe199d8106dadf7c5ff3d88d2228e89b5
Author: Hervé Poussineau
Date: Wed Jun 3 22:45:48 2015 +0200
net/dp8393x: correc
390x, and the third
patch adds a test that certain machines can at least still be started
with the "-cdrom" parameter (i.e. that test would have catched the
mistake that I did with my SCSI cleanup patch).
Reviewed-by: Hervé Poussineau <hpous...@reactos.org>
v2:
- Use g_spawn
We are now able to embed floppy controllers in another object.
Acked-by: Michael S. Tsirkin <m...@redhat.com>
Acked-by: Paolo Bonzini <pbonz...@redhat.com>
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
hw/block/f
Le 04/01/2018 à 14:11, Marcel Apfelbaum a écrit :
On 29/12/2017 16:29, Hervé Poussineau wrote:
We are now able to embed floppy controllers in another object.
Hi Hervé,
Are you sure we need to move all the struct definitions to the header file?
I looked at patch 11/16 and it seems only
We are now able to embed floppy controllers in another object.
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
hw/block/fdc.c | 102
include/hw/block/fdc.h | 103 +
2 files c
We are now able to embed floppy controllers in another object.
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
hw/block/fdc.c | 102
include/hw/block/fdc.h | 103 +
2 files c
We are now able to embed floppy controllers in another object.
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
hw/block/fdc.c | 101
include/hw/block/fdc.h | 103 +
2 files c
Le 17/07/2017 à 17:12, Max Reitz a écrit :
gcc 7 complains that the sprintf() might write a null byte beyond the
end of the tail buffer. That is wrong, but we can silence it by making
i unsigned (it can never be negative anyway, see the if condition right
before). For some reason, this allows
Le 16/07/2017 à 00:24, Philippe Mathieu-Daudé a écrit :
Hi Hervé,
On 07/15/2017 10:28 AM, Hervé Poussineau wrote:
This prevents some host to guest memory content leaks.
Fixes: https://bugs.launchpad.net/qemu/+bug/1599539
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
This prevents some host to guest memory content leaks.
Fixes: https://bugs.launchpad.net/qemu/+bug/1599539
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/vvfat.c b/block/vvfat.c
index afc6170a69..7340
Write support works again when image contains non-ASCII names. It is either the
case when user created a non-ASCII filename, or when initial directory contained
a non-ASCII filename (since 0c36111f57ec2188f679e7fa810291b7386bdca1)
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
Also add links to related compatibility problems.
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index c2674d7703..e585a8e0be 100644
--- a/block/vvfat.c
+++ b
problem reported by MS Scandisk.
Hervé
Hervé Poussineau (4):
vvfat: add constants for special values of name[0]
vvfat: add a constant for bootsector name
vvfat: correctly parse non-ASCII short and long file names
vvfat: initialize memory after allocating it
block/vvfat.c | 85
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 4fd28e1e87..c2674d7703 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -71,6 +71,11 @@ void
branch, or should I send the v3 as is?
It fixes the last random errors I had in Win9x Scandisk (uninitialized memory).
Regards,
Hervé
Le 03/07/2017 à 18:50, Kevin Wolf a écrit :
Am 22.05.2017 um 23:11 hat Hervé Poussineau geschrieben:
Hi,
This patchset fixes some of issues I encountered when
Hi Philippe,
Le 24/05/2017 à 06:17, Philippe Mathieu-Daudé a écrit :
Hi Hervé,
On 05/22/2017 06:12 PM, Hervé Poussineau wrote:
More specifically, create short name from filename and change blacklist of
invalid chars to whitelist of valid chars.
Windows 9x also now correctly see long file
Hi Philippe,
Le 23/05/2017 à 06:23, Philippe Mathieu-Daudé a écrit :
Hi Hervé,
On 05/22/2017 06:12 PM, Hervé Poussineau wrote:
According to specification:
"'MSWIN4.1' is the recommanded setting, because it is the setting least likely
to cause compatibility problems. If you want t
This was a complete mess. On 2299 indented lines:
- 1329 were with spaces only
- 617 with tabulations only
- 353 with spaces and tabulations
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 2054 -
1 file c
/1599539/comments/4
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 26 +-
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 414bca6dee..5376659010 100644
--- a/block/vvfat.c
+++ b/block/v
MODE_FAKED and MODE_RENAMED are not and were never used.
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 8b5f53ad26..6a36d4f7fa 100644
--- a
Specification: "FAT: General overview of on-disk format" v1.03, pages 11-13
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
cification: "FAT: General overview of on-disk format" v1.03, page 9
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 53e8faa54c..1f7f46ecea 100644
--- a
CII filenames.
Specification: "FAT: General overview of on-disk format" v1.03, page 31
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 62 ---
1 file changed, 29 insertions(+), 33 deletions(-)
diff --gi
Specification: "FAT: General overview of on-disk format" v1.03, page 23
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 5376659010..5
Assume that input filename is encoded as UTF-8, so correctly create UTF-16
encoding.
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 38 ++
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git a/block/vvfat.c b
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index d3afb731b6..8b5f53ad26 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -404,9 +404,9 @@ static void in
, as it changes indentation only.
Hervé
Changes v1->v2:
- small changes following Kevin remarks (patches 3, 5, 6)
- use g_utf8_* functions instead of ad-hock code (patches 8 and 9)
- fix a bug with filenames starting with a dot (patch 9)
Hervé Poussineau (13):
vvfat: fix qemu-img map and qemu-
25
Fixes: https://bugs.launchpad.net/qemu/+bug/1599539
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index c1034cdd1f..d4664c531b 100644
--- a/block/vvf
first_sectors_number by offset_to_fat.
Replace faked_sectors by offset_to_rootdir.
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 70 ---
1 file changed, 43 insertions(+), 27 deletions(-)
diff --git a/block/vvfat.c b
onvert.
Fixes: 4480e0f924a42e1db8b8cfcac4d0634dd1bb27a0
Fixes: https://bugs.launchpad.net/qemu/+bug/1599539
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
inde
Le 16/05/2017 à 16:39, Kevin Wolf a écrit :
Am 15.05.2017 um 22:31 hat Hervé Poussineau geschrieben:
Specification: "FAT: General overview of on-disk format" v1.03, page 11
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 10 +-
1 file chang
Le 16/05/2017 à 16:16, Kevin Wolf a écrit :
Am 15.05.2017 um 22:31 hat Hervé Poussineau geschrieben:
- offset_to_bootsector is the number of sectors up to FAT bootsector
- offset_to_fat is the number of sectors up to first File Allocation Table
- offset_to_root_dir is the number of sectors up
Le 16/05/2017 à 15:21, Kevin Wolf a écrit :
Am 15.05.2017 um 22:31 hat Hervé Poussineau geschrieben:
@@ -806,7 +806,7 @@ static int read_directory(BDRVVVFATState* s, int
mapping_index)
(ROOT_ENTRIES - cur) * sizeof(direntry_t));
}
- /* reget the mapping, since s
This was a complete mess. On 2299 indented lines:
- 1329 were with spaces only
- 617 with tabulations only
- 353 with spaces and tabulations
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 2054 -
1 file c
Specification: "FAT: General overview of on-disk format" v1.03, page 23
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 7b21d6bb21..f
/7153935/how-to-convert-utf-8-stdstring-to-utf-16-stdwstring
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 132 ++
1 file changed, 97 insertions(+), 35 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
neral overview of on-disk format" v1.03, pages 30/31
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 84 +++
1 file changed, 56 insertions(+), 28 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
CII filenames.
Specification: "FAT: General overview of on-disk format" v1.03, page 31
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 67 +++
1 file changed, 35 insertions(+), 32 deletions(-)
diff --gi
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 002bd86e42..57f2489689 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -404,9 +404,9 @@ static void in
cification: "FAT: General overview of on-disk format" v1.03, page 9
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index f96034cda1..b321065060 100644
--- a
25
Fixes: https://bugs.launchpad.net/qemu/+bug/1599539
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 348cffe1c4..7da07068b8 100644
--- a/block/vvf
Specification: "FAT: General overview of on-disk format" v1.03, page 11
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index f60d2a3889..3
, as it changes indentation only.
Hervé
Hervé Poussineau (13):
vvfat: fix qemu-img map and qemu-img convert
vvfat: replace tabs by 8 spaces
vvfat: fix typos
vvfat: rename useless enumeration values
vvfat: introduce offset_to_bootsector, offset_to_fat and
offset_to_root_dir
vvfat: fix
).
Fixes: https://bugs.launchpad.net/qemu/+bug/1599539/comments/4
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 26 +-
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 98978df404..7b21
first_sectors_number by offset_to_fat.
Replace faked_sectors by offset_to_rootdir.
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 67 +++
1 file changed, 40 insertions(+), 27 deletions(-)
diff --git a/block/vvfat.c b
MODE_FAKED and MODE_RENAMED are not and were never used.
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 57f2489689..4f4a63c03f 100644
--- a
onvert.
Fixes: 4480e0f924a42e1db8b8cfcac4d0634dd1bb27a0
Fixes: https://bugs.launchpad.net/qemu/+bug/1599539
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
block/vvfat.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
inde
Ping?
Le 20/02/2017 à 21:41, Hervé Poussineau a écrit :
In commit af6bf1328ef90fae617857c02697e0174b84d596 (May 2011),
ide-hd, ide-cd and scsi-cd have been added to disable default cdrom,
"or else you can't put one on secondary master without -nodefaults".
Make it the same for scsi-
rom device will disappear instead of being empty.
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
vl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/vl.c b/vl.c
index 27d9829..4af95b3 100644
--- a/vl.c
+++ b/vl.c
@@ -226,6 +226,7 @@ static struct {
{ .driver = "ide-hd&
patches:
Tested-by: Hervé Poussineau <hpous...@reactos.org>
For convenience, this branch is available at:
https://github.com/jnsnow/qemu.git branch ide-fix-read-cd
https://github.com/jnsnow/qemu/tree/ide-fix-r
Le 29/10/2016 à 00:32, John Snow a écrit :
For the purposes of byte_count_limit verification, add a new flag that
identifies read_cd as sometimes returning data, then check the BCL in
its command handler after we know that it will indeed return data.
Reported-by: Hervé Poussineau <hp
Le 18/08/2016 à 16:24, Kevin Wolf a écrit :
Hm, which of the paths in cmd_read_cd() does this hit? Is it the one
that directly calls ide_atapi_cmd_ok() without doing anything?
This is in ide_atapi_cmd, at line:
if (cmd->handler && !(cmd->flags & NONDATA)) {
handler is cmd_read_cd and flags
This fixes Windows NT4 startup when a cdrom is inserted.
Fixes: 9ef2e93f9b1888c7d0deb4a105149138e6ad2e98
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
hw/ide/atapi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
index 6
ut the easiest thing is to
restore the misfeature where empty drives have non-zero geometries
applied.
Document the hack accordingly.
Signed-off-by: John Snow<js...@redhat.com>
---
hw/block/fdc.c | 16
1 file changed, 16 insertions(+)
Tested-by: Hervé Poussineau <hpous...@reactos.org>
All functions relative to DMA (DMA_*() functions) are stubs on sparc platform.
Disable the DMA in the floppy controller, instead of calling these stubs.
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
hw/block/fdc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/block
All functions relative to DMA (DMA_*() functions) are stubs on sparc platform.
Disable the DMA in the floppy controller, instead of calling these stubs.
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
hw/block/fdc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/block
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
hw/block/fdc.c | 63 ++
1 file changed, 46 insertions(+), 17 deletions(-)
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index 4069c46..e3ba751 100644
--- a/hw/block/fdc.c
++
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
hw/block/fdc.c | 63 ++
1 file changed, 46 insertions(+), 17 deletions(-)
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index 14891c1..3c3d046 100644
--- a/hw/block/fdc.c
++
All functions relative to DMA (DMA_*() functions) are stubs on sparc platform.
Disable the DMA in the floppy controller, instead of calling these stubs.
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
hw/block/fdc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/block
Floppy uses the DMA controller in rc4030 chipset, and not the i8259 from the
ISA bus.
It's better to disable DMA than to call the wrong DMA controller.
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
---
hw/block/fdc.c | 5 +++--
hw/mips/mips_jazz.c| 3 ++-
include/hw
91 matches
Mail list logo
