Re: [PATCH 11/12] hw/xen: automatically assign device index to block devices

On Wed, 18 Oct 2023 09:32:47 +0100 David Woodhouse wrote: > On Wed, 2023-10-18 at 09:32 +0200, Igor Mammedov wrote: > > On Mon, 16 Oct 2023 16:19:08 +0100 > > David Woodhouse wrote: > > > > > From: David Woodhouse > > > > > > &g

Re: [PATCH 11/12] hw/xen: automatically assign device index to block devices

On Mon, 16 Oct 2023 16:19:08 +0100 David Woodhouse wrote: > From: David Woodhouse > is this index a user (guest) visible? > There's no need to force the user to assign a vdev. We can automatically > assign one, starting at xvda and searching until we find the first disk > name that's unused.

Re: [PATCH v4 2/2] pcie: Specify 0 for ARI next function numbers

On Tue, 4 Jul 2023 21:22:14 +0900 Akihiko Odaki wrote: > The current implementers of ARI are all SR-IOV devices. The ARI next > function number field is undefined for VF . ^ add a reference to a spec (spec name, rev, chapter) where it's declared so

Re: [PATCH v3 2/2] pcie: Specify 0 for ARI next function numbers

On Sun, 2 Jul 2023 21:02:27 +0900 Akihiko Odaki wrote: > The current implementers of ARI are all SR-IOV devices. The ARI next > function number field is undefined for VF. The PF should end the linked > list formed with the field by specifying 0. this should also describe compat behavior

Re: [PATCH 01/32] hw/mips/malta: Introduce PIIX4_PCI_DEVFN definition

u-Daudé > Message-Id: <20221027204720.33611-2-phi...@linaro.org> Reviewed-by: Igor Mammedov > --- > hw/mips/malta.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/mips/malta.c b/hw/mips/malta.c > index c0a2e0ab04..9bffa1b128 100644

Re: [PATCH v7 12/12] hw/acpi: Make the PCI hot-plug aware of SR-IOV

On Fri, 18 Mar 2022 20:18:19 +0100 Lukasz Maniak wrote: > From: Łukasz Gieryk > > PCI device capable of SR-IOV support is a new, still-experimental > feature with only a single working example of the Nvme device. > > This patch in an attempt to fix a double-free problem when a >

Re: [PATCH v2 3/3] Use g_new() & friends where that makes obvious sense

FILES... > > Signed-off-by: Markus Armbruster > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Cédric Le Goater > Reviewed-by: Alex Bennée > Acked-by: Dr. David Alan Gilbert for */i386/* Reviewed-by: Igor Mammedov nit: possible miss, see below [...] > diff --gi

Re: [PATCH 09/28] hw/acpi: Replace g_memdup() by g_memdup2_qemu()

can likely > be exploited in various modules to cause a heap buffer overflow. > > Replace g_memdup() by the safer g_memdup2_qemu() wrapper. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Igor Mammedov > --- > hw/acpi/core.c | 3 ++- > hw/i386/acpi-bu

Re: [PATCH 08/28] hw/acpi: Avoid truncating acpi_data_len() to 32-bit

; > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Igor Mammedov > --- > hw/arm/virt-acpi-build.c | 2 +- > hw/i386/acpi-build.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c >

Re: [PATCH v4 23/32] qdev: Move dev->realized check to qdev_property_set()

On Mon, 14 Dec 2020 12:24:18 -0500 Eduardo Habkost wrote: > On Mon, Dec 14, 2020 at 03:55:30PM +0100, Igor Mammedov wrote: > > On Fri, 11 Dec 2020 17:05:20 -0500 > > Eduardo Habkost wrote: > > > > > Every single qdev property setter function manually checks >

Re: [PATCH v4 30/32] qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr()

On Fri, 11 Dec 2020 17:05:27 -0500 Eduardo Habkost wrote: > The function will be moved to common QOM code, as it is not > specific to TYPE_DEVICE anymore. > > Reviewed-by: Stefan Berger > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Changes

Re: [PATCH v4 23/32] qdev: Move dev->realized check to qdev_property_set()

On Fri, 11 Dec 2020 17:05:20 -0500 Eduardo Habkost wrote: > Every single qdev property setter function manually checks > dev->realized. We can just check dev->realized inside > qdev_property_set() instead. > > The check is being added as a separate function > (qdev_prop_allow_set()) because it

Re: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros

;UPPERCASE); > > Signed-off-by: Eduardo Habkost for x86/virtio/hostmem/QOM Acked-by: Igor Mammedov > --- > Cc: "Marc-André Lureau" > Cc: Gerd Hoffmann > Cc: "Michael S. Tsirkin" > Cc: "Daniel P. Berrangé" > Cc:

Re: [PATCH v6 2/7] hw: add 5.2 machine types and 5.1 compat options

On Tue, 18 Aug 2020 15:33:43 +0100 Stefan Hajnoczi wrote: > arm, i386, ppc, and s390x have versioned machine types and associated > compatibility options. Introduce new ones now that QEMU 5.1 has been > released. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov &

Re: [PATCH v6 2/7] hw: add 5.2 machine types and 5.1 compat options

On Tue, 18 Aug 2020 17:11:32 +0200 Cornelia Huck wrote: > On Tue, 18 Aug 2020 15:33:43 +0100 > Stefan Hajnoczi wrote: > > > arm, i386, ppc, and s390x have versioned machine types and associated > > compatibility options. Introduce new ones now that QEMU 5.1 has been > > released. > > > >

Re: [PATCH v7 0/9] acpi: i386 tweaks

On Wed, 10 Jun 2020 17:53:46 +0200 Gerd Hoffmann wrote: > On Wed, Jun 10, 2020 at 10:54:26AM -0400, Michael S. Tsirkin wrote: > > On Wed, Jun 10, 2020 at 01:40:02PM +0200, Igor Mammedov wrote: > > > On Wed, 10 Jun 2020 11:41:22 +0200 > > > Gerd Hoffmann wrote: &

Re: [PATCH v7 0/9] acpi: i386 tweaks

On Wed, 10 Jun 2020 11:41:22 +0200 Gerd Hoffmann wrote: > First batch of microvm patches, some generic acpi stuff. > Split the acpi-build.c monster, specifically split the > pc and q35 and pci bits into a separate file which we > can skip building at some point in the future. > It looks like

Re: [PATCH v2 2/8] qapi/misc: Restrict LostTickPolicy enum to machine code

On Mon, 16 Mar 2020 01:03:42 +0100 Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > qapi/machine.json| 32 > qapi/misc.json | 32 &

Re: [PATCH v5 13/15] acpi: drop build_piix4_pm()

On Tue, 12 May 2020 13:16:05 +0200 Gerd Hoffmann wrote: > On Mon, May 11, 2020 at 09:37:32PM +0200, Igor Mammedov wrote: > > On Thu, 7 May 2020 15:16:38 +0200 > > Gerd Hoffmann wrote: > > > > > The _SB.PCI0.PX13.P13C opregion (holds isa device enable bits) >

Re: [PATCH v5 14/15] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.

On Thu, 7 May 2020 15:16:39 +0200 Gerd Hoffmann wrote: > Seems to be unused. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 11 --- > 1 file changed, 11 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i

Re: [PATCH v5 13/15] acpi: drop build_piix4_pm()

On Thu, 7 May 2020 15:16:38 +0200 Gerd Hoffmann wrote: > The _SB.PCI0.PX13.P13C opregion (holds isa device enable bits) > is not used any more, remove it from DSDT. > > Signed-off-by: Gerd Hoffmann > --- > hw/i386/acpi-build.c | 16 > 1 file changed, 16 deletions(-) > >

Re: [PATCH v5 12/15] acpi: drop serial/parallel enable bits from dsdt

On Thu, 7 May 2020 15:16:37 +0200 Gerd Hoffmann wrote: > The _STA methods for COM+LPT used to reference them, > but that isn't the case any more. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 23 --- >

Re: [PATCH v5 03/15] acpi: rtc: use a single crs range

On Thu, 7 May 2020 15:16:28 +0200 Gerd Hoffmann wrote: > Use a single io range for _CRS instead of two, > following what real hardware does. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > hw/rtc/mc146818rtc.c | 8 +--- > 1 file change

Re: [PATCH v4 03/13] acpi: rtc: use a single crs range

On Wed, 6 May 2020 10:39:02 +0200 Gerd Hoffmann wrote: > Hi, > > > > crs = aml_resource_template(); > > > aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE, > > > - 0x10, 0x02)); > > > + 0x10, 0x08)); > > >

Re: [PATCH v4 13/13] floppy: make isa_fdc_get_drive_max_chs static

On Tue, 5 May 2020 13:38:43 +0200 Gerd Hoffmann wrote: > acpi aml generator needs this, but it is in floppy code now > so we can make the function static. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > include/hw/block/fdc.h | 2 -- > hw/bl

Re: [PATCH v4 12/13] acpi: drop serial/parallel enable bits from dsdt

On Tue, 5 May 2020 13:38:42 +0200 Gerd Hoffmann wrote: > The _STA methods for COM+LPT used to reference them, > but that isn't the case any more. > > Signed-off-by: Gerd Hoffmann > --- > hw/i386/acpi-build.c | 23 --- > 1 file changed, 23 deletions(-) > > diff --git

Re: [PATCH v4 11/13] acpi: simplify build_isa_devices_aml()

On Tue, 5 May 2020 13:38:41 +0200 Gerd Hoffmann wrote: > x86 machines can have a single ISA bus only. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 15 +-- > 1 file changed, 5 insertions(+), 10 deletions(-) > &

Re: [PATCH v4 03/13] acpi: rtc: use a single crs range

On Tue, 5 May 2020 13:38:33 +0200 Gerd Hoffmann wrote: > Use a single io range for _CRS instead of two, > following what real hardware does. > > Signed-off-by: Gerd Hoffmann > --- > hw/rtc/mc146818rtc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

Re: [PATCH v4 02/13] acpi: move aml builder code for rtc device

On Tue, 5 May 2020 13:38:32 +0200 Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 17 - > hw/rtc/mc146818rtc.c | 22 ++ > 2 files changed, 22 insertions(+), 17 deletions(-)

Re: [PATCH v3 10/15] acpi: parallel: don't use _STA method

On Mon, 4 May 2020 15:25:16 +0200 Gerd Hoffmann wrote: > On Thu, Apr 30, 2020 at 06:25:24PM +0200, Igor Mammedov wrote: > > On Wed, 29 Apr 2020 15:59:58 +0200 > > Gerd Hoffmann wrote: > > > > > The _STA method dates back to the days where we had a static DSD

Re: [PATCH v3 14/15] acpi: factor out fw_cfg_add_acpi_dsdt()

On Wed, 29 Apr 2020 16:00:02 +0200 Gerd Hoffmann wrote: > Add helper function to add fw_cfg device, > also move code to hw/i386/fw_cfg.c. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > hw/i386/fw_cfg.h |

Re: [PATCH v3 13/15] acpi: move aml builder code for i8042 (kbd+mouse) device

On Wed, 29 Apr 2020 16:00:01 +0200 Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 39 --- > hw/input/pckbd.c | 31 +++ > 2 files changed, 31 in

Re: [PATCH v3 10/15] acpi: parallel: don't use _STA method

s isa device is present or not, then evaluates to 0x0f (present) > or 0x00 (absent). > > These days the DSDT is generated by qemu anyway, so if a device is not > present we can simply drop it from the DSDT instead. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Igor Mammedo

Re: [PATCH v3 12/15] acpi: move aml builder code for floppy device

On Wed, 29 Apr 2020 16:00:00 +0200 Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov see small nit below > --- > hw/block/fdc.c | 83 > hw/i386/acpi-

Re: [PATCH v3 11/15] acpi: move aml builder code for parallel device

On Wed, 29 Apr 2020 15:59:59 +0200 Gerd Hoffmann wrote: > Also adds support for multiple LPT devices. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > hw/char/parallel.c | 32 > hw/i386/acpi-build.c | 23 --

Re: [PATCH v3 07/15] acpi: move aml builder code for rtc device

On Wed, 29 Apr 2020 15:59:55 +0200 Gerd Hoffmann wrote: > Also use a single io range instead of two, > following what real hardware does. I'd make a separate patch for this comment. Also qemu maps only the first range (0x70) if I'm not mistaken, so we perhaps should drop the second (0x72)

Re: [PATCH v3 06/15] rtc: add RTC_ISA_BASE

On Wed, 29 Apr 2020 15:59:54 +0200 Gerd Hoffmann wrote: > Add and use RTC_ISA_BASE define instead of hardcoding 0x70. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > include/hw/rtc/mc146818rtc.h | 1 + > hw/rtc/mc146818rtc.c | 5 ++--- >

Re: [PATCH v2 07/12] acpi: move aml builder code for rtc device

On Tue, 7 Apr 2020 12:26:58 +0200 Gerd Hoffmann wrote: > On Mon, Apr 06, 2020 at 02:17:05PM +0200, Igor Mammedov wrote: > > On Mon, 6 Apr 2020 10:25:17 +0200 > > Gerd Hoffmann wrote: > > > > > On Fri, Apr 03, 2020 at 12:09:21PM +0200, Igor Mammedov wrote: >

Re: hotplug issue of vhost-user-blk

On Wed, 8 Apr 2020 10:25:42 +0800 Li Feng wrote: > Hi all, > > Hotplug of vhost-user-blk doesn't not work in qemu master branch and > all previous version. > > The action I insert a vhost-user-blk disk is: > (qemu) chardev-add socket,id=spdk_vhost_blk2,path=/vhost-blk.0,reconnect=1 > (qemu)

Re: [PATCH v2 07/12] acpi: move aml builder code for rtc device

On Mon, 6 Apr 2020 10:25:17 +0200 Gerd Hoffmann wrote: > On Fri, Apr 03, 2020 at 12:09:21PM +0200, Igor Mammedov wrote: > > On Fri, 3 Apr 2020 10:04:57 +0200 > > Gerd Hoffmann wrote: > > > > > Signed-off-by: Gerd Hoffmann > > > --- > > [...]

Re: [PATCH v2 09/12] acpi: move aml builder code for parallel device

On Mon, 6 Apr 2020 12:26:52 +0200 Gerd Hoffmann wrote: > On Fri, Apr 03, 2020 at 12:16:01PM +0200, Igor Mammedov wrote: > > On Fri, 3 Apr 2020 12:12:10 +0200 > > Igor Mammedov wrote: > > > > > On Fri, 3 Apr 2020 10:04:59 +0200 > > > Gerd Hoffmann wrot

Re: [PATCH v2 06/12] acpi: add ISADeviceClass->build_aml()

On Fri, 3 Apr 2020 10:04:56 +0200 Gerd Hoffmann wrote: > Also add isa_aml_build() function which walks all isa devices. > This allows to move aml builder code to isa devices. > > Signed-off-by: Gerd Hoffmann > --- > include/hw/isa/isa.h | 2 ++ > hw/i386/acpi-build.c | 1 + >

Re: [PATCH v2 09/12] acpi: move aml builder code for parallel device

On Fri, 3 Apr 2020 12:12:10 +0200 Igor Mammedov wrote: > On Fri, 3 Apr 2020 10:04:59 +0200 > Gerd Hoffmann wrote: > [...] > > +static void parallel_isa_build_aml(ISADevice *isadev, Aml *scope) > > +{ > > +ISAParallelState *isa = ISA_PARALLEL(isadev); > >

Re: [PATCH v2 09/12] acpi: move aml builder code for parallel device

On Fri, 3 Apr 2020 10:04:59 +0200 Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/char/parallel.c | 25 + > hw/i386/acpi-build.c | 23 --- > 2 files changed, 25 insertions(+), 23 deletions(-) > > diff --git a/hw/char/parallel.c

Re: [PATCH v2 08/12] acpi: move aml builder code for serial device

On Fri, 3 Apr 2020 10:04:58 +0200 Gerd Hoffmann wrote: > The code uses the isa_serial_io array to figure what the device uid is. > Side effect is that acpi antries are not limited to port 1+2 any more, > we'll also get entries for ports 3+4. > > Signed-off-by: Gerd Hoffmann Re

Re: [PATCH v2 07/12] acpi: move aml builder code for rtc device

On Fri, 3 Apr 2020 10:04:57 +0200 Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- [...] > +static void rtc_build_aml(ISADevice *isadev, Aml *scope) > +{ > +Aml *dev; > +Aml *crs; > + > +crs = aml_resource_template(); > +aml_append(crs, aml_io(AML_DECODE16, 0x0070,

Re: [PATCH v2 06/12] acpi: add ISADeviceClass->build_aml()

On Fri, 3 Apr 2020 10:04:56 +0200 Gerd Hoffmann wrote: > Also add isa_aml_build() function which walks all isa devices. > This allows to move aml builder code to isa devices. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > include/hw/isa/isa.h | 2

Re: [PATCH v2 05/12] acpi: parallel: don't use _STA method

s isa device is present or not, then evaluates to 0x0f (present) > or 0x00 (absent). > > These days the DSDT is generated by qemu anyway, so if a device is not > present we can simply drop it from the DSDT instead. same as 4/12 applies Reviewed-by: Igor Mammedov > > Signed-off-

Re: [PATCH v2 04/12] acpi: serial: don't use _STA method

ommit message into 8/12, but I don't insist since get_system_io() added here is removed by 8/12, so either way Reviewed-by: Igor Mammedov also for patches that modify DSDT, see comment at the start of tests/qtest/bios-tables-test.c to make 'make check' happy and don't break tests during bis

Re: [PATCH v2 03/12] acpi: drop pointless _STA method

On Fri, 3 Apr 2020 10:04:53 +0200 Gerd Hoffmann wrote: > When returning a constant there is no point in having a method > in the first place, _STA can be a simple integer instead. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > hw/i386

Re: [PATCH v2 02/12] acpi: add aml builder stubs

On Fri, 3 Apr 2020 10:04:52 +0200 Gerd Hoffmann wrote: > Needed when moving aml builder code to devices. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build-stub.c | 79 > hw/acpi/Makefile.ob

Re: [PATCH v2 01/12] move 'typedef Aml' to qemu/types.h

On Fri, 3 Apr 2020 10:04:51 +0200 Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > include/hw/acpi/aml-build.h | 1 - > include/qemu/typedefs.h | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/

Re: [PATCH v2 5/8] qapi/misc: Restrict query-vm-generation-id command to machine code

On Tue, 17 Mar 2020 10:44:33 +0100 Philippe Mathieu-Daudé wrote: > On 3/16/20 1:45 PM, Igor Mammedov wrote: > > On Mon, 16 Mar 2020 01:03:45 +0100 > > Philippe Mathieu-Daudé wrote: > > > >> Signed-off-by: Philippe Mathieu-Daudé > > > > Acked

Re: [PATCH v2 5/8] qapi/misc: Restrict query-vm-generation-id command to machine code

On Mon, 16 Mar 2020 01:03:45 +0100 Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Igor Mammedov > --- > qapi/machine.json | 20 > qapi/misc.json| 21 - > hw/acpi/vmgenid.c | 2 +- > stubs/vmgeni

Re: [PATCH v2 8/8] qapi/misc: Restrict device memory commands to machine code

On Mon, 16 Mar 2020 01:03:48 +0100 Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Igor Mammedov > --- > qapi/machine.json | 131 +++ > qapi/misc.json | 132 ---

Re: [PATCH v2 4/8] qapi/misc: Move query-uuid command with block code

On Mon, 16 Mar 2020 01:03:44 +0100 Philippe Mathieu-Daudé wrote: here should be why PS: I don't see a reason to move it to block code at all if this command is moved then it should be machine code > Signed-off-by: Philippe Mathieu-Daudé > --- > qapi/block-core.json | 30

Re: [PATCH v2 6/8] qapi/misc: Restrict ACPI commands to machine code

On Mon, 16 Mar 2020 01:03:46 +0100 Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Igor Mammedov > --- > qapi/machine.json| 154 +++ > qapi/misc.json

Re: [PATCH 0/2] misc: Replace zero-length arrays with flexible array member

d to upstream > coccinelle? > > I used spatch 1.0.8 with: > > -I include --include-headers \ > --macro-file scripts/cocci-macro-file.h \ > --keep-comments --indent 4 > > Regards, > > Phil. > > Based-on: <20200304153311.22959-1-phi...@redhat.com&g

Re: [Qemu-block] [PATCH v2 08/18] tests/bios-tables: Improve portability by searching bash in the $PATH

On Tue, 29 Jan 2019 18:53:53 +0100 Philippe Mathieu-Daudé wrote: > Bash is not always installed as /bin/bash. In particular on OpenBSD, > the package installs it in /usr/local/bin. > Use the 'env' shebang to search bash in the $PATH. > > Signed-off-by: Philippe Mathieu-Daudé Re

Re: [Qemu-block] [Qemu-devel] [PATCH v3 3/5] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays

On Wed, 19 Dec 2018 14:00:37 +0100 Andrew Jones wrote: > On Wed, Dec 19, 2018 at 01:43:40PM +0100, Philippe Mathieu-Daudé wrote: > > Hi Drew, > > > > On 12/19/18 11:10 AM, Andrew Jones wrote: > > > On Tue, Dec 18, 2018 at 06:51:20PM +0100, Philippe Mathieu-Daudé wrote: > > >> GCC 8 added a

Re: [Qemu-block] [Qemu-devel] [PATCH v3 3/5] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays

On Wed, 19 Dec 2018 10:20:36 +0100 Philippe Mathieu-Daudé wrote: > Le mer. 19 déc. 2018 10:16, Igor Mammedov a écrit : > > > On Tue, 18 Dec 2018 18:51:20 +0100 > > Philippe Mathieu-Daudé wrote: > > > > > GCC 8 added a -Wstringop-truncation warning: > &

Re: [Qemu-block] [Qemu-devel] [PATCH v3 3/5] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays

On Tue, 18 Dec 2018 18:51:20 +0100 Philippe Mathieu-Daudé wrote: > GCC 8 added a -Wstringop-truncation warning: > > The -Wstringop-truncation warning added in GCC 8.0 via r254630 for > bug 81117 is specifically intended to highlight likely unintended > uses of the strncpy function that

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/3] hw/acpi: Replace strncpy() by strpadcpy(pad='\0')

around, disable the warning globally using -Wno-stringop-truncation, > but since QEMU provides the strpadcpy() which does the same purpose, > simply use it to avoid the annoying warning. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Eric Blake > Reviewed-by: Philippe Mathieu-D

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] nvme: don't unref ctrl_mem when device unrealized

ect. > > Signed-off-by: Li Qiang nvme device holds a reference to ctrl_mem MemoryRegion as a parent so MemoryRegion will be destroyed later during destruction of nvme object when its cildren are un-parented. Reviewed-by: Igor Mammedov > --- > hw/block/nvme.c | 3 --- >

[Qemu-block] [PATCH for-2.11] ide: ahci: unparent children buses before freeing their memory

nd tries to unparent them, which causes access to freed memory where they where located. Reported-by: Thomas Huth <th...@redhat.com> Signed-off-by: Igor Mammedov <imamm...@redhat.com> --- hw/ide/ahci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10-rc4?] acpi: pcihp: fix use-after-free for machines previous pc-1.7 compat

On Wed, 23 Aug 2017 08:04:06 +0200 Thomas Huth wrote: > On 23.08.2017 07:40, Thomas Huth wrote: > > On 23.08.2017 02:10, Philippe Mathieu-Daudé wrote: > >> On 08/22/2017 07:42 PM, Michael S. Tsirkin wrote: > >>> On Tue, Aug 22, 2017 at 06:43:43PM -0300, Philippe

Re: [Qemu-block] [PATCH for-2.10-rc4?] acpi: pcihp: fix use-after-free for machines previous pc-1.7 compat

On Tue, 22 Aug 2017 18:43:43 -0300 Philippe Mathieu-Daudé wrote: > 9e047b982452 "piix4: add acpi pci hotplug support" introduced a new property > 'use_acpi_pci_hotplug' for pc-1.7 and older machines. > c24d5e0b91d1 "convert ACPI PCI hotplug to use hotplug-handler API" added the

Re: [Qemu-block] [Qemu-devel] [RFC PATCH 12/56] pc-dimm: Make size and address unsigned in QAPI/QMP

On Tue, 22 Aug 2017 15:50:14 +0200 Markus Armbruster <arm...@redhat.com> wrote: > Igor Mammedov <imamm...@redhat.com> writes: > > > On Mon, 7 Aug 2017 16:45:16 +0200 > > Markus Armbruster <arm...@redhat.com> wrote: > > > >> Sizes

Re: [Qemu-block] [Qemu-devel] [RFC PATCH 12/56] pc-dimm: Make size and address unsigned in QAPI/QMP

signed integers with PRIx64 and PRIu32. s/signed/unsigned/ > Signed-off-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Igor Mammedov <imamm...@redhat.com> > --- > qapi-schema.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/q

[Qemu-block] [PATCH for-2.8] qtail: clean up direct access to tqe_prev field

instead of accessing tqe_prev field dircetly outside of queue.h use macros to check if element is in list and make sure that afer element is removed from list tqe_prev field could be used to do the same check. Signed-off-by: Igor Mammedov <imamm...@redhat.com> --- The patch is spli

Re: [Qemu-block] [PATCH v5 0/6] i386: expose floppy-related objects in SSDT

On Thu, 7 Jan 2016 12:56:58 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Thu, Jan 07, 2016 at 12:56:09PM +0200, Michael S. Tsirkin wrote: > > On Wed, Jan 06, 2016 at 03:04:40PM +0100, Igor Mammedov wrote: > > > On Wed, 30 Dec 2015 23:

Re: [Qemu-block] [PATCH v5 0/6] i386: expose floppy-related objects in SSDT

device from DSDT > to SSDT"; I haven't managed to avoid that while trying to meet > maintainer's comments. Tested with XPsp3 WS2008R2 WS2012R2, no regressions so far it boots fine and can read floppy. So for whole series: Reviewed-by: Igor Mammedov <imamm...@redhat.com> > R

Re: [Qemu-block] [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects in SSDT

On Tue, 29 Dec 2015 19:17:46 +0300 Roman Kagan <rka...@virtuozzo.com> wrote: > On Tue, Dec 29, 2015 at 03:09:36PM +0100, Igor Mammedov wrote: > > On Fri, 25 Dec 2015 18:04:08 +0300 > > Roman Kagan <rka...@virtuozzo.com> wrote: > > > > > Windows on

Re: [Qemu-block] [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects in SSDT

make floppy controller object dynamic > expose floppy drive geometry and CMOS type > i386: populate floppy drive information in SSDT > > Signed-off-by: Roman Kagan <rka...@virtuozzo.com> > Cc: "Michael S. Tsirkin" <m...@redhat.com> > Cc: Eduardo Hab

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] dataplane: simplify indirect descriptor read

On Mon, 2 Nov 2015 17:43:16 + Stefan Hajnoczi wrote: > On Wed, Oct 28, 2015 at 05:48:02PM +0200, Michael S. Tsirkin wrote: > > Use address_space_read to make sure we handle the case of an indirect > > descriptor crossing DIMM boundary correctly. > > > > Signed-off-by:

Re: [Qemu-block] [PATCH 2/2] dataplane: support non-contigious s/g

th very small DIMM sizes, unfortunately: > e.g. this will fail with 4K DIMMs where a single > request might span a large number of DIMMs. > > Let's hope these are uncommon - at least we are not breaking things. > > Reported-by: Stefan Hajnoczi <stefa...@redhat.com> > Reported-by: I

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] dataplane: simplify indirect descriptor read

On Wed, 28 Oct 2015 17:48:02 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > Use address_space_read to make sure we handle the case of an indirect > descriptor crossing DIMM boundary correctly. > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com&g