Re: [PATCH v2 0/7] qemu: implementation of transient disk option

[FYI pkrempa is on PTO this week so he won't review this until the next one] On a Friday in 2020, Masayoshi Mizuma wrote: This patchset tries to implement transient option for qcow2 and raw format disk. This uses the snapshot cleanup codes:

Re: [PATCH] block/qcow2-threads: fix qcow2_decompress

bug. Let's fix it. This is to be a new base of zstd series. block/qcow2-threads.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH v2 3/3] qemu-img: Deprecate use of -b without -F

On a Wednesday in 2020, Eric Blake wrote: Creating an image that requires format probing of the backing image is inherently unsafe (we've had several CVEs over the years based on probes leaking information to the guest on a subsequent boot). If our probing algorithm ever changes, or if other

Re: [PATCH v2 2/3] block: Add support to warn on backing file change without format

| 13 ++--- block/qcow2.c | 2 +- block/stream.c| 2 +- blockdev.c| 3 ++- qemu-img.c| 4 ++-- 6 files changed, 18 insertions(+), 10 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH v2 1/3] iotests: Specify explicit backing format where sensible

o('-f', 'raw', '-c', 'write -P 0x1 0 512', backing_img) qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0x1 524288 512', mid_img) self.vm = iotests.VM().add_drive("blkdebug::" + test_img, With test #225 fixed: Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH v2 1/3] iotests: Specify explicit backing format where sensible

On a Thursday in 2020, Peter Krempa wrote: On Wed, Feb 26, 2020 at 20:39:26 -0600, Eric Blake wrote: There are many existing qcow2 images that specify a backing file but no format. This has been the source of CVEs in the past, but has become more prominent of a problem now that libvirt has

Re: [PATCH 5/7] commit: Fix is_read for block_job_error_action()

++- 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 1/7] qapi: Document meaning of 'ignore' BlockdevOnError for jobs

': unknown revision or path not in the working tree. introduced later and use the same model as mirror. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 3/7] commit: Fix argument order for block_job_error_action()

.) Signed-off-by: Kevin Wolf --- block/commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 6/7] commit: Expose on-error option in QMP

, even if a bit later than expected: "This will be part of the QMP command, if/when the BlockdevOnError change for blkmirror makes it in". Signed-off-by: Kevin Wolf --- qapi/block-core.json | 4 blockdev.c | 8 2 files changed, 8 insertions(+), 4 deletions(-) Review

Re: [PATCH 4/7] commit: Inline commit_populate()

in the BLOCK_JOB_ERROR QMP event. Signed-off-by: Kevin Wolf --- block/commit.c | 28 ++-- 1 file changed, 6 insertions(+), 22 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 2/7] commit: Remove unused bytes_written

changed, 2 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 1/3] block/qcow2-bitmap: Remove unneeded variable assignment

Analyzer Signed-off-by: Philippe Mathieu-Daudé --- block/qcow2-bitmap.c | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Ján Tomko Unused since its introduction in 88ddffae8fc1e30cc907c2dbb989b7eba9e62319 Jano signature.asc Description: PGP signature

Re: [PATCH] nbd-client: Support leading / in NBD URI

JSON even without this patch. Signed-off-by: Eric Blake --- block/nbd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH v2 2/2] qemu-nbd: Removed deprecated --partition option

| 49 ++ qemu-nbd.c| 133 +- 3 files changed, 24 insertions(+), 173 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups

On Mon, Jan 27, 2020 at 04:01:31PM -0500, John Snow wrote: On 1/27/20 3:43 PM, Peter Krempa wrote: On Mon, Jan 27, 2020 at 14:39:02 -0500, John Snow wrote: On 1/27/20 5:36 AM, Maxim Levitsky wrote: This patch series is bunch of cleanups to the hmp monitor code. This series only touched