On Wed, Apr 12, 2017 at 09:11:09PM -0400, Jeff Cody wrote:
> On Thu, Apr 13, 2017 at 07:54:20AM +0800, Fam Zheng wrote:
> > On Wed, 04/12 18:22, Jeff Cody wrote:
> > > On Wed, Apr 12, 2017 at 05:38:17PM -0400, John Snow wrote:
> > > >
> > > >
>
On Thu, Apr 13, 2017 at 07:54:20AM +0800, Fam Zheng wrote:
> On Wed, 04/12 18:22, Jeff Cody wrote:
> > On Wed, Apr 12, 2017 at 05:38:17PM -0400, John Snow wrote:
> > >
> > >
> > > On 04/12/2017 04:46 PM, Jeff Cody wrote:
> > > >
>
On Wed, Apr 12, 2017 at 05:38:17PM -0400, John Snow wrote:
>
>
> On 04/12/2017 04:46 PM, Jeff Cody wrote:
> >
> > This occurs on v2.9.0-rc4, but not on v2.8.0.
> >
> > When running QEMU with an iothread, and then performing a block-mirror, if
> > we do a
This occurs on v2.9.0-rc4, but not on v2.8.0.
When running QEMU with an iothread, and then performing a block-mirror, if
we do a system-reset after the BLOCK_JOB_READY event has emitted, qemu
becomes deadlocked.
The block job is not paused, nor cancelled, so we are stuck in the while
loop in blo
Move bdrv_is_read_only() up with its friends.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
---
block.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index 68a18b0..a05ad48 100644
--- a/block.c
+++ b/block.c
This adds support for reopen in rbd, for changing between r/w and r/o.
Note, that this is only a flag change, but we will block a change from
r/o to r/w if we are using an RBD internal snapshot.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Jeff Cody
---
block/rbd.c | 21
image_t value returned by rbd_open().
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Jeff Cody
---
block/rbd.c | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 1c43171..35853c9 100644
--- a/block/rbd.c
+++ b/block/r
Signed-off-by: Jeff Cody
---
block.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index 1514ae9..5d560f5 100644
--- a/block.c
+++ b/block.c
@@ -2785,6 +2785,7 @@ int bdrv_reopen_prepare(BDRVReopenState *reopen_state,
BlockReopenQueue
The BDRV_O_ALLOW_RDWR flag allows / prohibits the changing of
the BDS 'read_only' state, but there are a few places where it
is ignored. In the bdrv_set_read_only() helper, make sure to
honor the flag.
Signed-off-by: Jeff Cody
---
block.c | 7 +++
1 file changed, 7 insertion
Introduce check function for setting read_only flags. Will return < 0 on
error, with appropriate Error value set. Does not alter any flags.
Signed-off-by: Jeff Cody
---
block.c | 14 +-
include/block/block.h | 1 +
2 files changed, 14 insertions(+), 1 delet
arameter would result in a writable image:
"-drive format=vvfat,dir=/tmp/vvfat,rw,if=virtio,readonly=on"
This is not correct. Now, attempting to use the above -drive parameter
will result in an error (i.e., 'rw' is incompatible with 'readonly=on').
Signed-off-by: Jeff
o that it is done consistently
(and rules are applied consistently), and
2.) Adds .bdrv_reopen_prepare() implementation for RBD, so that block
jobs can be run on backing chains that have rbd protocol nodes.
Jeff Cody (8):
block: add bdrv_set_read_only() helper function
block: do
We have a helper wrapper for checking for the BDS read_only flag,
add a helper wrapper to set the read_only flag as well.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Jeff Cody
---
block.c | 5 +
block/bochs.c | 2 +-
block/cloop.c | 2 +-
block/dmg.c
On Wed, Apr 05, 2017 at 08:20:28PM -0400, Jeff Cody wrote:
> On Wed, Apr 05, 2017 at 02:26:53PM -0500, Eric Blake wrote:
> > On 04/05/2017 02:20 PM, John Snow wrote:
> >
> > > Conceptually straightforward.
> > >
> > > looks like this might change behav
On Wed, Apr 05, 2017 at 04:25:39PM -0400, John Snow wrote:
>
>
> On 04/05/2017 02:28 PM, Jeff Cody wrote:
> > Signed-off-by: Jeff Cody
> > ---
> > block.c | 14 --
> > 1 file changed, 8 insertions(+), 6 deletions(-)
> >
> > diff --git a
On Wed, Apr 05, 2017 at 04:28:44PM -0400, John Snow wrote:
>
>
> On 04/05/2017 02:28 PM, Jeff Cody wrote:
> > Introduce try function for setting read_only flags. Will return < 0 on
> > error, with appropriate Error value set. Does not alter any flags.
> >
On Wed, Apr 05, 2017 at 02:26:53PM -0500, Eric Blake wrote:
> On 04/05/2017 02:20 PM, John Snow wrote:
>
> > Conceptually straightforward.
> >
> > looks like this might change behavior for... RBD and vvfat, right?
> > RBD is the subject of this series so we'll just assume that was broken
> > and
On Wed, Apr 05, 2017 at 03:16:38PM -0400, John Snow wrote:
>
>
> On 04/05/2017 02:28 PM, Jeff Cody wrote:
> > A few block drivers will set the BDS read_only flag from their
> > .bdrv_open() function. This means the bs->read_only flag could
> > be set after
Introduce try function for setting read_only flags. Will return < 0 on
error, with appropriate Error value set. Does not alter any flags.
Signed-off-by: Jeff Cody
---
block.c | 14 +-
include/block/block.h | 1 +
2 files changed, 14 insertions(+), 1 delet
We do not want to just blindly set bs->read_only. The only time
we need to set it with the current rbd driver, is if we are using an
rbd snapshot. In that case, we must set it to read-only.
Signed-off-by: Jeff Cody
---
block/rbd.c | 13 +
1 file changed, 9 insertions(+)
Move bdrv_is_read_only() up with its friends.
Signed-off-by: Jeff Cody
---
block.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index 4a61ff0..8bfe7f4 100644
--- a/block.c
+++ b/block.c
@@ -192,6 +192,11 @@ void path_combine(char *dest, int
d_only(), and an error will be
return if we try to set the BDS to read_only while copy_on_read is
enabled.
Signed-off-by: Jeff Cody
---
block.c | 10 +-
block/bochs.c | 5 -
block/cloop.c | 5 -
block/dmg.c | 6 +-
block/rbd.c
The BDRV_O_ALLOW_RDWR flag allows / prohibits the changing of
the BDS 'read_only' state, but there are a few places where it
is ignored. In the bdrv_set_read_only() helper, make sure to
honor the flag.
Signed-off-by: Jeff Cody
---
block.c | 7 +++
1 file changed, 7 insertion
This adds support for reopen in rbd, for changing between r/w and r/o.
Note, that this is only a flag change, but we will block a change from
r/o to r/w if we are using an RBD internal snapshot.
Signed-off-by: Jeff Cody
---
block/rbd.c | 21 +
1 file changed, 21 insertions
Signed-off-by: Jeff Cody
---
block.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index ad958b9..3245fae 100644
--- a/block.c
+++ b/block.c
@@ -2785,6 +2785,7 @@ int bdrv_reopen_prepare(BDRVReopenState *reopen_state,
BlockReopenQueue
age_t value returned by rbd_open().
Signed-off-by: Jeff Cody
---
block/rbd.c | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 328e4a9..c5e1aeb 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -94,7 +94,7 @@
We have a helper wrapper for checking for the BDS read_only flag,
add a helper wrapper to set the read_only flag as well.
Signed-off-by: Jeff Cody
---
block.c | 5 +
block/bochs.c | 2 +-
block/cloop.c | 2 +-
block/dmg.c | 2 +-
block/rbd.c
on backing chains that have rbd protocol nodes.
Jeff Cody (9):
block: add bdrv_set_read_only() helper function
block: do not set BDS read_only if copy_on_read enabled
block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_only
block: code movement
block: introduce bdrv_try_set_read_o
lippe Mathieu-Daudé
Reviewed-by: Jeff Cody
Reviewed-by: Eric Blake
Message-id: 20170331120431.1767-3-mre...@redhat.com
Signed-off-by: Jeff Cody
---
block/curl.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/block/curl.c b/block/curl.c
index 34dbd33..2708d57 100644
--- a/block/c
=drive-virtio-disk0,'\
'serial=ea141b5c-cdb3-4765-910d-e7008b209a70,cache=writeback'
Even without an RBD setup, this serves a test of whether we get
the incorrect parser error of:
qemu-system-x86_64: -drive file=rbd:...cache=writeback: conf option 6789 has no
value
or the correc
From: Max Reitz
The curl block driver accepts more options than just "filename"; also,
the URL is actually expected to be passed through the "url" option
instead of "filename".
Signed-off-by: Max Reitz
Reviewed-by: Jeff Cody
Reviewed-by: Eric Blake
Message
The following changes since commit 95b31d709ba343ad237c3630047ee7438bac4065:
Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20170331.0'
into staging (2017-03-31 18:06:13 +0100)
are available in the git repository at:
git://github.com/codyprime/qemu-kvm-jtc.git tags/block-p
On Fri, Mar 31, 2017 at 02:04:30PM +0200, Max Reitz wrote:
> The curl block driver accepts more options than just "filename"; also,
> the URL is actually expected to be passed through the "url" option
> instead of "filename".
>
> Signed-off-by: Max Reitz
> ---
> qapi/block-core.json | 103
> +++
On Fri, Mar 31, 2017 at 02:04:29PM +0200, Max Reitz wrote:
> Yes, it's yet another episode in our popular
> get-blockdev-add-ready-for-2.9 drama!
>
> Right now, the schema for the curl block driver is seriously lacking.
> This series improves things at least a bit.
>
> To improve things seriously
by
> surprise.
>
> Signed-off-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> block/curl.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/block/curl.c b/block/curl.c
> index 34dbd335f4..2708d57c2f 100644
> --- a/block/curl.c
> +++ b/block/cu
On Fri, Mar 31, 2017 at 02:04:30PM +0200, Max Reitz wrote:
> The curl block driver accepts more options than just "filename"; also,
> the URL is actually expected to be passed through the "url" option
> instead of "filename".
>
> Signed-off-by: Max R
On Fri, Mar 31, 2017 at 10:27:30AM -0500, Eric Blake wrote:
> Commit c7cacb3 accidentally broke legacy key-value parsing through
> pseudo-filename parsing of -drive file=rbd://..., for any key that
> contains an escaped ':'. Such a key is surprisingly common, thanks
> to mon_host specifying a 'hos
s_t cluster, const char *keypairs_json,
> Error **errp)
> {
> -char *p, *buf;
> -char *name;
> -char *value;
> +QList *keypairs;
> +QString *name;
> +QString *value;
> +const char *key;
> +size_t remaining;
>
S_FLAT_TYPE__MAX, -1, NULL);
> +if (type != SOCKET_ADDRESS_FLAT_TYPE_INET
> +&& type != SOCKET_ADDRESS_FLAT_TYPE_UNIX) {
> +error_setg(&local_err,
> + "Parameter '%s' may be 'inet' or 'unix'",
> + GLUSTER_OPT_TYPE);
> error_append_hint(&local_err, GERR_INDEX_HINT, i);
> goto out;
> }
> +gsconf->type = type;
> qemu_opts_del(opts);
>
> if (gsconf->type == SOCKET_ADDRESS_FLAT_TYPE_INET) {
> --
> 2.7.4
>
Reviewed-by: Jeff Cody
ert the
feature for 2.9.
Note that users can still configure an authentication key with a
configuration file. They probably do that anyway if they use Ceph
outside QEMU as well.
Signed-off-by: Markus Armbruster
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Jeff Cody
Message-id: 1490
ccessible.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
Message-id: 1490691368-32099-6-git-send-email-arm...@redhat.com
Signed-off-by: Jeff Cody
---
block/rbd.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --
that this doesn't affect use of key "auth-supported" in
-drive file=rbd:...:key=value.
qemu_rbd_array_opts()'s parameter @type now must be RBD_MON_HOST,
which is silly. This will be cleaned up shortly.
Signed-off-by: Markus Armbruster
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
Reviewe
t and port instead of silently ignoring them.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Jeff Cody
Message-id: 1490691368-32099-11-git-send-email-arm...@redhat.com
Signed-off-by: Jeff Cody
---
block/rbd.c | 127 +++---
"filename", because none of the three users actually uses it.
This fixes -drive to reject parameter filename instead of silently
ignoring it.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
Message-id: 1490691368-32099-7-git-send
From: Markus Armbruster
The conversion from QDict to QemuOpts is pointless. Simply get the
stuff straight from the QDict.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Reviewed-by: Jeff Cody
Message-id: 1490691368-32099-8-git-send-email-arm...@redhat.com
t -blockdev, because pool and image are mandatory in the
QAPI schema.
Fix by adding the missing checks.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
Message-id: 1490691368-32099-3-git-send-email-arm...@redhat.com
Signed-off-by: Jeff Cody
-
The following changes since commit 142b9ca51d7260d20f6e87bd7f2020ac0a7d95d9:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into
staging (2017-03-28 11:10:36 +0100)
are available in the git repository at:
git://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-r
4" and "ipv6" are now rejected.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
Message-id: 1490691368-32099-2-git-send-email-arm...@redhat.com
Signed-off-by: Jeff Cody
---
qapi-schema.json | 21 ++---
qapi/
iewed-by: Jeff Cody
Message-id: 1490691368-32099-5-git-send-email-arm...@redhat.com
Signed-off-by: Jeff Cody
---
block/rbd.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 0fea348..182a5a3 100644
--- a/block/rbd.c
+++
Max Reitz
Reviewed-by: Jeff Cody
Message-id: 1490691368-32099-4-git-send-email-arm...@redhat.com
Signed-off-by: Jeff Cody
---
block/rbd.c | 91 ++---
1 file changed, 14 insertions(+), 77 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
ind
On Tue, Mar 28, 2017 at 10:55:58AM +0200, Markus Armbruster wrote:
> I really, really want to correct a few issues in external interfaces
> before while I can. Bonus: several minor bug fixes.
>
> Thanks to Jeff Cody for testing this series.
>
> v4:
> * PATCH 01,04-06 u
ut
> server.*.host is absent.
>
> Fixes -drive to reject invalid server.*.*.
>
> Permits cleaning up runtime_opts. Do that, and fix -drive to reject
> bogus parameters host and port instead of silently ignoring them
On Tue, Mar 28, 2017 at 10:56:05AM +0200, Markus Armbruster wrote:
> The conversion from QDict to QemuOpts is pointless. Simply get the
> stuff straight from the QDict.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Eric Blake
> Reviewed-by: Kevin Wolf
Revi
: John Snow
Reviewed-by: Jeff Cody
Message-id: 20170316212351.13797-4-js...@redhat.com
Signed-off-by: Jeff Cody
---
blockjob.c | 29 -
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/blockjob.c b/blockjob.c
index 0e9ed03..9b619f385 100644
--- a
Reviewed-by: Jeff Cody
Message-id: 20170316212351.13797-3-js...@redhat.com
Signed-off-by: Jeff Cody
---
block/block-backend.c | 24 ++--
include/sysemu/block-backend.h | 8
2 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/block/block-backend.c b
The following changes since commit 55a19ad8b2d0797e3a8fe90ab99a9bb713824059:
Update version for v2.9.0-rc1 release (2017-03-21 17:13:29 +)
are available in the git repository at:
https://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request
for you to fetch changes up to 600ac6a
pause only if necessary. We could avoid
requiring a wrapper, but all jobs would need to do it, so it's been
factored out here.
Signed-off-by: John Snow
Reviewed-by: Jeff Cody
Message-id: 20170316212351.13797-2-js...@redhat.com
Signed-off-by: Jeff Cody
---
blockjob.c | 26 ++
is therefore enough to skip the second acquisition when the two
AioContexts are one and the same.
Signed-off-by: Paolo Bonzini
Reviewed-by: Eric Blake
Reviewed-by: Jeff Cody
Message-id: 1490118490-5597-1-git-send-email-pbonz...@redhat.com
Signed-off-by: Jeff Cody
---
blockjob.c | 8
On Thu, Mar 16, 2017 at 02:28:47PM -0700, no-re...@patchew.org wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Type: series
> Subject: [Qemu-devel] [PATCH v2 0/3] block: pause block jobs for
> bdrv_drain_begin/end
> Message-id:
On Wed, Mar 22, 2017 at 12:05:26PM -0400, John Snow wrote:
>
>
> On 03/22/2017 12:01 PM, Jeff Cody wrote:
> > On Wed, Mar 22, 2017 at 11:37:15AM -0400, John Snow wrote:
> >> ping, is this the only issue? Any feedback? If this can hit 2.9 that
> >> would be goo
On Wed, Mar 22, 2017 at 08:57:51AM -0400, Jeff Cody wrote:
> On Thu, Mar 16, 2017 at 05:23:49PM -0400, John Snow wrote:
> > The purpose of this shim is to allow us to pause pre-started jobs.
> > The purpose of *that* is to allow us to buffer a pause request that
> > will b
RM_ALL, &error_abort);
> bs->job = job;
>
> + blk_set_dev_ops(blk, &block_job_dev_ops, job);
> +bdrv_op_unblock(bs, BLOCK_OP_TYPE_DATAPLANE, job->blocker);
> +
> QLIST_INSERT_HEAD(&block_jobs, job, job_list);
>
> blk_add_aio_context_notifier(blk, block_job_attached_aio_context,
> --
> 2.9.3
>
Reviewed-by: Jeff Cody
e size changed (e.g. monitor command block_resize)
> */
> void (*resize_cb)(void *opaque);
> + /*
> + * Runs when the backend receives a drain request.
> + */
> +void (*drained_begin)(void *opaque);
> +/*
> + * Runs when the backend's last drain request ends.
> + */
> +void (*drained_end)(void *opaque);
> } BlockDevOps;
>
> /* This struct is embedded in (the private) BlockBackend struct and contains
> --
> 2.9.3
>
Reviewed-by: Jeff Cody
On Wed, Mar 22, 2017 at 11:37:15AM -0400, John Snow wrote:
> ping, is this the only issue? Any feedback? If this can hit 2.9 that
> would be good.
>
The series looks fine to me, and I can patch up the nit from patchew when
applying. But do you happen to have a qemu-iotest for this case, or is it
+/* Try a few ioctls to get the right size */
> +for (i = 0; i < ARRAY_SIZE(ioctl_list); i++) {
> + if (ioctl(fd, ioctl_list[i], §or_size) >= 0) {
> +*sector_size_p = sector_size;
> +success = true;
> +}
> +}
>
> return success ? 0 : -errno;
> }
> --
> 2.7.4
>
>
Reviewed-by: Jeff Cody
On Thu, Mar 16, 2017 at 05:23:49PM -0400, John Snow wrote:
> The purpose of this shim is to allow us to pause pre-started jobs.
> The purpose of *that* is to allow us to buffer a pause request that
> will be able to take effect before the job ever does any work, allowing
> us to create jobs during
On Tue, Mar 21, 2017 at 06:48:10PM +0100, Paolo Bonzini wrote:
> Streaming or any other block job hangs when performed on a block device
> that has a non-default iothread. This happens because the AioContext
> is acquired twice by block_job_defer_to_main_loop_bh and then released
> only once by BD
o_main_loop = false;
> data->fn(data->job, data->opaque);
>
> -aio_context_release(aio_context);
> +if (aio_context != data->aio_context) {
> + aio_context_release(aio_context);
> +}
>
> aio_context_release(data->aio_context);
>
> --
> 1.8.3.1
>
>
Reviewed-by: Jeff Cody
array items are join as a single string with a ';'
character as a delimiter when setting the configuration values.
Reviewed-by: Markus Armbruster
Signed-off-by: Jeff Cody
---
block/rbd.c | 135 +++
qapi/block-core.json | 29 +++
On Wed, Mar 01, 2017 at 04:30:55PM +, Peter Maydell wrote:
> On 28 February 2017 at 16:34, Jeff Cody wrote:
> > The following changes since commit c8c0a1a784cdf70ecea50e93213137c6c89337a7:
> >
> > Merge remote-tracking branch 'remotes/cody/tags/block-pull-request&#
, and
offload the responsibility for safely handling/coping these strings to
the caller.
This also cleans up error handling some, as the callers now rely on
the Error object to determine if there is a parse error.
Reviewed-by: Eric Blake
Reviewed-by: Markus Armbruster
Signed-off-by: Jeff Cody
continued in this patch; there is an option
"keyvalue-pairs" that is populated with all the key/value pairs that the
QEMU driver does not care about. These key/value pairs will override
any settings in the 'conf' configuration file, just as they did before.
Reviewed-by: Eric Blake
D blockdev-add patches for 2.9
----
Jeff Cody (5):
block/rbd: don't copy strings in qemu_rbd_next_tok()
block/rbd: add all the currently supported runtime_opts
block/rbd: parse all options via bdrv_parse_filename
block/rbd: add blockdev-add support
b
rbd
driver merely unescapes, and passes along blindly to rados. This
option is a "legacy" option, and will not be exposed in the QAPI
or available for introspection.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
---
block/rbd.c | 68 -
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
---
qapi/block-core.json | 33 +++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index cf24c04..803edc3 100644
--- a/qapi/block-core.json
+++ b/qapi/block
On Tue, Feb 28, 2017 at 09:31:41AM -0800, no-re...@patchew.org wrote:
> Hi,
>
> This series failed build test on s390x host. Please find the details below.
>
> Type: series
> Subject: [Qemu-devel] [PULL v2 0/5] Block patches for 2.9
> Message-id: 20170228163436.31357-1-jc...@redhat.com
>
[...]
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
---
qapi/block-core.json | 33 +++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index cf24c04..803edc3 100644
--- a/qapi/block-core.json
+++ b/qapi/block
array items are join as a single string with a ';'
character as a delimiter when setting the configuration values.
Reviewed-by: Markus Armbruster
Signed-off-by: Jeff Cody
---
block/rbd.c | 134 +++
qapi/block-core.json | 29 +++
On Tue, Feb 28, 2017 at 10:26:49AM -0600, Eric Blake wrote:
> On 02/28/2017 10:15 AM, Jeff Cody wrote:
> > This adds support for three additional options that may be specified
> > by QAPI in blockdev-add:
> >
> > server: host, port
> > auth method: eith
d blockdev-add. Added s-o-b's.
----
Jeff Cody (5):
block/rbd: don't copy strings in qemu_rbd_next_tok()
block/rbd: add all the currently supported runtime_opts
block/rbd: parse all options via bdrv_parse_filename
block/r
continued in this patch; there is an option
"keyvalue-pairs" that is populated with all the key/value pairs that the
QEMU driver does not care about. These key/value pairs will override
any settings in the 'conf' configuration file, just as they did before.
Reviewed-by: Eric Blake
rbd
driver merely unescapes, and passes along blindly to rados. This
option is a "legacy" option, and will not be exposed in the QAPI
or available for introspection.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
---
block/rbd.c | 68 -
, and
offload the responsibility for safely handling/coping these strings to
the caller.
This also cleans up error handling some, as the callers now rely on
the Error object to determine if there is a parse error.
Reviewed-by: Eric Blake
Reviewed-by: Markus Armbruster
Signed-off-by: Jeff Cody
for 2.9, for rbd blockdev-add
----
Jeff Cody (5):
block/rbd: don't copy strings in qemu_rbd_next_tok()
block/rbd: add all the currently supported runtime_opts
block/rbd: parse all options via bdrv_parse_filename
block/rbd: add blockdev-a
On Tue, Feb 28, 2017 at 10:51:02AM -0500, Jeff Cody wrote:
>
> This series adds blockdev-add for rbd.
>
>
> Changes from v3:
>
> Patch 5: Encapsulate ipv6 addresses with '[]' (Thanks Daniel, Eric, Markus)
> Free auth_supported (Thanks
Get rid of qemu_rbd_parsename in favor of bdrv_parse_filename.
This simplifies a lot of the parsing as well, as we can treat everything
a bit simpler since nonexistent options are simply NULL pointers instead
of empty strings.
An important item to note:
Ceph has many extra option values that can
This patch is prep work for parsing options for .bdrv_parse_filename,
and using QDict options.
The function qemu_rbd_next_tok() searched for various key/value pairs,
and copied them into buffers. This will soon be an unnecessary extra
step, so we will now return found strings by reference only, a
Reviewed-by: Eric Blake
---
qapi/block-core.json | 33 +++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index cf24c04..803edc3 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2111,6 +2111,
This adds support for three additional options that may be specified
by QAPI in blockdev-add:
server: host, port
auth method: either 'cephx' or 'none'
The "server" and "auth-supported" QAPI parameters are arrays. To conform
with the rados API, the array items are join as a single string
This adds all the currently supported runtime opts, which
are the options as parsed from the filename. All of these
options are explicitly checked for during during runtime,
with an exception to the "keyvalue-pairs" option.
This option contains all the key/value pairs that the QEMU rbd
driver mer
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
---
qapi/block-core.json | 33 +++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index cf24c04..803edc3 100644
--- a/qapi/block-core.json
+++ b/qapi/block
rbd
driver merely unescapes, and passes along blindly to rados. This
option is a "legacy" option, and will not be exposed in the QAPI
or available for introspection.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
---
block/rbd.c | 68 -
, and
offload the responsibility for safely handling/coping these strings to
the caller.
This also cleans up error handling some, as the callers now rely on
the Error object to determine if there is a parse error.
Reviewed-by: Eric Blake
Reviewed-by: Markus Armbruster
Signed-off-by: Jeff Cody
array items are join as a single string with a ';'
character as a delimiter when setting the configuration values.
Signed-off-by: Jeff Cody
---
block/rbd.c | 134 +++
qapi/block-core.json | 29 +++
2 files changed, 1
continued in this patch; there is an option
"keyvalue-pairs" that is populated with all the key/value pairs that the
QEMU driver does not care about. These key/value pairs will override
any settings in the 'conf' configuration file, just as they did before.
Reviewed-by: Eric Blake
changes in patch 2
* Removed the string unescape from qemu_rbd_set_keypairs(), because the
strings have already been unescaped by the time they hit this function.
Patch 4:
* 'rbd-id' becomes 'user'
* drop the 'keyvalue-pairs' from the QAPI (both, thanks Daniel)
Patc
On Tue, Feb 28, 2017 at 03:34:10PM +0100, Markus Armbruster wrote:
> Starting with just the QAPI schema.
>
> Jeff Cody writes:
>
> > This adds support for three additional options that may be specified
> > by QAPI in blockdev-add:
> >
> > server: ho
On Tue, Feb 28, 2017 at 04:07:14PM +0100, Markus Armbruster wrote:
> Jeff Cody writes:
>
> > This adds support for three additional options that may be specified
> > by QAPI in blockdev-add:
> >
> > server: host, port
> > auth method: either '
On Tue, Feb 28, 2017 at 10:28:49AM +, Daniel P. Berrange wrote:
> On Tue, Feb 28, 2017 at 10:16:51AM +, Daniel P. Berrange wrote:
> > On Mon, Feb 27, 2017 at 10:57:44PM -0500, Jeff Cody wrote:
> > > On Mon, Feb 27, 2017 at 04:47:54PM -0600, Eric Blake wrote:
> > &g
The missing colons make the iscsi part of the documentation not render
quite as nicely, so add those in.
Signed-off-by: Jeff Cody
---
qapi/block-core.json | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index
601 - 700 of 1251 matches
Mail list logo
