Re: [Qemu-block] [PATCH for-2.8? 1/3] qemu-options: Drop mentions of curl's TFTP support

r http(s) and ftp(s). > > Syntax using a single filename: > @example > @@ -2617,7 +2617,7 @@ Syntax using a single filename: > where: > @table @option > @item protocol > -'http', 'https', 'ftp', 'ftps', or 'tftp'. > +'http', 'https', 'ftp', or 'ftps'. > > @item u

Re: [Qemu-block] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"

On Wed, Nov 02, 2016 at 06:55:36PM +0100, Max Reitz wrote: > See patch 3 for the reason why we have actually never supported TFTP at > all (except for very small files (i.e. below 256 kB or so)). > > I would consider this series a bug fix because, well, it doesn't really > change any

[Qemu-block] [PULL v2 13/14] blockjobs: split interface into public/private, Part 1

patches. Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1477584421-1399-7-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/backup.c

[Qemu-block] [PULL v2 14/14] blockjobs: fix documentation

From: John Snow <js...@redhat.com> (Trivial) Fix wrong function names in documentation. Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1477584421-1399-8-git-send-email-js.

[Qemu-block] [PULL v2 10/14] Replication/Blockjobs: Create replication jobs as internal

From: John Snow <js...@redhat.com> Bubble up the internal interface to commit and backup jobs, then switch replication tasks over to using this methodology. Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Jeff Cody <jc...@r

[Qemu-block] [PULL v2 12/14] Blockjobs: Internalize user_pause logic

vin Wolf <kw...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1477584421-1399-6-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- blockdev.c | 12 +--- blockjob.c | 22 --

[Qemu-block] [PULL v2 09/14] blockjobs: Allow creating internal jobs

From: John Snow <js...@redhat.com> Add the ability to create jobs without an ID. Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1477584421-1399-3-git-send-email-js...@redhat.com

[Qemu-block] [PULL v2 03/14] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support

if the compilation environment supports SEEK_DATA. Reviewed-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> Tested-by: Eric Blake <ebl...@redhat.com> Message-id: 00370bce5c98140d6c56ad5145635ec6551265cc.1475876377.git.jc...@redhat.com Signed-off

[Qemu-block] [PULL v2 08/14] blockjobs: hide internal jobs from management API

ow <js...@redhat.com> Message-id: 1477584421-1399-2-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- blockdev.c | 17 + blockjob.c | 41 ++--- include/block/blockjob.h | 12 +++

[Qemu-block] [PULL v2 11/14] blockjob: centralize QMP event emissions

ow <js...@redhat.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1477584421-1399-5-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/commit.c| 8 block/mirror.c

[Qemu-block] [PULL v2 07/14] block/gluster: fix port type in the QAPI options list

'*ipv4': 'bool', '*ipv6': 'bool' } } but the current code still treats it as QEMU_OPT_NUMBER, hence fixing port to accept QEMU_OPT_STRING. Suggested-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> Reviewed-by: Jeff Cody

[Qemu-block] [PULL v2 02/14] rbd: make the code more readable

From: Xiubo Li <lixi...@cmss.chinamobile.com> Make it a bit clearer and more readable. Signed-off-by: Xiubo Li <lixi...@cmss.chinamobile.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: John Snow <js...@redhat.com> Reviewed-by: Jeff Cody <j

[Qemu-block] [PULL v2 06/14] block/gluster: improve defense over string to int conversion

port argument is actually a string type, in the follow up patch let's move port type from QEMU_OPT_NUMBER to QEMU_OPT_STRING [Jeff Cody: removed spurious parenthesis] Signed-off-by: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> Reviewed-by: Markus Armbruster <arm...@redha

[Qemu-block] [PULL v2 01/14] qapi: add release designator to gluster logfile option

The "logfile" option to BlockdevOptionsGluster will not be in QEMU until 2.8. Update comment to indicate this. Reported-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- qapi/block-core.json | 2 +- 1 file changed, 1 insertion(+), 1 d

[Qemu-block] [PULL v2 04/14] block/gluster: memory usage: use one glfs instance per volume

Z and RSS are analyzed using 'ps aux' utility. Signed-off-by: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1477581890-4811-1-git-send-email-prasanna.kale...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com>

[Qemu-block] [PULL v2 00/14] Block patches for 2.8

Zheng (1): block: Turn on "unmap" in active commit Jeff Cody (2): qapi: add release designator to gluster logfile option block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support John Snow (7): blockjobs: hide internal jobs from management API blockjobs: Allow creatin

[Qemu-block] [PULL v2 05/14] block: Turn on "unmap" in active commit

email-f...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 7e99f3a..82a9529 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1081,7 +1081,7 @@ void comm

[Qemu-block] [PATCH 1/1] migration: fix compiler warning on uninitialized variable

ayl...@ilande.co.uk> Signed-off-by: Jeff Cody <jc...@redhat.com> --- migration/colo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/colo.c b/migration/colo.c index e7224b8..93c85c5 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -439,7 +4

[Qemu-block] [PULL 11/14] blockjob: centralize QMP event emissions

ow <js...@redhat.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1477584421-1399-5-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/commit.c| 8 block/mirror.c

[Qemu-block] [PULL 13/14] blockjobs: split interface into public/private, Part 1

patches. Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1477584421-1399-7-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/backup.c

[Qemu-block] [PULL 14/14] blockjobs: fix documentation

From: John Snow <js...@redhat.com> (Trivial) Fix wrong function names in documentation. Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1477584421-1399-8-git-send-email-js.

[Qemu-block] [PULL 12/14] Blockjobs: Internalize user_pause logic

vin Wolf <kw...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1477584421-1399-6-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- blockdev.c | 12 +--- blockjob.c | 22 --

[Qemu-block] [PULL 09/14] blockjobs: Allow creating internal jobs

From: John Snow <js...@redhat.com> Add the ability to create jobs without an ID. Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1477584421-1399-3-git-send-email-js...@redhat.com

[Qemu-block] [PULL 06/14] block/gluster: improve defense over string to int conversion

port argument is actually a string type, in the follow up patch let's move port type from QEMU_OPT_NUMBER to QEMU_OPT_STRING [Jeff Cody: removed spurious parenthesis] Signed-off-by: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> Reviewed-by: Markus Armbruster <arm...@redha

[Qemu-block] [PULL 08/14] blockjobs: hide internal jobs from management API

ow <js...@redhat.com> Message-id: 1477584421-1399-2-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- blockdev.c | 17 + blockjob.c | 41 ++--- include/block/blockjob.h | 12 +++

[Qemu-block] [PULL 05/14] block: Turn on "unmap" in active commit

email-f...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 3a0788e..80be93e 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1074,7 +1074,7 @@ void comm

[Qemu-block] [PULL 10/14] Replication/Blockjobs: Create replication jobs as internal

From: John Snow <js...@redhat.com> Bubble up the internal interface to commit and backup jobs, then switch replication tasks over to using this methodology. Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Jeff Cody <jc...@r

[Qemu-block] [PULL 07/14] block/gluster: fix port type in the QAPI options list

'*ipv4': 'bool', '*ipv6': 'bool' } } but the current code still treats it as QEMU_OPT_NUMBER, hence fixing port to accept QEMU_OPT_STRING. Suggested-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> Reviewed-by: Jeff Cody

[Qemu-block] [PULL 04/14] block/gluster: memory usage: use one glfs instance per volume

Z and RSS are analyzed using 'ps aux' utility. Signed-off-by: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1477581890-4811-1-git-send-email-prasanna.kale...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com>

[Qemu-block] [PULL 00/14] Block patches for 2.8

Zheng (1): block: Turn on "unmap" in active commit Jeff Cody (2): qapi: add release designator to gluster logfile option block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support John Snow (7): blockjobs: hide internal jobs from management API blockjobs: Allow creatin

[Qemu-block] [PULL 03/14] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support

if the compilation environment supports SEEK_DATA. Reviewed-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> Tested-by: Eric Blake <ebl...@redhat.com> Message-id: 00370bce5c98140d6c56ad5145635ec6551265cc.1475876377.git.jc...@redhat.com Signed-off

[Qemu-block] [PULL 01/14] qapi: add release designator to gluster logfile option

The "logfile" option to BlockdevOptionsGluster will not be in QEMU until 2.8. Update comment to indicate this. Reported-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- qapi/block-core.json | 2 +- 1 file changed, 1 insertion(+), 1 d

[Qemu-block] [PULL 02/14] rbd: make the code more readable

From: Xiubo Li <lixi...@cmss.chinamobile.com> Make it a bit clearer and more readable. Signed-off-by: Xiubo Li <lixi...@cmss.chinamobile.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: John Snow <js...@redhat.com> Reviewed-by: Jeff Cody <j

Re: [Qemu-block] [PATCH v2 0/7] blockjobs: preliminary refactoring work, Pt 1

On Thu, Oct 27, 2016 at 12:06:54PM -0400, John Snow wrote: > This is a follow-up to patches 2-6 of: > [PATCH v2 00/11] blockjobs: Fix transactional race condition > > That series started trying to refactor blockjobs with the goal of > internalizing BlockJob state as a side effect of having gone

Re: [Qemu-block] [PATCH v3] block: Turn on "unmap" in active commit

On Tue, Sep 27, 2016 at 07:14:52PM +0800, Fam Zheng wrote: > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > commit', but didn't turn on the "unmap" in the active commit job. This > patch fixes that so that zeroed clusters in top image can be discarded > which is desired in

Re: [Qemu-block] [PATCH 0/7] blockjobs: preliminary refactoring work, Pt 1

On Fri, Oct 14, 2016 at 02:32:55PM -0400, John Snow wrote: > > > On 10/13/2016 06:56 PM, John Snow wrote: > >This is a follow-up to patches 1-6 of: > >[PATCH v2 00/11] blockjobs: Fix transactional race condition > > > >That series started trying to refactor blockjobs with the goal of >

Re: [Qemu-block] [PATCH 7/7] blockjobs: fix documentation

Job *job); > void block_job_enter(BlockJob *job); > > /** > - * block_job_ready: > - * @job: The job which is now ready to complete. > + * block_job_event_ready: > + * @job: The job which is now ready to be completed. > * > * Send a BLOCK_JOB_READY event for the specified job. > */ > -- > 2.7.4 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH 5/7] Blockjobs: Internalize user_pause logic

k_job_paused: > + * @job: The job to query. > + * > + * Returns true if the job is user-paused. > + */ > +bool block_job_user_paused(BlockJob *job); > + > +/** > * block_job_resume: > * @job: The job to be resumed. > * > @@ -366,6 +383,15 @@ void block_job_pause(BlockJob *job); > void block_job_resume(BlockJob *job); > > /** > + * block_job_user_resume: > + * @job: The job to be resumed. > + * > + * Resume the specified job. > + * Must be paired with a preceding block_job_user_pause. > + */ > +void block_job_user_resume(BlockJob *job); > + > +/** > * block_job_enter: > * @job: The job to enter. > * > -- > 2.7.4 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH 4/7] blockjob: centralize QMP event emissions

on @bs. Clusters that are allocated > @@ -734,9 +727,7 @@ void mirror_start(const char *job_id, BlockDriverState > *bs, >MirrorSyncMode mode, BlockMirrorBackingMode backing_mode, >BlockdevOnError on_source_error, >BlockdevOnError on_target_error, > - bool unmap, > - BlockCompletionFunc *cb, > - void *opaque, Error **errp); > + bool unmap, Error **errp); > > /* > * backup_start: > diff --git a/include/block/blockjob.h b/include/block/blockjob.h > index fdb31e0..928f0b8 100644 > --- a/include/block/blockjob.h > +++ b/include/block/blockjob.h > @@ -374,23 +374,6 @@ void block_job_resume(BlockJob *job); > void block_job_enter(BlockJob *job); > > /** > - * block_job_event_cancelled: > - * @job: The job whose information is requested. > - * > - * Send a BLOCK_JOB_CANCELLED event for the specified job. > - */ > -void block_job_event_cancelled(BlockJob *job); > - > -/** > - * block_job_ready: > - * @job: The job which is now ready to complete. > - * @msg: Error message. Only present on failure. > - * > - * Send a BLOCK_JOB_COMPLETED event for the specified job. > - */ > -void block_job_event_completed(BlockJob *job, const char *msg); > - > -/** > * block_job_ready: > * @job: The job which is now ready to complete. > * > -- > 2.7.4 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH 3/7] Replication/Blockjobs: Create replication jobs as internal

const char *job_id, BlockDriverState > *bs, >bool compress, >BlockdevOnError on_source_error, >BlockdevOnError on_target_error, > + int creation_flags, >BlockCompletionFunc *cb, void *opaque, >BlockJobTxn *txn, Error **errp); > > diff --git a/qemu-img.c b/qemu-img.c > index 02c07b9..3897d82 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -928,8 +928,9 @@ static int img_commit(int argc, char **argv) > .bs = bs, > }; > > -commit_active_start("commit", bs, base_bs, 0, BLOCKDEV_ON_ERROR_REPORT, > -common_block_job_cb, , _err, false); > +commit_active_start("commit", bs, base_bs, BLOCK_JOB_DEFAULT, 0, > +BLOCKDEV_ON_ERROR_REPORT, common_block_job_cb, , > +_err, false); > if (local_err) { > goto done; > } > -- > 2.7.4 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH 2/7] blockjobs: Allow creating internal jobs

iterations; > s->use_timer = use_timer; > s->rc = rc; > diff --git a/tests/test-blockjob.c b/tests/test-blockjob.c > index 5b0e934..18bf850 100644 > --- a/tests/test-blockjob.c > +++ b/tests/test-blockjob.c > @@ -31,7 +31,7 @@ static BlockJob *do_test_id(BlockBackend *blk, const char > *id, > Error *errp = NULL; > > job = block_job_create(id, _block_job_driver, blk_bs(blk), 0, > - block_job_cb, NULL, ); > + BLOCK_JOB_DEFAULT, block_job_cb, NULL, ); > if (should_succeed) { > g_assert_null(errp); > g_assert_nonnull(job); > -- > 2.7.4 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH v2] rbd: make the code more readable

On Sat, Oct 15, 2016 at 04:26:13PM +0800, Xiubo Li wrote: > Make it a bit clearer and more readable. > > Signed-off-by: Xiubo Li > CC: John Snow > --- > > V2: > - Advice from John Snow. Thanks. > > > block/rbd.c | 25 -

[Qemu-block] [PATCH v2 1/1] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support

if the compilation environment supports SEEK_DATA. Reviewed-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- Changes from v1: - Fixed undefined variable warnings by moving variable declarations - Add a bit more whitespace to improve readabil

Re: [Qemu-block] [PATCH 1/1] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support

On Fri, Oct 07, 2016 at 09:20:54AM -0500, Eric Blake wrote: > On 10/06/2016 10:53 PM, Jeff Cody wrote: > > Add checks to see if the system compiling QEMU has support for > > SEEK_HOLE/SEEK_DATA. If the system does not, we will flag that seek > > data is unsupported in g

Re: [Qemu-block] [Qemu-devel] [PATCH] block/gluster: add support for SEEK_DATA/SEEK_HOLE

On Thu, Oct 06, 2016 at 05:09:59PM -0500, Eric Blake wrote: > On 03/07/2016 01:14 PM, Eric Blake wrote: > > [adding qemu-devel; ALL patches must cc qemu-devel even when sent to > > another list] > > > > On 03/07/2016 11:04 AM, Niels de Vos wrote: > >> GlusterFS 3.8 contains support for SEEK_DATA

[Qemu-block] [PATCH 1/1] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support

if the compilation environment supports SEEK_DATA. Signed-off-by: Jeff Cody <jc...@redhat.com> --- Note: this patch is untested on older systems that do not support SEEK_DATA (e.g.. RHEL6). This won't be pulled into my tree until it is verified. block/gluster.c | 11 +-- 1 file c

Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] qemu-iotests: update test 085.out with correct output

On Tue, Oct 04, 2016 at 02:48:41PM -0500, Eric Blake wrote: > On 10/04/2016 12:22 PM, Jeff Cody wrote: > > Commit 5c678ee8d9406b9baeec788530965483575db555 changed the qmp > > dispatch and validation code, and the error output that test > > 085 relied on changed. Up

[Qemu-block] [PATCH 1/1] qemu-iotests: update test 085.out with correct output

Commit 5c678ee8d9406b9baeec788530965483575db555 changed the qmp dispatch and validation code, and the error output that test 085 relied on changed. Update it to be correct. Signed-off-by: Jeff Cody <jc...@redhat.com> --- tests/qemu-iotests/085.out | 2 +- 1 file changed, 1 insertion

Re: [Qemu-block] [PATCH v2 03/11] Blockjobs: Internalize user_pause logic

On Fri, Sep 30, 2016 at 06:00:41PM -0400, John Snow wrote: > BlockJobs will begin hiding their state in preparation for some > refactorings anyway, so let's internalize the user_pause mechanism > instead of leaving it to callers to correctly manage. > > Signed-off-by: John Snow

Re: [Qemu-block] [PATCH v3 1/2] block: sync bdrv_co_get_block_status_above() with bdrv_is_allocated_above()

stefa...@redhat.com> > >CC: Fam Zheng <f...@redhat.com> > >CC: Kevin Wolf <kw...@redhat.com> > >CC: Max Reitz <mre...@redhat.com> > >CC: Jeff Cody <jc...@redhat.com> > >--- > > block/io.c | 25 - > > 1 file

Re: [Qemu-block] [PATCH v8 12/12] Add UUID files to MAINTAINERS

> > +UUID > +M: Fam Zheng <f...@redhat.com> > +S: Supported > +F: util/uuid.c > +F: include/qemu/uuid.h > + > Usermode Emulation > -- > Overall > -- > 2.7.4 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH v8 10/12] uuid: Tighten uuid parse

gt; +(c >= 'A' && c <= 'F') || > +(c >= 'a' && c <= 'f')) { > +continue; > +} > +return false; > +} > +} > +return i == 36; > +} > + Doesn't verify variant / version, but it is

Re: [Qemu-block] [PATCH v8 07/12] tests: No longer dependent on CONFIG_UUID

; #endif > > -#if defined(CONFIG_UUID) && (defined(_WIN32) || defined RUSAGE_THREAD) > +#if (defined(_WIN32) || defined RUSAGE_THREAD) > #define TEST_LUKS > #else > #undef TEST_LUKS > -- > 2.7.4 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH v8 09/12] vl: Switch qemu_uuid to QemuUUID

], [1], [2], [3], > + [4], [5], [6], [7], [8], [9], > + [10], [11], [12], [13], [14], > + [15]); > > if (ret != 16) { > return -1; > diff --git a/vl.c b/vl.c > index 1e787a0..a12170f 100644 > --- a/vl.c > +++ b/vl.c > @@ -183,10 +183,10 @@ uint8_t qemu_extra_params_fw[2]; > > int icount_align_option; > > -/* The bytes in qemu_uuid[] are in the order specified by RFC4122, _not_ in > the > +/* The bytes in qemu_uuid are in the order specified by RFC4122, _not_ in the > * little-endian "wire format" described in the SMBIOS 2.6 specification. > */ > -uint8_t qemu_uuid[16]; > +QemuUUID qemu_uuid; > bool qemu_uuid_set; > > static NotifierList exit_notifiers = > @@ -3739,7 +3739,7 @@ int main(int argc, char **argv, char **envp) > cursor_hide = 0; > break; > case QEMU_OPTION_uuid: > -if(qemu_uuid_parse(optarg, qemu_uuid) < 0) { > +if (qemu_uuid_parse(optarg, _uuid) < 0) { > error_report("failed to parse UUID string: wrong > format"); > exit(1); > } > -- > 2.7.4 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH v8 04/12] vdi: Use QEMU UUID API

UP; > goto fail; > @@ -821,8 +782,8 @@ static int vdi_create(const char *filename, QemuOpts > *opts, Error **errp) > if (image_type == VDI_TYPE_STATIC) { > header.blocks_allocated = blocks; > } > -uuid_generate(header.uuid_image); > -uuid_generate(header.uuid_last_snap); > +qemu_uuid_generate(_image); > +qemu_uuid_generate(_last_snap); > /* There is no need to set header.uuid_link or header.uuid_parent here. > */ > #if defined(CONFIG_VDI_DEBUG) > vdi_header_print(); > -- > 2.7.4 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH v8 08/12] configure: Remove detection code for UUID

-lstdc++ > -Wl,--enable-stdcall-fixup $libs_qga" > qga_vss_provider="qga/vss-win32/qga-vss.dll qga/vss-win32/qga-vss.tlb" >else > if test "$vss_win32_sdk" != "" ; then > @@ -4868,7 +4837,6 @@ echo "preadv support$preadv" > echo "fdatasync $fdatasync" > echo "madvise $madvise" > echo "posix_madvise $posix_madvise" > -echo "uuid support $uuid" > echo "libcap-ng support $cap_ng" > echo "vhost-net support $vhost_net" > echo "vhost-scsi support $vhost_scsi" > @@ -5058,9 +5026,6 @@ fi > if test "$fnmatch" = "yes" ; then >echo "CONFIG_FNMATCH=y" >> $config_host_mak > fi > -if test "$uuid" = "yes" ; then > - echo "CONFIG_UUID=y" >> $config_host_mak > -fi > if test "$xfs" = "yes" ; then >echo "CONFIG_XFS=y" >> $config_host_mak > fi > -- > 2.7.4 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH v8 05/12] vpc: Use QEMU UUID API

VHDFooter; > @@ -980,9 +978,7 @@ static int vpc_create(const char *filename, QemuOpts > *opts, Error **errp) > > footer->type = cpu_to_be32(disk_type); > > -#if defined(CONFIG_UUID) > -uuid_generate(footer->uuid); > -#endif > +qemu_uuid_generate(>uuid); > > footer->checksum = cpu_to_be32(vpc_checksum(buf, HEADER_SIZE)); > > -- > 2.7.4 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH v8 06/12] crypto: Switch to QEMU UUID API

ks->header.uuid, > -errp) < 0) { > -goto error; > -} > +qcrypto_block_luks_uuid_gen(luks->header.uuid); > > cipher_alg = qcrypto_block_luks_cipher_alg_lookup(luks_opts.cipher_alg, >errp); > -- > 2.7.4 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH v8 03/12] vhdx: Use QEMU UUID API

### > # xfsctl() probe, used for raw-posix > if test "$xfs" != "no" ; then >cat > $TMPC << EOF > @@ -4918,7 +4902,6 @@ echo "TPM support $tpm" > echo "libssh2 support $libssh2" > echo "TPM passthrough $tpm_passthrough" > echo "QOM debugging $qom_cast_debug" > -echo "vhdx $vhdx" > echo "lzo support $lzo" > echo "snappy support$snappy" > echo "bzip2 support $bzip2" > @@ -5443,10 +5426,6 @@ if test "$libssh2" = "yes" ; then >echo "LIBSSH2_LIBS=$libssh2_libs" >> $config_host_mak > fi > > -if test "$vhdx" = "yes" ; then > - echo "CONFIG_VHDX=y" >> $config_host_mak > -fi > - > # USB host support > if test "$libusb" = "yes"; then >echo "HOST_USB=libusb legacy" >> $config_host_mak > -- > 2.7.4 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH v8 02/12] uuid: Make null_uuid static

l_uuid = { 0 }; > +static QemuUUID null_uuid; > return memcmp(uu, _uuid, sizeof(QemuUUID)) == 0; > } > > -- > 2.7.4 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH v8 01/12] util: Add UUID API

+return g_strdup_printf(UUID_FMT, > + uu[0], uu[1], uu[2], uu[3], uu[4], uu[5], uu[6], > + uu[7], uu[8], uu[9], uu[10], uu[11], uu[12], > + uu[13], uu[14], uu[15]); > +} > + > +int qemu_uuid_parse(const char *str, uint8_t *uuid) > +{ > +int ret; > + > +if (strlen(str) != 36) { > +return -1; > +} > + > +ret = sscanf(str, UUID_FMT, [0], [1], [2], [3], > + [4], [5], [6], [7], [8], [9], > + [10], [11], [12], [13], [14], > + [15]); > + > +if (ret != 16) { > +return -1; > +} > +return 0; > +} > + > +/* Swap from UUID format endian (BE) to the opposite or vice versa. > + */ > +void qemu_uuid_bswap(QemuUUID *uuid) > +{ > +assert(QEMU_PTR_IS_ALIGNED(uuid, sizeof(uint32_t))); > +bswap32s(>fields.time_low); > +bswap16s(>fields.time_mid); > +bswap16s(>fields.time_high_and_version); > +} > diff --git a/vl.c b/vl.c > index ad2664b..1e787a0 100644 > --- a/vl.c > +++ b/vl.c > @@ -25,6 +25,7 @@ > #include "qemu-version.h" > #include "qemu/cutils.h" > #include "qemu/help_option.h" > +#include "qemu/uuid.h" > > #ifdef CONFIG_SECCOMP > #include "sysemu/seccomp.h" > -- > 2.7.4 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags

On Wed, Sep 14, 2016 at 06:52:15PM +0300, Alberto Garcia wrote: > If an image is opened with snapshot=on, its flags are modified by > bdrv_backing_options() and then bs->open_flags is updated accordingly. > This last step is unnecessary if we calculate the new flags before > setting

[Qemu-block] [PATCH 1/1] qapi: add release designator to gluster logfile option

The "logfile" option to BlockdevOptionsGluster will not be in QEMU until 2.8. Update comment to indicate this. Reported-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- qapi/block-core.json | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [Qemu-block] [Qemu-devel] [PULL 1/2] block/gluster: add support to choose libgfapi logfile

On Tue, Sep 13, 2016 at 10:23:32AM -0500, Eric Blake wrote: > On 09/13/2016 12:42 AM, Jeff Cody wrote: > > From: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> > > > > currently all the libgfapi logs defaults to '/dev/stderr' as it was > > hardcoded > &

[Qemu-block] [PULL 1/2] block/gluster: add support to choose libgfapi logfile

ot;:"1.2.3.4", "port":24007 }, { "type":"unix", "socket":"/var/run/glusterd.socket" } ] } }'

[Qemu-block] [PULL 2/2] qapi/block-core: add doc describing GlusterServer vs. SocketAddress

From: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> Added documentation describing relation between GlusterServer and SocketAddress qapi schemas. Thanks to Markus Armbruster <arm...@redhat.com> Reviewed-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Jeff Cody

[Qemu-block] [PULL 0/2] Block patches

The following changes since commit 7263da78045dc91cc207f350911efe4259e99b3c: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-signed' into staging (2016-09-12 15:09:47 +0100) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] mirror: fix improperly filled copy_bitmap for mirror block job

Kevin Wolf <kw...@redhat.com> > CC: Max Reitz <mre...@redhat.com> > CC: Jeff Cody <jc...@redhat.com> > --- > block/mirror.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/block/mirror.c b/block/mirror.c > ind

Re: [Qemu-block] [PATCH 1/1] mirror: fix improperly filled copy_bitmap for mirror block job

if it is BDRV_BLOCK_ZERO. > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Jeff Cody <jc...@redhat.com> > CC: Kevin Wolf <kw...@redhat.com> > CC: Max Reitz <mre...@redhat.com> > --- > block/mirror.c | 13 - > 1 file changed, 8 i

Re: [Qemu-block] [PATCH v2 1/1] block-backend: allow flush on devices with open tray

4d5cf > block: Move some bdrv_*_all() functions to BB > > Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> I don't have any real suggestions for a test either, except to point you to test 091 which does a live migration test (which i

Re: [Qemu-block] [PATCH] block jobs: Improve error message for missing job ID

return NULL; > +} > } > > if (!id_wellformed(job_id)) { > -- > 1.8.3.1 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH for-2.7? v2 0/5] block: Use QemuOpts for runtime options

tions(+), 83 deletions(-) > create mode 100755 tests/qemu-iotests/162 > create mode 100644 tests/qemu-iotests/162.out > > -- > 2.9.2 > Series: Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH v3 8/9] vl: Switch qemu_uuid to QemuUUID

On Wed, Aug 10, 2016 at 09:28:56AM +0800, Fam Zheng wrote: > On Tue, 08/09 17:45, Jeff Cody wrote: > > > diff --git a/util/uuid.c b/util/uuid.c > > > index 80c89f0..5d8bc88 100644 > > > --- a/util/uuid.c > > > +++ b/util/uuid.c > > > @@ -61,1

Re: [Qemu-block] [PATCH v3 8/9] vl: Switch qemu_uuid to QemuUUID

On Tue, Aug 09, 2016 at 02:50:06PM +0800, Fam Zheng wrote: > Update all qemu_uuid users as well, especially get rid of the duplicated > low level g_strdup_printf, sscanf and snprintf calls with QEMU UUID API. > > Since qemu_uuid_parse is quite tangled with qemu_uuid, it's switching to > QemuUUID

Re: [Qemu-block] [PATCH v3 1/9] util: Add UUID API

On Tue, Aug 09, 2016 at 02:49:59PM +0800, Fam Zheng wrote: > A number of different places across the code base use CONFIG_UUID. Some > of them are soft dependency, some are not built if libuuid is not > available, some come with dummy fallback, some throws runtime error. > > It is hard to

Re: [Qemu-block] [PATCH v3 1/9] util: Add UUID API

On Tue, Aug 09, 2016 at 02:49:59PM +0800, Fam Zheng wrote: > A number of different places across the code base use CONFIG_UUID. Some > of them are soft dependency, some are not built if libuuid is not > available, some come with dummy fallback, some throws runtime error. > > It is hard to

Re: [Qemu-block] [PATCH v2 8/8] configure: Remove detection code for UUID

On Mon, Aug 08, 2016 at 02:09:28PM +0800, Fam Zheng wrote: > All code now uses built-in UUID implementation. Remove the code of > libuuid and make --enable-uuid and --disable-uuid only print a message. > > Signed-off-by: Fam Zheng > --- > configure | 43

Re: [Qemu-block] [PATCH v2 5/8] vpc: Use QEMU UUID API

On Mon, Aug 08, 2016 at 02:09:25PM +0800, Fam Zheng wrote: > Previously we conditionally generate if footer->uuid, when libuuid is s/generate if/generated/ s/is/was/ > available. Now that we have a built-in implementation, we can switch to > it. > > Signed-off-by: Fam Zheng >

Re: [Qemu-block] [PATCH v2 3/8] vhdx: Use QEMU UUID API

On Mon, Aug 08, 2016 at 02:09:23PM +0800, Fam Zheng wrote: > This removes our dependency to libuuid, so that the driver can always be > built. > > Similar to how we handled data plane configure options, --enable-vhdx > and --disable-vhdx are also changed to a nop with a message saying it's >

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/8] util: Add UUID API

On Mon, Aug 08, 2016 at 01:07:33PM +0200, Markus Armbruster wrote: > Fam Zheng writes: > > > A number of different places across the code base use CONFIG_UUID. Some > > of them are soft dependency, some are not built if libuuid is not > > available, some come with dummy

Re: [Qemu-block] [PATCH 1/7] util: Add UUID API

On Tue, Aug 02, 2016 at 05:18:32PM +0800, Fam Zheng wrote: > A number of different places across the code base use CONFIG_UUID. Some > of them are soft dependency, some are not built if libuuid is not > available, some come with dummy fallback, some throws runtime error. > > It is hard to

Re: [Qemu-block] [Qemu-devel] [PATCH 1/7] util: Add UUID API

On Wed, Aug 03, 2016 at 10:36:40AM +0800, Fam Zheng wrote: > On Tue, 08/02 15:45, Paolo Bonzini wrote: > > > > > > - Original Message - > > > From: "Fam Zheng" > > > To: qemu-de...@nongnu.org > > > Cc: f...@redhat.com, berra...@redhat.com, pbonz...@redhat.com, > > >

[Qemu-block] [PULL 2/2] mirror: double performance of the bulk stage if the disc is full

igned-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Max Reitz <mre...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1468516741-82174-1-git-send-email-vsement...@virtuoz

[Qemu-block] [PULL 1/2] block/gluster: fix doc in the qapi schema and member name

wed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-Id: <1469198048-8535-1-git-send-email-prasanna.kale...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- qapi/block-core.json | 8 1 file changed, 4 insertions(+), 4 d

[Qemu-block] [PULL 0/2] Block patches for 2.7

The following changes since commit f49ee630d73729ecaeecf4b38a8df11bc613914d: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160726' into staging (2016-07-26 11:53:47 +0100) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git

Re: [Qemu-block] [PATCH v2] mirror: double performance of the bulk stage if the disc is full

> > CC: Kevin Wolf <kw...@redhat.com> > CC: Max Reitz <mre...@redhat.com> > CC: Jeff Cody <jc...@redhat.com> > CC: Eric Blake <ebl...@redhat.com> > --- > > v2: in case of s->buf_size larger than default use it to limit io_sectors > > bl

Re: [Qemu-block] [PATCH v2] mirror: double performance of the bulk stage if the disc is full

> > CC: Kevin Wolf <kw...@redhat.com> > CC: Max Reitz <mre...@redhat.com> > CC: Jeff Cody <jc...@redhat.com> > CC: Eric Blake <ebl...@redhat.com> > --- > > v2: in case of s->buf_size larger than default use it to limit io_sectors > > bl

Re: [Qemu-block] [Qemu-devel] [PULL 13/14] block/gluster: using new qapi schema

On Wed, Jul 20, 2016 at 03:24:41PM -0600, Eric Blake wrote: > On 07/19/2016 06:21 PM, Jeff Cody wrote: > > From: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> > > > > this patch adds 'GlusterServer' related schema in qapi/block-core.json > > >

[Qemu-block] [PULL 11/14] block/gluster: code cleanup

: Eric Blake <ebl...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1468947453-5433-3-git-send-email-prasanna.kale...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/gluster.c | 143 +--- 1 file

[Qemu-block] [PULL 14/14] block/gluster: add support for multiple gluster servers

{"type":"unix","socket":"/var/run/glusterd.socket"} ]}}' This patch gives a mechanism to provide all the server addresses, which are in replica set, so in case host1 is down VM can still boot from any of the active hosts. This is equivalent to the backu

[Qemu-block] [PULL 13/14] block/gluster: using new qapi schema

d-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Message-id: 1468947453-5433-5-git-send-email-prasanna.kale...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/gluster.c | 109 -

[Qemu-block] [PULL 09/14] mirror: fix request throttling in drive-mirror

ht == MAX_IN_FLIGHT is wrong. The patch adds the check and throttling into mirror_iteration and fixes the check in mirror_run() to be sure. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Max Reitz <mre...@redhat.com> Message-id: 1466598927-5990-1-git-send-email-.

[Qemu-block] [PULL 08/14] mirror: improve performance of mirroring of empty disk

<d...@openvz.org> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> Reviewed-by: Fam Zheng <f...@redhat.com> Message-id: 1468503209-19498-9-git-send-email-...@openvz.org CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Kevin Wolf <kw...@redhat.com> CC: M

[Qemu-block] [PULL 05/14] block: remove extra condition in bdrv_can_write_zeroes_with_unmap

t.com> CC: Max Reitz <mre...@redhat.com> CC: Jeff Cody <jc...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index d2dac3d..30d64e6 100644 --- a/block.c +++

[Qemu-block] [PULL 07/14] mirror: efficiently zero out target

Hajnoczi <stefa...@redhat.com> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre...@redhat.com> CC: Jeff Cody <jc...@redhat.com> CC: Eric Blake <ebl...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/mirror.c | 28 ++--

[Qemu-block] [PULL 06/14] mirror: optimize dirty bitmap filling in mirror_run a bit

Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: John Snow <js...@redhat.com> Reviewed-by: Fam Zheng <f...@redhat.com> Message-id: 1468503209-19498-7-git-send-email-...@openvz.org CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Kevin Wolf <kw...@redhat.com> CC: Max

[Qemu-block] [PULL 10/14] block/gluster: rename [server, volname, image] -> [host, volume, path]

ltiple servers. Therefore, rename the following options: 'server' -> 'host' 'image' -> 'path' 'volname' -> 'volume' Signed-off-by: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com&

[Qemu-block] [PULL 01/14] dirty-bitmap: operate with int64_t amount

<kw...@redhat.com> CC: Max Reitz <mre...@redhat.com> CC: Jeff Cody <jc...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/dirty-bitmap.c | 6 +++--- include/block/block_int.h| 2 +- include/block/dirty-bitmap.h | 4 ++-- 3 files changed, 6 in

[Qemu-block] [PULL 04/14] mirror: create mirror_dirty_init helper for mirror_run

Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Fam Zheng <f...@redhat.com> Message-id: 1468503209-19498-5-git-send-email-...@openvz.org CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre...@redhat.com> CC: Jeff

[Qemu-block] [PULL 02/14] mirror: make sectors_in_flight int64_t

;kw...@redhat.com> CC: Max Reitz <mre...@redhat.com> CC: Jeff Cody <jc...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index b1e633e..fbacee2 10064

<    4   5   6   7   8   9   10   11   12   >