qemu_get_current_aio_context() != qemu_get_aio_context();
}
Reviewed-by: Laurent Vivier
Le 12/05/2023 à 14:08, John Paul Adrian Glaubitz a écrit :
Hello Laurent!
On Fri, 2023-05-12 at 13:13 +0200, Laurent Vivier wrote:
This patch breaks something with LTP (20230127) test fchown05_16 on sid/sparc64:
tst_test.c:1558: TINFO: Timeout per run is 0h 00m 30s
fchown05.c:44: TPASS
by: Gregor Riepl
Tested-by: John Paul Adrian Glaubitz
Tested-by: Zach van Rijn
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1394
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Acked-by: Laurent Vivier
Message-Id: <20230327131910.78564-1-phi...@linaro.org>
Le 12/01/2023 à 13:00, Philippe Mathieu-Daudé a écrit :
Hi, can this reviewed patch get merged via a block tree?
I can take this via trivial.
Thanks,
Laurent
On 25/11/22 18:53, Philippe Mathieu-Daudé wrote:
The inlined nbd_readXX() functions call beXX_to_cpu(), themselves
declared in .
Le 22/09/2022 à 17:37, Kevin Wolf a écrit :
Am 19.09.2022 um 20:27 hat Philippe Mathieu-Daudé geschrieben:
Commit d1258dd0c8 ("qcow2: autoloading dirty bitmaps") added the
set_readonly_helper() GFunc handler, correctly casting the gpointer
user_data in both the g_slist_foreach() caller and the
CC:
John Snow (supporter:IDE)
qemu-block@nongnu.org (open list:IDE)
Le 28/05/2022 à 23:02, Lev Kujawski a écrit :
One method to enable PCI bus mastering for IDE controllers, often used
by x86 firmware, is to write 0x7 to the PCI command register. Neither
the PIIX3 specification nor actual
CC:
John Snow (supporter:IDE)
qemu-block@nongnu.org (open list:IDE)
Le 28/05/2022 à 23:02, Lev Kujawski a écrit :
Prior to this patch, cmd_exec_dev_diagnostic relied upon
ide_set_signature to clear the device register. While the
preservation of the drive bit by ide_set_signature is necessary
CC:
John Snow (supporter:IDE)
qemu-block@nongnu.org (open list:IDE)
Le 28/05/2022 à 23:02, Lev Kujawski a écrit :
Eliminates the remaining TODOs in hw/ide/piix.c by:
- Using pci_set_{size} functions to write the PIIX PCI configuration
space instead of manipulating it directly as an array;
Le 14/06/2022 à 12:40, Dr. David Alan Gilbert (git) a écrit :
From: "Dr. David Alan Gilbert"
Inspired by Julia Lawall's fixing of Linux
kernel comments, I looked at qemu, although I did it manually.
Signed-off-by: Dr. David Alan Gilbert
---
hw/intc/openpic.c| 2 +-
Le 14/06/2022 à 12:40, Dr. David Alan Gilbert (git) a écrit :
From: "Dr. David Alan Gilbert"
'namespace' is misspelled in a bunch of places.
Signed-off-by: Dr. David Alan Gilbert
---
hw/9pfs/9p-xattr-user.c | 8
hw/acpi/nvdimm.c| 2 +-
hw/nvme/ctrl.c | 2 +-
3
efine MODE_PAGE_ALLS0x3f
/* Not in Mt. Fuji, but in ATAPI 2.6 -- deprecated now in favor
* of MODE_PAGE_SENSE_POWER */
Reviewed-by: Laurent Vivier
t(ObjectClass *oc, void
*data)
mc->max_cpus = 1;
mc->block_default_type = IF_SCSI;
mc->default_ram_id = "m68k_mac.ram";
+compat_props_add(mc->compat_props, hw_compat_q800, hw_compat_q800_len);
}
static const TypeInfo q800_machine_typeinfo = {
Reviewed-by: Laurent Vivier
si-hd", "quirk_mode_page_apple_vendor", "on"},
+{ "scsi-cd", "quirk_mode_sense_rom_force_dbd", "on"},
};
static const size_t hw_compat_q800_len = G_N_ELEMENTS(hw_compat_q800);
Reviewed-by: Laurent Vivier
irk_mode_sense_rom_force_dbd", "on"},
+{ "scsi-cd", "vendor", "MATSHITA" },
+{ "scsi-cd", "product", "CD-ROM CR-8005" },
+{ "scsi-cd", "ver", "1.0k" },
};
static const size_t hw_compat_q800_len = G_N_ELEMENTS(hw_compat_q800);
Reviewed-by: Laurent Vivier
@@ -94,6 +94,7 @@ struct SCSIDiskState {
uint16_t port_index;
uint64_t max_unmap_size;
uint64_t max_io_size;
+uint32_t quirks;
QEMUBH *bh;
char *version;
char *serial;
Reviewed-by: Laurent Vivier
-hd", "vendor", " SEAGATE" },
+{ "scsi-hd", "product", " ST225N" },
+{ "scsi-hd", "ver", "1.0 " },
{ "scsi-cd", "quirk_mode_sense_rom_force_dbd", "on"},
};
static const size_t hw_compat_q800_len = G_N_ELEMENTS(hw_compat_q800);
Reviewed-by: Laurent Vivier
/scsi/scsi-disk.c | 4
hw/scsi/trace-events | 1 +
2 files changed, 5 insertions(+)
Reviewed-by: Laurent Vivier
est/fuzz-virtio-scsi-test.c | 8 ++--
tests/qtest/meson.build | 13 ++---
6 files changed, 22 insertions(+), 43 deletions(-)
Reviewed-by: Laurent Vivier
Le 07/03/2022 à 11:35, Marc-André Lureau a écrit :
Hi
On Mon, Mar 7, 2022 at 2:13 PM Laurent Vivier mailto:laur...@vivier.eu>> wrote:
Le 05/03/2022 à 20:17, Marc-André Lureau a écrit :
> On Sat, Mar 5, 2022 at 1:18 AM mailto:marcandre.lur...@redhat.com>> wrote:
concern.
Signed-off-by: Marc-André Lureau
Reviewed-by: Laurent Vivier
---
blockdev.c | 8
hw/rtc/m41t80.c| 6 +++---
hw/virtio/virtio-balloon.c | 9 +
qapi/qmp-event.c | 12 +---
qemu-img.c | 8
target
Le 04/03/2022 à 17:08, Laurent Vivier a écrit :
Le 04/03/2022 à 16:27, marcandre.lur...@redhat.com a écrit :
From: Marc-André Lureau
GLib g_get_real_time() is an alternative to gettimeofday().
For semihosting, a few bits are lost on POSIX host, but this shouldn't
be a big concern.
Signed
3 files changed, 29 deletions(-)
Reviewed-by: Laurent Vivier
Returns: Time in nanoseconds.
#
# Since: 1.5
##
{ 'command': 'guest-get-time',
'returns': 'int' }
Except this problem:
Reviewed-by: Laurent Vivier
Le 04/03/2022 à 16:54, Laurent Vivier a écrit :
Le 04/03/2022 à 16:27, marcandre.lur...@redhat.com a écrit :
From: Marc-André Lureau
glib provides a convenience helper to measure elapsed time. It isn't
subject to wall-clock time changes.
Note that this changes the initial OPENED time, which
Le 04/03/2022 à 16:27, marcandre.lur...@redhat.com a écrit :
From: Marc-André Lureau
glib provides a convenience helper to measure elapsed time. It isn't
subject to wall-clock time changes.
Note that this changes the initial OPENED time, which used to print the
current time.
Time is
-by: Laurent Vivier
Le 18/12/2021 à 12:19, Philippe Mathieu-Daudé a écrit :
This code is easier to review using the load/store API.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
v2: Fixed offset in megasas_setup_inquiry (rth)
---
hw/scsi/megasas.c | 17 +++--
1 file
Alex,
I've added this patch to my trivial patches branch, do you want I drop it?
Thanks,
Laurent
On 17/12/2021 12:10, Alex Bennée wrote:
Philippe Mathieu-Daudé writes:
On 12/16/21 15:11, Alex Bennée wrote:
Philippe Mathieu-Daudé writes:
When experimenting raising
Le 15/12/2021 à 17:54, Philippe Mathieu-Daudé a écrit :
Hi Laurent,
On 9/3/21 19:44, Philippe Mathieu-Daudé wrote:
This series provides the safely equivalent g_memdup2() wrapper,
and replace all g_memdup() calls by it.
Philippe Mathieu-Daudé (28):
hw/hyperv/vmbus: Remove unused
Le 03/09/2021 à 19:45, Philippe Mathieu-Daudé a écrit :
g_memdup() is insecure and as been deprecated in GLib 2.68.
QEMU provides the safely equivalent g_memdup2() wrapper.
Do not allow more g_memdup() calls in the repository, provide
a hint to use g_memdup2().
Signed-off-by: Philippe
Le 03/09/2021 à 19:45, Philippe Mathieu-Daudé a écrit :
Per
https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538
The old API took the size of the memory to duplicate as a guint,
whereas most memory functions take memory sizes as a gsize. This
made it easy
Le 03/09/2021 à 19:44, Philippe Mathieu-Daudé a écrit :
When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68
(Fedora 34 provides GLib 2.68.1) we get:
hw/virtio/virtio-crypto.c:245:24: error: 'g_memdup' is deprecated: Use
'g_memdup2' instead [-Werror,-Wdeprecated-declarations]
...
On 10/11/2021 17:17, Markus Armbruster wrote:
Laurent Vivier writes:
move them from block/qapi.c to qobject/qdict.c, qobject/qlist.c,
qobject/qobject.c
This is useful to debug qobjects
Signed-off-by: Laurent Vivier
I think qobject_to_json_pretty() is better suited to debugging, because
Add test cases to test several error cases that must be
generated by invalid failover configuration.
Add a combination of coldplug and hotplug test cases to be
sure the primary is correctly managed according the
presence or not of the STANDBY feature.
Signed-off-by: Laurent Vivier
---
tests
Scan the PCI devices to find bridge and set PCI_SECONDARY_BUS and
PCI_SUBORDINATE_BUS (algorithm from seabios)
Signed-off-by: Laurent Vivier
---
include/hw/pci/pci_bridge.h | 8 +++
tests/qtest/libqos/pci.c| 118
tests/qtest/libqos/pci.h| 1 +
3
move them from block/qapi.c to qobject/qdict.c, qobject/qlist.c,
qobject/qobject.c
This is useful to debug qobjects
Signed-off-by: Laurent Vivier
---
block/qapi.c | 82 +-
include/qapi/qmp/qdict.h | 2 +
include/qapi/qmp/qlist.h | 1
ind it are not
available
Laurent Vivier (3):
qdict: make available dump_qobject(), dump_qdict(), dump_qlist()
qtest/libqos: add a function to initialize secondary PCI buses
tests/qtest: add some tests for virtio-net failover
block/qapi.c | 82 +
include/hw/
On 27/10/2021 13:59, David Hildenbrand wrote:
On 27.10.21 13:41, Jonah Palmer wrote:
From: Laurent Vivier
Display feature names instead of bitmaps for host, guest, and
backend for VirtIODevice.
Display status names instead of bitmaps for VirtIODevice.
Display feature names instead
On 08/10/2021 15:34, Kevin Wolf wrote:
Instead of accessing the global QemuOptsList, which really belong to the
command line parser and shouldn't be accessed from devices, store a
pointer to the QemuOpts in a new VirtIONet field.
This is not the final state, but just an intermediate step to get
On 08/10/2021 15:34, Kevin Wolf wrote:
QDicts are both what QMP natively uses and what the keyval parser
produces. Going through QemuOpts isn't useful for either one, so switch
the main device creation function to QDicts. By sharing more code with
the -object/object-add code path, we can even
On 06/10/2021 12:53, Kevin Wolf wrote:
Am 06.10.2021 um 11:20 hat Laurent Vivier geschrieben:
On 06/10/2021 10:21, Juan Quintela wrote:
Kevin Wolf wrote:
Am 05.10.2021 um 17:52 hat Damien Hedde geschrieben:
Hi
Usage
-
The primary device can be hotplugged or be part of the startup
On 06/10/2021 10:21, Juan Quintela wrote:
Kevin Wolf wrote:
Am 05.10.2021 um 17:52 hat Damien Hedde geschrieben:
Hi
Usage
-
The primary device can be hotplugged or be part of the startup
configuration
-device virtio-net-pci,netdev=hostnet1,id=net1,
Le 05/05/2021 à 12:37, Daniel P. Berrangé a écrit :
> The GDateTime APIs provided by GLib avoid portability pitfalls, such
> as some platforms where 'struct timeval.tv_sec' field is still 'long'
> instead of 'time_t'. When combined with automatic cleanup, GDateTime
> often results in simpler code
Le 11/05/2021 à 12:41, Philippe Mathieu-Daudé a écrit :
> Trivial patches to keep VirtIOFeature arrays read-only
> (better safe than sorry).
>
> Philippe Mathieu-Daudé (3):
> hw/virtio: Pass virtio_feature_get_config_size() a const argument
> virtio-blk: Constify VirtIOFeature feature_sizes[]
simpler code too.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> linux-user/elfload.c | 36 +---
> 1 file changed, 9 insertions(+), 27 deletions(-)
>
Reviewed-by: Laurent Vivier
Le 25/04/2021 à 00:20, Philippe Mathieu-Daudé a écrit :
> The Microdrive Compact Flash can be plugged on a PCMCIA bus.
> Express the dependency using the 'depends on' Kconfig expression.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/ide/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Le 25/04/2021 à 00:20, Philippe Mathieu-Daudé a écrit :
> If the Kconfig 'PCMCIA' value is not selected, it is pointless
> to build the PCMCIA core components.
>
> (Currently only one machine of the ARM targets requires this).
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
>
Le 25/04/2021 à 00:20, Philippe Mathieu-Daudé a écrit :
> The Intel XScale PXA chipsets provide a PCMCIA controller,
> which expose a PCMCIA (IDE) bus. Express this dependency using
> the Kconfig 'select' expression.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/arm/Kconfig | 1 +
> 1
Mathieu-Daudé
Signed-off-by: Laurent Vivier
---
blockdev.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 5cc7c7effe9f..64da5350e3ad 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -969,11 +969,7 @@ DriveInfo *drive_new(QemuOpts *all_opts
This allows to cover the virtio tests with a 32bit big-endian
virtio-mmio machine.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Cornelia Huck
Signed-off-by: Laurent Vivier
---
tests/qemu-iotests/testenv.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/testenv.py b
will be respectively
"virtio-scsi-device", "virtio-scsi-ccw" or "virtio-scsi-pci".
This already exists for s390x and -ccw interfaces, add them
for m68k and MMIO (-device) interfaces.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Cornelia Huck
Signed-off-by: La
And ioeventfd are only available with virtio-scsi-pci or virtio-scsi-ccw,
use the alias but add a rule to require virtio-scsi-pci or virtio-scsi-ccw
for the tests that use iothreads.
Signed-off-by: Laurent Vivier
---
tests/qemu-iotests/127| 3 ++-
tests/qemu-iotests/256| 6
all virtio-*-pci and virtio-*-ccw to use virtio-*
instead and remove get_virtio_scsi_device().
This also enables virtio-mmio devices (virtio-*-device)
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Cornelia Huck
Signed-off-by: Laurent Vivier
---
tests/qemu
.out of test 051
Add a patch to update "-drive if=virtio"
Laurent Vivier (6):
qdev: define list of archs with virtio-pci or virtio-ccw
m68k: add the virtio devices aliases
blockdev: with -drive if=virtio, use generic virtio-blk
iotests: Revert "iotests: use -ccw on s39
This is used to define virtio-*-pci and virtio-*-ccw aliases
rather than substracting the CCW architecture from all the others.
Reviewed-by: Cornelia Huck
Signed-off-by: Laurent Vivier
---
include/sysemu/arch_init.h | 8 ++
softmmu/qdev-monitor.c | 53
Le 19/03/2021 à 15:46, Cornelia Huck a écrit :
> On Fri, 19 Mar 2021 14:25:34 +0100
> Laurent Vivier wrote:
>
>> Rather than checking if the machine is an s390x to use virtio-blk-ccw
>> instead of virtio-blk-pci, use the alias virtio-blk that is set to
>> the exp
Le 19/03/2021 à 15:23, Cornelia Huck a écrit :
> On Fri, 19 Mar 2021 14:51:59 +0100
> Laurent Vivier wrote:
>
>> Le 19/03/2021 à 14:36, Philippe Mathieu-Daudé a écrit :
>>> On 3/19/21 2:25 PM, Laurent Vivier wrote:
>>>> And ioeventfd are only available wit
Le 19/03/2021 à 14:36, Philippe Mathieu-Daudé a écrit :
> On 3/19/21 2:25 PM, Laurent Vivier wrote:
>> And ioeventfd are only available with virtio-scsi-pci or virtio-scsi-ccw,
>> use the alias but add a rule to require virtio-scsi-pci or virtio-scsi-ccw
>> for the tes
This allows to cover the virtio tests with a 32bit big-endian
virtio-mmio machine.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Laurent Vivier
---
tests/qemu-iotests/testenv.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests
Rather than checking if the machine is an s390x to use virtio-blk-ccw
instead of virtio-blk-pci, use the alias virtio-blk that is set to
the expected target.
This also enables the use of virtio-blk-device for targets without
PCI or CCW.
Signed-off-by: Laurent Vivier
---
blockdev.c | 6
all virtio-*-pci and virtio-*-ccw to use virtio-*
instead. This also enables virtio-mmio devices (virtio-*-device)
Signed-off-by: Laurent Vivier
cc: Cornelia Huck
---
tests/qemu-iotests/040| 2 +-
tests/qemu-iotests/051| 12 +---
tests/qemu-iotests/051.out| 2
This is used to define virtio-*-pci and virtio-*-ccw aliases
rather than substracting the CCW architecture from all the others.
Signed-off-by: Laurent Vivier
---
include/sysemu/arch_init.h | 7 +
softmmu/qdev-monitor.c | 53 ++
2 files changed, 32
will be respectively
"virtio-scsi-device", "virtio-scsi-ccw" or "virtio-scsi-pci".
This already exists for s390x and -ccw interfaces, add them
for m68k and MMIO (-device) interfaces.
Signed-off-by: Laurent Vivier
---
include/sysemu/arch_init.h | 1 +
softmmu/qdev-mo
And ioeventfd are only available with virtio-scsi-pci or virtio-scsi-ccw,
use the alias but add a rule to require virtio-scsi-pci or virtio-scsi-ccw
for the tests that use iothreads.
Signed-off-by: Laurent Vivier
---
tests/qemu-iotests/127| 3 ++-
tests/qemu-iotests/256| 6
irtio"
Laurent Vivier (6):
qdev: define list of archs with virtio-pci or virtio-ccw
m68k: add the virtio devices aliases
blockdev: with -drive if=virtio, use generic virtio-blk
iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182"
iotests: test m68k with the vi
Le 19/03/2021 à 12:43, Cornelia Huck a écrit :
> On Thu, 18 Mar 2021 23:39:05 +0100
> Laurent Vivier wrote:
>
>> Commit f1d5516ab583 introduces a test in some iotests to check if
>> the machine is a s390-ssw-virtio and to select virtio-*-ccw rather
>
> s/ssw/c
Le 19/03/2021 à 12:36, Cornelia Huck a écrit :
> On Thu, 18 Mar 2021 23:39:04 +0100
> Laurent Vivier wrote:
>
>> Similarly to 5f629d943cb0 ("s390x: fix s390 virtio aliases"),
>> define the virtio aliases.
>>
>> This allows to start machin
Le 19/03/2021 à 12:27, Cornelia Huck a écrit :
> On Fri, 19 Mar 2021 12:06:43 +0100
> Paolo Bonzini wrote:
>
>> On 18/03/21 23:39, Laurent Vivier wrote:
>>> And ioeventfd are only available with virtio-scsi-pci, so don't use the
>>> alias
>>>
Le 19/03/2021 à 10:29, Paolo Bonzini a écrit :
> On 19/03/21 10:20, Max Reitz wrote:
>> On 19.03.21 07:32, Thomas Huth wrote:
>>> On 18/03/2021 18.28, Max Reitz wrote:
>>> [...]
From that it follows that I don’t see much use in testing specific
devices either. Say there’s
a
Le 19/03/2021 à 10:20, Max Reitz a écrit :
> On 19.03.21 07:32, Thomas Huth wrote:
>> On 18/03/2021 18.28, Max Reitz wrote:
>> [...]
>>> From that it follows that I don’t see much use in testing specific devices
>>> either. Say there’s
>>> a platform that provides both virtio-pci and
And ioeventfd are only available with virtio-scsi-pci, so don't use the alias
and add a rule to require virtio-scsi-pci for the tests that use iothreads.
Signed-off-by: Laurent Vivier
---
tests/qemu-iotests/127| 4 ++--
tests/qemu-iotests/256| 2 ++
tests/qemu-iotests/iotests.py
This allows to cover the virtio tests with a 32bit big-endian
virtio-mmio machine.
Signed-off-by: Laurent Vivier
---
tests/qemu-iotests/testenv.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py
index 1fbec854c1f7..6d27712617a3
all virtio-*-pci and virtio-*-ccw to use virtio-*
instead.
Signed-off-by: Laurent Vivier
cc: Cornelia Huck
---
blockdev.c| 6 +-
tests/qemu-iotests/040| 2 +-
tests/qemu-iotests/051| 12 +---
tests/qemu-iotests/068| 4 +---
tests/qemu
the aliases that
are a cleaner approach.
Laurent Vivier (4):
m68k: add the virtio devices aliases
iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182"
iotests: test m68k with the virt machine
iotests: iothreads need ioeventfd
blockdev.c
"virtio-scsi-device", "virtio-scsi-ccw" or "virtio-scsi-pci".
This already exists for s390x and -ccw interfaces, adds them
for m68k and MMIO (-device) interfaces.
Signed-off-by: Laurent Vivier
---
softmmu/qdev-monitor.c | 46 +++-
Le 11/01/2021 à 16:20, Philippe Mathieu-Daudé a écrit :
> The 'running' argument from VMChangeStateHandler does not require
> other value than 0 / 1. Make it a plain boolean.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/sysemu/runstate.h | 10 --
> target/arm/kvm_arm.h
Le 11/01/2021 à 16:20, Philippe Mathieu-Daudé a écrit :
> runstate_check() returns a boolean. runstate_is_running()
> returns what runstate_check() returns, also a boolean.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/sysemu/runstate.h | 2 +-
> softmmu/runstate.c| 2 +-
>
Le 03/03/2021 à 19:46, Philippe Mathieu-Daudé a écrit :
> Follow the inclusive terminology from the "Conscious Language in your
> Open Source Projects" guidelines [*] and replace the words "whitelist"
> appropriately.
>
> [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md
Le 03/03/2021 à 19:46, Philippe Mathieu-Daudé a écrit :
> Follow the inclusive terminology from the "Conscious Language in your
> Open Source Projects" guidelines [*] and replace the word "blacklist"
> appropriately.
>
> [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md
>
Le 03/03/2021 à 19:46, Philippe Mathieu-Daudé a écrit :
> Follow the inclusive terminology from the "Conscious Language in your
> Open Source Projects" guidelines [*] and replace the word "blacklist"
> appropriately.
>
> [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md
>
Le 03/03/2021 à 19:46, Philippe Mathieu-Daudé a écrit :
> Follow the inclusive terminology from the "Conscious Language in your
> Open Source Projects" guidelines [*] and replace the words "whitelist"
> appropriately.
>
> [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md
Le 09/03/2021 à 20:48, Thomas Huth a écrit :
> On 09/03/2021 18.41, Wainer dos Santos Moschetta wrote:
>> Hi,
>>
>> Any issue that prevent this of being queued?
>
> Maybe it's just not clear who should take the patch ... CC:-ing qemu-trivial
> and qemu-block now,
> since I think it could go
Le 11/10/2020 à 21:50, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/scsi/megasas.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
> index e24c12d7eed..d57402c9b09 100644
> ---
fn) << 8;
> s->sas_addr |= PCI_FUNC(dev->devfn);
> }
> if (!s->hba_serial) {
>
Reviewed-by: Laurent Vivier
Le 12/01/2021 à 12:29, Philippe Mathieu-Daudé a écrit :
> Replace fprintf() calls by qemu_log_mask(LOG_GUEST_ERROR).
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/ide/ahci.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
>
On 11/11/2020 16:56, Stefan Hajnoczi wrote:
> SystemTap's dtrace(1) prints the following warning when it encounters
> long long arguments:
>
> Warning: /usr/bin/dtrace:trace/trace-dtrace-hw_virtio.dtrace:76: syntax
> error near:
> probe vhost_vdpa_dev_start
>
> Warning: Proceeding as if
Le 13/12/2020 à 20:01, Peter Maydell a écrit :
> On Sun, 13 Dec 2020 at 17:21, Laurent Vivier wrote:
>>
>> Le 16/10/2020 à 18:52, Philippe Mathieu-Daudé a écrit :
>>> Cc'ing qemu-trivial@ since this patch is reviewed.
>>>
>>> On 10/15/20 8:12 PM,
Le 16/10/2020 à 18:52, Philippe Mathieu-Daudé a écrit :
> Cc'ing qemu-trivial@ since this patch is reviewed.
>
> On 10/15/20 8:12 PM, Philippe Mathieu-Daudé wrote:
>> ping^2...
>>
>> On 10/1/20 7:31 PM, Philippe Mathieu-Daudé wrote:
>>> ping qemu-block or qemu-arm?
>>>
>>> On 9/15/20 7:16 PM,
Le 24/10/2020 à 07:34, Thomas Huth a écrit :
> On 19/10/2020 18.36, Maxim Levitsky wrote:
>> Signed-off-by: Maxim Levitsky
>> ---
>> include/hw/qdev-core.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
>> index
ctober 14, 2020 11:56 PM
>> To: Chenqun (kuhn) ; qemu-de...@nongnu.org;
>> qemu-triv...@nongnu.org
>> Cc: mre...@redhat.com; stefa...@redhat.com; f...@euphon.net;
>> ebl...@redhat.com; js...@redhat.com; quint...@redhat.com;
>> dgilb...@redhat.com; Zhanghailiang ;
>
Le 13/10/2020 à 03:34, Li Qiang a écrit :
> Laurent Vivier 于2020年10月12日周一 下午11:33写道：
>>
>> Le 10/10/2020 à 13:07, Chen Qun a écrit :
>>> This if statement judgment is redundant and it will cause a warning:
>>>
>>> migration/block-dirty-bitmap.c:1
Le 10/10/2020 à 13:07, Chen Qun a écrit :
> This if statement judgment is redundant and it will cause a warning:
>
> migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> g_strlcpy(s->bitmap_name,
Le 09/10/2020 à 21:09, Elena Afanasova a écrit :
> Spotted by PVS-Studio
>
> Signed-off-by: Elena Afanasova
> ---
> block/blkdebug.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/blkdebug.c b/block/blkdebug.c
> index eecbf3e5c4..54da719dd1 100644
> --- a/block/blkdebug.c
> +++
Le 05/10/2020 à 08:26, Christian Borntraeger a écrit :
> On 30.09.20 18:36, Fam Zheng wrote:
>> On Wed, 2020-09-30 at 17:58 +0200, Christian Borntraeger wrote:
>>> Fedora 32 gcc 10 seems to give false positives:
>>>
>>> Compiling C object libblock.fa.p/block_vmdk.c.o
>>> ../block/vmdk.c: In
Le 02/10/2020 à 09:57, Philippe Mathieu-Daudé a écrit :
> As the 'timestamp' variable is declared as a 48-bit bitfield,
> we do not need to wrap the sum result.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/block/nvme.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
>
Le 15/09/2020 à 19:12, Yonggang Luo a écrit :
> Signed-off-by: Yonggang Luo
> Reviewed-by: Daniel P. Berrangé
> ---
> meson.build | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 690723b470..23cb1b8742 100644
> --- a/meson.build
> +++
Le 22/08/2020 à 20:09, Philippe Mathieu-Daudé a écrit :
> Most uses of qemu_hexdump() do not take an array of char
> as input, forcing use of cast. Since we can use this
> helper to dump any kind of buffer, use a pointer to void
> argument instead.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
Le 11/09/2020 à 16:35, Philippe Mathieu-Daudé a écrit :
> Hi Laurent,
>
> On 8/22/20 8:09 PM, Philippe Mathieu-Daudé wrote:
>> - Pass const void* buffer
>> - Reorder arguments
>>
>> Supersedes: <20200822150457.1322519-1-f4...@amsat.org>
>>
>> Philippe Mathieu-Daudé (2):
>> util/hexdump: Convert
Le 22/08/2020 à 20:09, Philippe Mathieu-Daudé a écrit :
> qemu_hexdump()'s pointer to the buffer and length of the
> buffer are closely related arguments but are widely separated
> in the argument list order (also, the format of
> function prototypes is usually to have the FILE* argument
> coming
Le 14/08/2020 à 10:28, Philippe Mathieu-Daudé a écrit :
> Trivial block patches:
> - Fix a typo
> - Replace '1 << 30' by '1 * GiB' in null-co
> - Replace 512 by BDRV_SECTOR_SIZE when appropriate.
>
> Philippe Mathieu-Daudé (7):
> block/null: Make more explicit the driver default size is 1GiB
>
1 - 100 of 570 matches
Mail list logo
