Re: [RFC PATCH 6/9] tests/acceptance: Use image_expand() in test_arm_orangepi_bionic_20_08

2021-08-05 Thread Niek Linnenbank
inflate it > Only a few typos here: download -> downloads inflate -> inflates Otherwise, looks fine: Reviewed-by: Niek Linnenbank +# to 1036 MiB, but 1/ the underlying filesystem is 1552 MiB, > +# 2/ U-Boot loads TFTP filenames from the last sector below &

Re: [PATCH 5/9] tests/acceptance: Use image_expand() in test_arm_orangepi_uboot_netbsd9

2021-08-05 Thread Niek Linnenbank
d by the NetBSD > installer: > > +# https://wiki.netbsd.org/ports/evbarm/raspberry_pi/#index7h2 > > +# "A 2 GB card is the smallest workable size that the > installation > > +# image will fit on." > > Do you agree with this comment and t

Re: [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'

2021-07-04 Thread Niek Linnenbank
for test_arm_orangepi_uboot_netbsd9: Reviewed-by: Niek Linnenbank Op za 3 jul. 2021 10:44 schreef Philippe Mathieu-Daudé : > On Sat, Jul 3, 2021 at 10:41 AM Philippe Mathieu-Daudé > wrote: > > > > CC'ing NetBSD maintainers. > > > > On 6/23/21 8:00 PM

Re: [PATCH] hw/sd: Zero out function selection fields before being populated

2020-10-27 Thread Niek Linnenbank
32_t > arg) > > sd->data[12] = 0x80;/* Supported group 1 functions */ > > sd->data[13] = 0x03; > > > > +memset(>data[14], 0, 3); > > for (i = 0; i < 6; i ++) { > > new_func = (arg >> (i * 4)) & 0x0f; > > if (mode && new_func != 0x0f) > > > > Thanks, series applied to sd-next tree. > > -- Niek Linnenbank

Re: [PATCH] hw/sd: Fix 2 GiB card CSD register values

2020-10-25 Thread Niek Linnenbank
as expected. I'm not an expert on SD internals so perhaps Philippe would like to give more detailed review comments on the code itself. So for the Orange Pi PC machine & acceptance tests: Tested-by: Niek Linnenbank Regards, Niek > > Fixes: 6d2d4069c47e ("hw/sd: Correct the m

Re: [RFC PATCH 4/4] tests/acceptance: Test U-Boot/Linux from Armbian 20.08 on Orange Pi PC

2020-10-25 Thread Niek Linnenbank
Hi Bin, On Sun, Oct 25, 2020 at 3:17 AM Bin Meng wrote: > Hi Niek, > > On Sun, Oct 25, 2020 at 5:01 AM Niek Linnenbank > wrote: > > > > Hi Philippe, > > > > I have ran this series with the new Armbian 20.08 test and noticed this > failure: > > >

Re: [RFC PATCH 1/4] Revert "hw/sd: Fix incorrect populated function switch status data structure"

2020-10-24 Thread Niek Linnenbank
Tested-by: Niek Linnenbank Reviewed-by: Niek Linnenbank On Fri, Oct 23, 2020 at 3:18 PM Philippe Mathieu-Daudé wrote: > This reverts commit b638627c723a8d0d2bb73489bc6bf9ff09b8d53a. > > Currently booting U-Boot on the Orange Pi PC we get: > > console: U-Boot SPL 2020.04-armbi

Re: [RFC PATCH 2/4] tests/acceptance: Allow running Orange Pi test using cached artifacts

2020-10-24 Thread Niek Linnenbank
As a temporary solution this should be fine, until we have decided on which reliable storage location to use. Reviewed-by: Niek Linnenbank On Fri, Oct 23, 2020 at 3:18 PM Philippe Mathieu-Daudé wrote: > Unfortunately the Armbian 19.11.3 image has been removed from the > dl.armbian.co

Re: [RFC PATCH 4/4] tests/acceptance: Test U-Boot/Linux from Armbian 20.08 on Orange Pi PC

2020-10-24 Thread Niek Linnenbank
_pow2ceil_expand(image_path) > + > +self.do_test_arm_orangepi_uboot_armbian(image_path) > + > @skipUnless(os.getenv('AVOCADO_ALLOW_LARGE_STORAGE'), 'storage > limited') > def test_arm_orangepi_uboot_netbsd9(self): > """ > -- > 2.26.2 > > -- Niek Linnenbank

Re: [PULL 22/23] hw/sd: Fix incorrect populated function switch status data structure

2020-10-22 Thread Niek Linnenbank
Hi Bin, Philippe, If im correct the acceptance tests for orange pi need to be run with a flag ARMBIAN_ARTIFACTS_CACHED set that explicitly allows them to be run using the armbian mirror. So if you pass that flag on the same command that Philippe gave, the rests should run. I have a follow up

Re: [PATCH] hw/sd/allwinner-sdhost: Use AddressSpace for DMA transfers

2020-08-17 Thread Niek Linnenbank
OrangePi_pc_debian_stretch_server_linux5.3.5_v1.0.img. Tested-by: Niek Linnenbank Reviewed-by: Niek Linnenbank Regards, Niek On Fri, Aug 14, 2020 at 1:01 PM Philippe Mathieu-Daudé wrote: > Allow the device to execute the DMA transfers in a different > AddressSpace. > > The A10 and H3 SoC keep using the system_me

Re: [PATCH 1/2] tests/acceptance/boot_linux: Truncate SD card image to power of 2

2020-07-12 Thread Niek Linnenbank
rnelTest): # Extend image, to avoid that NetBSD thinks the partition # inside the image is larger than device size itself -f_out.seek(0, 2) -f_out.seek(64 * 1024 * 1024, 1) -f_out.write(bytearray([0x00])) -- Niek Linnenbank

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-09 Thread Niek Linnenbank
On Thu, Jul 9, 2020 at 4:15 PM Peter Maydell wrote: > On Thu, 9 Jul 2020 at 14:56, Philippe Mathieu-Daudé > wrote: > > > > On 7/7/20 10:29 PM, Niek Linnenbank wrote: > > > So I manually copy & pasted the change into hw/sd/sd.c to test it. > > > It lo

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-09 Thread Niek Linnenbank
On Thu, Jul 9, 2020 at 3:56 PM Philippe Mathieu-Daudé wrote: > On 7/7/20 10:29 PM, Niek Linnenbank wrote: > > Hi Philippe, > > > > Just tried out your patch on latest master, and I noticed I couldn't > > apply it without getting this error: > > > > $

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-07 Thread Niek Linnenbank
gt; @@ -2130,11 +2131,26 @@ static void sd_realize(DeviceState *dev, Error > **errp) > >>> } > >>> > >>> if (sd->blk) { > >>> +int64_t blk_size; > >>> + > >>> if (blk_is_read_only(sd->blk)) { > >>>