On Tue, 2024-09-24 at 15:24 +0200, Thomas Huth wrote:
> According to https://marc.info/?l=fedora-devel-list&m=171934833215726
> the GlusterFS development effectively ended. Thus mark it as
> deprecated
> in QEMU, so we can remove it in a future release if the project does
> not gain momentum again.
nal schedule
> - Feb 4th 2023: Software Defined Storage dev room
>
> Talk proposals will be reviewed by a steering committee:
> - Niels de Vos (Red Hat)
> - Jan Fajerski (Red Hat)
> - TBD
>
> We also welcome additional volunteers to help with making this devroom a
> success.
&
On Thu, Feb 20, 2020 at 10:17:00AM +0100, Stefan Ring wrote:
> This list seems to be used for patches only. I will re-post to qemu-discuss.
Do include integrat...@gluster.org as well. There should be people on
that list that can help with debugging from the Gluster side.
Niels
On Mon, Feb 17, 2020 at 06:03:40AM -0600, Eric Blake wrote:
> On 2/17/20 2:06 AM, Niels de Vos wrote:
> > On Fri, Jan 31, 2020 at 11:44:26AM -0600, Eric Blake wrote:
> > > block.c already defaults to 0 if we don't provide a callback; there's
> > > no need
On Fri, Jan 31, 2020 at 11:44:31AM -0600, Eric Blake wrote:
> Since gluster already copies file-posix for lseek usage in block
> status, it also makes sense to copy it for learning if the image
> currently reads as all zeroes.
>
> Signed-off-by: Eric Blake
> ---
> block/gluster.c | 20 ++
On Fri, Jan 31, 2020 at 11:44:26AM -0600, Eric Blake wrote:
> block.c already defaults to 0 if we don't provide a callback; there's
> no need to write a callback that always fails.
>
> Signed-off-by: Eric Blake
Reviewed-by: Niels de Vos
> ---
> block/gluster.c |
s for SDS clusters
** Important dates:
- Nov 24th 2019: submission deadline for talk proposals
- Dec 15th 2019: announcement of the final schedule
- Feb 2nd 2020: Software Defined Storage dev room
Talk proposals will be reviewed by a steering committee:
- Niels de Vos (OpenShift Container St
On Wed, Aug 21, 2019 at 07:04:17PM +0200, Max Reitz wrote:
> On 17.08.19 23:21, Nir Soffer wrote:
> > Implement alignment probing similar to file-posix, by reading from the
> > first 4k of the image.
> >
> > Before this change, provisioning a VM on storage with sector size of
> > 4096 bytes would
On Fri, Jun 14, 2019 at 09:24:27AM +0200, Philippe Mathieu-Daudé wrote:
> It is pointless and confusing to have GLUSTERFS variables
> in config-host.mak when glusterfs is not usable.
>
> Signed-off-by: Philippe Mathieu-Daudé
Looks good to me, thanks.
Reviewed-by:
/patch/10613297/#22409943
>
> Signed-off-by: Thomas Huth
Thanks, this counts for the Gluster part:
Reviewed-by: Niels de Vos
> ---
> MAINTAINERS | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 66ddbda9c9..899a4cd5
n the Gluster volumes. For VM images shards
of 256MB are recommeneded (I think). When sharding is enabled, the
writes will be limited to that size as well, hence the problem is not
noticed on (most) production deployments.
Reviewed-by: Niels de Vos
>
>
> block/gluster.c | 16
On Mon, Mar 11, 2019 at 12:10:06PM +0100, Kevin Wolf wrote:
> Am 09.03.2019 um 10:40 hat Niels de Vos geschrieben:
> > On Fri, Mar 08, 2019 at 02:11:51PM +0100, Kevin Wolf wrote:
> > > Am 05.03.2019 um 16:46 hat Niels de Vos geschrieben:
> > > > Gluster 6 is
On Fri, Mar 08, 2019 at 02:11:51PM +0100, Kevin Wolf wrote:
> Am 05.03.2019 um 16:46 hat Niels de Vos geschrieben:
> > Gluster 6 is currently available as release candidate. There have been a
> > few changes to libgfapi.so that need to be adapted by consuming projects
> > like
hanged and needs to be
adopted.
Signed-off-by: Prasanna Kumar Kalever
Signed-off-by: Niels de Vos
--
v5: pass default NULL arguments through macro (Daniel P. Berrangé)
v4: rebase to current master branch
v3: define old backwards compatible glfs_ftruncate() macro, from Eric Blake
v2: do a compil
following two changes should be sufficient to consume Gluster 6 once
it is released. These have been tested on CentOS-7 with Gluster 5 and
Gluster 6 (minimal manual qemu-img tests only).
This v2 post contains changes suggested by Daniel P. Berrangé and Kevin
Wolf. Thanks!
Cheers,
Niels
Niels de Vos
includes these new arguments.
With an additional detection in ./configure, the new arguments can
conditionally get included in the glfs_io_cbk handler.
Signed-off-by: Niels de Vos
--
v2: correct typo in commit message (Kevin Wolf)
---
block/gluster.c | 6 +-
configure | 24
On Tue, Mar 05, 2019 at 11:29:34AM +0100, Kevin Wolf wrote:
> Am 04.03.2019 um 17:21 hat Niels de Vos geschrieben:
> > The glfs_*_async() functions do a callback once finished. This callback
> > has changed its arguments, pre- and post-stat structures have been
> > added. This
On Mon, Mar 04, 2019 at 04:41:44PM +, Daniel P. Berrangé wrote:
> On Mon, Mar 04, 2019 at 05:21:02PM +0100, Niels de Vos wrote:
> > From: Prasanna Kumar Kalever
> >
> > New versions of Glusters libgfapi.so have an updated glfs_ftruncate()
> > function that retu
following two changes should be sufficient to consume Gluster 6 once
it is released. These have been tested on CentOS-7 with Gluster 5 and
Gluster 6 (minimal manual qemu-img tests only).
Cheers,
Niels
Niels de Vos (2):
block/gluster: Handle changed glfs_ftruncate signature
gluster: the glfs_io_cbk
includes these new arguments.
With an additional detection in ./configure, the new arguments can
conditionally get included in the glfs_io_cbk handler.
Signed-off-by: Niels de Vos
---
block/gluster.c | 6 +-
configure | 24
2 files changed, 29 insertions(+), 1
hanged and needs to be
adopted.
Signed-off-by: Prasanna Kumar Kalever
Signed-off-by: Niels de Vos
---
v4: rebase to current master branch
v3: define old backwards compatible glfs_ftruncate() macro, from Eric Blake
v2: do a compile check as suggested by Eric Blake
---
block/glus
On Tue, Jan 08, 2019 at 08:12:16PM +0100, Kevin Wolf wrote:
> Am 08.01.2019 um 18:18 hat Markus Armbruster geschrieben:
> > This patch series got stuck.
> >
> > Markus Armbruster writes:
> >
> > > Fam Zheng writes:
> > >
> > >> On Tue, 09/25 07:00, Markus Armbruster wrote:
> > >>> Jeff Cody wr
R) | O_RDONLY;
> +s->fd = glfs_open(s->glfs, gconf->path, open_flags);
> +ret = s->fd ? 0 : -errno;
> + }
> }
>
> s->supports_seek_data = qemu_gluster_test_seek(s->fd);
> --
Looks good to me, thanks.
Reviewed-by: Niels de Vos
On Fri, Oct 12, 2018 at 12:31:21PM -0500, Eric Blake wrote:
> On 10/12/18 6:55 AM, Kevin Wolf wrote:
> > If read-only=off, but auto-read-only=on is given, open the file
> > read-write if we have the permissions, but instead of erroring out for
> > read-only files, just degrade to read-only.
> >
>
On Tue, Sep 25, 2018 at 01:32:04PM +0800, Fam Zheng wrote:
> On Tue, 09/25 07:00, Markus Armbruster wrote:
> > Jeff Cody writes:
> >
> > > I'll not be involved in day-to-day qemu development. Remove
> > > myself as maintainer from the remainder of the network block drivers
> > > (and vhdx), and
On Tue, Jul 31, 2018 at 03:51:22PM -0400, Jeff Cody wrote:
> On Tue, Jul 31, 2018 at 11:18:02AM +0200, Niels de Vos wrote:
> > On Mon, Jul 30, 2018 at 03:27:29PM -0400, Jeff Cody wrote:
> > > On Mon, Jul 30, 2018 at 10:07:27AM -0500, Eric Blake wrote:
> > > > On 07/
On Mon, Jul 30, 2018 at 03:27:29PM -0400, Jeff Cody wrote:
> On Mon, Jul 30, 2018 at 10:07:27AM -0500, Eric Blake wrote:
> > On 07/28/2018 02:50 AM, Niels de Vos wrote:
> > >>
> > >>Part of me wishes that libgfapi had just created a new function
> > >
On Sat, Jul 28, 2018 at 12:18:39AM -0400, Jeff Cody wrote:
> On Fri, Jul 27, 2018 at 08:24:05AM -0500, Eric Blake wrote:
> > On 07/27/2018 03:19 AM, Niels de Vos wrote:
> > >From: Prasanna Kumar Kalever
> > >
> > >New versions of Glusters libgfapi.so have an up
hanged and needs to be
adopted.
Signed-off-by: Prasanna Kumar Kalever
Signed-off-by: Niels de Vos
---
v2: do a compile check as suggested by Eric Blake
v3: define old backwards compatible glfs_ftruncate() macro, from Eric Blake
---
block/gluster.c | 11 +--
configure | 18 +++
hanged and needs to be
adopted.
Signed-off-by: Prasanna Kumar Kalever
Signed-off-by: Niels de Vos
--
v2: do a compile check as suggested by Eric Blake
---
block/gluster.c | 15 +--
configure | 18 ++
2 files changed, 31 insertions(+), 2 deletions(-)
diff --g
ent.
Both glfs_zerofill() and glfs_fallocate() have been introduced with
GlusterFS 3.5.0 (pkg-config glusterfs-api = 6). A #define for the
availability of glfs_fallocate() has been added to ./configure.
Reported-by: Satheesaran Sundaramoorthi
URL: https://bugzilla.redhat.com/1450759
Signed-off-by: Niels de V
On Wed, May 24, 2017 at 04:50:03PM -0400, Jeff Cody wrote:
> On Wed, May 24, 2017 at 11:02:02AM +0200, Niels de Vos wrote:
> > On Tue, May 23, 2017 at 01:27:50PM -0400, Jeff Cody wrote:
> > > On current released versions of glusterfs, glfs_lseek() will sometimes
> > >
#x27;ll treat it like H4. Unfortunately some
> + * versions of libgfapi will return offs < start, so an assert here
> + * will unneccesarily abort QEMU. */
> +return -EIO;
> +}
>
> if (offs > start) {
> /*
> --
> 2.9.3
>
You might want to explain the problem a little different in the commit
message. It is fine too if you think it would become too detailed, my
explanation is in the archives now in any case.
Reviewed-by: Niels de Vos
On Thu, May 18, 2017 at 01:54:36PM -0400, Jeff Cody wrote:
> On Thu, May 18, 2017 at 11:54:22AM +0200, Niels de Vos wrote:
> > Add missing support for "preallocation=falloc" to the Gluster block
> > driver. This change bases its logic on that of block/file-po
On Thu, May 18, 2017 at 09:30:53AM -0500, Eric Blake wrote:
> On 05/18/2017 04:54 AM, Niels de Vos wrote:
> > Add missing support for "preallocation=falloc" to the Gluster block
> > driver. This change bases its logic on that of block/file-posix.c and
> > remove
ent.
Both glfs_zerofill() and glfs_fallocate() have been introduced with
GlusterFS 3.5.0 (pkg-config glusterfs-api = 6). A #define for the
availability of glfs_fallocate() has been added to ./configure.
Reported-by: Satheesaran Sundaramoorthi
URL: https://bugzilla.redhat.com/1450759
Signed-off-by: Niels de V
On Tue, May 16, 2017 at 11:42:37AM -0400, Jeff Cody wrote:
> On Mon, May 15, 2017 at 09:11:36PM +0200, Niels de Vos wrote:
> > Add missing support for "preallocation=falloc" to the Gluster block
> > driver. This change bases its logic on that of block/file-po
orthi
URL: https://bugzilla.redhat.com/1450759
Signed-off-by: Niels de Vos
---
block/gluster.c | 61 +++--
1 file changed, 38 insertions(+), 23 deletions(-)
diff --git a/block/gluster.c b/block/gluster.c
index 7c76cd0..566166f 100644
-
-
> 1 file changed, 23 insertions(+), 24 deletions(-)
Looks good to me, thanks.
Reviewed-by: Niels de Vos
> diff --git a/block/gluster.c b/block/gluster.c
> index 1d4e2f7..3f252c6 100644
> --- a/block/gluster.c
> +++ b/block/gluster.c
> @@ -1332,24 +1332,24 @@ exit
On Fri, Mar 03, 2017 at 09:35:16AM +0100, Markus Armbruster wrote:
> Niels de Vos writes:
>
> > On Fri, Mar 03, 2017 at 08:38:45AM +0100, Markus Armbruster wrote:
> >> Niels de Vos writes:
> >>
> >> > On Thu, Mar 02, 2017 at 10:44:03PM +0100, Markus A
On Fri, Mar 03, 2017 at 08:38:45AM +0100, Markus Armbruster wrote:
> Niels de Vos writes:
>
> > On Thu, Mar 02, 2017 at 10:44:03PM +0100, Markus Armbruster wrote:
> >> To reproduce, run
> >>
> >> $ valgrind qemu-system-x86_64 --nodefaults -S --drive
On Thu, Mar 02, 2017 at 10:44:03PM +0100, Markus Armbruster wrote:
> To reproduce, run
>
> $ valgrind qemu-system-x86_64 --nodefaults -S --drive
> driver=gluster,volume=testvol,path=/a/b/c,server.0.type=xxx
>
> Signed-off-by: Markus Armbruster
> ---
> block/gluster.c | 28 ++---
; (int)port);
> }
> --
> 2.7.4
Instead of the strings for "unix" and "tcp", I would have liked
#define's. Unfortunately it seems that these are not available in public
headers :-/
If this is easier to understand, I don't have any objections.
Reviewed-by: Niels de Vos
error_setg(&local_err, QERR_INVALID_PARAMETER_VALUE,
> - GLUSTER_OPT_TYPE, "tcp or unix");
> +if (local_err) {
> +error_append_hint(&local_err,
> + "Parameter '%s' may be 'tcp' or 'unix'\n",
> + GLUSTER_OPT_TYPE);
> error_append_hint(&local_err, GERR_INDEX_HINT, i);
> goto out;
> }
> --
> 2.7.4
>
>
Looks good to me.
Reviewed-by: Niels de Vos
On Wed, Jul 20, 2016 at 10:30:25PM +1000, Dave Chinner wrote:
> On Wed, Jul 20, 2016 at 05:19:37AM -0400, Paolo Bonzini wrote:
> > Adding ext4 and XFS guys (Lukas and Dave respectively). As a quick recap,
> > the
> > issue here is the semantics of FIEMAP and SEEK_HOLE/SEEK_DATA, which we use
> >
On Fri, Apr 15, 2016 at 11:27:56AM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng
> ---
> block/gluster.c | 30 ++
> 1 file changed, 30 insertions(+)
The Gluster changes look good to me.
Reviewed-by: Niels de Vos
>
> diff --git a/block
2 - Alert
> 3 - Critical
> 4 - Error
> 5 - Warning
> 6 - Notice
> 7 - Info
> 8 - Debug
> 9 - Trace
>
> (From: glusterfs/logging.h)
>
> Signed-off-by: Jeff Cody
Thanks, this is something I wanted to get don
ror being EPERM (i.e. 1). Instead, set
> it to the proper error result.
>
> Signed-off-by: Jeff Cody
Looks good to me.
Reviewed-by: Niels de Vos
> ---
> block/gluster.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/gluster.c b/block/gl
On Wed, Apr 06, 2016 at 08:44:18AM -0400, Jeff Cody wrote:
> On Wed, Apr 06, 2016 at 01:02:16PM +0200, Kevin Wolf wrote:
> > [ Adding some CCs ]
> >
> > Am 06.04.2016 um 05:29 hat Jeff Cody geschrieben:
> > > Upon receiving an I/O error after an fsync, by default gluster will
> > > dump its cache.
On Tue, Mar 15, 2016 at 03:52:02PM -0400, Jeff Cody wrote:
> On Tue, Mar 15, 2016 at 03:50:17PM -0400, Jeff Cody wrote:
> > On Thu, Mar 10, 2016 at 07:38:00PM +0100, Niels de Vos wrote:
> > > GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes
> > > i
GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes
it possible to detect sparse areas in files.
Signed-off-by: Niels de Vos
---
Tested by compiling and running "qemu-img map gluster://..." with a
build of the current master branch of glusterfs. Using a Fedora cloud
On Wed, Mar 09, 2016 at 10:46:02AM -0500, Jeff Cody wrote:
> On Wed, Mar 09, 2016 at 01:30:14PM +0100, Niels de Vos wrote:
> > GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes
> > it possible to detect sparse areas in files.
> >
> >
GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes
it possible to detect sparse areas in files.
Signed-off-by: Niels de Vos
---
Tested by compiling and running "qemu-img map gluster://..." with a
build of the current master branch of glusterfs. Using a Fedora cloud
On Tue, Mar 08, 2016 at 01:53:26PM +0100, Kevin Wolf wrote:
> Am 08.03.2016 um 05:21 hat Niels de Vos geschrieben:
> > On Mon, Mar 07, 2016 at 01:27:38PM -0500, Jeff Cody wrote:
> > > On Mon, Mar 07, 2016 at 07:04:15PM +0100, Niels de Vos wrote:
> > > > GlusterFS 3.8
On Tue, Mar 08, 2016 at 07:33:26AM -0500, Jeff Cody wrote:
> On Tue, Mar 08, 2016 at 05:21:48AM +0100, Niels de Vos wrote:
> > On Mon, Mar 07, 2016 at 01:27:38PM -0500, Jeff Cody wrote:
> > > On Mon, Mar 07, 2016 at 07:04:15PM +0100, Niels de Vos wrote:
> > > > Glus
On Mon, Mar 07, 2016 at 01:27:38PM -0500, Jeff Cody wrote:
> On Mon, Mar 07, 2016 at 07:04:15PM +0100, Niels de Vos wrote:
> > GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes
> > it possible to detect sparse areas in files.
> >
> >
GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes
it possible to detect sparse areas in files.
Signed-off-by: Niels de Vos
--
Tested by compiling and running "qemu-img map gluster://..." with a
build of the current master branch of glusterfs. Using a Fedora
cloud
57 matches
Mail list logo
