[Qemu-block] Limiting coroutine stack usage

2018-02-20 Thread Peter Lieven
Hi, I remember we discussed a long time ago to limit the stack usage of all functions that are executed in a coroutine context to a very low value to be able to safely limit the coroutine stack size as well. I checked through all functions in block/, migration/ and nbd/ and there are only

[Qemu-block] [PATCH] migration: do not transfer ram during bulk storage migration

2018-02-20 Thread Peter Lieven
this patch makes the bulk phase of a block migration to take place before we start transferring ram. As the bulk block migration can take a long time its pointless to transfer ram during that phase. Signed-off-by: Peter Lieven <p...@kamp.de> --- migration/ram.c | 8 1 file chan

Re: [Qemu-block] Block Migration and CPU throttling

2018-02-07 Thread Peter Lieven
> Am 07.02.2018 um 19:29 schrieb Dr. David Alan Gilbert <dgilb...@redhat.com>: > > * Peter Lieven (p...@kamp.de) wrote: >> Am 12.12.2017 um 18:05 schrieb Dr. David Alan Gilbert: >>> * Peter Lieven (p...@kamp.de) wrote: >>>> Am 21.09.2017 um 14:36 sch

Re: [Qemu-block] Block Migration and CPU throttling

2018-02-06 Thread Peter Lieven
Am 12.12.2017 um 18:05 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 21.09.2017 um 14:36 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 19.09.2017 um 16:41 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 19.09.2017

Re: [Qemu-block] [PATCH] block/iscsi: fix initialization of iTask in iscsi_co_get_block_status

2018-01-08 Thread Peter Lieven
Am 08.01.2018 um 16:55 schrieb Eric Blake: On 01/08/2018 09:27 AM, Peter Lieven wrote: in case of unaligned requests or on a target that does not support block provisioning we leave iTask uninitialized and check iTask.task for NULL later. Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8 Cc

[Qemu-block] [PATCH] block/iscsi: fix initialization of iTask in iscsi_co_get_block_status

2018-01-08 Thread Peter Lieven
in case of unaligned requests or on a target that does not support block provisioning we leave iTask uninitialized and check iTask.task for NULL later. Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8 Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven <p...@kamp.de> Reviewed-by: Eric

Re: [Qemu-block] [PATCH] scsi: Don't check uninitialized local variable

2018-01-08 Thread Peter Lieven
csilun); -    iscsi_co_init_iscsitask(iscsilun, ); qemu_mutex_lock(>mutex);  retry: if (iscsi_get_lba_status_task(iscsilun->iscsi, iscsilun->lun, Peter -- Mit freundlichen Grüßen Peter Lieven ... KAMP Netzwerkdienste GmbH Vesti

Re: [Qemu-block] [PATCH V5 01/10] specs/qcow2: add compress format extension

2017-12-13 Thread Peter Lieven
Am 18.09.2017 um 12:50 schrieb Kevin Wolf: > Am 18.09.2017 um 12:09 hat Peter Lieven geschrieben: >> Am 11.09.2017 um 16:22 schrieb Kevin Wolf: >>> Am 25.07.2017 um 16:41 hat Peter Lieven geschrieben: >>>> Signed-off-by: Peter Lieven <p...@kamp.de> >>

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block/iscsi: only report an iSCSI Failure if we don't handle it gracefully

2017-12-13 Thread Peter Lieven
Am 08.12.2017 um 18:03 schrieb Eric Blake: > On 12/08/2017 10:14 AM, Peter Lieven wrote: >> Am 08.12.2017 um 16:11 schrieb Eric Blake: >>> On 12/08/2017 05:51 AM, Peter Lieven wrote: >>>> we currently report an "iSCSI Failure" in iscsi_co_gene

Re: [Qemu-block] Block Migration and CPU throttling

2017-12-13 Thread Peter Lieven
Am 12.12.2017 um 18:05 schrieb Dr. David Alan Gilbert: > * Peter Lieven (p...@kamp.de) wrote: >> Am 21.09.2017 um 14:36 schrieb Dr. David Alan Gilbert: >>> * Peter Lieven (p...@kamp.de) wrote: >>>> Am 19.09.2017 um 16:41 schrieb Dr. David Alan Gilbert: >>>

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block/iscsi: only report an iSCSI Failure if we don't handle it gracefully

2017-12-08 Thread Peter Lieven
Am 08.12.2017 um 16:11 schrieb Eric Blake: > On 12/08/2017 05:51 AM, Peter Lieven wrote: >> we currently report an "iSCSI Failure" in iscsi_co_generic_cb if the task >> hasn't completed with SCSI_STATUS_GOOD. However, we expect a failure in >> some cases and handle

[Qemu-block] [PATCH 1/2] block/iscsi: dont leave allocmap in an invalid state on UNMAP failure

2017-12-08 Thread Peter Lieven
we forgot to set the allocmap to invalid if an UNMAP call fails. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven <p...@kamp.de> --- block/iscsi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 4683f3b..c532ec7

[Qemu-block] [PATCH 2/2] block/iscsi: only report an iSCSI Failure if we don't handle it gracefully

2017-12-08 Thread Peter Lieven
n the logs can be quite misleading. While we are at it improve the logging to reveal which operation failed at what LBA. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/iscsi.c | 43 --- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git

[Qemu-block] [PATCH 0/2] iscsi fixes

2017-12-08 Thread Peter Lieven
fix a bug leaving the allocmap in a wrong state if an UNMAP fails and improve the logging of iscsi failures. Peter Lieven (2): block/iscsi: dont leave allocmap in an invalid state on UNMAP failure block/iscsi: only report an iSCSI Failure if we don't handle it gracefully block/iscsi.c

[Qemu-block] [PATCH for-2.11] block/nfs: fix nfs_client_open for filesize greater than 1TB

2017-11-27 Thread Peter Lieven
DIV_ROUND_UP(st.st_size, BDRV_SECTOR_SIZE) was overflowing ret (int) if st.st_size is greater than 1TB. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven <p...@kamp.de> --- block/nfs.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/block/nfs.c b/block/nfs.c

Re: [Qemu-block] [Qemu-devel] Clean Block Driver Shutdown

2017-11-07 Thread Peter Lieven
Am 07.11.2017 um 12:02 schrieb Markus Armbruster: Peter Lieven <p...@kamp.de> writes: Am 07.11.2017 um 11:22 schrieb Markus Armbruster: Stefan Hajnoczi <stefa...@gmail.com> writes: On Tue, Oct 17, 2017 at 01:46:25PM +0200, Kevin Wolf wrote: Am 17.10.2017 um 12:33 hat

Re: [Qemu-block] [Qemu-devel] Clean Block Driver Shutdown

2017-11-07 Thread Peter Lieven
Am 07.11.2017 um 11:22 schrieb Markus Armbruster: Stefan Hajnoczi <stefa...@gmail.com> writes: On Tue, Oct 17, 2017 at 01:46:25PM +0200, Kevin Wolf wrote: Am 17.10.2017 um 12:33 hat Peter Lieven geschrieben: I noticed that Qemu quits at several points with an exit() if the su

Re: [Qemu-block] Clean Block Driver Shutdown

2017-10-17 Thread Peter Lieven
Am 17.10.2017 um 13:46 schrieb Kevin Wolf: Am 17.10.2017 um 12:33 hat Peter Lieven geschrieben: I noticed that Qemu quits at several points with an exit() if the supplied parameters in the commandline are incorrect. This at some stages happens after there have already been connections

[Qemu-block] Clean Block Driver Shutdown

2017-10-17 Thread Peter Lieven
Hi, I noticed that Qemu quits at several points with an exit() if the supplied parameters in the commandline are incorrect. This at some stages happens after there have already been connections to storage backends established. These connections are not cleanly shut down in this case. For posix

Re: [Qemu-block] Block Migration and CPU throttling

2017-10-12 Thread Peter Lieven
Am 21.09.2017 um 14:36 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 19.09.2017 um 16:41 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 19.09.2017 um 16:38 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi, I just

Re: [Qemu-block] Block Migration and CPU throttling

2017-09-21 Thread Peter Lieven
Am 21.09.2017 um 14:36 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 19.09.2017 um 16:41 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 19.09.2017 um 16:38 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi, I just

Re: [Qemu-block] Block Migration and CPU throttling

2017-09-20 Thread Peter Lieven
Am 19.09.2017 um 16:41 schrieb Paolo Bonzini: > On 19/09/2017 15:36, Peter Lieven wrote: >> Hi, >> >> I just noticed that CPU throttling and Block Migration don't work >> together very well. >> During block migration the throttling heuristic detects that we >&g

Re: [Qemu-block] Block Migration and CPU throttling

2017-09-20 Thread Peter Lieven
Am 19.09.2017 um 16:41 schrieb Dr. David Alan Gilbert: > * Peter Lieven (p...@kamp.de) wrote: >> Am 19.09.2017 um 16:38 schrieb Dr. David Alan Gilbert: >>> * Peter Lieven (p...@kamp.de) wrote: >>>> Hi, >>>> >>>> I just noticed that CPU throttl

Re: [Qemu-block] Block Migration and CPU throttling

2017-09-19 Thread Peter Lieven
Am 19.09.2017 um 16:38 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi, I just noticed that CPU throttling and Block Migration don't work together very well. During block migration the throttling heuristic detects that we obviously make no progress in ram transfer

[Qemu-block] Block Migration and CPU throttling

2017-09-19 Thread Peter Lieven
Hi, I just noticed that CPU throttling and Block Migration don't work together very well. During block migration the throttling heuristic detects that we obviously make no progress in ram transfer. But the reason is the running block migration and not a too high dirty pages rate. The result

Re: [Qemu-block] [PATCH V5 01/10] specs/qcow2: add compress format extension

2017-09-18 Thread Peter Lieven
Am 11.09.2017 um 16:22 schrieb Kevin Wolf: Am 25.07.2017 um 16:41 hat Peter Lieven geschrieben: Signed-off-by: Peter Lieven <p...@kamp.de> --- docs/interop/qcow2.txt | 51 +- roms/ipxe | 2 +- 2 files changed, 51 insertions

Re: [Qemu-block] [PATCH for-2.10] block/nfs: fix mutex assertion in nfs_file_close()

2017-08-08 Thread Peter Lieven
urn ret; } -qemu_mutex_init(>mutex); + bs->total_sectors = ret; ret = 0; return ret; Reviewed-by: Peter Lieven <p...@kamp.de> Also CC'ing qemu-stable as this affects 2.9.0 as well. Peter

Re: [Qemu-block] [PATCH V5 10/10] block/qcow2: add compress info to image specific info

2017-08-03 Thread Peter Lieven
Am 25.07.2017 um 23:55 schrieb Eric Blake: > On 07/25/2017 09:41 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven <p...@kamp.de> >> --- >> block/qcow2.c| 7 +++ >> qapi/block-core.json | 6 +- >> 2 files changed, 12 insertions(+

Re: [Qemu-block] [PATCH V5 10/10] block/qcow2: add compress info to image specific info

2017-07-26 Thread Peter Lieven
Am 25.07.2017 um 23:55 schrieb Eric Blake: > On 07/25/2017 09:41 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven <p...@kamp.de> >> --- >> block/qcow2.c| 7 +++ >> qapi/block-core.json | 6 +- >> 2 files changed, 12 insertions(+

Re: [Qemu-block] [PATCH V5 01/10] specs/qcow2: add compress format extension

2017-07-25 Thread Peter Lieven
Am 25.07.2017 um 17:03 schrieb Eric Blake: > On 07/25/2017 09:41 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven <p...@kamp.de> >> --- >> docs/interop/qcow2.txt | 51 >> +- >> roms/ipxe |

[Qemu-block] [PATCH V5 04/10] qemu-img: add documentation for compress settings

2017-07-25 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- qemu-img.texi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi index 72dabd6..3612c59 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -676,6 +676,32 @@ file which is COW and ha

[Qemu-block] [PATCH V5 08/10] block/qcow2: start using the compress format extension

2017-07-25 Thread Peter Lieven
we now pass the parameters to the zlib compressor if the extension is present and use the old default values if the extension is absent. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2-cluster.c | 58 ++- block/qcow2.c

[Qemu-block] [PATCH V5 07/10] block/qcow2: optimize qcow2_co_pwritev_compressed

2017-07-25 Thread Peter Lieven
if we specify exactly one iov of s->cluster_size bytes we can avoid the bounce buffer. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index ffe609d..a12b3

[Qemu-block] [PATCH V5 05/10] block/qcow2: read and write the compress format extension

2017-07-25 Thread Peter Lieven
we now read the extension on open and write it on update, but do not yet use it. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 92 +++ block/qcow2.h | 21 ++ 2 files changed, 108 insertions(+), 5 del

[Qemu-block] [PATCH V5 10/10] block/qcow2: add compress info to image specific info

2017-07-25 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c| 7 +++ qapi/block-core.json | 6 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index 0e9c2b8..7e03877 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -3968,6 +3

[Qemu-block] [PATCH V5 09/10] block/qcow2: add lzo compress format

2017-07-25 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2-cluster.c | 15 +++ block/qcow2.c | 25 - configure | 2 +- docs/interop/qcow2.txt | 2 ++ qapi/block-core.json | 15 --- qemu-img.texi | 1 + 6

[Qemu-block] [PATCH V5 01/10] specs/qcow2: add compress format extension

2017-07-25 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- docs/interop/qcow2.txt | 51 +- roms/ipxe | 2 +- 2 files changed, 51 insertions(+), 2 deletions(-) diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt index d7fdb1f..d

[Qemu-block] [PATCH V5 00/10] add Qcow2 compress format extension

2017-07-25 Thread Peter Lieven
header extensions - added missing lzo_init and fixed compress overhead for lzo Peter Lieven (10): specs/qcow2: add compress format extension qapi/block-core: add Qcow2Compress parameters block/qcow2: parse compress create options qemu-img: add documentation for compress settings

[Qemu-block] [PATCH V5 03/10] block/qcow2: parse compress create options

2017-07-25 Thread Peter Lieven
this adds parsing and validation for the compress create options. They are only validated but not yet used. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 86 +-- include/block/block_int.h | 39 +++-- 2

[Qemu-block] [PATCH V5 06/10] block/qcow2: simplify ret usage in qcow2_create

2017-07-25 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 7fd52e1..ffe609d 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -3031,7 +3031,7 @@ static int qcow2_create

[Qemu-block] [PATCH V5 02/10] qapi/block-core: add Qcow2Compress parameters

2017-07-25 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- qapi/block-core.json | 40 1 file changed, 40 insertions(+) diff --git a/qapi/block-core.json b/qapi/block-core.json index 833c602..f652206 100644 --- a/qapi/block-core.json +++ b/qapi/block-cor

Re: [Qemu-block] [PATCH V4 01/10] specs/qcow2: add compress format extension

2017-07-20 Thread Peter Lieven
Am 20.07.2017 um 20:31 schrieb Eric Blake: > On 07/20/2017 11:26 AM, Peter Lieven wrote: >>> I haven't yet checked your code implementation to see where you are >>> setting window sizes, to know if window size is something that should be >>> a tunable in the file

Re: [Qemu-block] [PATCH V4 10/10] block/qcow2: add compress info to image specific info

2017-07-20 Thread Peter Lieven
Am 20.07.2017 um 18:05 schrieb Eric Blake: > On 07/20/2017 09:20 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven <p...@kamp.de> >> --- >> block/qcow2.c| 9 + >> qapi/block-core.json | 6 +- >> 2 files changed, 14 insertions(+)

Re: [Qemu-block] [PATCH V4 09/10] block/qcow2: add lzo compress format

2017-07-20 Thread Peter Lieven
Am 20.07.2017 um 18:03 schrieb Eric Blake: > On 07/20/2017 09:20 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven <p...@kamp.de> >> --- >> block/qcow2-cluster.c | 15 +++ >> block/qcow2.c | 42 +++-

Re: [Qemu-block] [PATCH V4 08/10] block/qcow2: start using the compress format extension

2017-07-20 Thread Peter Lieven
Am 20.07.2017 um 18:00 schrieb Eric Blake: > On 07/20/2017 09:20 AM, Peter Lieven wrote: >> we now pass the parameters to the zlib compressor if the >> extension is present and use the old default values if >> the extension is absent. >> >> Signed-o

Re: [Qemu-block] [PATCH V4 01/10] specs/qcow2: add compress format extension

2017-07-20 Thread Peter Lieven
Am 20.07.2017 um 17:52 schrieb Eric Blake: > On 07/20/2017 09:20 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven <p...@kamp.de> >> --- >> docs/interop/qcow2.txt | 43 ++- >> 1 file changed, 42 insertions(+), 1 dele

[Qemu-block] [PATCH V4 07/10] block/qcow2: optimize qcow2_co_pwritev_compressed

2017-07-20 Thread Peter Lieven
if we specify exactly one iov of s->cluster_size bytes we can avoid the bounce buffer. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 67e48e1..978e8

[Qemu-block] [PATCH V4 10/10] block/qcow2: add compress info to image specific info

2017-07-20 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c| 9 + qapi/block-core.json | 6 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index 0ba5977..59cf3b3 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -

[Qemu-block] [PATCH V4 03/10] block/qcow2: parse compress create options

2017-07-20 Thread Peter Lieven
this adds parsing and validation for the compress create options. They are only validated but not yet used. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 53 +-- include/block/block_int.h | 2 ++ 2 files chang

[Qemu-block] [PATCH V4 05/10] block/qcow2: read and write the compress format extension

2017-07-20 Thread Peter Lieven
we now read the extension on open and write it on update, but do not yet use it. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 94 +++ block/qcow2.h | 21 + 2 files changed, 105 insertions(+), 10 del

[Qemu-block] [PATCH V4 09/10] block/qcow2: add lzo compress format

2017-07-20 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2-cluster.c | 15 +++ block/qcow2.c | 42 +++--- configure | 2 +- qapi/block-core.json | 14 -- qemu-img.texi | 1 + 5 files changed, 64 inse

[Qemu-block] [PATCH V4 06/10] block/qcow2: simplify ret usage in qcow2_create

2017-07-20 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 1dff87e..67e48e1 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -2996,7 +2996,7 @@ static int qcow2_create

[Qemu-block] [PATCH V4 01/10] specs/qcow2: add compress format extension

2017-07-20 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- docs/interop/qcow2.txt | 43 ++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt index d7fdb1f..ef5abb2 100644 --- a/docs/interop/qcow2.txt

[Qemu-block] [PATCH V4 08/10] block/qcow2: start using the compress format extension

2017-07-20 Thread Peter Lieven
we now pass the parameters to the zlib compressor if the extension is present and use the old default values if the extension is absent. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2-cluster.c | 58 ++- block/qcow2.c

[Qemu-block] [PATCH V4 02/10] qapi/block-core: add Qcow2Compress parameters

2017-07-20 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- qapi/block-core.json | 38 ++ 1 file changed, 38 insertions(+) diff --git a/qapi/block-core.json b/qapi/block-core.json index ff8e2ba..95e5393 100644 --- a/qapi/block-core.json +++ b/qapi/block-cor

[Qemu-block] [PATCH V4 00/10] add Qcow2 compress format extension

2017-07-20 Thread Peter Lieven
ing lzo_init and fixed compress overhead for lzo Peter Lieven (10): specs/qcow2: add compress format extension qapi/block-core: add Qcow2Compress parameters block/qcow2: parse compress create options qemu-img: add documentation for compress settings block/qcow2: read and write the com

[Qemu-block] [PATCH V4 04/10] qemu-img: add documentation for compress settings

2017-07-20 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- qemu-img.texi | 20 1 file changed, 20 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi index 72dabd6..fcc4c1d 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -676,6 +676,26 @@ file which is COW and has data

Re: [Qemu-block] [PATCH V3 1/9] specs/qcow2: add compress format extension

2017-07-14 Thread Peter Lieven
Am 14.07.2017 um 16:52 schrieb Eric Blake: > On 07/14/2017 04:56 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven <p...@kamp.de> >> --- >> docs/interop/qcow2.txt | 35 ++- >> 1 file changed, 34 insertions(+), 1 deletion(-

[Qemu-block] [PATCH V3 6/9] block/qcow2: simplify ret usage in qcow2_create

2017-07-14 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 1dd2a48..04b03de 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -2996,7 +2996,7 @@ static int qcow2_create

[Qemu-block] [PATCH V3 4/9] qemu-img: add documentation for compress settings

2017-07-14 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- qemu-img.texi | 20 1 file changed, 20 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi index f11f603..79b0182 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -669,6 +669,26 @@ file which is COW and has data

[Qemu-block] [PATCH V3 7/9] block/qcow2: optimize qcow2_co_pwritev_compressed

2017-07-14 Thread Peter Lieven
if we specify exactly one iov of s->cluster_size bytes we can avoid the bounce buffer. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 04b03de..ecb4b

[Qemu-block] [PATCH V3 1/9] specs/qcow2: add compress format extension

2017-07-14 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- docs/interop/qcow2.txt | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt index d7fdb1f..c2d3dab 100644 --- a/docs/interop/qcow2.txt +++

[Qemu-block] [PATCH V3 3/9] block/qcow2: parse compress create options

2017-07-14 Thread Peter Lieven
this adds parsing and validation for the compress create options. They are only validated but not yet used. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 53 +-- include/block/block_int.h | 2 ++ 2 files chang

[Qemu-block] [PATCH V3 0/9] add Qcow2 compress format extension

2017-07-14 Thread Peter Lieven
ved extra reservations for header extensions - added missing lzo_init and fixed compress overhead for lzo Peter Lieven (9): specs/qcow2: add compress format extension qapi/block-core: add Qcow2Compress parameters block/qcow2: parse compress create options qemu-img: add documentation for compress

[Qemu-block] [PATCH V3 5/9] block/qcow2: read and write the compress format extension

2017-07-14 Thread Peter Lieven
we now read the extension on open and write it on update, but do not yet use it. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 94 +++ block/qcow2.h | 21 + 2 files changed, 105 insertions(+), 10 del

[Qemu-block] [PATCH V3 9/9] block/qcow2: add lzo compress format

2017-07-14 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2-cluster.c | 15 +++ block/qcow2.c | 42 +++--- configure | 2 +- qapi/block-core.json | 14 -- qemu-img.texi | 1 + 5 files changed, 64 inse

[Qemu-block] [PATCH V3 2/9] qapi/block-core: add Qcow2Compress parameters

2017-07-14 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- qapi/block-core.json | 38 ++ 1 file changed, 38 insertions(+) diff --git a/qapi/block-core.json b/qapi/block-core.json index c437aa5..d6703a2 100644 --- a/qapi/block-core.json +++ b/qapi/block-cor

[Qemu-block] [PATCH V3 8/9] block/qcow2: start using the compress format extension

2017-07-14 Thread Peter Lieven
we now pass the parameters to the zlib compressor if the extension is present and use the old default values if the extension is absent. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2-cluster.c | 58 ++- block/qcow2.c

Re: [Qemu-block] [PATCH V2 5/8] block/qcow2: read and write the compress format extension

2017-07-13 Thread Peter Lieven
Am 13.07.2017 um 17:17 schrieb Daniel P. Berrange: On Thu, Jul 13, 2017 at 05:13:23PM +0200, Peter Lieven wrote: Am 13.07.2017 um 17:06 schrieb Daniel P. Berrange: On Thu, Jul 13, 2017 at 05:02:51PM +0200, Peter Lieven wrote: Am 13.07.2017 um 17:01 schrieb Daniel P. Berrange: On Thu, Jul 13

Re: [Qemu-block] [PATCH V2 5/8] block/qcow2: read and write the compress format extension

2017-07-13 Thread Peter Lieven
Am 13.07.2017 um 17:06 schrieb Daniel P. Berrange: On Thu, Jul 13, 2017 at 05:02:51PM +0200, Peter Lieven wrote: Am 13.07.2017 um 17:01 schrieb Daniel P. Berrange: On Thu, Jul 13, 2017 at 05:00:39PM +0200, Peter Lieven wrote: Am 13.07.2017 um 16:58 schrieb Daniel P. Berrange: On Thu, Jul 13

Re: [Qemu-block] [PATCH V2 5/8] block/qcow2: read and write the compress format extension

2017-07-13 Thread Peter Lieven
Am 13.07.2017 um 17:01 schrieb Daniel P. Berrange: On Thu, Jul 13, 2017 at 05:00:39PM +0200, Peter Lieven wrote: Am 13.07.2017 um 16:58 schrieb Daniel P. Berrange: On Thu, Jul 13, 2017 at 04:18:13PM +0200, Peter Lieven wrote: Okay, so it has to be a mix of QAPI parsing and manual parameter

Re: [Qemu-block] [PATCH V2 5/8] block/qcow2: read and write the compress format extension

2017-07-13 Thread Peter Lieven
Am 13.07.2017 um 16:58 schrieb Daniel P. Berrange: On Thu, Jul 13, 2017 at 04:18:13PM +0200, Peter Lieven wrote: Okay, so it has to be a mix of QAPI parsing and manual parameter checking, right? Yeah. It does feel like a valid RFE for QAPI to add a permitted range to 'int' types though, which

Re: [Qemu-block] [PATCH V2 5/8] block/qcow2: read and write the compress format extension

2017-07-13 Thread Peter Lieven
Am 13.07.2017 um 16:07 schrieb Daniel P. Berrange: On Thu, Jul 13, 2017 at 04:03:47PM +0200, Peter Lieven wrote: Am 13.07.2017 um 16:00 schrieb Daniel P. Berrange: On Thu, Jul 13, 2017 at 03:49:09PM +0200, Peter Lieven wrote: Am 13.07.2017 um 11:21 schrieb Daniel P. Berrange: On Thu, Jul 13

Re: [Qemu-block] [PATCH V2 5/8] block/qcow2: read and write the compress format extension

2017-07-13 Thread Peter Lieven
Am 13.07.2017 um 16:00 schrieb Daniel P. Berrange: On Thu, Jul 13, 2017 at 03:49:09PM +0200, Peter Lieven wrote: Am 13.07.2017 um 11:21 schrieb Daniel P. Berrange: On Thu, Jul 13, 2017 at 10:44:53AM +0200, Peter Lieven wrote: Am 10.07.2017 um 15:55 schrieb Daniel P. Berrange: On Mon, Jul 10

Re: [Qemu-block] [PATCH V2 5/8] block/qcow2: read and write the compress format extension

2017-07-13 Thread Peter Lieven
Am 13.07.2017 um 11:21 schrieb Daniel P. Berrange: On Thu, Jul 13, 2017 at 10:44:53AM +0200, Peter Lieven wrote: Am 10.07.2017 um 15:55 schrieb Daniel P. Berrange: On Mon, Jul 10, 2017 at 03:52:18PM +0200, Kevin Wolf wrote: Am 10.07.2017 um 15:44 hat Daniel P. Berrange geschrieben: On Mon

Re: [Qemu-block] [PATCH V2 2/8] qapi: add compress parameters to Qcow2 Blockdev options

2017-07-13 Thread Peter Lieven
Am 10.07.2017 um 15:30 schrieb Kevin Wolf: Am 10.07.2017 um 15:24 hat Peter Lieven geschrieben: Am 10.07.2017 um 15:10 schrieb Kevin Wolf: Am 29.06.2017 um 12:57 hat Peter Lieven geschrieben: Signed-off-by: Peter Lieven <p...@kamp.de> --- qapi/block-core.jso

Re: [Qemu-block] [PATCH V2 5/8] block/qcow2: read and write the compress format extension

2017-07-13 Thread Peter Lieven
Am 10.07.2017 um 15:55 schrieb Daniel P. Berrange: On Mon, Jul 10, 2017 at 03:52:18PM +0200, Kevin Wolf wrote: Am 10.07.2017 um 15:44 hat Daniel P. Berrange geschrieben: On Mon, Jul 10, 2017 at 03:34:59PM +0200, Kevin Wolf wrote: Am 10.07.2017 um 15:29 hat Peter Lieven geschrieben: Am

Re: [Qemu-block] [PATCH V2 5/8] block/qcow2: read and write the compress format extension

2017-07-10 Thread Peter Lieven
Am 10.07.2017 um 15:44 schrieb Daniel P. Berrange: On Mon, Jul 10, 2017 at 03:34:59PM +0200, Kevin Wolf wrote: Am 10.07.2017 um 15:29 hat Peter Lieven geschrieben: Am 10.07.2017 um 15:25 schrieb Kevin Wolf: Am 29.06.2017 um 12:57 hat Peter Lieven geschrieben: we now read the extension

Re: [Qemu-block] [PATCH V2 2/8] qapi: add compress parameters to Qcow2 Blockdev options

2017-07-10 Thread Peter Lieven
Am 10.07.2017 um 15:30 schrieb Kevin Wolf: Am 10.07.2017 um 15:24 hat Peter Lieven geschrieben: Am 10.07.2017 um 15:10 schrieb Kevin Wolf: Am 29.06.2017 um 12:57 hat Peter Lieven geschrieben: Signed-off-by: Peter Lieven <p...@kamp.de> --- qapi/block-core.jso

Re: [Qemu-block] [PATCH V2 5/8] block/qcow2: read and write the compress format extension

2017-07-10 Thread Peter Lieven
Am 10.07.2017 um 15:25 schrieb Kevin Wolf: Am 29.06.2017 um 12:57 hat Peter Lieven geschrieben: we now read the extension on open and write it on update, but do not yet use it. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c

Re: [Qemu-block] [PATCH V2 1/8] docs: add compress format extension to qcow2 spec

2017-07-10 Thread Peter Lieven
Am 10.07.2017 um 14:58 schrieb Kevin Wolf: Am 29.06.2017 um 12:57 hat Peter Lieven geschrieben: Signed-off-by: Peter Lieven <p...@kamp.de> --- docs/interop/qcow2.txt | 43 ++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/docs/i

Re: [Qemu-block] [PATCH 1/4] block/qcow2: add compression_algorithm create option

2017-07-03 Thread Peter Lieven
Am 27.06.2017 um 17:04 schrieb Eric Blake: > On 06/27/2017 09:49 AM, Peter Lieven wrote: > >> Before I continue, can you please give feedback on the following spec >> change: >> >> diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt >> index 80cdfd0..

[Qemu-block] [PATCH V2 4/8] qemu-img: add documentation for compress settings

2017-06-29 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- qemu-img.texi | 21 + 1 file changed, 21 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi index 5b925ec..430f0b9 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -621,6 +621,27 @@ file which is COW and has data

[Qemu-block] [PATCH V2 6/8] block/qcow2: optimize qcow2_co_pwritev_compressed

2017-06-29 Thread Peter Lieven
if we specify exactly one iov of s->cluster_size bytes we can avoid the bounce buffer. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 39a8afc..0a720

[Qemu-block] [PATCH V2 5/8] block/qcow2: read and write the compress format extension

2017-06-29 Thread Peter Lieven
we now read the extension on open and write it on update, but do not yet use it. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 100 ++ block/qcow2.h | 23 +++--- 2 files changed, 104 insertions(+), 19 del

[Qemu-block] [PATCH V2 7/8] block/qcow2: start using the compress format extension

2017-06-29 Thread Peter Lieven
we now pass the parameters to the zlib compressor if the extension is present and use the old default values if the extension is absent. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2-cluster.c | 58 ++- block/qcow2.c

[Qemu-block] [PATCH V2 0/8] add Qcow2 compress format extension

2017-06-29 Thread Peter Lieven
oad and compress level. - removed extra reservations for header extensions - added missing lzo_init and fixed compress overhead for lzo Peter Lieven (8): docs: add compress format extension to qcow2 spec qapi: add compress parameters to Qcow2 Blockdev options block/qcow2: parse compress cre

[Qemu-block] [PATCH V2 3/8] block/qcow2: parse compress create options

2017-06-29 Thread Peter Lieven
this adds parsing and validation for the compress create options. They are only validated but not yet used. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 56 +-- block/qcow2.h | 9 include

[Qemu-block] [PATCH V2 8/8] block/qcow2: add lzo compress format

2017-06-29 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2-cluster.c | 15 +++ block/qcow2.c | 26 +- block/qcow2.h | 1 + configure | 2 +- qapi/block-core.json | 14 -- qemu-img.texi | 1 + 6 files c

[Qemu-block] [PATCH V2 1/8] docs: add compress format extension to qcow2 spec

2017-06-29 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- docs/interop/qcow2.txt | 43 ++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt index 80cdfd0..c01daf3 100644 --- a/docs/interop/qcow2.txt

[Qemu-block] [PATCH V2 2/8] qapi: add compress parameters to Qcow2 Blockdev options

2017-06-29 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- qapi/block-core.json | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index f85c223..1574ffb 100644 --- a/qapi/block-core.json +++

Re: [Qemu-block] [PATCH 1/4] block/qcow2: add compression_algorithm create option

2017-06-27 Thread Peter Lieven
Am 27.06.2017 um 17:04 schrieb Eric Blake: On 06/27/2017 09:49 AM, Peter Lieven wrote: Before I continue, can you please give feedback on the following spec change: diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt index 80cdfd0..f1428e9 100644 --- a/docs/interop/qcow2.txt +++ b

Re: [Qemu-block] [PATCH 1/4] block/qcow2: add compression_algorithm create option

2017-06-27 Thread Peter Lieven
Am 27.06.2017 um 17:11 schrieb Peter Lieven: Am 27.06.2017 um 17:04 schrieb Eric Blake: On 06/27/2017 09:49 AM, Peter Lieven wrote: Before I continue, can you please give feedback on the following spec change: diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt index 80cdfd0

Re: [Qemu-block] [PATCH 1/4] block/qcow2: add compression_algorithm create option

2017-06-27 Thread Peter Lieven
Am 27.06.2017 um 14:49 schrieb Eric Blake: On 06/27/2017 07:34 AM, Peter Lieven wrote: this patch adds a new compression_algorithm option when creating qcow2 images. The current default for the compresison algorithm is zlib and zlib will be s/compresison/compression/ used when this option

Re: [Qemu-block] [Qemu-devel] [PATCH 1/4] block/qcow2: add compression_algorithm create option

2017-06-27 Thread Peter Lieven
Am 27.06.2017 um 15:20 schrieb Daniel P. Berrange: On Tue, Jun 27, 2017 at 02:34:07PM +0200, Peter Lieven wrote: this patch adds a new compression_algorithm option when creating qcow2 images. The current default for the compresison algorithm is zlib and zlib will be used when this option

Re: [Qemu-block] [Qemu-devel] [PATCH 4/4] block/qcow2: add zlib-fast compression algorithm

2017-06-27 Thread Peter Lieven
Am 27.06.2017 um 15:16 schrieb Daniel P. Berrange: On Tue, Jun 27, 2017 at 02:34:10PM +0200, Peter Lieven wrote: this adds support for optimized zlib settings which almost tripples the compression speed while maintaining about the same compressed size. Signed-off-by: Peter Lieven <p...@kamp

Re: [Qemu-block] [PATCH 4/4] block/qcow2: add zlib-fast compression algorithm

2017-06-27 Thread Peter Lieven
Am 27.06.2017 um 14:53 schrieb Eric Blake: On 06/27/2017 07:34 AM, Peter Lieven wrote: this adds support for optimized zlib settings which almost Start sentences with a capital. tripples the compression speed while maintaining about s/tripples/triples/ the same compressed size. Signed

[Qemu-block] [PATCH 3/4] block/qcow2: add lzo compression algorithm

2017-06-27 Thread Peter Lieven
Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2-cluster.c | 65 +++--- block/qcow2.c | 72 ++- block/qcow2.h | 1 + configure | 2 +- qemu-img.texi |

[Qemu-block] [PATCH 1/4] block/qcow2: add compression_algorithm create option

2017-06-27 Thread Peter Lieven
of Qemu. This means if the compression_algorithm option is specified Qemu prior to this commit will not be able to open the created image. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2.c | 93 --- block/qcow2.h

[Qemu-block] [PATCH 4/4] block/qcow2: add zlib-fast compression algorithm

2017-06-27 Thread Peter Lieven
this adds support for optimized zlib settings which almost tripples the compression speed while maintaining about the same compressed size. Signed-off-by: Peter Lieven <p...@kamp.de> --- block/qcow2-cluster.c | 3 ++- block/qcow2.c | 11 +-- block/qcow2.h | 1 +

<    1   2   3   4   5   6   >