On 22/05/2024 14.48, Fabiano Rosas wrote:
Thomas Huth writes:
On 21/05/2024 14.46, Fabiano Rosas wrote:
Alex Bennée writes:
Juan Quintela writes:
From: Fabiano Rosas
Add a smoke test that migrates to a file and gives it to the
script. It should catch the most annoying errors
way harder to figure out what is
causing the script to fail, the person making the change is the most
likely to know right away what the problem is.
Signed-off-by: Fabiano Rosas
Acked-by: Thomas Huth
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231009184326.15777-7-f
test_read_guest_mem, );
+opts.before = vhost_user_test_setup_shm;
+qos_add_test("vhost-user/read-guest-mem/shm",
+ "virtio-net",
+ test_read_guest_mem, );
+
if (qemu_memfd_check(MFD_ALLOW_SEALING)) {
opts.before = vhost_user_test_setup_memfd;
qos_add_test("vhost-user/read-guest-mem/memfd",
Acked-by: Thomas Huth
d=mem,size=256M,share=on "
" -M memory-backend=mem -m 256M ");
for (i = 0; i < vus_instances; i++) {
Acked-by: Thomas Huth
On 30/04/2024 06.32, Thomas Huth wrote:
On 30/04/2024 02.17, Richard Henderson wrote:
On 4/28/24 20:25, Jeuk Kim wrote:
From: Jeuk Kim
It fixes the buffer overflow vulnerability in the ufs device.
The bug was detected by sanitizers.
You can reproduce it by:
cat << EOF |\
qemu-system-
On 30/04/2024 02.17, Richard Henderson wrote:
On 4/28/24 20:25, Jeuk Kim wrote:
From: Jeuk Kim
It fixes the buffer overflow vulnerability in the ufs device.
The bug was detected by sanitizers.
You can reproduce it by:
cat << EOF |\
qemu-system-x86_64 \
-display none -machine accel=qtest -m
-off-by: Paolo Bonzini
Reviewed-by: Thomas Huth
Message-ID: <20240412103708.27650-1-pbonz...@redhat.com>
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
.../stream/{8 => 9}/build-environment.yml | 31 ++---
.../stream/{8 => 9}/x86_64/configure
Now that we bumped the minumum glib version to 2.66, we can drop
the old code.
Suggested-by: Paolo Bonzini
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
qga/commands-posix-ssh.c | 8
util/error-report.c | 10 --
2 files changed, 18 deletions(-)
diff
or other mistakes.
Reviewed-by: Richard W.M. Jones
Signed-off-by: Thomas Huth
---
block/ssh.c | 75 -
1 file changed, 40 insertions(+), 35 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index 2748253d4a..a88171d4b5 100644
--- a/block/ssh.c
-are-coming-for-centos-stream-8-and-centos-linux-7/
"After May 31, 2024, CentOS Stream 8 will be archived
and no further updates will be provided."
Thus upgrade our CentOS Stream container to major version 9 now.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
.g
.
Reviewed-by: Richard W.M. Jones
Reviewed-by: Eric Blake
Signed-off-by: Thomas Huth
---
block/nbd.c | 76 ++---
1 file changed, 37 insertions(+), 39 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index ef05f7cdfd..589d28af83 100644
--- a/block
We need the latest fixes for the lcitool to be able to properly
update our CentOS docker file to CentOS Stream 9.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
tests/lcitool/libvirt-ci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/lcitool/libvirt-ci
ce the
latter rather sounds like the users were breaking a law here.
Reviewed-by: Eric Blake
Signed-off-by: Thomas Huth
---
block/nfs.c | 110 ++--
1 file changed, 54 insertions(+), 56 deletions(-)
diff --git a/block/nfs.c b/block/nfs.c
index f7
Now that we switched all consumers of the URI code to use the URI
parsing functions from glib instead, we can remove our internal
URI parsing code since it is not used anymore.
Reviewed-by: Eric Blake
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 99 ---
util/uri.c | 1466
ation environment. Our containers are disposable
though, so a venv has no benefit. Removing the 'EXTERNALLY-MANAGED'
allows the historical arbitrary use of 'pip' outside a venv.
lcitool just does this unconditionally given the containers are
not precious."
Reviewed-by: Daniel P. Berrangé
Signed-off-
can drop the entries from the individual jobs and use the global
setting again.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
.travis.yml | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 8a3ae76a7c..56a2a01e14 1006
which will
allow further clean-ups in the following patches.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
meson.build | 16 +---
include/glib-compat.h| 27 ++-
qga/commands-posix-ssh.c | 4 ++--
3 files changed, 5 insertions
of g_uri_get_path() as input).
Reviewed-by: Eric Blake
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
block/gluster.c | 71 -
1 file changed, 35 insertions(+), 36 deletions(-)
diff --git a/block/gluster.c b/block/gluster.c
index cc74af06dc
Since Ubuntu 22.04 is now available since two years, we can stop
actively supporting the previous LTS version of Ubuntu now.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
tests/docker/dockerfiles/ubuntu2004.docker | 157 -
tests/lcitool/refresh
r simplification
- Don't allow port 0 in the URIs
Paolo Bonzini (1):
ci: move external build environment setups to CentOS Stream 9
Thomas Huth (12):
tests: Remove Ubuntu 20.04 container
tests/lcitool/libvirt-ci: Update to the latest master branch
tests/docker/dockerfiles: Run lcitool-re
On 17/04/2024 18.15, Daniel P. Berrangé wrote:
On Fri, Apr 12, 2024 at 03:24:06PM +0200, Thomas Huth wrote:
RHEL 9 (and thus also the derivatives) are available since two years
now, so according to QEMU's support policy, we can drop the active
support for the previous major version 8 now.
Thus
On 12/04/2024 16.40, Eric Blake wrote:
On Fri, Apr 12, 2024 at 03:24:11PM +0200, Thomas Huth wrote:
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Signed-off-by: Thomas Huth
---
block
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Reviewed-by: Richard W.M. Jones
Signed-off-by: Thomas Huth
---
block/ssh.c | 75 -
1 file
.
Reviewed-by: Richard W.M. Jones
Signed-off-by: Thomas Huth
---
block/nbd.c | 76 ++---
1 file changed, 37 insertions(+), 39 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index ef05f7cdfd..589d28af83 100644
--- a/block/nbd.c
+++ b/block/nbd.c
Now that we bumped the minumum glib version to 2.66, we can drop
the old code.
Suggested-by: Paolo Bonzini
Signed-off-by: Thomas Huth
---
qga/commands-posix-ssh.c | 8
util/error-report.c | 10 --
2 files changed, 18 deletions(-)
diff --git a/qga/commands-posix-ssh.c b
-off-by: Paolo Bonzini
Reviewed-by: Thomas Huth
Message-ID: <20240412103708.27650-1-pbonz...@redhat.com>
Signed-off-by: Thomas Huth
---
.../stream/{8 => 9}/build-environment.yml | 31 ++---
.../stream/{8 => 9}/x86_64/configure | 4 +-
.../stream/{8 => 9}/x86_
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Signed-off-by: Thomas Huth
---
block/nfs.c | 110 ++--
1 file changed, 54 insertions(+), 56
can drop the entries from the individual jobs and use the global
setting again.
Signed-off-by: Thomas Huth
---
.travis.yml | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 8a3ae76a7c..56a2a01e14 100644
--- a/.travis.yml
+++ b/.tra
Now that we switched all consumers of the URI code to use the URI
parsing functions from glib instead, we can remove our internal
URI parsing code since it is not used anymore.
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 99 ---
util/uri.c | 1466
RHEL 9 (and thus also the derivatives) are available since two years
now, so according to QEMU's support policy, we can drop the active
support for the previous major version 8 now.
Thus upgrade our CentOS Stream container to major version 9 now.
Signed-off-by: Thomas Huth
---
.gitlab-ci.d
This update adds the removing of the EXTERNALLY-MANAGED marker files
that has been added to the lcitool recently.
Signed-off-by: Thomas Huth
---
tests/docker/dockerfiles/alpine.docker| 3 ++-
tests/docker/dockerfiles/centos8.docker | 1 +
tests/docker/dockerfiles
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Signed-off-by: Thomas Huth
---
block/gluster.c | 71 -
1 file changed, 35 insertions(+), 36
to drop more glib compatibility hunks
- Use g_autoptr() in the URI patches for simplification
- Don't allow port 0 in the URIs
Paolo Bonzini (1):
ci: move external build environment setups to CentOS Stream 9
Thomas Huth (12):
tests: Remove Ubuntu 20.04 container
tests/lcitool/libvirt-ci: Update
We need the latest fixes for the lcitool to be able to properly
update our CentOS docker file to CentOS Stream 9.
Signed-off-by: Thomas Huth
---
tests/lcitool/libvirt-ci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci
index
which will
allow further clean-ups in the following patches.
Signed-off-by: Thomas Huth
---
meson.build | 16 +---
include/glib-compat.h| 27 ++-
qga/commands-posix-ssh.c | 4 ++--
3 files changed, 5 insertions(+), 42 deletions(-)
diff --git
Since Ubuntu 22.04 is now available since two years, we can stop
actively supporting the previous LTS version of Ubuntu now.
Signed-off-by: Thomas Huth
---
tests/docker/dockerfiles/ubuntu2004.docker | 157 -
tests/lcitool/refresh | 1 -
2 files changed
On 12/04/2024 12.16, Paolo Bonzini wrote:
On Thu, Mar 28, 2024 at 3:06 PM Thomas Huth wrote:
Now that we dropped support for CentOS 8 and Ubuntu 20.04, we can
look into bumping the glib version to a new minimum for further
clean-ups. According to repology.org, available versions
* 2], "%02x", data[i]);
^
1 warning generated.
Signed-off-by: Philippe Mathieu-Daudé
---
system/qtest.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Thomas Huth
cs/system/qemu-block-drivers.rst.inc | 1 -
block/gluster.c| 39 --
3 files changed, 2 insertions(+), 42 deletions(-)
Reviewed-by: Thomas Huth
m-mux tool from contrib/
Cc: Yuval Shaia
Cc: Marcel Apfelbaum
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Thomas Huth
On 28/03/2024 15.59, Daniel P. Berrangé wrote:
On Thu, Mar 28, 2024 at 09:54:49AM -0500, Eric Blake wrote:
On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote:
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
On 28/03/2024 16.01, Peter Xu wrote:
On Thu, Mar 28, 2024 at 11:18:04AM -0300, Fabiano Rosas wrote:
Philippe Mathieu-Daudé writes:
The whole RDMA subsystem was deprecated in commit e9a54265f5
("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
released in v8.2.
Remove:
- RDMA
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Signed-off-by: Thomas Huth
---
block/ssh.c | 69 +++--
1 file changed, 40 insertions(+), 29
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Signed-off-by: Thomas Huth
---
block/nfs.c | 102 ++--
1 file changed, 52 insertions(+), 50
Since Ubuntu 22.04 is now available since two years, we can stop
actively supporting the previous LTS version of Ubuntu now.
Signed-off-by: Thomas Huth
---
tests/docker/dockerfiles/ubuntu2004.docker | 157 -
tests/lcitool/refresh | 1 -
2 files changed
.
Signed-off-by: Thomas Huth
---
block/nbd.c | 66 ++---
1 file changed, 38 insertions(+), 28 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index ef05f7cdfd..95b507f872 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -31,7 +31,6 @@
#include "
RHEL 9 (and thus also the derivatives) are available since two years
now, so according to QEMU's support policy, we can drop the active
support for the previous major version 8 now.
Thus upgrade our CentOS Stream container to major version 9 now.
Signed-off-by: Thomas Huth
---
.gitlab-ci.d
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Cc: integrat...@gluster.org
Signed-off-by: Thomas Huth
---
block/gluster.c | 63 +
1 file
We need the latest fixes for the lcitool to be able to properly
update our CentOS docker file to CentOS Stream 9.
Signed-off-by: Thomas Huth
---
tests/lcitool/libvirt-ci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci
index
which will
allow further clean-ups in the following patches.
Signed-off-by: Thomas Huth
---
meson.build | 16 +---
include/glib-compat.h| 27 ++-
qga/commands-posix-ssh.c | 4 ++--
3 files changed, 5 insertions(+), 42 deletions(-)
diff --git
. By switching to
these parsing functions, we can finally drop our own URI parsing
code in util/uri.c.
NB: We also need to update some of the custom runners in our CI
environment first (since they still use Ubuntu 20.04).
Thomas Huth (9):
tests: Remove Ubuntu 20.04 container
tests/lcitool
Now that we switched all consumers of the URI code to use the URI
parsing functions from glib instead, we can remove our internal
URI parsing code since it is not used anymore.
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 99 ---
util/uri.c | 1466
On 27/03/2024 11.55, Philippe Mathieu-Daudé wrote:
The whole RDMA subsystem was deprecated in commit e9a54265f5
("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
released in v8.2. Time to remove it.
Keep the RAM_SAVE_FLAG_HOOK definition since it might appears
in old migration
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Thomas Huth
On 19/01/2024 17.18, Peter Maydell wrote:
On Fri, 19 Jan 2024 at 15:26, Peter Maydell wrote:
(Also, we should probably put an entry for sh4 in machine_map,
because the default board type (shix) is about to be deprecated,
and the r2d board type is thus a better choice.)
The good news is if we
Tests 157 and 227 use the virtio-blk device, so we have to mark these
tests accordingly to be skipped if this devices is not available (e.g.
when running the tests with qemu-system-avr only).
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/157 | 2 ++
tests/qemu-iotests/227 | 2 ++
2 files
gitlab.com/qemu-project/qemu/-/issues/2228
Fixes: 27a2c66c92ec ("aspeed/smc: Wire CS lines at reset")
Reported-by: Thomas Huth
Signed-off-by: Cédric Le Goater
---
Thanks!
Reviewed-by: Thomas Huth
Tested-by: Thomas Huth
ption")
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/134 | 2 +-
tests/qemu-iotests/158 | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/134 b/tests/qemu-iotests/134
index ded153c0b9..b2c3c03f08 100755
--- a/tests/qemu-iotests/134
+++ b/tests/qemu-i
Tests that use "--blockdev" with the "file" driver cannot work with
other protocols, so we should mark them accordingly.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/tests/qcow2-internal-snapshots | 2 +-
tests/qemu-iotests/tests/qsd-jobs | 2 +-
ts/scratch/qcow2-ssh-114/t.qcow2.orig'
for writing: No such file or directory
Thus mark this test for "file protocol only" accordingly.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/114 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/114
Tests 263, 284 and detect-zeroes-registered-buf use qemu-io
with --image-opts so we have to enforce IMGOPTSSYNTAX=true here
to get $TEST_IMG in shape for other protocols than "file".
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/263| 6 --
(XXX YYY/sec and XXX ops/sec)
We already check for the qcow2 format here, so let's simply also
add a check for the protocol here, too, to only test the truncation
with the file protocol.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/033 | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
Using "-drive ...,backing.file.filename=..." only works with the
file protocol, but not with URIs, so mark this test accordingly.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/130 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/130 b/tests/qe
The hand-crafted json statement in this test only works if the test
is run with the "file" protocol, so mark this test accordingly.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/066 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/066 b/
These tests 188, 189 and 198 use qemu-io with --image-opts with additional
hard-coded parameters for the file protocol, so they cannot work for other
protocols. Thus we have to limit these tests to the file protocol only.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/188 | 2 +-
tests/qemu
The test fails completely when you try to use it with a different
protocol, e.g. with "./check -ssh -qcow2 156".
The test uses some hand-crafted JSON statements which cannot work with other
protocols, thus let's change this test to only support the 'file' protocol.
Signed-off-by: T
eal bug or whether this test should also
simply be marked to work with the "file" protocol only. Suggestions are
welcome!
Thomas Huth (9):
tests/qemu-iotests: Fix test 033 for running with non-file protocols
tests/qemu-iotests: Restrict test 066 to the 'file' protocol
tests/qemu
qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-ID: <20240311033822.3142585-6-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/nbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/nbd.c b/block/nbd.c
index b9d4f935e0..e
ck@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Stefan Hajnoczi
Acked-by: "Michael S. Tsirkin"
Message-ID: <20240311033822.3142585-14-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
hw/block/virtio-blk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/
nongnu.org
Signed-off-by: Zhao Liu
Message-ID: <20240311033822.3142585-12-zhao1@linux.intel.com>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
block/vdi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/vdi.c b/block/vdi.c
index 3b57becb9f..6363da08ce 100644
--- a/b
-Ogievskiy
Message-ID: <20240311033822.3142585-8-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/qcow2-bitmap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index 0e567ed588..874ea56948 100644
--- a/block/qcow2-bitmap.c
+++ b/bloc
uot;).
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Message-ID: <20240311033822.3142585-11-zhao1@linux.intel.com>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
block/snapshot.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/sn
("error: New macro ERRP_GUARD()").
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Eric Blake
Message-ID: <20240311033822.3142585-9-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/qcow2.c | 2 ++
1 file changed, 2 ins
n Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Stefan Hajnoczi
Message-ID: <20240311033822.3142585-10-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/qed.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qed.c b/b
("error: New macro ERRP_GUARD()").
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Eric Blake
Message-ID: <20240311033822.3142585-4-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
block.c | 4
1 file chang
n Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-ID: <20240311033822.3142585-5-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/copy-before-write.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/b
H_UNLOCKED
vdi_co_do_create(BlockdevCreateOptions *create_options, size_t block_size,
Error **errp)
{
+ERRP_GUARD();
BlockdevCreateOptionsVdi *vdi_opts;
int ret = 0;
uint64_t bytes = 0;
Reviewed-by: Thomas Huth
@@ -605,6 +606,7 @@ int bdrv_all_goto_snapshot(const char *name,
bool has_devices, strList *devices,
Error **errp)
{
+ERRP_GUARD();
g_autoptr(GList) bdrvs = NULL;
GList *iterbdrvs;
int ret;
Reviewed-by: Thomas Huth
On 05/03/2024 04.21, Xinying Yu wrote:
One more thing, I would ask how do I get the full series patch? Do I copy
the RFC line by line from this link[1]?
For getting patches that you might have missed on the mailing list, I
recommend lore.kernel.org :
virtio_ccw_start_ioeventfd(dev);
}
sch->curr_status.scsw.count = ccw.count - sizeof(status);
Acked-by: Thomas Huth
ev, vq_idx);
return 0;
-
}
Acked-by: Thomas Huth
ot;hw/ide/pci.h"
#include "hw/ide/ahci-pci.h"
-#include "ahci_internal.h"
+#include "ahci-internal.h"
#define ICH9_MSI_CAP_OFFSET 0x80
#define ICH9_SATA_CAP_OFFSET0xA8
Reviewed-by: Thomas Huth
>gic,
irq));
sysahci = SYSBUS_AHCI(dev);
- ahci = >ahci;
ide_drive_get(hd, ARRAY_SIZE(hd));
- for (i = 0; i < ahci->ports; i++) {
- if (hd[i] == NULL) {
- continue;
- }
- ide_bus_create_drive(>dev[i].port, 0, hd[i]);
- }
+ ahci_ide_create_devs(>ahci, hd);
}
Reviewed-by: Thomas Huth
t;hw/ide/internal.h"
+#include "hw/ide/ide-bus.h"
#include "hw/intc/heathrow_pic.h"
#include "hw/misc/macio/cuda.h"
#include "hw/misc/macio/gpio.h"
Oh, I was sure that I got them all ... thanks for double checking!
Reviewed-by: Thomas Huth
On 21/02/2024 19.43, Philippe Mathieu-Daudé wrote:
On 20/2/24 09:55, Thomas Huth wrote:
Unentangle internal.h by moving public IDE device related
Disentangle ... from? Untangle? TIL Unentangle.
You're right, "disentangle" seems to be the more appropriate word.
I'll fix it up.
qdev.c is a mixture between IDE bus specific functions and IDE device
functions. Let's split it up to make it more obvious which part is
related to bus handling and which part is related to device handling.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
hw/ide/ide-bus.c
Unentangle internal.h by moving public IDE device related
definitions to ide-dev.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dev.h | 143 +-
include/hw/ide/internal.h | 143 +-
hw/ide/ide-dev.c | 1 +
3
/ide.h
Thomas Huth (7):
hw/ide: Add the possibility to disable the CompactFlash device in the
build
hw/ide: Split qdev.c into ide-bus.c and ide-dev.c
hw/ide: Move IDE DMA related definitions to a separate header
ide-dma.h
hw/ide: Move IDE device related definitions to ide-dev.h
hw
definitions related to IDE devices.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dev.h | 41
hw/ide/cf.c | 58
hw/ide/qdev.c| 51
Let's consolidate the public IDE bus related functions in a separate
header.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-bus.h | 42 +++
include/hw/ide/internal.h | 40 +
2 files changed, 43 insertions(+), 39
These definitions are required outside of the hw/ide/ code, too,
so lets's move them from internal.h to a new header called ide-dma.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dma.h | 37 +
include/hw/ide/internal.h | 29
-by: Thomas Huth
---
include/hw/ide/pci.h | 2 +-
hw/i386/pc.c | 2 +-
hw/ide/cmd646.c | 1 +
hw/ide/pci.c | 1 +
hw/ide/piix.c| 1 +
hw/ide/sii3112.c | 1 +
hw/ide/via.c | 1 +
7 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/include/hw/ide
There was only one prototype left in this legacy file. Move it to
ide-dev.h to finally get rid of it.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
MAINTAINERS | 1 -
include/hw/ide.h | 9 -
include/hw/ide/ide-dev.h | 2 ++
include/hw/ide
On 19/02/2024 12.53, BALATON Zoltan wrote:
On Mon, 19 Feb 2024, Thomas Huth wrote:
These definitions are required outside of the hw/ide/ code, too,
so lets's move them from internal.h to a new header called ide-dma.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dma.h | 30
On 19/02/2024 12.32, Philippe Mathieu-Daudé wrote:
On 19/2/24 11:49, Thomas Huth wrote:
Let's start to unentangle internal.h by moving public IDE device
related definitions to ide-dev.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dev.h | 145
On 19/02/2024 12.45, BALATON Zoltan wrote:
On Mon, 19 Feb 2024, Thomas Huth wrote:
qdev.c is a mixture between IDE bus specific functions and IDE device
functions. Let's split it up to make it more obvious which part is
related to bus handling and which part is related to device handling
On 16/02/2024 12.03, Philippe Mathieu-Daudé wrote:
QDev objects created with qdev_*new() need to manually add
their parent relationship with object_property_add_child().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/s390x/s390-pci-bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git
There was only one prototype left in this legacy file. Move it to
ide-dev.h to finally get rid of it.
Signed-off-by: Thomas Huth
---
include/hw/ide.h | 9 -
include/hw/ide/ide-dev.h | 2 ++
include/hw/ide/internal.h | 1 -
3 files changed, 2 insertions(+), 10 deletions
These definitions are required outside of the hw/ide/ code, too,
so lets's move them from internal.h to a new header called ide-dma.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dma.h | 30 ++
include/hw/ide/internal.h | 27 +--
2
include/hw/ide/internal.h is currently included by include/hw/ide/pci.h
and thus exposed to a lot of files that are not part of the IDE subsystem.
Stop including internal.h there and use the appropriate new headers
ide-bus.h and ide-dma.h instead.
Signed-off-by: Thomas Huth
---
include/hw/ide
1 - 100 of 1249 matches
Mail list logo
