[PATCH] iotests: Add more "_require_drivers" checks to the shell-based tests

2019-12-18 Thread Thomas Huth
Test 051 should be skipped if nbd is not available, and 267 should be skipped if copy-on-read is not enabled. Signed-off-by: Thomas Huth --- tests/qemu-iotests/051 | 1 + tests/qemu-iotests/267 | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051

[PATCH v2] iotests: Add more "skip_if_unsupported" statements to the python tests

2019-12-18 Thread Thomas Huth
The python code already contains a possibility to skip tests if the corresponding driver is not available in the qemu binary - use it in more spots to avoid that the tests are failing if the driver has been disabled. Signed-off-by: Thomas Huth --- v2: Thanks to Max' "iotests: Allo

Re: [PATCH] virtio-blk: deprecate SCSI passthrough

2019-12-14 Thread Thomas Huth
virtio-scsi device was introduced for > +full SCSI support. Use virtio-scsi instead when SCSI passthrough is > required. > + > +Note this also applies to ``-device virtio-blk-pci,scsi=on|off'', which is an > +alias. ... and "-device virtio-blk-ccw,scsi=on|off". With that added: Reviewed-by: Thomas Huth

Re: [PATCH] tests: skip block layer tests if !CONFIG_TOOLS

2019-12-11 Thread Thomas Huth
On 11/12/2019 15.24, Paolo Bonzini wrote: > From: Marc-André Lureau > > The block tests, as well as ahci-test needs qemu-img. Do not run > them if it wasn't built. > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > tests/Makefile.include | 4 > 1 file changed, 4

Re: [PATCH v2 3/7] iotests: Skip test 079 if it is not possible to create large files

2019-12-06 Thread Thomas Huth
On 04/12/2019 16.46, Thomas Huth wrote: > Test 079 fails in the arm64, s390x and ppc64le LXD containers on Travis For the record: It's working on s390x as noticed by Cleber. It's only failing on arm64 and ppc64le. After fixing the problem with 060 which fails on all three architectur

[PATCH v2 5/7] tests/test-util-filemonitor: Skip test on non-x86 Travis containers

2019-12-04 Thread Thomas Huth
test-util-filemonitor fails in restricted non-x86 Travis containers since they apparently blacklisted some required system calls there. Let's simply skip the test if we detect such an environment. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Signed-off-by: Thomas

[PATCH v2 6/7] configure: allow disable of cross compilation containers

2019-12-04 Thread Thomas Huth
From: Alex Bennée Our docker infrastructure isn't quite as multiarch as we would wish so let's allow the user to disable it if they want. This will allow us to use still run check-tcg on non-x86 CI setups. Signed-off-by: Alex Bennée Reviewed-by: Stefan Weil Signed-off-by: T

[PATCH v2 4/7] tests/hd-geo-test: Skip test when images can not be created

2019-12-04 Thread Thomas Huth
dé Reviewed-by: Alex Bennée Signed-off-by: Thomas Huth --- tests/hd-geo-test.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c index 7e86c5416c..a249800544 100644 --- a/tests/hd-geo-test.c +++ b/tests/hd-geo-test.c @@ -34,8 +

[PATCH v2 3/7] iotests: Skip test 079 if it is not possible to create large files

2019-12-04 Thread Thomas Huth
first whether we can really create such files before executing the test. Signed-off-by: Thomas Huth --- tests/qemu-iotests/079 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/079 b/tests/qemu-iotests/079 index 81f0c21f53..78536d3bbf 100755 --- a/tests/qemu-iotests/079

[PATCH v2 0/7] Enable Travis builds on arm64, ppc64le and s390x

2019-12-04 Thread Thomas Huth
ashing on bionic on these hosts. - Dropped "libcap-dev" from the package list since it will be replaced by libcapng-dev soon. Alex Bennée (1): configure: allow disable of cross compilation containers Thomas Huth (6): iotests: Provide a function for checking the creation of huge f

[PATCH v2 7/7] travis.yml: Enable builds on arm64, ppc64le and s390x

2019-12-04 Thread Thomas Huth
d / fixed. Signed-off-by: Thomas Huth --- .travis.yml | 86 + 1 file changed, 86 insertions(+) diff --git a/.travis.yml b/.travis.yml index 445b0646c1..0e6458b0af 100644 --- a/.travis.yml +++ b/.travis.yml @@ -354,6 +354,92 @@ matrix: -

[PATCH v2 2/7] iotests: Skip test 060 if it is not possible to create large files

2019-12-04 Thread Thomas Huth
and skip the test if that's not the case. Signed-off-by: Thomas Huth --- tests/qemu-iotests/060 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/060 b/tests/qemu-iotests/060 index b91d8321bb..d96f17a484 100755 --- a/tests/qemu-iotests/060 +++ b/tests/qemu-iotest

[PATCH v2 1/7] iotests: Provide a function for checking the creation of huge files

2019-12-04 Thread Thomas Huth
sting checks in the iotests 005 and 220 with this function. Reviewed-by: Alex Bennée Signed-off-by: Thomas Huth --- tests/qemu-iotests/005 | 5 + tests/qemu-iotests/220 | 6 ++ tests/qemu-iotests/common.rc | 10 ++ 3 files changed, 13 insertions(+), 8 deletions(-) diff

Re: [PATCH 0/6] Enable Travis builds on arm64, ppc64le and s390x

2019-12-04 Thread Thomas Huth
On 27/11/2019 09.50, Thomas Huth wrote: > On 25/11/2019 11.28, Alex Bennée wrote: >> >> Alex Bennée writes: >> >>> Thomas Huth writes: >>> >>>> Travis recently added build hosts for arm64, ppc64le and s390x, so >>>> this is a welcome

Re: virtiofsd: Where should it live?

2019-12-04 Thread Thomas Huth
On 04/12/2019 14.28, Kevin Wolf wrote: > Am 04.12.2019 um 09:17 hat Gerd Hoffmann geschrieben: >> Hi, >> | ... +- qemu-edid >>> >>> Has its own MAINTAINERS section, together with hw/display/edit* and >>> include/hw/display/edid.h. I'm not sure moving it hw/display/ is a good

[PATCH 1/3] iotests: Provide a function for checking the creation of huge files

2019-12-02 Thread Thomas Huth
sting checks in the iotests 005 and 220 with this function. Signed-off-by: Thomas Huth --- tests/qemu-iotests/005 | 5 + tests/qemu-iotests/220 | 6 ++ tests/qemu-iotests/common.rc | 10 ++ 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/tests/qemu-iotest

[PATCH 0/3] iotests: Check for the possibility to create large files

2019-12-02 Thread Thomas Huth
first. Thomas Huth (3): iotests: Provide a function for checking the creation of huge files iotests: Skip test 060 if it is not possible to create large files iotests: Skip test 079 if it is not possible to create large files tests/qemu-iotests/005 | 5 + tests/qemu-iotests/060

[PATCH 2/3] iotests: Skip test 060 if it is not possible to create large files

2019-12-02 Thread Thomas Huth
and skip the test if that's not the case. Signed-off-by: Thomas Huth --- tests/qemu-iotests/060 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/060 b/tests/qemu-iotests/060 index b91d8321bb..d96f17a484 100755 --- a/tests/qemu-iotests/060 +++ b/tests/qemu-iotest

[PATCH 3/3] iotests: Skip test 079 if it is not possible to create large files

2019-12-02 Thread Thomas Huth
first whether we can really create such files before executing the test. Signed-off-by: Thomas Huth --- tests/qemu-iotests/079 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/079 b/tests/qemu-iotests/079 index 81f0c21f53..78536d3bbf 100755 --- a/tests/qemu-iotests/079

[PATCH v4 5/6] iotests: Skip Python-based tests if QEMU does not support virtio-blk

2019-12-02 Thread Thomas Huth
every test (which does not sound very appealing), let's rather add a check for this a central spot in the "check" script instead (so that it is still possible to run "make check" for qemu-system-tricore for example). Signed-off-by: Thomas Huth --- tests/qemu-iotests/ch

[PATCH v4 6/6] iotests: Enable more tests in the 'auto' group to improve test coverage

2019-12-02 Thread Thomas Huth
iothreads. For migration, let's enable 181 and 203 (which also tests iothreads). (091 would be a good candidate for migration, too, but Alex Bennée reported that this test fails on ZFS file systems, so it can't be included yet) Signed-off-by: Thomas Huth --- tests/qemu-iotests/

[PATCH v4 3/6] iotests: Test 183 does not work on macOS and OpenBSD

2019-12-02 Thread Thomas Huth
handle 0" error. Let's mark it as supported only on systems where the test is working fine (i.e. Linux, FreeBSD and NetBSD). Signed-off-by: Thomas Huth --- tests/qemu-iotests/183 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/183 b/tests/qemu-iotests/183 index bced

[PATCH v4 2/6] iotests: Test 041 only works on certain systems

2019-12-02 Thread Thomas Huth
041 works fine on Linux, FreeBSD, NetBSD and OpenBSD, but fails on macOS. Let's mark it as only supported on the systems where we know that it is working fine. Signed-off-by: Thomas Huth --- tests/qemu-iotests/041 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests

[PATCH v4 4/6] iotests: Check for the availability of the required devices in 267 and 127

2019-12-02 Thread Thomas Huth
in iotest 267 - it has been added to the "auto" group already, but requires virtio-blk and thus currently fails with qemu-system-tricore for example. Let's also add aproper check there. Signed-off-by: Thomas Huth --- tests/qemu-iotests/127 | 2 ++ tests/qemu-iotests/267

[PATCH v4 0/6] Enable more iotests during "make check-block"

2019-12-02 Thread Thomas Huth
too (now that Eduardo has re-activated Gerd's patches for creating NetBSD VM images) - Use 'openbsd' instead of 'openbsd6' - Use 'grep -q' instead of 'grep' for grep'ing silently - Added the patch to disable 130 from the "auto" grou

[PATCH v4 1/6] iotests: remove 'linux' from default supported platforms

2019-12-02 Thread Thomas Huth
From: John Snow verify_platform will check an explicit whitelist and blacklist instead. The default will now be assumed to be allowed to run anywhere. For tests that do not specify their platforms explicitly, this has the effect of enabling these tests on non-linux platforms. For tests that alwa

Re: [PATCH v3 5/6] iotests: Enable more tests in the 'auto' group to improve test coverage

2019-11-27 Thread Thomas Huth
On 24/10/2019 13.14, Alex Bennée wrote: Thomas Huth writes: According to Max, it would be good to have a test for iothreads and migration. 127 and 256 seem to be good candidates for iothreads. For migration, let's enable 091, 181, and 203 (which also tests iothreads). @@ -112,7 +

Re: [PATCH 0/6] Enable Travis builds on arm64, ppc64le and s390x

2019-11-27 Thread Thomas Huth
On 25/11/2019 11.28, Alex Bennée wrote: Alex Bennée writes: Thomas Huth writes: Travis recently added build hosts for arm64, ppc64le and s390x, so this is a welcome addition to our Travis testing matrix. Unfortunately, the builds are running in quite restricted LXD containers there, for

Re: [PATCH 2/6] iotests: Skip test 079 if it is not possible to create large files

2019-11-19 Thread Thomas Huth
On 19/11/2019 18.50, Daniel P. Berrangé wrote: > On Tue, Nov 19, 2019 at 06:38:20PM +0100, Philippe Mathieu-Daudé wrote: >> On 11/19/19 6:34 PM, Thomas Huth wrote: >>> On 19/11/2019 18.29, Philippe Mathieu-Daudé wrote: >>>> On 11/19/19 6:08 PM, Thomas Huth wrote: >

Re: [PATCH 2/6] iotests: Skip test 079 if it is not possible to create large files

2019-11-19 Thread Thomas Huth
On 19/11/2019 18.29, Philippe Mathieu-Daudé wrote: > On 11/19/19 6:08 PM, Thomas Huth wrote: >> Test 079 fails in the arm64, s390x and ppc64le LXD containers, which >> apparently do not allow large files to be created. Test 079 tries to >> create a 4G sparse file, so check

[PATCH 6/6] travis.yml: Enable builds on arm64, ppc64le and s390x

2019-11-19 Thread Thomas Huth
here, so we can not use the global list of packages to install, but have to provide individual package lists instead. Signed-off-by: Thomas Huth --- .travis.yml | 83 + 1 file changed, 83 insertions(+) diff --git a/.travis.yml b/.travis.yml

[PATCH 3/6] tests/hd-geo-test: Skip test when images can not be created

2019-11-19 Thread Thomas Huth
In certain environments like restricted containers, we can not create huge test images. To be able to use "make check" in such container environments, too, let's skip the hd-geo-test instead of failing when the test images could not be created. Signed-off-by: Thomas Huth --- test

[PATCH 5/6] travis.yml: drop 32 bit systems from MAIN_SOFTMMU_TARGETS

2019-11-19 Thread Thomas Huth
-off-by: Thomas Huth --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index b9a026c8ee..c09b6a0014 100644 --- a/.travis.yml +++ b/.travis.yml @@ -79,7 +79,7 @@ env: - BASE_CONFIG="--disable-docs --disable-tools" - TEST

[PATCH 4/6] tests/test-util-filemonitor: Skip test on non-x86 Travis containers

2019-11-19 Thread Thomas Huth
test-util-filemonitor fails in restricted non-x86 Travis containers since they apparently blacklisted some required system calls there. Let's simply skip the test if we detect such an environment. Signed-off-by: Thomas Huth --- tests/test-util-filemonitor.c | 11 +++ 1 file change

[PATCH 1/6] iotests: Skip test 060 if it is not possible to create large files

2019-11-19 Thread Thomas Huth
Test 060 fails in the arm64, s390x and ppc64le LXD containers, which apparently do not allow large files to be created. The repair process in test 060 creates a file of 64 GiB, so test first whether such large files are possible and skip the test if that's not the case. Signed-off-by: Thomas

[PATCH 0/6] Enable Travis builds on arm64, ppc64le and s390x

2019-11-19 Thread Thomas Huth
times hits the 50 minutes timeout otherwise. For the curious, here's a test run (non-x86 at the end of the page): https://travis-ci.com/huth/qemu/jobs/258095792 Thomas Alex Bennée (1): travis.yml: drop 32 bit systems from MAIN_SOFTMMU_TARGETS Thomas Huth (5): iotests: Skip test 060 if

[PATCH 2/6] iotests: Skip test 079 if it is not possible to create large files

2019-11-19 Thread Thomas Huth
Test 079 fails in the arm64, s390x and ppc64le LXD containers, which apparently do not allow large files to be created. Test 079 tries to create a 4G sparse file, so check first whether we can really create such files before executing the test. Signed-off-by: Thomas Huth --- tests/qemu-iotests

Re: [PATCH v3 4/6] iotests: Skip "make check-block" if QEMU does not support virtio-blk

2019-11-11 Thread Thomas Huth
On 30/10/2019 12.21, Max Reitz wrote: > On 22.10.19 09:21, Thomas Huth wrote: >> The next patch is going to add some python-based tests to the "auto" >> group, and these tests require virtio-blk to work properly. Running >> iotests without virtio-blk likely does

Re: [PATCH v4 16/16] libqos: add VIRTIO PCI 1.0 support

2019-10-23 Thread Thomas Huth
es changed, 476 insertions(+), 1 deletion(-) > create mode 100644 tests/libqos/virtio-pci-modern.h > create mode 100644 tests/libqos/virtio-pci-modern.c Acked-by: Thomas Huth

Re: [PATCH v4 08/16] libqos: implement VIRTIO 1.0 FEATURES_OK step

2019-10-23 Thread Thomas Huth
-- > tests/libqos/virtio.c | 18 +++++- > 1 file changed, 17 insertions(+), 1 deletion(-) Reviewed-by: Thomas Huth"

Re: [PATCH v4 07/16] libqos: enforce Device Initialization order

2019-10-23 Thread Thomas Huth
s/virtio.c | 7 +++ > 2 files changed, 8 insertions(+) Reviewed-by: Thomas Huth

Re: [PATCH v4 04/16] virtio-scsi-test: add missing feature negotiation

2019-10-23 Thread Thomas Huth
-test.c | 8 ++++ > 1 file changed, 8 insertions(+) Reviewed-by: Thomas Huth"

Re: [PATCH v4 06/16] libqos: add missing virtio-9p feature negotiation

2019-10-23 Thread Thomas Huth
n Hajnoczi > --- > tests/libqos/virtio-9p.c | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Thomas Huth"

Re: [PATCH v3 0/6] Enable more iotests during "make check-block"

2019-10-22 Thread Thomas Huth
On 22/10/2019 15.48, Alex Bennée wrote: > > Max Reitz writes: > >> On 22.10.19 15:11, Alex Bennée wrote: >>> >>> Thomas Huth writes: >>> >>>> As discussed here: >>>> >>>> https://lists.gnu.org/archive/html/qemu-de

Re: [PATCH v3 07/16] libqos: enforce Device Initialization order

2019-10-22 Thread Thomas Huth
On 22/10/2019 17.48, Stefan Hajnoczi wrote: > On Mon, Oct 21, 2019 at 02:15:53PM +0200, Thomas Huth wrote: >> On 19/10/2019 08.38, Stefan Hajnoczi wrote: >>> According to VIRTIO 1.1 "3.1.1 Driver Requirements: Device >>> Initialization", configuration sp

Re: [PATCH v3 0/6] Enable more iotests during "make check-block"

2019-10-22 Thread Thomas Huth
On 22/10/2019 13.39, Alex Bennée wrote: > > Thomas Huth writes: > >> On 22/10/2019 09.21, Thomas Huth wrote: >>> As discussed here: >>> >>> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html >>> >>> and here: &g

Re: [PATCH v3 0/6] Enable more iotests during "make check-block"

2019-10-22 Thread Thomas Huth
On 22/10/2019 09.21, Thomas Huth wrote: > As discussed here: > > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html > > and here: > > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg01388.html > > it would be good to have some more valu

[PATCH v3 6/6] iotests: Remove 130 from the "auto" group

2019-10-22 Thread Thomas Huth
he "auto" group so that it does not gate the pull requests. Reviewed-by: John Snow Signed-off-by: Thomas Huth --- tests/qemu-iotests/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index 33b499ed41..4596497bc

[PATCH v3 5/6] iotests: Enable more tests in the 'auto' group to improve test coverage

2019-10-22 Thread Thomas Huth
iothreads. For migration, let's enable 091, 181, and 203 (which also tests iothreads). Reviewed-by: Max Reitz Signed-off-by: Thomas Huth --- tests/qemu-iotests/group | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-io

[PATCH v3 4/6] iotests: Skip "make check-block" if QEMU does not support virtio-blk

2019-10-22 Thread Thomas Huth
every test (which does not sound very appealing), let's rather add a check for this at the top level in the check-block.sh script instead (so that it is possible to run "make check" without the "check-block" part for qemu-system-tricore for example). Reviewed-by: Max Reitz Sig

[PATCH v3 3/6] iotests: Test 183 does not work on macOS and OpenBSD

2019-10-22 Thread Thomas Huth
handle 0" error. Let's mark it as supported only on systems where the test is working fine (i.e. Linux, FreeBSD and NetBSD). Signed-off-by: Thomas Huth --- tests/qemu-iotests/183 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/183 b/tests/qemu-iotests/183 index bced

[PATCH v3 1/6] iotests: remove 'linux' from default supported platforms

2019-10-22 Thread Thomas Huth
From: John Snow verify_platform will check an explicit whitelist and blacklist instead. The default will now be assumed to be allowed to run anywhere. For tests that do not specify their platforms explicitly, this has the effect of enabling these tests on non-linux platforms. For tests that alwa

[PATCH v3 0/6] Enable more iotests during "make check-block"

2019-10-22 Thread Thomas Huth
rdo has re-activated Gerd's patches for creating NetBSD VM images) - Use 'openbsd' instead of 'openbsd6' - Use 'grep -q' instead of 'grep' for grep'ing silently - Added the patch to disable 130 from the "auto" group John Snow (1):

[PATCH v3 2/6] iotests: Test 041 only works on certain systems

2019-10-22 Thread Thomas Huth
041 works fine on Linux, FreeBSD, NetBSD and OpenBSD, but fails on macOS. Let's mark it as only supported on the systems where we know that it is working fine. Signed-off-by: Thomas Huth --- tests/qemu-iotests/041 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests

Re: [PATCH] iotests: Remove 130 from the "auto" group

2019-10-21 Thread Thomas Huth
On 18/10/2019 18.51, Bruce Rogers wrote: > On Fri, 2019-10-18 at 18:10 +0200, Thomas Huth wrote: >> Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared >> 'write' lock - Is another process using the image >> [TEST_DIR/t.IMGFMT]?&quo

Re: [PATCH v2 0/6] Enable more iotests during "make check-block"

2019-10-21 Thread Thomas Huth
On 21/10/2019 15.09, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20191021105350.1710-1-th...@redhat.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you have Docker installed, yo

Re: [PATCH v3 14/16] libqos: make the virtio-pci BAR index configurable

2019-10-21 Thread Thomas Huth
- > tests/libqos/virtio-pci.h | 2 ++ > tests/libqos/virtio-pci.c | 3 ++- > 2 files changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Thomas Huth

Re: [PATCH v3 10/16] libqos: add iteration support to qpci_find_capability()

2019-10-21 Thread Thomas Huth
ent qpci_find_capability() > --- > tests/libqos/pci.h | 2 +- > tests/libqos/pci.c | 30 -- > 2 files changed, 25 insertions(+), 7 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v3 09/16] libqos: access VIRTIO 1.0 vring in little-endian

2019-10-21 Thread Thomas Huth
;used, 0); > +qvirtio_writew(vq->vdev, qts, vq->used, 0); > /* vq->used->avail_event */ > -qtest_writew(qts, vq->used + 2 + sizeof(struct vring_used_elem) * > vq->size, > - 0); > +qvirtio_writew(vq->vdev, qts, vq->used + 2 + > +sizeof(struct vring_used_elem) * vq->size, 0); Fix indentation in the above line? Apart from that, patch looks fine to me. Reviewed-by: Thomas Huth

Re: [PATCH v3 08/16] libqos: implement VIRTIO 1.0 FEATURES_OK step

2019-10-21 Thread Thomas Huth
On 19/10/2019 08.38, Stefan Hajnoczi wrote: > Device initialization has an extra step in VIRTIO 1.0. The FEATURES_OK > status bit is set to indicate that feature negotiation has completed. > The driver then reads the status register again to check that the device > agrees with the final features.

Re: [PATCH v3 07/16] libqos: enforce Device Initialization order

2019-10-21 Thread Thomas Huth
On 19/10/2019 08.38, Stefan Hajnoczi wrote: > According to VIRTIO 1.1 "3.1.1 Driver Requirements: Device > Initialization", configuration space and virtqueues cannot be accessed > before features have been negotiated. Enforce this requirement. > > Signed-off-by: Stefan Hajnoczi > --- > tests/li

Re: [PATCH v3 06/16] libqos: add missing virtio-9p feature negotiation

2019-10-21 Thread Thomas Huth
On 19/10/2019 08.38, Stefan Hajnoczi wrote: > VIRTIO Device Initialization requires feature negotiation. The libqos > virtio-9p driver lacks feature negotiation and is therefore > non-compliant. > > Signed-off-by: Stefan Hajnoczi > --- > tests/libqos/virtio-9p.c | 6 ++ > 1 file changed, 6

Re: [PATCH v3 05/16] tests/virtio-blk-test: set up virtqueue after feature negotiation

2019-10-21 Thread Thomas Huth
lloc, 0); > - > -test_basic(dev, t_alloc, vq); > +vq = test_basic(dev, t_alloc); > > qmp_discard_response("{ 'execute': 'block_resize', " > " 'arguments': { 'device': 'drive0', " > Reviewed-by: Thomas Huth

Re: [PATCH v3 04/16] virtio-scsi-test: add missing feature negotiation

2019-10-21 Thread Thomas Huth
On 19/10/2019 08.37, Stefan Hajnoczi wrote: > VIRTIO Device Initialization requires feature negotiation. Currently > virtio-scsi-test.c is non-compliant. > > Signed-off-by: Stefan Hajnoczi > --- > tests/virtio-scsi-test.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/tests/v

[PATCH v2 4/6] iotests: Skip "make check-block" if QEMU does not support virtio-blk

2019-10-21 Thread Thomas Huth
every test (which does not sound very appealing), let's rather add a check for this at the top level in the check-block.sh script instead (so that it is possible to run "make check" without the "check-block" part for qemu-system-tricore for example). Reviewed-by: Max Reitz Sig

[PATCH v2 3/6] iotests: Test 183 does not work on macOS and OpenBSD

2019-10-21 Thread Thomas Huth
When running 183 in Cirrus-CI on macOS, or with our vm-build-openbsd target, it fails with an "Timeout waiting for return on handle 0" error. Let's mark it as supported only on systems where the test is working fine (i.e. Linux, FreeBSD and NetBSD). Signed-off-by: Thomas Huth

[PATCH v2 6/6] iotests: Remove 130 from the "auto" group

2019-10-21 Thread Thomas Huth
he "auto" group so that it does not gate the pull requests. Reviewed-by: John Snow Signed-off-by: Thomas Huth --- tests/qemu-iotests/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index 2dd671b82e..9f99f8623

[PATCH v2 1/6] iotests: remove 'linux' from default supported platforms

2019-10-21 Thread Thomas Huth
From: John Snow verify_platform will check an explicit whitelist and blacklist instead. The default will now be assumed to be allowed to run anywhere. For tests that do not specify their platforms explicitly, this has the effect of enabling these tests on non-linux platforms. For tests that alwa

[PATCH v2 5/6] iotests: Enable more tests in the 'auto' group to improve test coverage

2019-10-21 Thread Thomas Huth
iothreads. For migration, let's enable 091, 181, 183, and 203 (which also tests iothreads). Reviewed-by: Max Reitz Signed-off-by: Thomas Huth --- tests/qemu-iotests/group | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/qemu-iotests/group b/tests

[PATCH v2 2/6] iotests: Test 041 only works on certain systems

2019-10-21 Thread Thomas Huth
041 works fine on Linux, FreeBSD, NetBSD and OpenBSD, but fails on macOS. Let's mark it as only supported on the systems where we know that it is working fine. Signed-off-by: Thomas Huth --- tests/qemu-iotests/041 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests

[PATCH v2 0/6] Enable more iotests during "make check-block"

2019-10-21 Thread Thomas Huth
enbsd' instead of 'openbsd6' - Use 'grep -q' instead of 'grep' for grep'ing silently - Added the patch to disable 130 from the "auto" group John Snow (1): iotests: remove 'linux' from default supported platforms Thomas Huth (5): iotes

Re: [PATCH v3 03/16] libqos: extend feature bits to 64-bit

2019-10-21 Thread Thomas Huth
2 ++-- > tests/libqos/virtio.c | 4 ++-- > tests/virtio-blk-test.c| 8 > 6 files changed, 43 insertions(+), 27 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v3 02/16] libqos: read QVIRTIO_MMIO_VERSION register

2019-10-21 Thread Thomas Huth
n the version. > > Signed-off-by: Stefan Hajnoczi > --- > tests/libqos/virtio-mmio.h | 1 + > tests/libqos/virtio-mmio.c | 3 +++ > 2 files changed, 4 insertions(+) Reviewed-by: Thomas Huth

Re: [PATCH v3 01/16] tests/virtio-blk-test: read config space after feature negotiation

2019-10-21 Thread Thomas Huth
r VIRTIO 1.0 support. > > Signed-off-by: Stefan Hajnoczi > --- > tests/virtio-blk-test.c | 33 - > 1 file changed, 20 insertions(+), 13 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 2/5] iotests: Test 041 does not work on macOS

2019-10-21 Thread Thomas Huth
On 18/10/2019 18.19, Max Reitz wrote: > On 11.10.19 16:50, Thomas Huth wrote: >> 041 works fine on Linux, FreeBSD and OpenBSD, so let's mark it as >> only supported on these systems. >> >> Signed-off-by: Thomas Huth >> --- >> tests/qemu-iotests/041 |

[PATCH] iotests: Remove 130 from the "auto" group

2019-10-18 Thread Thomas Huth
causing this issue, so for the time being, let's disable it from the "auto" group so that it does not gate the pull requests. Signed-off-by: Thomas Huth --- tests/qemu-iotests/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/grou

Re: iotest failure -- test possibly not using sufficiently unique temp filename?

2019-10-18 Thread Thomas Huth
On 18/10/2019 10.42, Max Reitz wrote: > On 18.10.19 08:20, Thomas Huth wrote: >> On 17/10/2019 18.41, Peter Maydell wrote: >>> On Fri, 27 Sep 2019 at 17:44, Max Reitz wrote: >>>> >>>> On 27.09.19 18:39, Peter Maydell wrote: >>>>> Hi; I jus

Re: iotest failure -- test possibly not using sufficiently unique temp filename?

2019-10-17 Thread Thomas Huth
On 17/10/2019 18.41, Peter Maydell wrote: > On Fri, 27 Sep 2019 at 17:44, Max Reitz wrote: >> >> On 27.09.19 18:39, Peter Maydell wrote: >>> Hi; I just saw this iotest failure (on an s390x box, as it happens): >>> >>> TESTiotest-qcow2: 130 [fail] >>> QEMU -- >>> "/home/linux1/qemu/b

Re: [PATCH v2 21/23] iotests/240: Create socket in $SOCK_DIR

2019-10-17 Thread Thomas Huth
On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/240 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 20/23] iotests/223: Create socket in $SOCK_DIR

2019-10-17 Thread Thomas Huth
On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/223 | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 15/23] iotests/201: Create socket in $SOCK_DIR

2019-10-17 Thread Thomas Huth
e" > > # get standard environment, filters and checks > . ./common.rc > Reviewed-by: Thomas Huth

Re: [PATCH v2 05/23] iotests: Let common.nbd create socket in $SOCK_DIR

2019-10-17 Thread Thomas Huth
On 17/10/2019 15.31, Max Reitz wrote: > In addition, drop the nbd_unix_socket assignment in 241 because it does > not really do anything. Right, common.nbd is included afterwards, so it gets overwritten. Reviewed-by: Thomas Huth

Re: [PATCH v2 23/23] iotests: Drop TEST_DIR filter from _filter_nbd

2019-10-17 Thread Thomas Huth
SOCK_DIR#g" \ > -e 's#\(foo\|PORT/\?\|.sock\): Failed to .*$#\1#' > } > Reviewed-by: Thomas Huth

Re: [PATCH v2 22/23] iotests/267: Create socket in $SOCK_DIR

2019-10-17 Thread Thomas Huth
On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/267 | 4 ++-- > tests/qemu-iotests/267.out | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 13/23] iotests/192: Create socket in $SOCK_DIR

2019-10-17 Thread Thomas Huth
On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/192 | 4 ++-- > tests/qemu-iotests/192.out | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 16/23] iotests/205: Create socket in $SOCK_DIR

2019-10-17 Thread Thomas Huth
7;) > +nbd_sock = os.path.join(iotests.sock_dir, 'nbd_sock') > nbd_uri = 'nbd+unix:///exp?socket=' + nbd_sock > disk = os.path.join(iotests.test_dir, 'disk') Reviewed-by: Thomas Huth

Re: [PATCH v2 04/23] iotests: Filter $SOCK_DIR

2019-10-17 Thread Thomas Huth
On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/common.filter | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Thomas Huth

Re: [PATCH 4/5] iotests: Skip "make check-block" if QEMU does not support virtio-blk

2019-10-14 Thread Thomas Huth
On 14/10/2019 13.21, Kevin Wolf wrote: > Am 11.10.2019 um 16:50 hat Thomas Huth geschrieben: >> The next patch is going to add some python-based tests to the "auto" >> group, and these tests require virtio-blk to work properly. Running >> iotests without virtio-bl

[PATCH 5/5] iotests: Enable more tests in the 'auto' group to improve test coverage

2019-10-11 Thread Thomas Huth
iothreads. For migration, let's enable 091, 181, 183, and 203 (which also tests iothreads). Signed-off-by: Thomas Huth --- tests/qemu-iotests/group | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group

[PATCH 4/5] iotests: Skip "make check-block" if QEMU does not support virtio-blk

2019-10-11 Thread Thomas Huth
every test (which does not sound very appealing), let's rather add a check for this at the top level in the check-block.sh script instead (so that it is possible to run "make check" without the "check-block" part for qemu-system-tricore for example). Signed-off-by: Thomas H

[PATCH 1/5] iotests: remove 'linux' from default supported platforms

2019-10-11 Thread Thomas Huth
From: John Snow verify_platform will check an explicit whitelist and blacklist instead. The default will now be assumed to be allowed to run anywhere. For tests that do not specify their platforms explicitly, this has the effect of enabling these tests on non-linux platforms. For tests that alwa

[PATCH 3/5] iotests: Test 183 does not work on macOS and OpenBSD

2019-10-11 Thread Thomas Huth
When running 183 in Cirrus-CI on macOS, or with our vm-build-openbsd target, it fails with an "Timeout waiting for return on handle 0" error. Let's mark it as supported only on systems where the test is working fine (i.e. Linux and FreeBSD). Signed-off-by: Thomas Huth --- tes

[PATCH 2/5] iotests: Test 041 does not work on macOS

2019-10-11 Thread Thomas Huth
041 works fine on Linux, FreeBSD and OpenBSD, so let's mark it as only supported on these systems. Signed-off-by: Thomas Huth --- tests/qemu-iotests/041 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index 85684

[PATCH 0/5] Enable more iotests during "make check-block"

2019-10-11 Thread Thomas Huth
un the iotests with binaries like qemu-system-tricore anymore. But since the iotests were not very useful with such binaries anyway, I think it's ok now if we skip them there. Based-on: 20191010152457.17713-1-mre...@redhat.com John Snow (1): iotests: remove 'linux' from default suppor

Re: [PATCH v2] iotests/028: Fix for long $TEST_DIRs

2019-10-11 Thread Thomas Huth
Formatting" to being greppable at all after "read"-ing it (if the > prompt injects an IFS character into the "Formatting" string). > > So just wait until we get a prompt. At that point, the block job must > have been started, so "info block-jobs" will onl

Re: [PATCH] iotests/028: Fix for long $TEST_DIRs

2019-10-11 Thread Thomas Huth
On 11/10/2019 11.07, Max Reitz wrote: > For long test image paths, the order of the "Formatting" line and the > "(qemu)" prompt after a drive_backup HMP command may be reversed. It is > not well-defined anyway, so just silence everything and wait until we > get a

Re: [PATCH 00/23] iotests: Add and use $SOCK_DIR

2019-10-11 Thread Thomas Huth
On 11/10/2019 10.03, Max Reitz wrote: > On 11.10.19 09:27, Thomas Huth wrote: >> On 10/10/2019 17.24, Max Reitz wrote: >>> Hi, >>> >>> Perhaps the main reason we cannot run important tests such as 041 in CI >>> is that when they care Unix sockets in $

Re: [PATCH 04/23] iotests: Filter $SOCK_DIR

2019-10-11 Thread Thomas Huth
On 11/10/2019 09.54, Max Reitz wrote: > On 10.10.19 20:42, Eric Blake wrote: >> On 10/10/19 10:24 AM, Max Reitz wrote: >>> Signed-off-by: Max Reitz >>> --- >>>   tests/qemu-iotests/common.filter | 8 ++-- >>>   1 file changed, 6 insertions(+), 2 deletions(-) >>> >>> diff --git a/tests/qemu-iote

Re: [PATCH 12/23] iotests/183: Create socket in $SOCK_DIR

2019-10-11 Thread Thomas Huth
On 10/10/2019 17.24, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/183 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Thomas Huth

Re: [PATCH 11/23] iotests/182: Create socket in $SOCK_DIR

2019-10-11 Thread Thomas Huth
On 10/10/2019 17.24, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/182 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

<    3   4   5   6   7   8   9   10   11   12   >