On 24.04.23 21:32, Juan Quintela wrote:
Notice that we changed the test of ->has_block_bitmap_mapping
for the test that block_bitmap_mapping is not NULL.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
migration/block-dirty-bitmap.c |
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
[same recommendations]
--
Best regards,
Vladimir
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
Still same recommendations: "const char *" and "s" becomes unused in
migration_tls_channel_process_incoming()
--
Best regards,
Vladimir
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
migration/options.c | 7 +++
migration/options.h | 1 +
migration/tls.c | 9 -
3 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/migration
On 24.04.23 21:32, Juan Quintela wrote:
This makes the function more regular with everything else.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
migration/migration.c | 4 ++--
migration/options.c | 4 +++-
migration/options.h | 2 +-
3 files changed
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 26.04.23 21:45, Vladimir Sementsov-Ogievskiy wrote:
On 24.04.23 21:32, Juan Quintela wrote:
Once there, make it more regular and remove th eneed for
some type here
haha, and my typo here
MigrationState parameter.
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards
On 24.04.23 21:32, Juan Quintela wrote:
Once there, make it more regular and remove th eneed for
some type here
MigrationState parameter.
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 25.04.23 19:48, Hanna Czenczek wrote:
On 24.04.23 20:32, Vladimir Sementsov-Ogievskiy wrote:
On 24.04.23 16:36, Emanuele Giuseppe Esposito wrote:
Am 21/04/2023 um 12:13 schrieb Vladimir Sementsov-Ogievskiy:
On 17.03.23 15:35, Thomas Huth wrote:
On 17/03/2023 11.17, Peter Maydell wrote
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 24.04.23 21:32, Juan Quintela wrote:
Once there, rename it to migrate_tls() and make it return bool for
consistency.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 24.04.23 16:36, Emanuele Giuseppe Esposito wrote:
Am 21/04/2023 um 12:13 schrieb Vladimir Sementsov-Ogievskiy:
On 17.03.23 15:35, Thomas Huth wrote:
On 17/03/2023 11.17, Peter Maydell wrote:
On Mon, 6 Mar 2023 at 11:16, Peter Maydell
wrote:
On Fri, 3 Mar 2023 at 18:36, Peter Maydell
On 15.02.23 16:25, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
Let's get rid of pattern
result = self.vm.qmp(...)
self.assert_qmp(result, 'return', {})
And switch to just
self.vm.cmd(...)
v5:
- include fixups by John
- fix 'make check-dev'
- split
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c | 278 +
1 file changed, 89 insertions(+), 189 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index edaf7c6601..2bfa77e564 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -
Only backup supports GROUPED mode. Make this logic more clear. And
avoid passing extra thing to each action.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c | 92 +++---
1 file changed, 19 insertions(+), 73 deletions(-)
diff --git a
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 2174ab2694..89c573a094 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2375,7 +2375,7 @@ void qmp_transaction(TransactionActionList
n.
Next, we have to rename global map of actions, to not conflict with new
name for function argument.
Rename also dev_entry loop variable accordingly to new name of the
list.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c | 30 +++---
1 file changed, 15 inserti
Hi all!
v8: resend, fix my emails
That's a portion of old good
"[PATCH v5 00/45] Transactional block-graph modifying API".
Let's refactor QMP transactions implementation into new (relatively)
transaction API.
Vladimir Sementsov-Ogievskiy (5):
blockdev: refactor transactio
, now let's just transform what we have into new-style transaction
actions.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c | 317 +++--
1 file changed, 186 insertions(+), 131 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index
Demonstrate new blockdev-replace API for filter insertion and removal.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/tests/filter-insertion | 257 ++
tests/qemu-iotests/tests/filter-insertion.out | 5 +
2 files changed, 262 insertions(+)
create mode
Currently for block exports we report empty blk names. That's not good.
Let's try to find corresponding block export and report its id.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 4
block/export/export.c | 13 +
include/bloc
Add a command that can replace bs in following BdrvChild structures:
- qdev blk root child
- block-export blk root child
- any child of BlockDriverState selected by child-name
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c | 56
We need it for further blockdev-replace functionality.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/export/export.c | 18 ++
include/sysemu/block-backend-global-state.h | 1 +
2 files changed, 19 insertions(+)
diff --git a/block/export/export.c b
We'll need get non-const child pointer for graph modifications in
further commits.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-backend.c | 2 +-
include/sysemu/block-backend-global-state.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
Add an alternative method to check block graph, to be used in further
commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 17 +
1 file changed, 17 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index
To be reused soon for blockdev-replace functionality.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 13 +
blockdev.c | 14 --
include/block/block_int-io.h | 1 +
3 files changed, 14 insertions(+), 14 deletions(-)
diff
ck-node by node-name and child name
To simplify things, let's postpone transaction support and start from
blockdev-replace single command. That still allows to insert filters
here and there!)
v7: rebase and change QAPI versions to 8.1
Vladimir Sementsov-Ogievskiy (7):
block-backend: bl
On 17.03.23 15:35, Thomas Huth wrote:
On 17/03/2023 11.17, Peter Maydell wrote:
On Mon, 6 Mar 2023 at 11:16, Peter Maydell wrote:
On Fri, 3 Mar 2023 at 18:36, Peter Maydell wrote:
I've noticed that test-blockjob seems to fail intermittently
on the msys2-64bit job:
https://gitlab.com/qemu-
Let's add --enable / --disable configure options for these formats,
so that those who don't need them may not build them.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
v2: just a resend instead of ping, bonus: fix mistake in commit message.
block/meson.build
On 21.04.23 05:22, Zhang, Chen wrote:
-Original Message-
From: Vladimir Sementsov-Ogievskiy
Sent: Thursday, April 20, 2023 7:26 PM
To: Zhang, Chen ; qemu-de...@nongnu.org
Cc: qemu-block@nongnu.org; michael.r...@amd.com; arm...@redhat.com;
ebl...@redhat.com; jasow...@redhat.com; quint
On 21.04.23 06:02, Zhang, Chen wrote:
-Original Message-
From: Vladimir Sementsov-Ogievskiy
Sent: Thursday, April 20, 2023 6:53 AM
To: qemu-de...@nongnu.org
Cc: qemu-block@nongnu.org; michael.r...@amd.com; arm...@redhat.com;
ebl...@redhat.com; jasow...@redhat.com; quint...@redhat.com
On 20.04.23 16:39, Juan Quintela wrote:
To be consistent with every other parameter, rename to
migrate_block_incremental().
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 16:39, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 16:39, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 16:39, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 16:39, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 16:39, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 16:39, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 17:43, Eric Blake wrote:
On Thu, Apr 20, 2023 at 01:52:30AM +0300, Vladimir Sementsov-Ogievskiy wrote:
To be used in the next commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
scripts/qapi/types.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/qapi
On 02.03.23 19:33, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 02.03.23 19:33, Juan Quintela wrote:
Once that we are there, we rename the function to migrate_return_path()
to be consistent with all other capabilities.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 02.03.23 19:33, Juan Quintela wrote:
Once that we are there, we rename the function to migrate_block()
to be consistent with all other capabilities.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 02.03.23 19:33, Juan Quintela wrote:
Once that we are there, we rename the function to migrate_xbzrle()
to be consistent with all other capabilities.
We change the type to return bool also for consistency.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best
ff-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 02.03.23 19:33, Juan Quintela wrote:
Once that we are there, we rename the function to migrate_multifd()
to be consistent with all other capabilities.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 02.03.23 19:33, Juan Quintela wrote:
Once that we are there, we rename the function to migrate_events()
to be consistent with all other capabilities.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 02.03.23 19:33, Juan Quintela wrote:
Once that we are there, we rename the function to migrate_compress()
to be consistent with all other capabilities.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
migration/migration.h | 1 -
migration/options.h | 1
On 02.03.23 19:33, Juan Quintela wrote:
Once that we are there, we rename the function to migrate_colo() to be
consistent with all other capabilities.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 13:03, Juan Quintela wrote:
Vladimir Sementsov-Ogievskiy wrote:
We don't allow to use x-colo capability when replication is not
configured. So, no reason to build COLO when replication is disabled,
it's unusable in this case.
Signed-off-by: Vladimir Sementsov-Ogievskiy
On 20.04.23 12:09, Zhang, Chen wrote:
-Original Message-
From: Vladimir Sementsov-Ogievskiy
Sent: Thursday, April 20, 2023 6:53 AM
To: qemu-de...@nongnu.org
Cc: qemu-block@nongnu.org; michael.r...@amd.com; arm...@redhat.com;
ebl...@redhat.com; jasow...@redhat.com; quint...@redhat.com
On 20.04.23 11:33, Lukas Straub wrote:
On Thu, 20 Apr 2023 01:52:28 +0300
Vladimir Sementsov-Ogievskiy wrote:
Hi all!
COLO substem seems to be useless when CONFIG_REPLICATION is unset, as we
simply don't allow to set x-colo capability in this case. So, let's not
compile in unreac
To be used in the next commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
scripts/qapi/types.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/qapi/types.py b/scripts/qapi/types.py
index c39d054d2c..18f8734047 100644
--- a/scripts/qapi/types.py
+++ b/scripts/qapi/types.py
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/meson.build b/block/meson.build
index 382bec0e7d..b9a72e219b 100644
--- a/block/meson.build
+++ b/block/meson.build
@@ -84,7 +84,7 @@ block_ss.add(when
Add option to not build COLO Proxy subsystem if it is not needed.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
meson.build | 1 +
meson_options.txt | 2 ++
net/meson.build | 11 ---
scripts/meson-buildoptions.sh | 3 +++
4 files changed
We don't allow to use x-colo capability when replication is not
configured. So, no reason to build COLO when replication is disabled,
it's unusable in this case.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hmp-commands.hx| 2 ++
migration/colo.c
n for COLO Proxy subsystem.
v1 was
[PATCH] replication: compile out some staff when replication is not configured
Supersedes: <20230411145112.497785-1-vsement...@yandex-team.ru>
Vladimir Sementsov-Ogievskiy (4):
block/meson.build: prefer positive condition for replication
scripts/qapi
On 11.04.23 17:51, Vladimir Sementsov-Ogievskiy wrote:
Don't compile-in replication-related files when replication is disabled
in config.
Signed-off-by: Vladimir Sementsov-Ogievskiy
v2 will be called "[PATCH v2 0/4] COLO: improve build options"
--
Best regards,
Vladimir
On 17.04.23 20:19, Vladimir Sementsov-Ogievskiy wrote:
On 16.04.23 21:44, Zhang, Chen wrote:
-Original Message-
From: Vladimir Sementsov-Ogievskiy
Sent: Friday, April 14, 2023 5:51 PM
To: Zhang, Chen ; qemu-de...@nongnu.org
Cc: qemu-block@nongnu.org; pbonz...@redhat.com; arm
On 16.04.23 21:44, Zhang, Chen wrote:
-Original Message-
From: Vladimir Sementsov-Ogievskiy
Sent: Friday, April 14, 2023 5:51 PM
To: Zhang, Chen ; qemu-de...@nongnu.org
Cc: qemu-block@nongnu.org; pbonz...@redhat.com; arm...@redhat.com;
ebl...@redhat.com; jasow...@redhat.com; dgilb
On 21.03.23 23:13, Vladimir Sementsov-Ogievskiy wrote:
Currently block_resize qmp command is simply ignored by vhost-user-blk
export. So, the block-node is successfully resized, but virtio config
is unchanged and guest doesn't see that disk is resized.
Let's handle the resize by mod
On 14.04.23 04:24, Zhang, Chen wrote:
So, if I want to have an option to disable all COLO modules, do you mean it
should be additional --disable-colo option? Or better keep one option --
disable-replication (and, maybe just rename to to --disable-colo)?
I think keep the option --disable-replicat
On 13.04.23 12:52, Zhang, Chen wrote:
-Original Message-
From: Vladimir Sementsov-Ogievskiy
Sent: Tuesday, April 11, 2023 10:51 PM
To: qemu-de...@nongnu.org
Cc: qemu-block@nongnu.org; pbonz...@redhat.com; arm...@redhat.com;
ebl...@redhat.com; jasow...@redhat.com; dgilb...@redhat.com
ality is not implemented twice.
Buglink:https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
Let's add --enable / --disable configure options for these formats,
so that thous who don't need them may not build them.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/meson.build | 18 +-
meson.build | 3 +++
meson_o
Don't compile-in replication-related files when replication is disabled
in config.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Hi all!
I'm unsure, should it be actually separate
--disable-colo / --enable-colo options or it's really used only together
with replication staff.
On 06.04.23 19:51, Hanna Czenczek wrote:
On 05.04.23 11:59, Vladimir Sementsov-Ogievskiy wrote:
On 04.04.23 20:32, Hanna Czenczek wrote:
On 04.04.23 10:10, Vladimir Sementsov-Ogievskiy wrote:
On 03.04.23 16:33, Hanna Czenczek wrote:
(Sorry for the rather late reply... Thanks for the review
On 04.04.23 20:32, Hanna Czenczek wrote:
On 04.04.23 10:10, Vladimir Sementsov-Ogievskiy wrote:
On 03.04.23 16:33, Hanna Czenczek wrote:
(Sorry for the rather late reply... Thanks for the review!)
On 20.03.23 11:31, Vladimir Sementsov-Ogievskiy wrote:
On 17.03.23 20:50, Hanna Czenczek wrote
, but looked through and nothing seems wrong
to me. Good cleanup!
all patches:
Reviewed-by: Vladimir Sementsov-Ogievskiy
PS: do you plan some automatic checks in build process to avoid similar
style/naming problems in future?
--
Best regards,
Vladimir
On 04.04.23 14:59, Markus Armbruster wrote:
@@ -2741,7 +2741,7 @@
#
# @on-error: the action to take on an error (default report).
#'stop' and 'enospc' can only be used if the block device
-#supports io-status (see BlockInfo). Since 1.3.
+#supports io-sta
On 03.04.23 16:33, Hanna Czenczek wrote:
(Sorry for the rather late reply... Thanks for the review!)
On 20.03.23 11:31, Vladimir Sementsov-Ogievskiy wrote:
On 17.03.23 20:50, Hanna Czenczek wrote:
[...]
diff --git a/block/io.c b/block/io.c
index 8974d46941..1e9cdba17a 100644
--- a/block
After this comment, lsblk in linux guest with attached
vhost-user-blk-pci device shows new size immediately after block_resize
QMP command on vhost-user exported block node.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Hi all! Seems, we have everything except this tiny patch to support live
d
On 17.03.23 20:50, Hanna Czenczek wrote:
Test that even vectored IO requests with 1024 vector elements that are
not aligned to the device's request alignment will succeed.
Signed-off-by: Hanna Czenczek
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
re-implement it in qemu_iovec_concat_iov(), which might
also benefit its pre-existing users.
Signed-off-by: Hanna Czenczek
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
bdrv_padding_destroy(&pad);
Now, the request is formally finished inside bdrv_padding_destroy().. Not sure,
does it really violate something, but seems safer to swap these two calls. With
that:
Reviewed-by: Vladimir Sementsov-Ogievskiy
PS, I feel here still exists small space for optimizati
, thus get the number of elements, and also create an
iovec array with the superfluous prefixing elements stripped, so the
following processing functions no longer need to skip them.)
Signed-off-by: Hanna Czenczek
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 15.03.23 15:13, Hanna Czenczek wrote:
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this pad
On 09.03.23 14:39, Richard W.M. Jones wrote:
[ Patch series also available here, along with this cover letter and the
script used to generate test results:
https://gitlab.com/rwmjones/qemu/-/commits/2023-nbd-multi-conn-v1 ]
This patch series adds multi-conn support to the NBD block driver
On 02.03.23 19:33, Juan Quintela wrote:
We used to pass the old capabilities array and the new
capabilities as a list.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 02.03.23 19:33, Juan Quintela wrote:
Hi
This series move to options.c:
- all migration capabilities code
- all migration parameters code
- all properties code
- all qmp commands that only touch the previous
And once there:
- sort of functions
- make consistent and coherent all the functions
On 02.03.23 19:33, Juan Quintela wrote:
It is clear from the context what that means, and such a long name
with the extra long names of the capabilities make very difficilut to
stay inside the 80 columns limit.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best
On 02.03.23 15:34, Fiona Ebner wrote:
Am 02.03.23 um 11:13 schrieb Vladimir Sementsov-Ogievskiy:
On 02.03.23 13:00, Fiona Ebner wrote:
Am 01.03.23 um 17:31 schrieb Vladimir Sementsov-Ogievskiy:
On 24.02.23 17:48, Fiona Ebner wrote:
This can be used by management applications starting with a
On 02.03.23 13:00, Fiona Ebner wrote:
Am 01.03.23 um 17:31 schrieb Vladimir Sementsov-Ogievskiy:
On 24.02.23 17:48, Fiona Ebner wrote:
This can be used by management applications starting with a job in
background mode to determine when the switch to active mode should
happen.
Suggested-by
On 24.02.23 17:48, Fiona Ebner wrote:
This can be used by management applications starting with a job in
background mode to determine when the switch to active mode should
happen.
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Fiona Ebner
---
block/mirror.c | 1 +
qapi
On 24.02.23 17:48, Fiona Ebner wrote:
In preparation to additionally return job-type-specific information.
Signed-off-by: Fiona Ebner
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 24.02.23 17:48, Fiona Ebner wrote:
In preparation to turn BlockJobInfo into a union with @type as the
discriminator. That requires it to be an enum.
No functional change is intended.
Signed-off-by: Fiona Ebner
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 24.02.23 17:48, Fiona Ebner wrote:
which allows switching the @copy-mode from 'background' to
'write-blocking'.
Once the job is in active mode, no new writes need to be registered in
the dirty bitmap, because they are synchronously written to the
target. But since the method is called from th
On 24.02.23 17:48, Fiona Ebner wrote:
With active mode, the guest write speed is limited by the synchronous
writes to the mirror target. For this reason, management applications
might want to start out in background mode and only switch to active
mode later, when certain conditions are met. This
On 24.02.23 17:48, Fiona Ebner wrote:
In preparation to allow switching from background to active mode. This
ensures that setting actively_synced will not be missed when the
switch happens after the job is ready.
Signed-off-by: Fiona Ebner
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best
Demonstrate new blockdev-replace API for filter insertion and removal.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/tests/filter-insertion | 257 ++
tests/qemu-iotests/tests/filter-insertion.out | 5 +
2 files changed, 262 insertions(+)
create mode
We need it for further blockdev-replace functionality.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/sysemu/block-backend-global-state.h | 1 +
block/export/export.c | 18 ++
2 files changed, 19 insertions(+)
diff --git a/include/sysemu/block
Currently for block exports we report empty blk names. That's not good.
Let's try to find corresponding block export and report its id.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/export.h | 1 +
block.c | 4
block/export/export.c
Add an alternative method to check block graph, to be used in further
commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 17 +
1 file changed, 17 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index
We'll need get non-const child pointer for graph modifications in
further commits.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/sysemu/block-backend-global-state.h | 2 +-
block/block-backend.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
Add a command that can replace bs in following BdrvChild structures:
- qdev blk root child
- block-export blk root child
- any child of BlockDriverState selected by child-name
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/block-core.json | 62
To be reused soon for blockdev-replace functionality.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/block_int-io.h | 1 +
block.c | 13 +
blockdev.c | 14 --
3 files changed, 14 insertions(+), 14 deletions(-)
diff
ted and not based on recent
"[PATCH v7 0/5] block: refactor blockdev transactions". The series may
be handled in any order.
Vladimir Sementsov-Ogievskiy (7):
block-backend: blk_root(): drop const specifier on return type
block/export: add blk_by_export_id()
block: make bdrv_find_
ror_top driver doesn't access it
too early.
Signed-off-by: Kevin Wolf
Probably bitmap initialization and (maybe) some other things in mirror_run()
should actually be done in mirror_start_job(). Still:
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
401 - 500 of 7639 matches
Mail list logo
